[jira] [Commented] (HBASE-9295) Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use proper comparator

2013-11-07 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13816414#comment-13816414
 ] 

Ted Yu commented on HBASE-9295:
---

Integrated to trunk.

Thanks for the review, Jesse.

 Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use 
 proper comparator
 -

 Key: HBASE-9295
 URL: https://issues.apache.org/jira/browse/HBASE-9295
 Project: HBase
  Issue Type: Task
Reporter: Ted Yu
Assignee: Ted Yu
 Fix For: 0.98.0

 Attachments: 9295-v1.txt, 9295-v2.txt


 There were two recent bug fixes (HBASE-9285 and HBASE-9238) for the case 
 where the TreeMap keyed by byte[] doesn't use proper comparator:
 {code}
 new TreeMapbyte[], ...()
 {code}
 test-patch.sh should be able to detect this situation and report accordingly.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (HBASE-9295) Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use proper comparator

2013-11-07 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13816879#comment-13816879
 ] 

Hudson commented on HBASE-9295:
---

SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #831 (See 
[https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/831/])
HBASE-9295 Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't 
use proper comparator (tedyu: rev 1539812)
* /hbase/trunk/dev-support/test-patch.sh


 Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use 
 proper comparator
 -

 Key: HBASE-9295
 URL: https://issues.apache.org/jira/browse/HBASE-9295
 Project: HBase
  Issue Type: Task
Reporter: Ted Yu
Assignee: Ted Yu
 Fix For: 0.98.0

 Attachments: 9295-v1.txt, 9295-v2.txt


 There were two recent bug fixes (HBASE-9285 and HBASE-9238) for the case 
 where the TreeMap keyed by byte[] doesn't use proper comparator:
 {code}
 new TreeMapbyte[], ...()
 {code}
 test-patch.sh should be able to detect this situation and report accordingly.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (HBASE-9295) Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use proper comparator

2013-11-07 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13816904#comment-13816904
 ] 

Hudson commented on HBASE-9295:
---

SUCCESS: Integrated in HBase-TRUNK #4672 (See 
[https://builds.apache.org/job/HBase-TRUNK/4672/])
HBASE-9295 Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't 
use proper comparator (tedyu: rev 1539812)
* /hbase/trunk/dev-support/test-patch.sh


 Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use 
 proper comparator
 -

 Key: HBASE-9295
 URL: https://issues.apache.org/jira/browse/HBASE-9295
 Project: HBase
  Issue Type: Task
Reporter: Ted Yu
Assignee: Ted Yu
 Fix For: 0.98.0

 Attachments: 9295-v1.txt, 9295-v2.txt


 There were two recent bug fixes (HBASE-9285 and HBASE-9238) for the case 
 where the TreeMap keyed by byte[] doesn't use proper comparator:
 {code}
 new TreeMapbyte[], ...()
 {code}
 test-patch.sh should be able to detect this situation and report accordingly.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (HBASE-9295) Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use proper comparator

2013-10-31 Thread Jesse Yates (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13810421#comment-13810421
 ] 

Jesse Yates commented on HBASE-9295:


+1

 Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use 
 proper comparator
 -

 Key: HBASE-9295
 URL: https://issues.apache.org/jira/browse/HBASE-9295
 Project: HBase
  Issue Type: Task
Reporter: Ted Yu
Assignee: Ted Yu
 Fix For: 0.98.0

 Attachments: 9295-v1.txt, 9295-v2.txt


 There were two recent bug fixes (HBASE-9285 and HBASE-9238) for the case 
 where the TreeMap keyed by byte[] doesn't use proper comparator:
 {code}
 new TreeMapbyte[], ...()
 {code}
 test-patch.sh should be able to detect this situation and report accordingly.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (HBASE-9295) Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use proper comparator

2013-10-30 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809790#comment-13809790
 ] 

Ted Yu commented on HBASE-9295:
---

Can I interpret the above as +1 ?

 Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use 
 proper comparator
 -

 Key: HBASE-9295
 URL: https://issues.apache.org/jira/browse/HBASE-9295
 Project: HBase
  Issue Type: Task
Reporter: Ted Yu
Assignee: Ted Yu
 Fix For: 0.98.0

 Attachments: 9295-v1.txt, 9295-v2.txt


 There were two recent bug fixes (HBASE-9285 and HBASE-9238) for the case 
 where the TreeMap keyed by byte[] doesn't use proper comparator:
 {code}
 new TreeMapbyte[], ...()
 {code}
 test-patch.sh should be able to detect this situation and report accordingly.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (HBASE-9295) Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use proper comparator

2013-10-21 Thread Jesse Yates (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13800917#comment-13800917
 ] 

Jesse Yates commented on HBASE-9295:


I think that we can make it a little bit more general to cover other 
anti-patterns, since others are sure to come up, even on single-line cases. 
But, until then, I guess this is fine - we can make it more general later

 Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use 
 proper comparator
 -

 Key: HBASE-9295
 URL: https://issues.apache.org/jira/browse/HBASE-9295
 Project: HBase
  Issue Type: Task
Reporter: Ted Yu
Assignee: Ted Yu
 Fix For: 0.98.0

 Attachments: 9295-v1.txt, 9295-v2.txt


 There were two recent bug fixes (HBASE-9285 and HBASE-9238) for the case 
 where the TreeMap keyed by byte[] doesn't use proper comparator:
 {code}
 new TreeMapbyte[], ...()
 {code}
 test-patch.sh should be able to detect this situation and report accordingly.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (HBASE-9295) Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use proper comparator

2013-10-19 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13799968#comment-13799968
 ] 

Ted Yu commented on HBASE-9295:
---

Since the detection is based on scanning a single line, there would not be that 
many anti-patterns to be discovered.
This one is the only I can think of now.

What do you think, Jesse ?

 Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use 
 proper comparator
 -

 Key: HBASE-9295
 URL: https://issues.apache.org/jira/browse/HBASE-9295
 Project: HBase
  Issue Type: Task
Reporter: Ted Yu
Assignee: Ted Yu
 Fix For: 0.98.0

 Attachments: 9295-v1.txt, 9295-v2.txt


 There were two recent bug fixes (HBASE-9285 and HBASE-9238) for the case 
 where the TreeMap keyed by byte[] doesn't use proper comparator:
 {code}
 new TreeMapbyte[], ...()
 {code}
 test-patch.sh should be able to detect this situation and report accordingly.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (HBASE-9295) Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use proper comparator

2013-09-17 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13769689#comment-13769689
 ] 

Ted Yu commented on HBASE-9295:
---

Here is sample output where the tested patch omits comparator for TreeMap:
{code}
{color:red}-1 Anti-pattern{color}.  The patch appears to 
have anti-pattern :
 +  Mapbyte[], Integer kvCount = new TreeMapbyte[], 
Integer();.
{code}

 Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use 
 proper comparator
 -

 Key: HBASE-9295
 URL: https://issues.apache.org/jira/browse/HBASE-9295
 Project: HBase
  Issue Type: Task
Reporter: Ted Yu
Assignee: Ted Yu
 Fix For: 0.98.0

 Attachments: 9295-v1.txt


 There were two recent bug fixes (HBASE-9285 and HBASE-9238) for the case 
 where the TreeMap keyed by byte[] doesn't use proper comparator:
 {code}
 new TreeMapbyte[], ...()
 {code}
 test-patch.sh should be able to detect this situation and report accordingly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-9295) Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use proper comparator

2013-09-17 Thread Jesse Yates (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13769736#comment-13769736
 ] 

Jesse Yates commented on HBASE-9295:


I was thinking that each anti-pattern would actually be a check to grep against 
and a description when found. Otherwise, we are just looking for the 
BYTES_COMPARATOR anti-pattern

 Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use 
 proper comparator
 -

 Key: HBASE-9295
 URL: https://issues.apache.org/jira/browse/HBASE-9295
 Project: HBase
  Issue Type: Task
Reporter: Ted Yu
Assignee: Ted Yu
 Fix For: 0.98.0

 Attachments: 9295-v1.txt, 9295-v2.txt


 There were two recent bug fixes (HBASE-9285 and HBASE-9238) for the case 
 where the TreeMap keyed by byte[] doesn't use proper comparator:
 {code}
 new TreeMapbyte[], ...()
 {code}
 test-patch.sh should be able to detect this situation and report accordingly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-9295) Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use proper comparator

2013-09-17 Thread Jesse Yates (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13769713#comment-13769713
 ] 

Jesse Yates commented on HBASE-9295:


Would be nice if each anti-patter came with a description of why it was bad 
(i.e. in this case, omits byte[] comparator for a treeMap). Otherwise, a cool 
idea!

 Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use 
 proper comparator
 -

 Key: HBASE-9295
 URL: https://issues.apache.org/jira/browse/HBASE-9295
 Project: HBase
  Issue Type: Task
Reporter: Ted Yu
Assignee: Ted Yu
 Fix For: 0.98.0

 Attachments: 9295-v1.txt


 There were two recent bug fixes (HBASE-9285 and HBASE-9238) for the case 
 where the TreeMap keyed by byte[] doesn't use proper comparator:
 {code}
 new TreeMapbyte[], ...()
 {code}
 test-patch.sh should be able to detect this situation and report accordingly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira