[jira] [Commented] (HBASE-9382) replicateWALEntry doesn't use the replication handlers
[ https://issues.apache.org/jira/browse/HBASE-9382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13754861#comment-13754861 ] Jean-Daniel Cryans commented on HBASE-9382: --- It all checks out, +1 replicateWALEntry doesn't use the replication handlers -- Key: HBASE-9382 URL: https://issues.apache.org/jira/browse/HBASE-9382 Project: HBase Issue Type: Bug Affects Versions: 0.95.2 Reporter: Jean-Daniel Cryans Assignee: stack Fix For: 0.98.0, 0.96.0 Attachments: 9382.trunk.txt, 9382.txt By default we assign 3 handlers for replication, but as far as I can tell the replication traffic uses the normal handlers in 0.96 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9382) replicateWALEntry doesn't use the replication handlers
[ https://issues.apache.org/jira/browse/HBASE-9382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13754863#comment-13754863 ] Hadoop QA commented on HBASE-9382: -- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12600741/9382.trunk.txt against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified tests. {color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop 1.0 profile. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//console This message is automatically generated. replicateWALEntry doesn't use the replication handlers -- Key: HBASE-9382 URL: https://issues.apache.org/jira/browse/HBASE-9382 Project: HBase Issue Type: Bug Affects Versions: 0.95.2 Reporter: Jean-Daniel Cryans Assignee: stack Fix For: 0.98.0, 0.96.0 Attachments: 9382.trunk.txt, 9382.txt By default we assign 3 handlers for replication, but as far as I can tell the replication traffic uses the normal handlers in 0.96 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9382) replicateWALEntry doesn't use the replication handlers
[ https://issues.apache.org/jira/browse/HBASE-9382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13755001#comment-13755001 ] Hudson commented on HBASE-9382: --- SUCCESS: Integrated in HBase-TRUNK #4450 (See [https://builds.apache.org/job/HBase-TRUNK/4450/]) HBASE-9382 replicateWALEntry doesn't use the replication handlers (stack: rev 1519017) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/QosFunction.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestQosFunction.java replicateWALEntry doesn't use the replication handlers -- Key: HBASE-9382 URL: https://issues.apache.org/jira/browse/HBASE-9382 Project: HBase Issue Type: Bug Affects Versions: 0.95.2 Reporter: Jean-Daniel Cryans Assignee: stack Fix For: 0.98.0, 0.96.0 Attachments: 9382.trunk.txt, 9382.txt By default we assign 3 handlers for replication, but as far as I can tell the replication traffic uses the normal handlers in 0.96 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9382) replicateWALEntry doesn't use the replication handlers
[ https://issues.apache.org/jira/browse/HBASE-9382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13754998#comment-13754998 ] Hudson commented on HBASE-9382: --- SUCCESS: Integrated in hbase-0.95 #509 (See [https://builds.apache.org/job/hbase-0.95/509/]) HBASE-9382 replicateWALEntry doesn't use the replication handlers (stack: rev 1519018) * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/QosFunction.java * /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestQosFunction.java replicateWALEntry doesn't use the replication handlers -- Key: HBASE-9382 URL: https://issues.apache.org/jira/browse/HBASE-9382 Project: HBase Issue Type: Bug Affects Versions: 0.95.2 Reporter: Jean-Daniel Cryans Assignee: stack Fix For: 0.98.0, 0.96.0 Attachments: 9382.trunk.txt, 9382.txt By default we assign 3 handlers for replication, but as far as I can tell the replication traffic uses the normal handlers in 0.96 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9382) replicateWALEntry doesn't use the replication handlers
[ https://issues.apache.org/jira/browse/HBASE-9382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13755045#comment-13755045 ] Hudson commented on HBASE-9382: --- FAILURE: Integrated in hbase-0.95-on-hadoop2 #282 (See [https://builds.apache.org/job/hbase-0.95-on-hadoop2/282/]) HBASE-9382 replicateWALEntry doesn't use the replication handlers (stack: rev 1519018) * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/QosFunction.java * /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestQosFunction.java replicateWALEntry doesn't use the replication handlers -- Key: HBASE-9382 URL: https://issues.apache.org/jira/browse/HBASE-9382 Project: HBase Issue Type: Bug Affects Versions: 0.95.2 Reporter: Jean-Daniel Cryans Assignee: stack Fix For: 0.98.0, 0.96.0 Attachments: 9382.trunk.txt, 9382.txt By default we assign 3 handlers for replication, but as far as I can tell the replication traffic uses the normal handlers in 0.96 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9382) replicateWALEntry doesn't use the replication handlers
[ https://issues.apache.org/jira/browse/HBASE-9382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13754824#comment-13754824 ] Jean-Daniel Cryans commented on HBASE-9382: --- I'll test this one out this morning. replicateWALEntry doesn't use the replication handlers -- Key: HBASE-9382 URL: https://issues.apache.org/jira/browse/HBASE-9382 Project: HBase Issue Type: Bug Affects Versions: 0.95.2 Reporter: Jean-Daniel Cryans Assignee: stack Fix For: 0.98.0, 0.96.0 Attachments: 9382.trunk.txt, 9382.txt By default we assign 3 handlers for replication, but as far as I can tell the replication traffic uses the normal handlers in 0.96 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9382) replicateWALEntry doesn't use the replication handlers
[ https://issues.apache.org/jira/browse/HBASE-9382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13755317#comment-13755317 ] Hudson commented on HBASE-9382: --- SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #705 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/705/]) HBASE-9382 replicateWALEntry doesn't use the replication handlers (stack: rev 1519017) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/QosFunction.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestQosFunction.java replicateWALEntry doesn't use the replication handlers -- Key: HBASE-9382 URL: https://issues.apache.org/jira/browse/HBASE-9382 Project: HBase Issue Type: Bug Affects Versions: 0.95.2 Reporter: Jean-Daniel Cryans Assignee: stack Fix For: 0.98.0, 0.96.0 Attachments: 9382.trunk.txt, 9382.txt By default we assign 3 handlers for replication, but as far as I can tell the replication traffic uses the normal handlers in 0.96 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9382) replicateWALEntry doesn't use the replication handlers
[ https://issues.apache.org/jira/browse/HBASE-9382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13754379#comment-13754379 ] stack commented on HBASE-9382: -- Broken by: {code} r1501834 | stack | 2013-07-10 09:30:32 -0700 (Wed, 10 Jul 2013) | 1 line HBASE-8915 protobuf message style {code} The priority checker thingy is brittle. It looks at name of incoming method to figure priority (we should do Elliott idea of having client just say what priority they want). The above change did this kinda thing: {code} 3 - rpc replicateWALEntry(ReplicateWALEntryRequest) 2 + rpc ReplicateWALEntry(ReplicateWALEntryRequest) 1 returns(ReplicateWALEntryResponse); {code} When we ask the regionserver its method via reflection it returns the proper java method name 'replicationWALEntry' but incoming, pb has method name as 'ReplicationWALEntry'. replicateWALEntry doesn't use the replication handlers -- Key: HBASE-9382 URL: https://issues.apache.org/jira/browse/HBASE-9382 Project: HBase Issue Type: Bug Affects Versions: 0.95.2 Reporter: Jean-Daniel Cryans Assignee: stack Fix For: 0.98.0, 0.96.0 By default we assign 3 handlers for replication, but as far as I can tell the replication traffic uses the normal handlers in 0.96 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira