[jira] [Commented] (HBASE-9388) [replication] ZK Dump prints the raw PBUF for the HLog positions
[ https://issues.apache.org/jira/browse/HBASE-9388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13758535#comment-13758535 ] stack commented on HBASE-9388: -- The presentation of the info is bound up w/ the composing of the info. Usually you'd want to separate the two getting the info first and then calling a method to 'present/format/publish' the collected data. What if I want to output this stuff as xml or as html, I'd have to redo this patch fundamentally rather than alter a single method. What if I want to change the formatting output? I have to go hunt it down in three places -- in the three different routines that are doing the printing to change it rather than make changes in one place in one method. [replication] ZK Dump prints the raw PBUF for the HLog positions Key: HBASE-9388 URL: https://issues.apache.org/jira/browse/HBASE-9388 Project: HBase Issue Type: Bug Affects Versions: 0.95.2 Reporter: Jean-Daniel Cryans Assignee: Jean-Daniel Cryans Fix For: 0.98.0, 0.96.0 Attachments: HBase-9388.patch, HBASE-9388.patch, ReplicationZnodesDump.png Looking at the ZK dump in the master's web ui, I can see that we're not trying to parse the positions for the HLogs so it looks like PBU��� -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9388) [replication] ZK Dump prints the raw PBUF for the HLog positions
[ https://issues.apache.org/jira/browse/HBASE-9388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13758557#comment-13758557 ] Himanshu Vashishtha commented on HBASE-9388: I was thinking of the same while redoing it... have methods to give list of znodes for these. But then, this binding of presentation and composition starts from the parent dump() API itself. If we need to make it functional programming oriented (which would be neat), I'd start from there. But then, we would be refactoring it, rather than fixing the current issue at hand. Please let me know if that's okay (refactoring a bit). Thanks. [replication] ZK Dump prints the raw PBUF for the HLog positions Key: HBASE-9388 URL: https://issues.apache.org/jira/browse/HBASE-9388 Project: HBase Issue Type: Bug Affects Versions: 0.95.2 Reporter: Jean-Daniel Cryans Assignee: Jean-Daniel Cryans Fix For: 0.98.0, 0.96.0 Attachments: HBase-9388.patch, HBASE-9388.patch, ReplicationZnodesDump.png Looking at the ZK dump in the master's web ui, I can see that we're not trying to parse the positions for the HLogs so it looks like PBU��� -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9388) [replication] ZK Dump prints the raw PBUF for the HLog positions
[ https://issues.apache.org/jira/browse/HBASE-9388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13758741#comment-13758741 ] Hudson commented on HBASE-9388: --- SUCCESS: Integrated in HBase-TRUNK #4468 (See [https://builds.apache.org/job/HBase-TRUNK/4468/]) HBASE-9388 [replication] ZK Dump prints the raw PBUF for the HLog positions (stack: rev 1520184) * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java [replication] ZK Dump prints the raw PBUF for the HLog positions Key: HBASE-9388 URL: https://issues.apache.org/jira/browse/HBASE-9388 Project: HBase Issue Type: Bug Affects Versions: 0.95.2 Reporter: Jean-Daniel Cryans Assignee: Himanshu Vashishtha Fix For: 0.98.0, 0.96.0 Attachments: HBase-9388.patch, HBASE-9388.patch, ReplicationZnodesDump.png Looking at the ZK dump in the master's web ui, I can see that we're not trying to parse the positions for the HLogs so it looks like PBU��� -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9388) [replication] ZK Dump prints the raw PBUF for the HLog positions
[ https://issues.apache.org/jira/browse/HBASE-9388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13758749#comment-13758749 ] Hudson commented on HBASE-9388: --- SUCCESS: Integrated in hbase-0.96-hadoop2 #6 (See [https://builds.apache.org/job/hbase-0.96-hadoop2/6/]) HBASE-9388 [replication] ZK Dump prints the raw PBUF for the HLog positions (stack: rev 1520183) * /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java [replication] ZK Dump prints the raw PBUF for the HLog positions Key: HBASE-9388 URL: https://issues.apache.org/jira/browse/HBASE-9388 Project: HBase Issue Type: Bug Affects Versions: 0.95.2 Reporter: Jean-Daniel Cryans Assignee: Himanshu Vashishtha Fix For: 0.98.0, 0.96.0 Attachments: HBase-9388.patch, HBASE-9388.patch, ReplicationZnodesDump.png Looking at the ZK dump in the master's web ui, I can see that we're not trying to parse the positions for the HLogs so it looks like PBU��� -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9388) [replication] ZK Dump prints the raw PBUF for the HLog positions
[ https://issues.apache.org/jira/browse/HBASE-9388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13758777#comment-13758777 ] Hudson commented on HBASE-9388: --- SUCCESS: Integrated in hbase-0.96 #12 (See [https://builds.apache.org/job/hbase-0.96/12/]) HBASE-9388 [replication] ZK Dump prints the raw PBUF for the HLog positions (stack: rev 1520183) * /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java [replication] ZK Dump prints the raw PBUF for the HLog positions Key: HBASE-9388 URL: https://issues.apache.org/jira/browse/HBASE-9388 Project: HBase Issue Type: Bug Affects Versions: 0.95.2 Reporter: Jean-Daniel Cryans Assignee: Himanshu Vashishtha Fix For: 0.98.0, 0.96.0 Attachments: HBase-9388.patch, HBASE-9388.patch, ReplicationZnodesDump.png Looking at the ZK dump in the master's web ui, I can see that we're not trying to parse the positions for the HLogs so it looks like PBU��� -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9388) [replication] ZK Dump prints the raw PBUF for the HLog positions
[ https://issues.apache.org/jira/browse/HBASE-9388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13758780#comment-13758780 ] Hudson commented on HBASE-9388: --- SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #711 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/711/]) HBASE-9388 [replication] ZK Dump prints the raw PBUF for the HLog positions (stack: rev 1520184) * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java [replication] ZK Dump prints the raw PBUF for the HLog positions Key: HBASE-9388 URL: https://issues.apache.org/jira/browse/HBASE-9388 Project: HBase Issue Type: Bug Affects Versions: 0.95.2 Reporter: Jean-Daniel Cryans Assignee: Himanshu Vashishtha Fix For: 0.98.0, 0.96.0 Attachments: HBase-9388.patch, HBASE-9388.patch, ReplicationZnodesDump.png Looking at the ZK dump in the master's web ui, I can see that we're not trying to parse the positions for the HLogs so it looks like PBU��� -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9388) [replication] ZK Dump prints the raw PBUF for the HLog positions
[ https://issues.apache.org/jira/browse/HBASE-9388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13754831#comment-13754831 ] Jean-Daniel Cryans commented on HBASE-9388: --- Oh yeah I missed that, I thought this was just used for HLog stuff. [replication] ZK Dump prints the raw PBUF for the HLog positions Key: HBASE-9388 URL: https://issues.apache.org/jira/browse/HBASE-9388 Project: HBase Issue Type: Bug Affects Versions: 0.95.2 Reporter: Jean-Daniel Cryans Assignee: Jean-Daniel Cryans Fix For: 0.98.0, 0.96.0 Attachments: HBASE-9388.patch Looking at the ZK dump in the master's web ui, I can see that we're not trying to parse the positions for the HLogs so it looks like PBU��� -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9388) [replication] ZK Dump prints the raw PBUF for the HLog positions
[ https://issues.apache.org/jira/browse/HBASE-9388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13754984#comment-13754984 ] stack commented on HBASE-9388: -- So what will this fix look like then? We have to have different deserialization per znode? [replication] ZK Dump prints the raw PBUF for the HLog positions Key: HBASE-9388 URL: https://issues.apache.org/jira/browse/HBASE-9388 Project: HBase Issue Type: Bug Affects Versions: 0.95.2 Reporter: Jean-Daniel Cryans Assignee: Jean-Daniel Cryans Fix For: 0.98.0, 0.96.0 Attachments: HBASE-9388.patch Looking at the ZK dump in the master's web ui, I can see that we're not trying to parse the positions for the HLogs so it looks like PBU��� -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9388) [replication] ZK Dump prints the raw PBUF for the HLog positions
[ https://issues.apache.org/jira/browse/HBASE-9388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13755111#comment-13755111 ] Jean-Daniel Cryans commented on HBASE-9388: --- bq. We have to have different deserialization per znode? Basically if it's a leaf under replication/rs/, we print a long. If it's a leaf under replication/peers, we print if it's enabled or disabled. [replication] ZK Dump prints the raw PBUF for the HLog positions Key: HBASE-9388 URL: https://issues.apache.org/jira/browse/HBASE-9388 Project: HBase Issue Type: Bug Affects Versions: 0.95.2 Reporter: Jean-Daniel Cryans Assignee: Jean-Daniel Cryans Fix For: 0.98.0, 0.96.0 Attachments: HBASE-9388.patch Looking at the ZK dump in the master's web ui, I can see that we're not trying to parse the positions for the HLogs so it looks like PBU��� -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9388) [replication] ZK Dump prints the raw PBUF for the HLog positions
[
https://issues.apache.org/jira/browse/HBASE-9388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13754333#comment-13754333
]
Hadoop QA commented on HBASE-9388:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12600702/HBASE-9388.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/6974//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6974//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6974//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6974//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6974//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6974//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6974//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6974//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6974//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/6974//console
This message is automatically generated.
[replication] ZK Dump prints the raw PBUF for the HLog positions
Key: HBASE-9388
URL: https://issues.apache.org/jira/browse/HBASE-9388
Project: HBase
Issue Type: Bug
Affects Versions: 0.95.2
Reporter: Jean-Daniel Cryans
Assignee: Jean-Daniel Cryans
Fix For: 0.98.0, 0.96.0
Attachments: HBASE-9388.patch
Looking at the ZK dump in the master's web ui, I can see that we're not
trying to parse the positions for the HLogs so it looks like PBU���
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9388) [replication] ZK Dump prints the raw PBUF for the HLog positions
[ https://issues.apache.org/jira/browse/HBASE-9388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13754340#comment-13754340 ] stack commented on HBASE-9388: -- +1 [replication] ZK Dump prints the raw PBUF for the HLog positions Key: HBASE-9388 URL: https://issues.apache.org/jira/browse/HBASE-9388 Project: HBase Issue Type: Bug Affects Versions: 0.95.2 Reporter: Jean-Daniel Cryans Assignee: Jean-Daniel Cryans Fix For: 0.98.0, 0.96.0 Attachments: HBASE-9388.patch Looking at the ZK dump in the master's web ui, I can see that we're not trying to parse the positions for the HLogs so it looks like PBU��� -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9388) [replication] ZK Dump prints the raw PBUF for the HLog positions
[ https://issues.apache.org/jira/browse/HBASE-9388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13754377#comment-13754377 ] Himanshu Vashishtha commented on HBASE-9388: So, it assume a long value for all znodes (it could be quorum, or peer state)? [replication] ZK Dump prints the raw PBUF for the HLog positions Key: HBASE-9388 URL: https://issues.apache.org/jira/browse/HBASE-9388 Project: HBase Issue Type: Bug Affects Versions: 0.95.2 Reporter: Jean-Daniel Cryans Assignee: Jean-Daniel Cryans Fix For: 0.98.0, 0.96.0 Attachments: HBASE-9388.patch Looking at the ZK dump in the master's web ui, I can see that we're not trying to parse the positions for the HLogs so it looks like PBU��� -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
