[jira] [Commented] (HBASE-9389) Favorednodes command line not verifying assignments correctly

2013-08-30 Thread Nicolas Liochon (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-9389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13754533#comment-13754533
 ] 

Nicolas Liochon commented on HBASE-9389:


for verifyRegionPlacement:
bq. +   * @param report
It should be @ return

But while this method now returns a report it's never used?

+if (cfStatus.getPath().getName().startsWith(.) ||
+
HConstants.HBASE_NON_USER_TABLE_DIRS.contains(cfStatus.getPath().getName())) {
We were skipping the technical directories, and .META., and now explicitly 
the system tables, but are we right to skip the system tables, .META. included? 
I could imagine that we want to use the favored node configuration for them as 
well.


 Favorednodes command line not verifying assignments correctly
 -

 Key: HBASE-9389
 URL: https://issues.apache.org/jira/browse/HBASE-9389
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.96.0
Reporter: Devaraj Das
Assignee: Devaraj Das
Priority: Critical
 Fix For: 0.96.0

 Attachments: verification-fix.1.txt


 In manual testing, encountered an issue to do with the command line tool 
 (HBASE-9116) not verifying the assignments correctly. Although the regions 
 are assigned to the favored nodes, the verification/print showed otherwise.
 The command to reproduce the problem (after having created the tables, and 
 loading some data):
 bin/hbase org.apache.hadoop.hbase.master.RegionPlacementMaintainer -tables 
 cluster_test1,cluster_test2 -hbase_root /apps/hbase/data -v 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-9389) Favorednodes command line not verifying assignments correctly

2013-08-30 Thread Nicolas Liochon (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-9389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13754786#comment-13754786
 ] 

Nicolas Liochon commented on HBASE-9389:


bq. The favored node is skipped for meta and that is true everywhere in the 
favored node code (it can be handled but it's not currently). 
Oh. I missed that previously. Good to know.

+1 

 Favorednodes command line not verifying assignments correctly
 -

 Key: HBASE-9389
 URL: https://issues.apache.org/jira/browse/HBASE-9389
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.96.0
Reporter: Devaraj Das
Assignee: Devaraj Das
Priority: Critical
 Fix For: 0.96.0

 Attachments: 9389-1.txt, verification-fix.1.txt


 In manual testing, encountered an issue to do with the command line tool 
 (HBASE-9116) not verifying the assignments correctly. Although the regions 
 are assigned to the favored nodes, the verification/print showed otherwise.
 The command to reproduce the problem (after having created the tables, and 
 loading some data):
 bin/hbase org.apache.hadoop.hbase.master.RegionPlacementMaintainer -tables 
 cluster_test1,cluster_test2 -hbase_root /apps/hbase/data -v 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-9389) Favorednodes command line not verifying assignments correctly

2013-08-30 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-9389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13754870#comment-13754870
 ] 

Hadoop QA commented on HBASE-9389:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12600797/9389-1.txt
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 
1.0 profile.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/6989//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/6989//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/6989//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/6989//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/6989//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/6989//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/6989//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/6989//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/6989//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/6989//console

This message is automatically generated.

 Favorednodes command line not verifying assignments correctly
 -

 Key: HBASE-9389
 URL: https://issues.apache.org/jira/browse/HBASE-9389
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.96.0
Reporter: Devaraj Das
Assignee: Devaraj Das
Priority: Critical
 Fix For: 0.96.0

 Attachments: 9389-1.txt, verification-fix.1.txt


 In manual testing, encountered an issue to do with the command line tool 
 (HBASE-9116) not verifying the assignments correctly. Although the regions 
 are assigned to the favored nodes, the verification/print showed otherwise.
 The command to reproduce the problem (after having created the tables, and 
 loading some data):
 bin/hbase org.apache.hadoop.hbase.master.RegionPlacementMaintainer -tables 
 cluster_test1,cluster_test2 -hbase_root /apps/hbase/data -v 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-9389) Favorednodes command line not verifying assignments correctly

2013-08-30 Thread Devaraj Das (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-9389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13754939#comment-13754939
 ] 

Devaraj Das commented on HBASE-9389:


The (unrelated) test failure seems to be caused by tasktracker not starting up 
correctly in the test. 
{noformat}
2013-08-30 16:19:37,869 INFO  [pool-1-thread-1] log.Slf4jLog(67): Stopped 
SelectChannelConnector@0.0.0.0:0
2013-08-30 16:19:37,971 ERROR [Thread-207] mapred.TaskTracker(1926): Caught 
exception: java.io.IOException: Jetty problem. Jetty didn't bind to a valid port
at 
org.apache.hadoop.mapred.TaskTracker.checkJettyPort(TaskTracker.java:1630)
at 
org.apache.hadoop.mapred.TaskTracker.offerService(TaskTracker.java:1903)
at org.apache.hadoop.mapred.TaskTracker.run(TaskTracker.java:2676)
at 
org.apache.hadoop.mapred.MiniMRCluster$TaskTrackerRunner.run(MiniMRCluster.java:217)
at java.lang.Thread.run(Thread.java:662)

{noformat}

 Favorednodes command line not verifying assignments correctly
 -

 Key: HBASE-9389
 URL: https://issues.apache.org/jira/browse/HBASE-9389
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.96.0
Reporter: Devaraj Das
Assignee: Devaraj Das
Priority: Critical
 Fix For: 0.96.0

 Attachments: 9389-1.txt, verification-fix.1.txt


 In manual testing, encountered an issue to do with the command line tool 
 (HBASE-9116) not verifying the assignments correctly. Although the regions 
 are assigned to the favored nodes, the verification/print showed otherwise.
 The command to reproduce the problem (after having created the tables, and 
 loading some data):
 bin/hbase org.apache.hadoop.hbase.master.RegionPlacementMaintainer -tables 
 cluster_test1,cluster_test2 -hbase_root /apps/hbase/data -v 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-9389) Favorednodes command line not verifying assignments correctly

2013-08-30 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-9389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13755044#comment-13755044
 ] 

Hudson commented on HBASE-9389:
---

FAILURE: Integrated in hbase-0.95-on-hadoop2 #282 (See 
[https://builds.apache.org/job/hbase-0.95-on-hadoop2/282/])
HBASE-9389. Fixes the verification part of favored node assignments (ddas: rev 
1519031)
* 
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentVerificationReport.java
* 
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionPlacementMaintainer.java
* 
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredNodesPlan.java
* 
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSRegionScanner.java
* 
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
* 
/hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java


 Favorednodes command line not verifying assignments correctly
 -

 Key: HBASE-9389
 URL: https://issues.apache.org/jira/browse/HBASE-9389
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.96.0
Reporter: Devaraj Das
Assignee: Devaraj Das
Priority: Critical
 Fix For: 0.96.0

 Attachments: 9389-1.txt, verification-fix.1.txt


 In manual testing, encountered an issue to do with the command line tool 
 (HBASE-9116) not verifying the assignments correctly. Although the regions 
 are assigned to the favored nodes, the verification/print showed otherwise.
 The command to reproduce the problem (after having created the tables, and 
 loading some data):
 bin/hbase org.apache.hadoop.hbase.master.RegionPlacementMaintainer -tables 
 cluster_test1,cluster_test2 -hbase_root /apps/hbase/data -v 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-9389) Favorednodes command line not verifying assignments correctly

2013-08-30 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-9389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13755107#comment-13755107
 ] 

Hudson commented on HBASE-9389:
---

FAILURE: Integrated in hbase-0.95 #510 (See 
[https://builds.apache.org/job/hbase-0.95/510/])
HBASE-9389. Fixes the verification part of favored node assignments (ddas: rev 
1519031)
* 
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentVerificationReport.java
* 
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionPlacementMaintainer.java
* 
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredNodesPlan.java
* 
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSRegionScanner.java
* 
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
* 
/hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java


 Favorednodes command line not verifying assignments correctly
 -

 Key: HBASE-9389
 URL: https://issues.apache.org/jira/browse/HBASE-9389
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.96.0
Reporter: Devaraj Das
Assignee: Devaraj Das
Priority: Critical
 Fix For: 0.96.0

 Attachments: 9389-1.txt, verification-fix.1.txt


 In manual testing, encountered an issue to do with the command line tool 
 (HBASE-9116) not verifying the assignments correctly. Although the regions 
 are assigned to the favored nodes, the verification/print showed otherwise.
 The command to reproduce the problem (after having created the tables, and 
 loading some data):
 bin/hbase org.apache.hadoop.hbase.master.RegionPlacementMaintainer -tables 
 cluster_test1,cluster_test2 -hbase_root /apps/hbase/data -v 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-9389) Favorednodes command line not verifying assignments correctly

2013-08-30 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-9389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13755119#comment-13755119
 ] 

Hudson commented on HBASE-9389:
---

SUCCESS: Integrated in HBase-TRUNK #4451 (See 
[https://builds.apache.org/job/HBase-TRUNK/4451/])
HBASE-9389. Fixes the verification part of favored node assignments (ddas: rev 
1519030)
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentVerificationReport.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionPlacementMaintainer.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredNodesPlan.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSRegionScanner.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java


 Favorednodes command line not verifying assignments correctly
 -

 Key: HBASE-9389
 URL: https://issues.apache.org/jira/browse/HBASE-9389
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.96.0
Reporter: Devaraj Das
Assignee: Devaraj Das
Priority: Critical
 Fix For: 0.96.0

 Attachments: 9389-1.txt, verification-fix.1.txt


 In manual testing, encountered an issue to do with the command line tool 
 (HBASE-9116) not verifying the assignments correctly. Although the regions 
 are assigned to the favored nodes, the verification/print showed otherwise.
 The command to reproduce the problem (after having created the tables, and 
 loading some data):
 bin/hbase org.apache.hadoop.hbase.master.RegionPlacementMaintainer -tables 
 cluster_test1,cluster_test2 -hbase_root /apps/hbase/data -v 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-9389) Favorednodes command line not verifying assignments correctly

2013-08-30 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-9389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13755316#comment-13755316
 ] 

Hudson commented on HBASE-9389:
---

SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #705 (See 
[https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/705/])
HBASE-9389. Fixes the verification part of favored node assignments (ddas: rev 
1519030)
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentVerificationReport.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionPlacementMaintainer.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredNodesPlan.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSRegionScanner.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java


 Favorednodes command line not verifying assignments correctly
 -

 Key: HBASE-9389
 URL: https://issues.apache.org/jira/browse/HBASE-9389
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.96.0
Reporter: Devaraj Das
Assignee: Devaraj Das
Priority: Critical
 Fix For: 0.96.0

 Attachments: 9389-1.txt, verification-fix.1.txt


 In manual testing, encountered an issue to do with the command line tool 
 (HBASE-9116) not verifying the assignments correctly. Although the regions 
 are assigned to the favored nodes, the verification/print showed otherwise.
 The command to reproduce the problem (after having created the tables, and 
 loading some data):
 bin/hbase org.apache.hadoop.hbase.master.RegionPlacementMaintainer -tables 
 cluster_test1,cluster_test2 -hbase_root /apps/hbase/data -v 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira