[jira] [Commented] (HBASE-9518) getFakedKey() improvement
[ https://issues.apache.org/jira/browse/HBASE-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13769131#comment-13769131 ] Liang Xie commented on HBASE-9518: -- any more comments? thanks > getFakedKey() improvement > - > > Key: HBASE-9518 > URL: https://issues.apache.org/jira/browse/HBASE-9518 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 0.98.0, 0.96.1 >Reporter: Liang Xie >Assignee: Liang Xie > Attachments: HBASE-9518.txt, HBASE-9518-v2.txt > > > make generating faked key algo more aggressive -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9518) getFakedKey() improvement
[ https://issues.apache.org/jira/browse/HBASE-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13769197#comment-13769197 ] stack commented on HBASE-9518: -- lgtm Makes sense (I see you left an 'opportunity for improvement' comment that this takes care of). Your explanation above should become the release note. Anyone else want to check it out? I'll commit tomorrow otherwise to trunk. > getFakedKey() improvement > - > > Key: HBASE-9518 > URL: https://issues.apache.org/jira/browse/HBASE-9518 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 0.98.0, 0.96.1 >Reporter: Liang Xie >Assignee: Liang Xie > Attachments: HBASE-9518.txt, HBASE-9518-v2.txt > > > make generating faked key algo more aggressive -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9518) getFakedKey() improvement
[ https://issues.apache.org/jira/browse/HBASE-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13771223#comment-13771223 ] Jean-Daniel Cryans commented on HBASE-9518: --- +1 When you have some time [~xieliang007], it'd be nice if you added the faked keys to this documentation http://hbase.apache.org/book.html#hfilev2 > getFakedKey() improvement > - > > Key: HBASE-9518 > URL: https://issues.apache.org/jira/browse/HBASE-9518 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 0.98.0, 0.96.1 >Reporter: Liang Xie >Assignee: Liang Xie > Attachments: HBASE-9518.txt, HBASE-9518-v2.txt > > > make generating faked key algo more aggressive -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9518) getFakedKey() improvement
[ https://issues.apache.org/jira/browse/HBASE-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13771922#comment-13771922 ] Liang Xie commented on HBASE-9518: -- [~jdcryans], thanks for review, i just filed HBASE-9583 to add the document. > getFakedKey() improvement > - > > Key: HBASE-9518 > URL: https://issues.apache.org/jira/browse/HBASE-9518 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 0.98.0, 0.96.1 >Reporter: Liang Xie >Assignee: Liang Xie > Attachments: HBASE-9518.txt, HBASE-9518-v2.txt > > > make generating faked key algo more aggressive -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9518) getFakedKey() improvement
[ https://issues.apache.org/jira/browse/HBASE-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13772654#comment-13772654 ] Hudson commented on HBASE-9518: --- SUCCESS: Integrated in HBase-TRUNK #4535 (See [https://builds.apache.org/job/HBase-TRUNK/4535/]) HBASE-9518 getFakedKey() improvement (stack: rev 1524896) * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java * /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/TestKeyValue.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHalfStoreFileReader.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheOnWrite.java > getFakedKey() improvement > - > > Key: HBASE-9518 > URL: https://issues.apache.org/jira/browse/HBASE-9518 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 0.98.0, 0.96.1 >Reporter: Liang Xie >Assignee: Liang Xie > Fix For: 0.98.0 > > Attachments: HBASE-9518.txt, HBASE-9518-v2.txt > > > make generating faked key algo more aggressive -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9518) getFakedKey() improvement
[ https://issues.apache.org/jira/browse/HBASE-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13772832#comment-13772832 ] Hudson commented on HBASE-9518: --- SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #743 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/743/]) HBASE-9518 getFakedKey() improvement (stack: rev 1524896) * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java * /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/TestKeyValue.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHalfStoreFileReader.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheOnWrite.java > getFakedKey() improvement > - > > Key: HBASE-9518 > URL: https://issues.apache.org/jira/browse/HBASE-9518 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 0.98.0, 0.96.1 >Reporter: Liang Xie >Assignee: Liang Xie > Fix For: 0.98.0 > > Attachments: HBASE-9518.txt, HBASE-9518-v2.txt > > > make generating faked key algo more aggressive -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9518) getFakedKey() improvement
[ https://issues.apache.org/jira/browse/HBASE-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13765255#comment-13765255 ] Liang Xie commented on HBASE-9518: -- TestCacheOnWrite case is updated due to the index size is smaller after applied the more aggressive change. > getFakedKey() improvement > - > > Key: HBASE-9518 > URL: https://issues.apache.org/jira/browse/HBASE-9518 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 0.98.0, 0.96.1 >Reporter: Liang Xie >Assignee: Liang Xie > Attachments: HBASE-9518.txt > > > make generating faked key algo more aggressive -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9518) getFakedKey() improvement
[
https://issues.apache.org/jira/browse/HBASE-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13765288#comment-13765288
]
Hadoop QA commented on HBASE-9518:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12602750/HBASE-9518.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.io.TestHalfStoreFileReader
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/7180//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7180//console
This message is automatically generated.
> getFakedKey() improvement
> -
>
> Key: HBASE-9518
> URL: https://issues.apache.org/jira/browse/HBASE-9518
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Affects Versions: 0.98.0, 0.96.1
>Reporter: Liang Xie
>Assignee: Liang Xie
> Attachments: HBASE-9518.txt
>
>
> make generating faked key algo more aggressive
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9518) getFakedKey() improvement
[
https://issues.apache.org/jira/browse/HBASE-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13765468#comment-13765468
]
Ted Yu commented on HBASE-9518:
---
{code}
+ System.out.println("midkey: " + midKV + " or: " +
Bytes.toStringBinary(midkey));
+ System.out.println("beforeMidKey: " + beforeMidKey);
{code}
Can you replace the above with LOG ?
> getFakedKey() improvement
> -
>
> Key: HBASE-9518
> URL: https://issues.apache.org/jira/browse/HBASE-9518
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Affects Versions: 0.98.0, 0.96.1
>Reporter: Liang Xie
>Assignee: Liang Xie
> Attachments: HBASE-9518.txt, HBASE-9518-v2.txt
>
>
> make generating faked key algo more aggressive
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9518) getFakedKey() improvement
[
https://issues.apache.org/jira/browse/HBASE-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13765459#comment-13765459
]
Hadoop QA commented on HBASE-9518:
--
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12602773/HBASE-9518-v2.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 9 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/7185//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7185//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7185//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7185//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7185//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7185//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7185//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7185//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7185//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7185//console
This message is automatically generated.
> getFakedKey() improvement
> -
>
> Key: HBASE-9518
> URL: https://issues.apache.org/jira/browse/HBASE-9518
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Affects Versions: 0.98.0, 0.96.1
>Reporter: Liang Xie
>Assignee: Liang Xie
> Attachments: HBASE-9518.txt, HBASE-9518-v2.txt
>
>
> make generating faked key algo more aggressive
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9518) getFakedKey() improvement
[ https://issues.apache.org/jira/browse/HBASE-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767033#comment-13767033 ] stack commented on HBASE-9518: -- bq. make generating faked key algo more aggressive What does this mean [~xieliang007]? Thanks. > getFakedKey() improvement > - > > Key: HBASE-9518 > URL: https://issues.apache.org/jira/browse/HBASE-9518 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 0.98.0, 0.96.1 >Reporter: Liang Xie >Assignee: Liang Xie > Attachments: HBASE-9518.txt, HBASE-9518-v2.txt > > > make generating faked key algo more aggressive -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9518) getFakedKey() improvement
[ https://issues.apache.org/jira/browse/HBASE-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767482#comment-13767482 ] Liang Xie commented on HBASE-9518: -- Hi [~stack] you can see the new TestKeyValue case: if the last kv of previous block and the first kv of current block have same postfix and just 1 offset diff, e.g. 100abcdefg and 101abcdefg, before 9518, the getShortMidpointKey() will fallback to the default right kv, say 101abcdefg. after 9518, it'll return "101", a shorter faked value, still reasonable, right? :) And i found this corner case existing in current hbase test cases as well, so i'd like to let it go into community codebase also. > getFakedKey() improvement > - > > Key: HBASE-9518 > URL: https://issues.apache.org/jira/browse/HBASE-9518 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 0.98.0, 0.96.1 >Reporter: Liang Xie >Assignee: Liang Xie > Attachments: HBASE-9518.txt, HBASE-9518-v2.txt > > > make generating faked key algo more aggressive -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
