[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13818122#comment-13818122 ] Hudson commented on HBASE-9808: --- SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #834 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/834/]) HBASE-9808 org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation (tedyu: rev 1540245) * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/PerformanceEvaluation.java > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > Fix For: 0.98.0 > > Attachments: HBASE-9808-v1.patch, HBASE-9808-v2.patch, > HBASE-9808-v3.patch, HBASE-9808.patch > > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clean clearBufferOnFail behavior and deprecate it > > r1518341 | jdcryans | 2013-08-28 12:46:55 -0700 (Wed, 28 Aug 2013) | 2 lines > HBASE-9330 Refactor PE to create HTable the correct way > {code} > Long term, we may consider consolidating the two PerformanceEvaluation > classes so that such maintenance work can be reduced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13818106#comment-13818106 ] Hudson commented on HBASE-9808: --- SUCCESS: Integrated in HBase-TRUNK #4677 (See [https://builds.apache.org/job/HBase-TRUNK/4677/]) HBASE-9808 org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation (tedyu: rev 1540245) * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/PerformanceEvaluation.java > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > Fix For: 0.98.0 > > Attachments: HBASE-9808-v1.patch, HBASE-9808-v2.patch, > HBASE-9808-v3.patch, HBASE-9808.patch > > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clean clearBufferOnFail behavior and deprecate it > > r1518341 | jdcryans | 2013-08-28 12:46:55 -0700 (Wed, 28 Aug 2013) | 2 lines > HBASE-9330 Refactor PE to create HTable the correct way > {code} > Long term, we may consider consolidating the two PerformanceEvaluation > classes so that such maintenance work can be reduced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817970#comment-13817970 ] Gustavo Anatoly commented on HBASE-9808: Thanks Ted and Nick, for helping me. > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > Fix For: 0.98.0 > > Attachments: HBASE-9808-v1.patch, HBASE-9808-v2.patch, > HBASE-9808-v3.patch, HBASE-9808.patch > > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clean clearBufferOnFail behavior and deprecate it > > r1518341 | jdcryans | 2013-08-28 12:46:55 -0700 (Wed, 28 Aug 2013) | 2 lines > HBASE-9330 Refactor PE to create HTable the correct way > {code} > Long term, we may consider consolidating the two PerformanceEvaluation > classes so that such maintenance work can be reduced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817960#comment-13817960 ] Ted Yu commented on HBASE-9808: --- Ran TestLogRolling#testCompactionRecordDoesntBlockRolling locally and it passed. Integrated to trunk. Thanks for the patch, Gustavo. Thanks for the review, Nick. > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > Attachments: HBASE-9808-v1.patch, HBASE-9808-v2.patch, > HBASE-9808-v3.patch, HBASE-9808.patch > > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clean clearBufferOnFail behavior and deprecate it > > r1518341 | jdcryans | 2013-08-28 12:46:55 -0700 (Wed, 28 Aug 2013) | 2 lines > HBASE-9330 Refactor PE to create HTable the correct way > {code} > Long term, we may consider consolidating the two PerformanceEvaluation > classes so that such maintenance work can be reduced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817605#comment-13817605 ] Gustavo Anatoly commented on HBASE-9808: While this, I will try understand the other issue: [HBASE-9809|https://issues.apache.org/jira/browse/HBASE-9809] > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > Attachments: HBASE-9808-v1.patch, HBASE-9808-v2.patch, > HBASE-9808-v3.patch, HBASE-9808.patch > > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clean clearBufferOnFail behavior and deprecate it > > r1518341 | jdcryans | 2013-08-28 12:46:55 -0700 (Wed, 28 Aug 2013) | 2 lines > HBASE-9330 Refactor PE to create HTable the correct way > {code} > Long term, we may consider consolidating the two PerformanceEvaluation > classes so that such maintenance work can be reduced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817588#comment-13817588 ] Ted Yu commented on HBASE-9808: --- I think so. > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > Attachments: HBASE-9808-v1.patch, HBASE-9808-v2.patch, > HBASE-9808-v3.patch, HBASE-9808.patch > > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clean clearBufferOnFail behavior and deprecate it > > r1518341 | jdcryans | 2013-08-28 12:46:55 -0700 (Wed, 28 Aug 2013) | 2 lines > HBASE-9330 Refactor PE to create HTable the correct way > {code} > Long term, we may consider consolidating the two PerformanceEvaluation > classes so that such maintenance work can be reduced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817587#comment-13817587 ] Gustavo Anatoly commented on HBASE-9808: Okay, Ted. Do you think, that patch it's completed? > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > Attachments: HBASE-9808-v1.patch, HBASE-9808-v2.patch, > HBASE-9808-v3.patch, HBASE-9808.patch > > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clean clearBufferOnFail behavior and deprecate it > > r1518341 | jdcryans | 2013-08-28 12:46:55 -0700 (Wed, 28 Aug 2013) | 2 lines > HBASE-9330 Refactor PE to create HTable the correct way > {code} > Long term, we may consider consolidating the two PerformanceEvaluation > classes so that such maintenance work can be reduced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817320#comment-13817320 ] Ted Yu commented on HBASE-9808: --- Test failure is not related. Will wait one day in case Jon has more comments. > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > Attachments: HBASE-9808-v1.patch, HBASE-9808-v2.patch, > HBASE-9808-v3.patch, HBASE-9808.patch > > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clean clearBufferOnFail behavior and deprecate it > > r1518341 | jdcryans | 2013-08-28 12:46:55 -0700 (Wed, 28 Aug 2013) | 2 lines > HBASE-9330 Refactor PE to create HTable the correct way > {code} > Long term, we may consider consolidating the two PerformanceEvaluation > classes so that such maintenance work can be reduced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817103#comment-13817103 ] Hadoop QA commented on HBASE-9808: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12612753/HBASE-9808-v3.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop 1.0 profile. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1 warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 site{color}. The patch appears to cause mvn site goal to fail. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.wal.TestLogRolling Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7788//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7788//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7788//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7788//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7788//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7788//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7788//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7788//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7788//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7788//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7788//console This message is automatically generated. > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > Attachments: HBASE-9808-v1.patch, HBASE-9808-v2.patch, > HBASE-9808-v3.patch, HBASE-9808.patch > > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clean clearBufferOnF
[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816881#comment-13816881 ] Gustavo Anatoly commented on HBASE-9808: Interesting, Nick :). Has been attached patch (v3) again, but with whitespace removed. [https://reviews.apache.org/r/15327/] Thanks for the tip. > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > Attachments: HBASE-9808-v1.patch, HBASE-9808-v2.patch, > HBASE-9808-v3.patch, HBASE-9808.patch > > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clean clearBufferOnFail behavior and deprecate it > > r1518341 | jdcryans | 2013-08-28 12:46:55 -0700 (Wed, 28 Aug 2013) | 2 lines > HBASE-9330 Refactor PE to create HTable the correct way > {code} > Long term, we may consider consolidating the two PerformanceEvaluation > classes so that such maintenance work can be reduced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816773#comment-13816773 ] Nick Dimiduk commented on HBASE-9808: - I just use whitespace mode in emacs ;) > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > Attachments: HBASE-9808-v1.patch, HBASE-9808-v2.patch, > HBASE-9808-v3.patch, HBASE-9808.patch > > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clean clearBufferOnFail behavior and deprecate it > > r1518341 | jdcryans | 2013-08-28 12:46:55 -0700 (Wed, 28 Aug 2013) | 2 lines > HBASE-9330 Refactor PE to create HTable the correct way > {code} > Long term, we may consider consolidating the two PerformanceEvaluation > classes so that such maintenance work can be reduced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816419#comment-13816419 ] Gustavo Anatoly commented on HBASE-9808: Now, I can see white spaces. I will fix it. Thanks. > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > Attachments: HBASE-9808-v1.patch, HBASE-9808-v2.patch, > HBASE-9808-v3.patch, HBASE-9808.patch > > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clean clearBufferOnFail behavior and deprecate it > > r1518341 | jdcryans | 2013-08-28 12:46:55 -0700 (Wed, 28 Aug 2013) | 2 lines > HBASE-9330 Refactor PE to create HTable the correct way > {code} > Long term, we may consider consolidating the two PerformanceEvaluation > classes so that such maintenance work can be reduced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816404#comment-13816404 ] Ted Yu commented on HBASE-9808: --- You can find out where whitespace was introduced by using https://reviews.apache.org Create a new review request. Select 'hbase' for 'Repository:' In 'Base Directory:', enter '/' (without quotes) Select patch v3. You would see a new whitespace on line 296. > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > Attachments: HBASE-9808-v1.patch, HBASE-9808-v2.patch, > HBASE-9808-v3.patch, HBASE-9808.patch > > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clean clearBufferOnFail behavior and deprecate it > > r1518341 | jdcryans | 2013-08-28 12:46:55 -0700 (Wed, 28 Aug 2013) | 2 lines > HBASE-9330 Refactor PE to create HTable the correct way > {code} > Long term, we may consider consolidating the two PerformanceEvaluation > classes so that such maintenance work can be reduced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816298#comment-13816298 ] Nick Dimiduk commented on HBASE-9808: - I don't see this class listed in the findbugs results; I don't think it's this patch. Not sure about the javadoc. > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > Attachments: HBASE-9808-v1.patch, HBASE-9808-v2.patch, > HBASE-9808.patch > > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clean clearBufferOnFail behavior and deprecate it > > r1518341 | jdcryans | 2013-08-28 12:46:55 -0700 (Wed, 28 Aug 2013) | 2 lines > HBASE-9330 Refactor PE to create HTable the correct way > {code} > Long term, we may consider consolidating the two PerformanceEvaluation > classes so that such maintenance work can be reduced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816296#comment-13816296 ] Nick Dimiduk commented on HBASE-9808: - {noformat} +scan.setCaching(100); {noformat} Just omit this line entirely. This can be done on commit -- same with the WS. Looks good otherwise. +1. > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > Attachments: HBASE-9808-v1.patch, HBASE-9808-v2.patch, > HBASE-9808.patch > > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clean clearBufferOnFail behavior and deprecate it > > r1518341 | jdcryans | 2013-08-28 12:46:55 -0700 (Wed, 28 Aug 2013) | 2 lines > HBASE-9330 Refactor PE to create HTable the correct way > {code} > Long term, we may consider consolidating the two PerformanceEvaluation > classes so that such maintenance work can be reduced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815755#comment-13815755 ] Hadoop QA commented on HBASE-9808: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12612526/HBASE-9808-v2.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop 1.0 profile. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1 warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 findbugs{color}. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 site{color}. The patch appears to cause mvn site goal to fail. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7773//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7773//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7773//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7773//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7773//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7773//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7773//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7773//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7773//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7773//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7773//console This message is automatically generated. > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > Attachments: HBASE-9808-v1.patch, HBASE-9808-v2.patch, > HBASE-9808.patch > > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clean clearBufferOnFail behavior and deprecate it > ---
[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813146#comment-13813146 ] Gustavo Anatoly commented on HBASE-9808: Thanks for review. You're right, I will fix it now, about performance commentary, was my error when sync two classes. > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > Attachments: HBASE-9808-v1.patch, HBASE-9808.patch > > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clean clearBufferOnFail behavior and deprecate it > > r1518341 | jdcryans | 2013-08-28 12:46:55 -0700 (Wed, 28 Aug 2013) | 2 lines > HBASE-9330 Refactor PE to create HTable the correct way > {code} > Long term, we may consider consolidating the two PerformanceEvaluation > classes so that such maintenance work can be reduced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813086#comment-13813086 ] Nick Dimiduk commented on HBASE-9808: - {noformat} +TableMapReduceUtil.addDependencyJars(job); +// Add a Class from the hbase.jar so it gets registered too. +TableMapReduceUtil.addDependencyJars(job.getConfiguration(), + org.apache.hadoop.hbase.util.Bytes.class); +TableMapReduceUtil.initCredentials(job); {noformat} the call to {{addDependencyJars(Configuration, Class)}} is not necessary because you've already called {{addDependencyJars(Job)}}. {noformat} void testRow(final int i) throws IOException { if (this.testScanner == null) { Scan scan = new Scan(format(this.startRow)); +scan.setCaching(30); scan.addColumn(FAMILY_NAME, QUALIFIER_NAME); this.testScanner = table.getScanner(scan); } {noformat} Our value in hbase-default.xml is now 100. What's the reason for lowering this value? {noformat} + * This method takes some time and is done inline uploading data. For + * example, doing the mapfile test, generation of the key and value + * consumes about 30% of CPU time. + * @return Generated random value to insert into a table cell. {noformat} Yikes! This is throwing off the performance number then? There's still trailing whitespace in places. > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > Attachments: HBASE-9808-v1.patch, HBASE-9808.patch > > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clean clearBufferOnFail behavior and deprecate it > > r1518341 | jdcryans | 2013-08-28 12:46:55 -0700 (Wed, 28 Aug 2013) | 2 lines > HBASE-9330 Refactor PE to create HTable the correct way > {code} > Long term, we may consider consolidating the two PerformanceEvaluation > classes so that such maintenance work can be reduced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13812585#comment-13812585 ] Ted Yu commented on HBASE-9808: --- Test failures were not related to the patch. > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > Attachments: HBASE-9808-v1.patch, HBASE-9808.patch > > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clean clearBufferOnFail behavior and deprecate it > > r1518341 | jdcryans | 2013-08-28 12:46:55 -0700 (Wed, 28 Aug 2013) | 2 lines > HBASE-9330 Refactor PE to create HTable the correct way > {code} > Long term, we may consider consolidating the two PerformanceEvaluation > classes so that such maintenance work can be reduced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13812531#comment-13812531 ] Hadoop QA commented on HBASE-9808: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12611840/HBASE-9808-v1.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop 1.0 profile. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 findbugs{color}. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 site{color}. The patch appears to cause mvn site goal to fail. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestHRegion org.apache.hadoop.hbase.regionserver.TestHRegionBusyWait Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7720//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7720//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7720//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7720//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7720//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7720//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7720//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7720//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7720//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7720//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7720//console This message is automatically generated. > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > Attachments: HBASE-9808-v1.patch, HBASE-9808.patch > > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clea
[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13806890#comment-13806890 ] Gustavo Anatoly commented on HBASE-9808: Hi, Nick. Thanks for review the patch, and I will fix the whitespace on the next patch. About the folding Rest functionality, has some particularities, such as use RemoteAdmin instead of HBaseAdmin (I'm working on this at moment), but the first view, yes we can aggregate them. > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > Attachments: HBASE-9808.patch > > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clean clearBufferOnFail behavior and deprecate it > > r1518341 | jdcryans | 2013-08-28 12:46:55 -0700 (Wed, 28 Aug 2013) | 2 lines > HBASE-9330 Refactor PE to create HTable the correct way > {code} > Long term, we may consider consolidating the two PerformanceEvaluation > classes so that such maintenance work can be reduced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13806778#comment-13806778 ] Nick Dimiduk commented on HBASE-9808: - These changes look pretty good. Please clean up the whitespace as part of your next revision. I'm seeing quite a lot of duplication with the regular PerformanceEvaluation tool. Any chance of folding the Rest functionality into that tool so we can remove duplication? See also HBASE-9599. > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > Attachments: HBASE-9808.patch > > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clean clearBufferOnFail behavior and deprecate it > > r1518341 | jdcryans | 2013-08-28 12:46:55 -0700 (Wed, 28 Aug 2013) | 2 lines > HBASE-9330 Refactor PE to create HTable the correct way > {code} > Long term, we may consider consolidating the two PerformanceEvaluation > classes so that such maintenance work can be reduced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805974#comment-13805974 ] Gustavo Anatoly commented on HBASE-9808: Ted, I'm still doing the changes, to resubmit a new patch. > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > Attachments: HBASE-9808.patch > > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clean clearBufferOnFail behavior and deprecate it > > r1518341 | jdcryans | 2013-08-28 12:46:55 -0700 (Wed, 28 Aug 2013) | 2 lines > HBASE-9330 Refactor PE to create HTable the correct way > {code} > Long term, we may consider consolidating the two PerformanceEvaluation > classes so that such maintenance work can be reduced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805857#comment-13805857 ] Hadoop QA commented on HBASE-9808: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12610386/HBASE-9808.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop 1.0 profile. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 findbugs{color}. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 site{color}. The patch appears to cause mvn site goal to fail. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.wal.TestLogRolling Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7637//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7637//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7637//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7637//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7637//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7637//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7637//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7637//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7637//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7637//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7637//console This message is automatically generated. > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > Attachments: HBASE-9808.patch > > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clean clearBufferOnFail behavior and deprecate it >
[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805750#comment-13805750 ] Gustavo Anatoly commented on HBASE-9808: Ok, I will fix it tonight and resubmit the patch. > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > Attachments: HBASE-9808.patch > > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clean clearBufferOnFail behavior and deprecate it > > r1518341 | jdcryans | 2013-08-28 12:46:55 -0700 (Wed, 28 Aug 2013) | 2 lines > HBASE-9330 Refactor PE to create HTable the correct way > {code} > Long term, we may consider consolidating the two PerformanceEvaluation > classes so that such maintenance work can be reduced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805733#comment-13805733 ] Ted Yu commented on HBASE-9808: --- Looking at svn history for src/test/java/org/apache/hadoop/hbase/rest/PerformanceEvaluation.java , it was created in HBASE-2542 I went through the patch once. Looks Okay. > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > Attachments: HBASE-9808.patch > > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clean clearBufferOnFail behavior and deprecate it > > r1518341 | jdcryans | 2013-08-28 12:46:55 -0700 (Wed, 28 Aug 2013) | 2 lines > HBASE-9330 Refactor PE to create HTable the correct way > {code} > Long term, we may consider consolidating the two PerformanceEvaluation > classes so that such maintenance work can be reduced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805711#comment-13805711 ] Gustavo Anatoly commented on HBASE-9808: Ted, I finished the task, but I have a question. Why we have two classes doing the same behavior? And could you please review the patch? I did some tests, but you have others test that I should run? > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > Attachments: HBASE-9808.patch > > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clean clearBufferOnFail behavior and deprecate it > > r1518341 | jdcryans | 2013-08-28 12:46:55 -0700 (Wed, 28 Aug 2013) | 2 lines > HBASE-9330 Refactor PE to create HTable the correct way > {code} > Long term, we may consider consolidating the two PerformanceEvaluation > classes so that such maintenance work can be reduced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13804388#comment-13804388 ] Ted Yu commented on HBASE-9808: --- Thanks a lot, Gustavo. > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clean clearBufferOnFail behavior and deprecate it > > r1518341 | jdcryans | 2013-08-28 12:46:55 -0700 (Wed, 28 Aug 2013) | 2 lines > HBASE-9330 Refactor PE to create HTable the correct way > {code} > Long term, we may consider consolidating the two PerformanceEvaluation > classes so that such maintenance work can be reduced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9808) org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with org.apache.hadoop.hbase.PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13804113#comment-13804113 ] Gustavo Anatoly commented on HBASE-9808: Ted, I'm still working with the aggregate diff file, because I'm having problems with malformed patch when applied, on my working copy. But, I'm doing efforts to finish this issue fast. > org.apache.hadoop.hbase.rest.PerformanceEvaluation is out of sync with > org.apache.hadoop.hbase.PerformanceEvaluation > > > Key: HBASE-9808 > URL: https://issues.apache.org/jira/browse/HBASE-9808 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Gustavo Anatoly > > Here is list of JIRAs whose fixes might have gone into > rest.PerformanceEvaluation : > {code} > > r1527817 | mbertozzi | 2013-09-30 15:57:44 -0700 (Mon, 30 Sep 2013) | 1 line > HBASE-9663 PerformanceEvaluation does not properly honor specified table name > parameter > > r1526452 | mbertozzi | 2013-09-26 04:58:50 -0700 (Thu, 26 Sep 2013) | 1 line > HBASE-9662 PerformanceEvaluation input do not handle tags properties > > r1525269 | ramkrishna | 2013-09-21 11:01:32 -0700 (Sat, 21 Sep 2013) | 3 lines > HBASE-8496 - Implement tags and the internals of how a tag should look like > (Ram) > > r1524985 | nkeywal | 2013-09-20 06:02:54 -0700 (Fri, 20 Sep 2013) | 1 line > HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a > dependency to MiniDFSCluster > > r1523782 | nkeywal | 2013-09-16 13:07:13 -0700 (Mon, 16 Sep 2013) | 1 line > HBASE-9521 clean clearBufferOnFail behavior and deprecate it > > r1518341 | jdcryans | 2013-08-28 12:46:55 -0700 (Wed, 28 Aug 2013) | 2 lines > HBASE-9330 Refactor PE to create HTable the correct way > {code} > Long term, we may consider consolidating the two PerformanceEvaluation > classes so that such maintenance work can be reduced. -- This message was sent by Atlassian JIRA (v6.1#6144)