[jira] [Commented] (HBASE-9856) Fix some findbugs Performance Warnings
[
https://issues.apache.org/jira/browse/HBASE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13836432#comment-13836432
]
Hudson commented on HBASE-9856:
---
SUCCESS: Integrated in HBase-TRUNK #4706 (See
[https://builds.apache.org/job/HBase-TRUNK/4706/])
HBASE-9856 Fix some findbugs Performance Warnings (tedyu: rev 1546888)
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEditsReplaySink.java
Fix some findbugs Performance Warnings
--
Key: HBASE-9856
URL: https://issues.apache.org/jira/browse/HBASE-9856
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Priority: Minor
Fix For: 0.98.0
Attachments: 9856-v1.txt, 9856-v2.txt
These are the warnings to be fixed:
{code}
SIC Should org.apache.hadoop.hbase.regionserver.HRegion$RowLock be a _static_
inner class?
UPM Private method
org.apache.hadoop.hbase.security.access.AccessController.requirePermission(String,
String, Permission$Action[]) is never called
WMI Method
org.apache.hadoop.hbase.regionserver.wal.WALEditsReplaySink.replayEntries(List)
makes inefficient use of keySet iterator instead of entrySet iterator
{code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9856) Fix some findbugs Performance Warnings
[
https://issues.apache.org/jira/browse/HBASE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13836574#comment-13836574
]
Hudson commented on HBASE-9856:
---
SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #860 (See
[https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/860/])
HBASE-9856 Fix some findbugs Performance Warnings (tedyu: rev 1546888)
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEditsReplaySink.java
Fix some findbugs Performance Warnings
--
Key: HBASE-9856
URL: https://issues.apache.org/jira/browse/HBASE-9856
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Priority: Minor
Fix For: 0.98.0
Attachments: 9856-v1.txt, 9856-v2.txt
These are the warnings to be fixed:
{code}
SIC Should org.apache.hadoop.hbase.regionserver.HRegion$RowLock be a _static_
inner class?
UPM Private method
org.apache.hadoop.hbase.security.access.AccessController.requirePermission(String,
String, Permission$Action[]) is never called
WMI Method
org.apache.hadoop.hbase.regionserver.wal.WALEditsReplaySink.replayEntries(List)
makes inefficient use of keySet iterator instead of entrySet iterator
{code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9856) Fix some findbugs Performance Warnings
[
https://issues.apache.org/jira/browse/HBASE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13836210#comment-13836210
]
Andrew Purtell commented on HBASE-9856:
---
Should this be committed?
Fix some findbugs Performance Warnings
--
Key: HBASE-9856
URL: https://issues.apache.org/jira/browse/HBASE-9856
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Priority: Minor
Fix For: 0.98.0
Attachments: 9856-v1.txt
These are the warnings to be fixed:
{code}
SIC Should org.apache.hadoop.hbase.regionserver.HRegion$RowLock be a _static_
inner class?
UPM Private method
org.apache.hadoop.hbase.security.access.AccessController.requirePermission(String,
String, Permission$Action[]) is never called
WMI Method
org.apache.hadoop.hbase.regionserver.wal.WALEditsReplaySink.replayEntries(List)
makes inefficient use of keySet iterator instead of entrySet iterator
{code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9856) Fix some findbugs Performance Warnings
[
https://issues.apache.org/jira/browse/HBASE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13836212#comment-13836212
]
Ted Yu commented on HBASE-9856:
---
The change in AccessController.java is no longer needed.
Integrated to trunk.
Fix some findbugs Performance Warnings
--
Key: HBASE-9856
URL: https://issues.apache.org/jira/browse/HBASE-9856
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Priority: Minor
Fix For: 0.98.0
Attachments: 9856-v1.txt, 9856-v2.txt
These are the warnings to be fixed:
{code}
SIC Should org.apache.hadoop.hbase.regionserver.HRegion$RowLock be a _static_
inner class?
UPM Private method
org.apache.hadoop.hbase.security.access.AccessController.requirePermission(String,
String, Permission$Action[]) is never called
WMI Method
org.apache.hadoop.hbase.regionserver.wal.WALEditsReplaySink.replayEntries(List)
makes inefficient use of keySet iterator instead of entrySet iterator
{code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9856) Fix some findbugs Performance Warnings
[
https://issues.apache.org/jira/browse/HBASE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808219#comment-13808219
]
Jeffrey Zhong commented on HBASE-9856:
--
Looks good to me(+1). Thanks.
Fix some findbugs Performance Warnings
--
Key: HBASE-9856
URL: https://issues.apache.org/jira/browse/HBASE-9856
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Fix For: 0.98.0
Attachments: 9856-v1.txt
These are the warnings to be fixed:
{code}
SIC Should org.apache.hadoop.hbase.regionserver.HRegion$RowLock be a _static_
inner class?
UPM Private method
org.apache.hadoop.hbase.security.access.AccessController.requirePermission(String,
String, Permission$Action[]) is never called
WMI Method
org.apache.hadoop.hbase.regionserver.wal.WALEditsReplaySink.replayEntries(List)
makes inefficient use of keySet iterator instead of entrySet iterator
{code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9856) Fix some findbugs Performance Warnings
[
https://issues.apache.org/jira/browse/HBASE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808306#comment-13808306
]
Hadoop QA commented on HBASE-9856:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12610863/9856-v1.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 7
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/7665//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7665//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7665//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7665//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7665//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7665//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7665//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7665//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7665//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7665//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7665//console
This message is automatically generated.
Fix some findbugs Performance Warnings
--
Key: HBASE-9856
URL: https://issues.apache.org/jira/browse/HBASE-9856
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Priority: Trivial
Fix For: 0.98.0
Attachments: 9856-v1.txt
These are the warnings to be fixed:
{code}
SIC Should org.apache.hadoop.hbase.regionserver.HRegion$RowLock be a _static_
inner class?
UPM Private method
org.apache.hadoop.hbase.security.access.AccessController.requirePermission(String,
String, Permission$Action[]) is never called
WMI Method
org.apache.hadoop.hbase.regionserver.wal.WALEditsReplaySink.replayEntries(List)
makes inefficient use of keySet iterator instead of entrySet iterator
{code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
