[jira] [Commented] (HBASE-9862) manage error per server and per region in the protobuffed client
[ https://issues.apache.org/jira/browse/HBASE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13810206#comment-13810206 ] Hudson commented on HBASE-9862: --- SUCCESS: Integrated in hbase-0.96 #173 (See [https://builds.apache.org/job/hbase-0.96/173/]) HBASE-9862 manage error per server and per region in the protobuffed client (nkeywal: rev 1537432) * /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java * /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiResponse.java * /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiServerCallable.java * /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java manage error per server and per region in the protobuffed client Key: HBASE-9862 URL: https://issues.apache.org/jira/browse/HBASE-9862 Project: HBase Issue Type: Bug Components: Client Affects Versions: 0.98.0, 0.96.0 Reporter: Nicolas Liochon Assignee: Nicolas Liochon Fix For: 0.98.0, 0.96.1 Attachments: 9862.v2.patch The patch does not change anything else than the description says. The changes are about extracting the common paths. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9862) manage error per server and per region in the protobuffed client
[ https://issues.apache.org/jira/browse/HBASE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13810252#comment-13810252 ] Hudson commented on HBASE-9862: --- SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #819 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/819/]) HBASE-9862 manage error per server and per region in the protobuffed client (nkeywal: rev 1537431) * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiResponse.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiServerCallable.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java manage error per server and per region in the protobuffed client Key: HBASE-9862 URL: https://issues.apache.org/jira/browse/HBASE-9862 Project: HBase Issue Type: Bug Components: Client Affects Versions: 0.98.0, 0.96.0 Reporter: Nicolas Liochon Assignee: Nicolas Liochon Fix For: 0.98.0, 0.96.1 Attachments: 9862.v2.patch The patch does not change anything else than the description says. The changes are about extracting the common paths. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9862) manage error per server and per region in the protobuffed client
[ https://issues.apache.org/jira/browse/HBASE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13810256#comment-13810256 ] Hudson commented on HBASE-9862: --- FAILURE: Integrated in hbase-0.96-hadoop2 #108 (See [https://builds.apache.org/job/hbase-0.96-hadoop2/108/]) HBASE-9862 manage error per server and per region in the protobuffed client (nkeywal: rev 1537432) * /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java * /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiResponse.java * /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiServerCallable.java * /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java manage error per server and per region in the protobuffed client Key: HBASE-9862 URL: https://issues.apache.org/jira/browse/HBASE-9862 Project: HBase Issue Type: Bug Components: Client Affects Versions: 0.98.0, 0.96.0 Reporter: Nicolas Liochon Assignee: Nicolas Liochon Fix For: 0.98.0, 0.96.1 Attachments: 9862.v2.patch The patch does not change anything else than the description says. The changes are about extracting the common paths. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9862) manage error per server and per region in the protobuffed client
[ https://issues.apache.org/jira/browse/HBASE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13810264#comment-13810264 ] Hudson commented on HBASE-9862: --- FAILURE: Integrated in HBase-TRUNK #4659 (See [https://builds.apache.org/job/HBase-TRUNK/4659/]) HBASE-9862 manage error per server and per region in the protobuffed client (nkeywal: rev 1537431) * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiResponse.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiServerCallable.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java manage error per server and per region in the protobuffed client Key: HBASE-9862 URL: https://issues.apache.org/jira/browse/HBASE-9862 Project: HBase Issue Type: Bug Components: Client Affects Versions: 0.98.0, 0.96.0 Reporter: Nicolas Liochon Assignee: Nicolas Liochon Fix For: 0.98.0, 0.96.1 Attachments: 9862.v2.patch The patch does not change anything else than the description says. The changes are about extracting the common paths. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9862) manage error per server and per region in the protobuffed client
[
https://issues.apache.org/jira/browse/HBASE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809560#comment-13809560
]
stack commented on HBASE-9862:
--
I tried it in my little harness and it doesn't break anything at least.
Patch application failed because you added something I had -- catching
Thowables.
+} catch (Throwable t) {
+ // This should not happen. Let's log retry anyway.
+ LOG.warn(# + id + , Caught throwable while calling. This is
unexpected. +
+ Retrying. Server is + loc.getServerName() + ,
tableName= + tableName, t);
+ receiveGlobalFailure(initialActions, multiAction, loc,
numAttempt, t,
+ errorsByServer);
return;
The above should be LOG.error because it is not supposed to happen (though it
did for me when making up my harness getting stuff wrong and probably for you
when you were refactoring -- it is too easy for exceptions to be suppressed in
this stuff).
We don't usually run w/ asserts:
+ assert responses != null;
.. perhaps in testing, I don't recall.
Let me mess some more w/ it in place before I give a +1... let me manufacture
the errors you address here.
manage error per server and per region in the protobuffed client
Key: HBASE-9862
URL: https://issues.apache.org/jira/browse/HBASE-9862
Project: HBase
Issue Type: Bug
Components: Client
Affects Versions: 0.98.0, 0.96.0
Reporter: Nicolas Liochon
Assignee: Nicolas Liochon
Fix For: 0.98.0, 0.96.1
Attachments: 9862.v2.patch
The patch does not change anything else than the description says. The
changes are about extracting the common paths.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9862) manage error per server and per region in the protobuffed client
[ https://issues.apache.org/jira/browse/HBASE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809573#comment-13809573 ] Sergey Shelukhin commented on HBASE-9862: - iirc we used to run w/asserts in testing, at least in the past. Patch looks reasonable, assuming it's just a refactoring for the most part it should be good. One thing we could do in theory (in some other jira) is somehow wake sleepers that want to retry to particular regions, when we get updated cache location for that region. manage error per server and per region in the protobuffed client Key: HBASE-9862 URL: https://issues.apache.org/jira/browse/HBASE-9862 Project: HBase Issue Type: Bug Components: Client Affects Versions: 0.98.0, 0.96.0 Reporter: Nicolas Liochon Assignee: Nicolas Liochon Fix For: 0.98.0, 0.96.1 Attachments: 9862.v2.patch The patch does not change anything else than the description says. The changes are about extracting the common paths. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9862) manage error per server and per region in the protobuffed client
[ https://issues.apache.org/jira/browse/HBASE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809588#comment-13809588 ] Nicolas Liochon commented on HBASE-9862: For the assert, I've used them as a kind of documentation (I use IllegalState when I fear it could occur in production). When we run the tests they are activated. I can remove them, or replace them with an IllegalArgumentException. bq. assuming it's just a refactoring for the most part it should be good. Yes, the logic is not supposed to change (if I did it well :-) ). The changes are 90% code extraction. The remaining 10% took me a while... Thanks for the comments. manage error per server and per region in the protobuffed client Key: HBASE-9862 URL: https://issues.apache.org/jira/browse/HBASE-9862 Project: HBase Issue Type: Bug Components: Client Affects Versions: 0.98.0, 0.96.0 Reporter: Nicolas Liochon Assignee: Nicolas Liochon Fix For: 0.98.0, 0.96.1 Attachments: 9862.v2.patch The patch does not change anything else than the description says. The changes are about extracting the common paths. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9862) manage error per server and per region in the protobuffed client
[
https://issues.apache.org/jira/browse/HBASE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809602#comment-13809602
]
Hadoop QA commented on HBASE-9862:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12611147/9862.v2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/7677//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7677//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7677//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7677//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7677//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7677//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7677//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7677//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7677//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7677//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7677//console
This message is automatically generated.
manage error per server and per region in the protobuffed client
Key: HBASE-9862
URL: https://issues.apache.org/jira/browse/HBASE-9862
Project: HBase
Issue Type: Bug
Components: Client
Affects Versions: 0.98.0, 0.96.0
Reporter: Nicolas Liochon
Assignee: Nicolas Liochon
Fix For: 0.98.0, 0.96.1
Attachments: 9862.v2.patch
The patch does not change anything else than the description says. The
changes are about extracting the common paths.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9862) manage error per server and per region in the protobuffed client
[ https://issues.apache.org/jira/browse/HBASE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809663#comment-13809663 ] stack commented on HBASE-9862: -- +1 Throwing a few exceptions it keeps chugging along so basic operation seems fine. manage error per server and per region in the protobuffed client Key: HBASE-9862 URL: https://issues.apache.org/jira/browse/HBASE-9862 Project: HBase Issue Type: Bug Components: Client Affects Versions: 0.98.0, 0.96.0 Reporter: Nicolas Liochon Assignee: Nicolas Liochon Fix For: 0.98.0, 0.96.1 Attachments: 9862.v2.patch The patch does not change anything else than the description says. The changes are about extracting the common paths. -- This message was sent by Atlassian JIRA (v6.1#6144)
