[jira] [Commented] (HBASE-9889) Make sure we clean up scannerReadPoints upon any exceptions

2013-12-16 Thread stack (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-9889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850101#comment-13850101
 ] 

stack commented on HBASE-9889:
--

[~amitanand] You resolved it as fixed but issue is pointing at 0.99.   You mean 
0.89fb?  Thanks.

> Make sure we clean up scannerReadPoints upon any exceptions
> ---
>
> Key: HBASE-9889
> URL: https://issues.apache.org/jira/browse/HBASE-9889
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 0.89-fb, 0.94.12, 0.96.0
>Reporter: Amitanand Aiyer
>Assignee: Amitanand Aiyer
>Priority: Minor
> Fix For: 0.99.0
>
> Attachments: hbase-9889.diff
>
>
> If there is an exception in the creation of RegionScanner (for example, 
> exception while opening store files) the scanner Read points is not cleaned 
> up.
> Having an unused old entry in the scannerReadPoints means that flushes and 
> compactions cannot garbage-collect older versions.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Commented] (HBASE-9889) Make sure we clean up scannerReadPoints upon any exceptions

2013-11-06 Thread Amitanand Aiyer (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-9889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815590#comment-13815590
 ] 

Amitanand Aiyer commented on HBASE-9889:


I think we can move it to the end of the constructor.

Just need to make sure that we grab the read points before we open the scanners 
(have seen get latency go up .. if we move the entier synchronized () .. block 
to the end).

for the removal .. i think it is okay. scannerReadPoints is supposed to be a 
concurrentHashMap.

> Make sure we clean up scannerReadPoints upon any exceptions
> ---
>
> Key: HBASE-9889
> URL: https://issues.apache.org/jira/browse/HBASE-9889
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 0.89-fb, 0.94.12, 0.96.0
>Reporter: Amitanand Aiyer
>Assignee: Amitanand Aiyer
>Priority: Minor
> Fix For: 0.96.1
>
> Attachments: hbase-9889.diff
>
>
> If there is an exception in the creation of RegionScanner (for example, 
> exception while opening store files) the scanner Read points is not cleaned 
> up.
> Having an unused old entry in the scannerReadPoints means that flushes and 
> compactions cannot garbage-collect older versions.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (HBASE-9889) Make sure we clean up scannerReadPoints upon any exceptions

2013-11-05 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-9889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813868#comment-13813868
 ] 

Hadoop QA commented on HBASE-9889:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12612003/hbase-9889.diff
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 
1.0 profile.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:red}-1 findbugs{color}.  The patch appears to introduce 2 new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

{color:red}-1 site{color}.  The patch appears to cause mvn site goal to 
fail.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   
org.apache.hadoop.hbase.security.access.TestNamespaceCommands

 {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s):   
at 
org.apache.hadoop.hbase.TestZooKeeper.testRegionAssignmentAfterMasterRecoveryDueToZKExpiry(TestZooKeeper.java:486)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/7737//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/7737//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/7737//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/7737//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/7737//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/7737//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/7737//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/7737//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/7737//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/7737//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/7737//console

This message is automatically generated.

> Make sure we clean up scannerReadPoints upon any exceptions
> ---
>
> Key: HBASE-9889
> URL: https://issues.apache.org/jira/browse/HBASE-9889
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 0.89-fb, 0.94.12, 0.96.0
>Reporter: Amitanand Aiyer
>Assignee: Amitanand Aiyer
>Priority: Minor
> Fix For: 0.96.1
>
> Attachments: hbase-9889.diff
>
>
> If there is an exception in the creation of RegionScanner (for example, 
> exception while opening store files) the scanner Read points is not cleaned 
> up.
> Having an unused old entry in the scannerReadPoints means that flushes and 
> compactions cannot garbage-collect older versions.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (HBASE-9889) Make sure we clean up scannerReadPoints upon any exceptions

2013-11-04 Thread Lars Hofhansl (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-9889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813693#comment-13813693
 ] 

Lars Hofhansl commented on HBASE-9889:
--

Need to synchronize any changes to scannerReadPoints.
I wonder whether it would instead be correct to just add to scannerReadPoints 
at the end of the constructor.


> Make sure we clean up scannerReadPoints upon any exceptions
> ---
>
> Key: HBASE-9889
> URL: https://issues.apache.org/jira/browse/HBASE-9889
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 0.89-fb, 0.94.12, 0.96.0
>Reporter: Amitanand Aiyer
>Assignee: Amitanand Aiyer
>Priority: Minor
> Fix For: 0.96.1
>
> Attachments: hbase-9889.diff
>
>
> If there is an exception in the creation of RegionScanner (for example, 
> exception while opening store files) the scanner Read points is not cleaned 
> up.
> Having an unused old entry in the scannerReadPoints means that flushes and 
> compactions cannot garbage-collect older versions.



--
This message was sent by Atlassian JIRA
(v6.1#6144)