[jira] [Commented] (HBASE-9989) Add a test on get in TestClientNoCluster
[ https://issues.apache.org/jira/browse/HBASE-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829771#comment-13829771 ] Nicolas Liochon commented on HBASE-9989: Yeah, the story on protobuf is not over I guess. I plan to do 3 tests next week: - test on get - test on the same machine (i.e. not network, and matches a real use case when the clients are deployed on the same machines) - test on a large enough cluster (~50 nodes). > Add a test on get in TestClientNoCluster > > > Key: HBASE-9989 > URL: https://issues.apache.org/jira/browse/HBASE-9989 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.98.0, 0.96.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon >Priority: Trivial > Fix For: 0.98.0, 0.96.1 > > Attachments: 9989.v1.patch > > -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9989) Add a test on get in TestClientNoCluster
[ https://issues.apache.org/jira/browse/HBASE-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829758#comment-13829758 ] stack commented on HBASE-9989: -- bq. I suppose that the solution to this is to create the builders with the HTable objects, then to pass them all along... You mean the client Get, Put, etc.? If so, yeah, would think these become facades on pbs. > Add a test on get in TestClientNoCluster > > > Key: HBASE-9989 > URL: https://issues.apache.org/jira/browse/HBASE-9989 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.98.0, 0.96.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon >Priority: Trivial > Fix For: 0.98.0, 0.96.1 > > Attachments: 9989.v1.patch > > -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9989) Add a test on get in TestClientNoCluster
[ https://issues.apache.org/jira/browse/HBASE-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13827572#comment-13827572 ] Hudson commented on HBASE-9989: --- SUCCESS: Integrated in hbase-0.96-hadoop2 #125 (See [https://builds.apache.org/job/hbase-0.96-hadoop2/125/]) HBASE-9989 Add a test on get in TestClientNoCluster (nkeywal: rev 1543515) * /hbase/branches/0.96/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java > Add a test on get in TestClientNoCluster > > > Key: HBASE-9989 > URL: https://issues.apache.org/jira/browse/HBASE-9989 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.98.0, 0.96.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon >Priority: Trivial > Fix For: 0.98.0, 0.96.1 > > Attachments: 9989.v1.patch > > -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9989) Add a test on get in TestClientNoCluster
[ https://issues.apache.org/jira/browse/HBASE-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13827024#comment-13827024 ] Hudson commented on HBASE-9989: --- SUCCESS: Integrated in HBase-TRUNK #4688 (See [https://builds.apache.org/job/HBase-TRUNK/4688/]) HBASE-9989 Add a test on get in TestClientNoCluster (nkeywal: rev 1543514) * /hbase/trunk/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java > Add a test on get in TestClientNoCluster > > > Key: HBASE-9989 > URL: https://issues.apache.org/jira/browse/HBASE-9989 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.98.0, 0.96.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon >Priority: Trivial > Fix For: 0.98.0, 0.96.1 > > Attachments: 9989.v1.patch > > -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9989) Add a test on get in TestClientNoCluster
[ https://issues.apache.org/jira/browse/HBASE-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826988#comment-13826988 ] Hudson commented on HBASE-9989: --- SUCCESS: Integrated in hbase-0.96 #196 (See [https://builds.apache.org/job/hbase-0.96/196/]) HBASE-9989 Add a test on get in TestClientNoCluster (nkeywal: rev 1543515) * /hbase/branches/0.96/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java > Add a test on get in TestClientNoCluster > > > Key: HBASE-9989 > URL: https://issues.apache.org/jira/browse/HBASE-9989 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.98.0, 0.96.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon >Priority: Trivial > Fix For: 0.98.0, 0.96.1 > > Attachments: 9989.v1.patch > > -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9989) Add a test on get in TestClientNoCluster
[ https://issues.apache.org/jira/browse/HBASE-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826845#comment-13826845 ] Hudson commented on HBASE-9989: --- SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #844 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/844/]) HBASE-9989 Add a test on get in TestClientNoCluster (nkeywal: rev 1543514) * /hbase/trunk/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java > Add a test on get in TestClientNoCluster > > > Key: HBASE-9989 > URL: https://issues.apache.org/jira/browse/HBASE-9989 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.98.0, 0.96.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon >Priority: Trivial > Fix For: 0.98.0, 0.96.1 > > Attachments: 9989.v1.patch > > -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9989) Add a test on get in TestClientNoCluster
[ https://issues.apache.org/jira/browse/HBASE-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826722#comment-13826722 ] Nicolas Liochon commented on HBASE-9989: Committed, thanks for the review Nick. > Add a test on get in TestClientNoCluster > > > Key: HBASE-9989 > URL: https://issues.apache.org/jira/browse/HBASE-9989 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.98.0, 0.96.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon >Priority: Trivial > Fix For: 0.98.0, 0.96.1 > > Attachments: 9989.v1.patch > > -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9989) Add a test on get in TestClientNoCluster
[
https://issues.apache.org/jira/browse/HBASE-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826705#comment-13826705
]
Hadoop QA commented on HBASE-9989:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12614414/9989.v1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
10 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/7932//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7932//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7932//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7932//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7932//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7932//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7932//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7932//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7932//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7932//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7932//console
This message is automatically generated.
> Add a test on get in TestClientNoCluster
>
>
> Key: HBASE-9989
> URL: https://issues.apache.org/jira/browse/HBASE-9989
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 0.98.0, 0.96.0
>Reporter: Nicolas Liochon
>Assignee: Nicolas Liochon
>Priority: Trivial
> Fix For: 0.98.0, 0.96.1
>
> Attachments: 9989.v1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9989) Add a test on get in TestClientNoCluster
[ https://issues.apache.org/jira/browse/HBASE-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825999#comment-13825999 ] Nick Dimiduk commented on HBASE-9989: - protobuf-gcless looks very interesting. +1 on the patch. Let's see what BuildBot says. > Add a test on get in TestClientNoCluster > > > Key: HBASE-9989 > URL: https://issues.apache.org/jira/browse/HBASE-9989 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.98.0, 0.96.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon >Priority: Trivial > Fix For: 0.98.0, 0.96.1 > > Attachments: 9989.v1.patch > > -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9989) Add a test on get in TestClientNoCluster
[ https://issues.apache.org/jira/browse/HBASE-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825649#comment-13825649 ] Nicolas Liochon commented on HBASE-9989: And as a side note it seems that the protobuf teams considers that byte copy or object creation is a non issue in java: array copy is cheap: http://code.google.com/p/protobuf/issues/detail?id=374 creating objects is cheap: http://comments.gmane.org/gmane.comp.lib.protocol-buffers.general/2667 someone created this: http://code.google.com/p/protobuf-gcless/ :-) > Add a test on get in TestClientNoCluster > > > Key: HBASE-9989 > URL: https://issues.apache.org/jira/browse/HBASE-9989 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.98.0, 0.96.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon >Priority: Trivial > Fix For: 0.98.0, 0.96.1 > > Attachments: 9989.v1.patch > > -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9989) Add a test on get in TestClientNoCluster
[ https://issues.apache.org/jira/browse/HBASE-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825633#comment-13825633 ] Nicolas Liochon commented on HBASE-9989: I suppose that the solution to this is to create the builders with the HTable objects, then to pass them all along... > Add a test on get in TestClientNoCluster > > > Key: HBASE-9989 > URL: https://issues.apache.org/jira/browse/HBASE-9989 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.98.0, 0.96.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon >Priority: Trivial > Fix For: 0.98.0, 0.96.1 > > Attachments: 9989.v1.patch > > -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9989) Add a test on get in TestClientNoCluster
[ https://issues.apache.org/jira/browse/HBASE-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825470#comment-13825470 ] Nicolas Liochon commented on HBASE-9989: fwiw, here are the builders we create for each get request (not taking into account that we need to parse the result). ClientProtos.GetRequest.Builder requestBuilder = ClientProtos.GetRequest.newBuilder(); HBaseProtos.RegionSpecifier.Builder regionBuilder = HBaseProtos.RegionSpecifier.newBuilder(); ClientProtos.Get.Builder getBuilder = ClientProtos.Get.newBuilder(); FilterProtos.Filter.Builder filterBuilder = FilterProtos.Filter.newBuilder(); HBaseProtos.TimeRange.Builder timeRangeBuilder = HBaseProtos.TimeRange.newBuilder(); HBaseProtos.NameBytesPair.Builder attributeBuilder = HBaseProtos.NameBytesPair.newBuilder(); ClientProtos.Column.Builder columnBuilder = ClientProtos.Column.newBuilder(); > Add a test on get in TestClientNoCluster > > > Key: HBASE-9989 > URL: https://issues.apache.org/jira/browse/HBASE-9989 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.98.0, 0.96.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon >Priority: Trivial > Fix For: 0.98.0, 0.96.1 > > Attachments: 9989.v1.patch > > -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9989) Add a test on get in TestClientNoCluster
[ https://issues.apache.org/jira/browse/HBASE-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825446#comment-13825446 ] Nicolas Liochon commented on HBASE-9989: I don't submit it to save an execution round on Apache builds, but it's ready for integration. > Add a test on get in TestClientNoCluster > > > Key: HBASE-9989 > URL: https://issues.apache.org/jira/browse/HBASE-9989 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.98.0, 0.96.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon >Priority: Trivial > Fix For: 0.98.0, 0.96.1 > > Attachments: 9989.v1.patch > > -- This message was sent by Atlassian JIRA (v6.1#6144)
