[jira] [Commented] (HBASE-9996) move the log io operation out of updateLock scope

2013-11-21 Thread stack (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-9996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13829763#comment-13829763
 ] 

stack commented on HBASE-9996:
--

Trunk does this already.

 move the log io operation out of updateLock scope
 -

 Key: HBASE-9996
 URL: https://issues.apache.org/jira/browse/HBASE-9996
 Project: HBase
  Issue Type: Improvement
  Components: regionserver
Affects Versions: 0.94.13
Reporter: Liang Xie
Assignee: Liang Xie
 Attachments: HBase-9996-0.94.txt


 I am working at another write outlier issue, and just saw this code pattern:
 {code}
 synchronized(updateLock) {
 ...
 LOG.info(xxx)
 ...
 }
 {code}
 let's move the log statement out of this sync block.  seems it's ok in trunk 
 code, just a 0.94 issue



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (HBASE-9996) move the log io operation out of updateLock scope

2013-11-19 Thread Jean-Marc Spaggiari (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-9996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13826448#comment-13826448
 ] 

Jean-Marc Spaggiari commented on HBASE-9996:


sgtm

Any risks that this.fs.getFileStatus(oldFile).getLen() changes between the sync 
and when it's called just after?

+1

 move the log io operation out of updateLock scope
 -

 Key: HBASE-9996
 URL: https://issues.apache.org/jira/browse/HBASE-9996
 Project: HBase
  Issue Type: Improvement
  Components: regionserver
Affects Versions: 0.94.13
Reporter: Liang Xie
Assignee: Liang Xie
 Attachments: HBase-9996-0.94.txt


 I am working at another write outlier issue, and just saw this code pattern:
 {code}
 synchronized(updateLock) {
 ...
 LOG.info(xxx)
 ...
 }
 {code}
 let's move the log statement out of this sync block.  seems it's ok in trunk 
 code, just a 0.94 issue



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (HBASE-9996) move the log io operation out of updateLock scope

2013-11-19 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-9996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13826474#comment-13826474
 ] 

Hadoop QA commented on HBASE-9996:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12614578/HBase-9996-0.94.txt
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/7930//console

This message is automatically generated.

 move the log io operation out of updateLock scope
 -

 Key: HBASE-9996
 URL: https://issues.apache.org/jira/browse/HBASE-9996
 Project: HBase
  Issue Type: Improvement
  Components: regionserver
Affects Versions: 0.94.13
Reporter: Liang Xie
Assignee: Liang Xie
 Attachments: HBase-9996-0.94.txt


 I am working at another write outlier issue, and just saw this code pattern:
 {code}
 synchronized(updateLock) {
 ...
 LOG.info(xxx)
 ...
 }
 {code}
 let's move the log statement out of this sync block.  seems it's ok in trunk 
 code, just a 0.94 issue



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (HBASE-9996) move the log io operation out of updateLock scope

2013-11-19 Thread Liang Xie (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-9996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13827246#comment-13827246
 ] 

Liang Xie commented on HBASE-9996:
--

[~jmspaggi], at my knowledge, the length would not be changed once after the 
sync block, since writer has been changed and the new data will be written into 
the new file.

 move the log io operation out of updateLock scope
 -

 Key: HBASE-9996
 URL: https://issues.apache.org/jira/browse/HBASE-9996
 Project: HBase
  Issue Type: Improvement
  Components: regionserver
Affects Versions: 0.94.13
Reporter: Liang Xie
Assignee: Liang Xie
 Attachments: HBase-9996-0.94.txt


 I am working at another write outlier issue, and just saw this code pattern:
 {code}
 synchronized(updateLock) {
 ...
 LOG.info(xxx)
 ...
 }
 {code}
 let's move the log statement out of this sync block.  seems it's ok in trunk 
 code, just a 0.94 issue



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (HBASE-9996) move the log io operation out of updateLock scope

2013-11-19 Thread Lars Hofhansl (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-9996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13827393#comment-13827393
 ] 

Lars Hofhansl commented on HBASE-9996:
--

Looks good. I do not expect any measurable performance gain from this, though.

 move the log io operation out of updateLock scope
 -

 Key: HBASE-9996
 URL: https://issues.apache.org/jira/browse/HBASE-9996
 Project: HBase
  Issue Type: Improvement
  Components: regionserver
Affects Versions: 0.94.13
Reporter: Liang Xie
Assignee: Liang Xie
 Attachments: HBase-9996-0.94.txt


 I am working at another write outlier issue, and just saw this code pattern:
 {code}
 synchronized(updateLock) {
 ...
 LOG.info(xxx)
 ...
 }
 {code}
 let's move the log statement out of this sync block.  seems it's ok in trunk 
 code, just a 0.94 issue



--
This message was sent by Atlassian JIRA
(v6.1#6144)