[jira] [Updated] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-10255: -- Resolution: Duplicate Assignee: (was: Ted Yu) Status: Resolved (was: Patch Available) Resolving as dupe of HBASE-19651 > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Priority: Minor > Attachments: 10255-v1.txt, 10255-v2.txt, alternate_lis.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-10255: --- Fix Version/s: (was: 0.99.0) (was: 0.98.0) Unscheduled. > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Attachments: 10255-v1.txt, 10255-v2.txt, alternate_lis.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-10255: -- Attachment: alternate_lis.txt Here is an alternate solution to this issue. The guava mess seems like a red herring. The added LIS from guava seems a workaround because pb LIS is protected. Would suggest we cut to the chase and use the pb version rather than guava or some class from somewhere else altogether. > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Fix For: 0.98.0, 0.99.0 > > Attachments: 10255-v1.txt, 10255-v2.txt, alternate_lis.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-10255: -- Priority: Minor (was: Major) Marking minor. Readjust if I have it wrong. [~ted_yu] I review your code because I am afraid if I don't, damaging changes will be committed; e.g. here you were upping the guava version which historically has proven a problematic exercise yet there is no evidence of testing done other than the running of some unit tests (guava issues usually show when downstreamers would make use of an hbase client to get to a cluster). This work seems prompted by HBASE-10174, where there there was a wrong-headed attempt at adding a guava class to hbase core. Meantime these issue have priority minor or trivial with no apparent real world justification, yet, of a weekend, Andrew Purtell is distracted reviewing minor/trivial patches though he has far higher priority issues on his plate trying to put together a release. I would suggest that if others are going to be distracted, then it should be for issues of higher priority and on issues that it is easy to discern how they move the project forward. > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Fix For: 0.98.0, 0.99.0 > > Attachments: 10255-v1.txt, 10255-v2.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-10255: --- Fix Version/s: 0.99.0 0.98.0 > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 0.98.0, 0.99.0 > > Attachments: 10255-v1.txt, 10255-v2.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-10255: --- Attachment: 10255-v2.txt bq. or use something from anywhere but Guava to replace it Good idea. Patch v2 uses org.apache.commons.io.input.BoundedInputStream where no upgrade of any dependency is needed. > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 10255-v1.txt, 10255-v2.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-10255: --- Status: Patch Available (was: Open) > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 10255-v1.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-10255: --- Attachment: 10255-v1.txt > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 10255-v1.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
