[jira] [Updated] (HBASE-11251) LoadTestTool should grant READ permission for the users that are given READ access for specific cells

2014-05-26 Thread Andrew Purtell (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell updated HBASE-11251:
---

Attachment: HBASE-11251-addendum-0.98.patch
HBASE-11251-addendum-trunk.patch

Addendums for trunk and 0.98. Contains testing fixes and a small cleanup of 
redundant code. TestTableLockManager passes locally on trunk and 0.98 after 
this change is applied. A cherry pick of this change set from trunk to 0.98 had 
one reject in LoadTestTool so there are two patches here.

> LoadTestTool should grant READ permission for the users that are given READ 
> access for specific cells
> -
>
> Key: HBASE-11251
> URL: https://issues.apache.org/jira/browse/HBASE-11251
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.98.2
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.99.0, 0.98.3
>
> Attachments: HBASE-11251-addendum-0.98.patch, 
> HBASE-11251-addendum-trunk.patch, HBASE-11251_0.98.patch, 
> HBASE-11251_0.98_1.patch, HBASE-11251_trunk.patch, HBASE-11251_trunk_1.patch
>
>
> In 0.98.2 onwards the AccessControlFilter
> {code}
> case CHECK_CELL_FIRST: {
> LOG.info("Am coming here for cell first strategy");
> if (authManager.authorize(user, table, cell, Permission.Action.READ) 
> &&
> authManager.authorize(user, table, family, qualifier, 
> Permission.Action.READ)) {
>   LOG.info("Returning include");
>   return ReturnCode.INCLUDE;
> }
> {code}
> expects a READ permission on the table for those Users that are granted READ 
> permission on the cell level.
> In 0.98.1
> {code}
> if (authManager.authorize(user, table, cell, cellFirstStrategy, 
> Permission.Action.READ)) {
>   return ReturnCode.INCLUDE;
> }
> {code}
> So from 0.98.2 onwards IntegrationTestIngestWithACL was failing.  Hence this 
> JIRA is targeted to correct the behaviour and make the IT work again.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (HBASE-11251) LoadTestTool should grant READ permission for the users that are given READ access for specific cells

2014-05-25 Thread ramkrishna.s.vasudevan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ramkrishna.s.vasudevan updated HBASE-11251:
---

Status: Open  (was: Patch Available)

> LoadTestTool should grant READ permission for the users that are given READ 
> access for specific cells
> -
>
> Key: HBASE-11251
> URL: https://issues.apache.org/jira/browse/HBASE-11251
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.98.2
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.99.0, 0.98.3
>
> Attachments: HBASE-11251_0.98.patch, HBASE-11251_0.98_1.patch, 
> HBASE-11251_trunk.patch, HBASE-11251_trunk_1.patch
>
>
> In 0.98.2 onwards the AccessControlFilter
> {code}
> case CHECK_CELL_FIRST: {
> LOG.info("Am coming here for cell first strategy");
> if (authManager.authorize(user, table, cell, Permission.Action.READ) 
> &&
> authManager.authorize(user, table, family, qualifier, 
> Permission.Action.READ)) {
>   LOG.info("Returning include");
>   return ReturnCode.INCLUDE;
> }
> {code}
> expects a READ permission on the table for those Users that are granted READ 
> permission on the cell level.
> In 0.98.1
> {code}
> if (authManager.authorize(user, table, cell, cellFirstStrategy, 
> Permission.Action.READ)) {
>   return ReturnCode.INCLUDE;
> }
> {code}
> So from 0.98.2 onwards IntegrationTestIngestWithACL was failing.  Hence this 
> JIRA is targeted to correct the behaviour and make the IT work again.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (HBASE-11251) LoadTestTool should grant READ permission for the users that are given READ access for specific cells

2014-05-25 Thread ramkrishna.s.vasudevan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ramkrishna.s.vasudevan updated HBASE-11251:
---

Attachment: HBASE-11251_trunk_1.patch
HBASE-11251_0.98_1.patch

> LoadTestTool should grant READ permission for the users that are given READ 
> access for specific cells
> -
>
> Key: HBASE-11251
> URL: https://issues.apache.org/jira/browse/HBASE-11251
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.98.2
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.99.0, 0.98.3
>
> Attachments: HBASE-11251_0.98.patch, HBASE-11251_0.98_1.patch, 
> HBASE-11251_trunk.patch, HBASE-11251_trunk_1.patch
>
>
> In 0.98.2 onwards the AccessControlFilter
> {code}
> case CHECK_CELL_FIRST: {
> LOG.info("Am coming here for cell first strategy");
> if (authManager.authorize(user, table, cell, Permission.Action.READ) 
> &&
> authManager.authorize(user, table, family, qualifier, 
> Permission.Action.READ)) {
>   LOG.info("Returning include");
>   return ReturnCode.INCLUDE;
> }
> {code}
> expects a READ permission on the table for those Users that are granted READ 
> permission on the cell level.
> In 0.98.1
> {code}
> if (authManager.authorize(user, table, cell, cellFirstStrategy, 
> Permission.Action.READ)) {
>   return ReturnCode.INCLUDE;
> }
> {code}
> So from 0.98.2 onwards IntegrationTestIngestWithACL was failing.  Hence this 
> JIRA is targeted to correct the behaviour and make the IT work again.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (HBASE-11251) LoadTestTool should grant READ permission for the users that are given READ access for specific cells

2014-05-25 Thread ramkrishna.s.vasudevan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ramkrishna.s.vasudevan updated HBASE-11251:
---

Attachment: HBASE-11251_0.98.patch

> LoadTestTool should grant READ permission for the users that are given READ 
> access for specific cells
> -
>
> Key: HBASE-11251
> URL: https://issues.apache.org/jira/browse/HBASE-11251
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.98.2
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.99.0, 0.98.3
>
> Attachments: HBASE-11251_0.98.patch, HBASE-11251_trunk.patch
>
>
> In 0.98.2 onwards the AccessControlFilter
> {code}
> case CHECK_CELL_FIRST: {
> LOG.info("Am coming here for cell first strategy");
> if (authManager.authorize(user, table, cell, Permission.Action.READ) 
> &&
> authManager.authorize(user, table, family, qualifier, 
> Permission.Action.READ)) {
>   LOG.info("Returning include");
>   return ReturnCode.INCLUDE;
> }
> {code}
> expects a READ permission on the table for those Users that are granted READ 
> permission on the cell level.
> In 0.98.1
> {code}
> if (authManager.authorize(user, table, cell, cellFirstStrategy, 
> Permission.Action.READ)) {
>   return ReturnCode.INCLUDE;
> }
> {code}
> So from 0.98.2 onwards IntegrationTestIngestWithACL was failing.  Hence this 
> JIRA is targeted to correct the behaviour and make the IT work again.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (HBASE-11251) LoadTestTool should grant READ permission for the users that are given READ access for specific cells

2014-05-25 Thread ramkrishna.s.vasudevan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ramkrishna.s.vasudevan updated HBASE-11251:
---

Attachment: HBASE-11251_trunk.patch

> LoadTestTool should grant READ permission for the users that are given READ 
> access for specific cells
> -
>
> Key: HBASE-11251
> URL: https://issues.apache.org/jira/browse/HBASE-11251
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.98.2
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.99.0, 0.98.3
>
> Attachments: HBASE-11251_0.98.patch, HBASE-11251_trunk.patch
>
>
> In 0.98.2 onwards the AccessControlFilter
> {code}
> case CHECK_CELL_FIRST: {
> LOG.info("Am coming here for cell first strategy");
> if (authManager.authorize(user, table, cell, Permission.Action.READ) 
> &&
> authManager.authorize(user, table, family, qualifier, 
> Permission.Action.READ)) {
>   LOG.info("Returning include");
>   return ReturnCode.INCLUDE;
> }
> {code}
> expects a READ permission on the table for those Users that are granted READ 
> permission on the cell level.
> In 0.98.1
> {code}
> if (authManager.authorize(user, table, cell, cellFirstStrategy, 
> Permission.Action.READ)) {
>   return ReturnCode.INCLUDE;
> }
> {code}
> So from 0.98.2 onwards IntegrationTestIngestWithACL was failing.  Hence this 
> JIRA is targeted to correct the behaviour and make the IT work again.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (HBASE-11251) LoadTestTool should grant READ permission for the users that are given READ access for specific cells

2014-05-25 Thread ramkrishna.s.vasudevan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ramkrishna.s.vasudevan updated HBASE-11251:
---

Status: Patch Available  (was: Open)

> LoadTestTool should grant READ permission for the users that are given READ 
> access for specific cells
> -
>
> Key: HBASE-11251
> URL: https://issues.apache.org/jira/browse/HBASE-11251
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.98.2
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.99.0, 0.98.3
>
> Attachments: HBASE-11251_0.98.patch, HBASE-11251_trunk.patch
>
>
> In 0.98.2 onwards the AccessControlFilter
> {code}
> case CHECK_CELL_FIRST: {
> LOG.info("Am coming here for cell first strategy");
> if (authManager.authorize(user, table, cell, Permission.Action.READ) 
> &&
> authManager.authorize(user, table, family, qualifier, 
> Permission.Action.READ)) {
>   LOG.info("Returning include");
>   return ReturnCode.INCLUDE;
> }
> {code}
> expects a READ permission on the table for those Users that are granted READ 
> permission on the cell level.
> In 0.98.1
> {code}
> if (authManager.authorize(user, table, cell, cellFirstStrategy, 
> Permission.Action.READ)) {
>   return ReturnCode.INCLUDE;
> }
> {code}
> So from 0.98.2 onwards IntegrationTestIngestWithACL was failing.  Hence this 
> JIRA is targeted to correct the behaviour and make the IT work again.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (HBASE-11251) LoadTestTool should grant READ permission for the users that are given READ access for specific cells

2014-05-25 Thread ramkrishna.s.vasudevan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ramkrishna.s.vasudevan updated HBASE-11251:
---

Fix Version/s: 0.99.0

> LoadTestTool should grant READ permission for the users that are given READ 
> access for specific cells
> -
>
> Key: HBASE-11251
> URL: https://issues.apache.org/jira/browse/HBASE-11251
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.98.2
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.99.0, 0.98.3
>
>
> In 0.98.2 onwards the AccessControlFilter
> {code}
> case CHECK_CELL_FIRST: {
> LOG.info("Am coming here for cell first strategy");
> if (authManager.authorize(user, table, cell, Permission.Action.READ) 
> &&
> authManager.authorize(user, table, family, qualifier, 
> Permission.Action.READ)) {
>   LOG.info("Returning include");
>   return ReturnCode.INCLUDE;
> }
> {code}
> expects a READ permission on the table for those Users that are granted READ 
> permission on the cell level.
> In 0.98.1
> {code}
> if (authManager.authorize(user, table, cell, cellFirstStrategy, 
> Permission.Action.READ)) {
>   return ReturnCode.INCLUDE;
> }
> {code}
> So from 0.98.2 onwards IntegrationTestIngestWithACL was failing.  Hence this 
> JIRA is targeted to correct the behaviour and make the IT work again.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (HBASE-11251) LoadTestTool should grant READ permission for the users that are given READ access for specific cells

2014-05-25 Thread ramkrishna.s.vasudevan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ramkrishna.s.vasudevan updated HBASE-11251:
---

Summary: LoadTestTool should grant READ permission for the users that are 
given READ access for specific cells  (was: LoadTestTool should grant READ 
permission for the users that are given READ access)

> LoadTestTool should grant READ permission for the users that are given READ 
> access for specific cells
> -
>
> Key: HBASE-11251
> URL: https://issues.apache.org/jira/browse/HBASE-11251
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.98.2
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.98.3
>
>
> In 0.98.2 onwards the AccessControlFilter
> {code}
> case CHECK_CELL_FIRST: {
> LOG.info("Am coming here for cell first strategy");
> if (authManager.authorize(user, table, cell, Permission.Action.READ) 
> &&
> authManager.authorize(user, table, family, qualifier, 
> Permission.Action.READ)) {
>   LOG.info("Returning include");
>   return ReturnCode.INCLUDE;
> }
> {code}
> expects a READ permission on the table for those Users that are granted READ 
> permission on the cell level.
> In 0.98.1
> {code}
> if (authManager.authorize(user, table, cell, cellFirstStrategy, 
> Permission.Action.READ)) {
>   return ReturnCode.INCLUDE;
> }
> {code}
> So from 0.98.2 onwards IntegrationTestIngestWithACL was failing.  Hence this 
> JIRA is targeted to correct the behaviour and make the IT work again.



--
This message was sent by Atlassian JIRA
(v6.2#6252)