[jira] [Updated] (HBASE-12164) Check for presence of user Id in SecureBulkLoadEndpoint#secureBulkLoadHFiles() is inaccurate
[ https://issues.apache.org/jira/browse/HBASE-12164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-12164: --- Attachment: 12164.addendum There was a test failure in: https://builds.apache.org/job/PreCommit-HBASE-Build/11207/console Proposed addendum which logs the exception. > Check for presence of user Id in > SecureBulkLoadEndpoint#secureBulkLoadHFiles() is inaccurate > > > Key: HBASE-12164 > URL: https://issues.apache.org/jira/browse/HBASE-12164 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 2.0.0, 0.98.7, 0.99.1 > > Attachments: 12164-v1.txt, 12164-v1.txt, 12164.addendum > > > Here is the code: > {code} > if (request.getFsToken().hasIdentifier() && > request.getFsToken().hasPassword()) { > {code} > In test case, request.getFsToken().hasIdentifier() returns false, leading to > userToken being null. > This would make secure bulk load unsuccessful because the body of > secureBulkLoadHFiles() is skipped. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12164) Check for presence of user Id in SecureBulkLoadEndpoint#secureBulkLoadHFiles() is inaccurate
[ https://issues.apache.org/jira/browse/HBASE-12164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-12164: --- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the reviews. Thanks for finding the issue about required field, Stack. > Check for presence of user Id in > SecureBulkLoadEndpoint#secureBulkLoadHFiles() is inaccurate > > > Key: HBASE-12164 > URL: https://issues.apache.org/jira/browse/HBASE-12164 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 2.0.0, 0.98.7, 0.99.1 > > Attachments: 12164-v1.txt, 12164-v1.txt > > > Here is the code: > {code} > if (request.getFsToken().hasIdentifier() && > request.getFsToken().hasPassword()) { > {code} > In test case, request.getFsToken().hasIdentifier() returns false, leading to > userToken being null. > This would make secure bulk load unsuccessful because the body of > secureBulkLoadHFiles() is skipped. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12164) Check for presence of user Id in SecureBulkLoadEndpoint#secureBulkLoadHFiles() is inaccurate
[ https://issues.apache.org/jira/browse/HBASE-12164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-12164: --- Fix Version/s: 0.99.1 0.98.7 2.0.0 Hadoop Flags: Reviewed > Check for presence of user Id in > SecureBulkLoadEndpoint#secureBulkLoadHFiles() is inaccurate > > > Key: HBASE-12164 > URL: https://issues.apache.org/jira/browse/HBASE-12164 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 2.0.0, 0.98.7, 0.99.1 > > Attachments: 12164-v1.txt, 12164-v1.txt > > > Here is the code: > {code} > if (request.getFsToken().hasIdentifier() && > request.getFsToken().hasPassword()) { > {code} > In test case, request.getFsToken().hasIdentifier() returns false, leading to > userToken being null. > This would make secure bulk load unsuccessful because the body of > secureBulkLoadHFiles() is skipped. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12164) Check for presence of user Id in SecureBulkLoadEndpoint#secureBulkLoadHFiles() is inaccurate
[ https://issues.apache.org/jira/browse/HBASE-12164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-12164: --- Summary: Check for presence of user Id in SecureBulkLoadEndpoint#secureBulkLoadHFiles() is inaccurate (was: Check for presence of user Id in SecureBulkLoadEndpoint#secureBulkLoadHFiles() is wrong) > Check for presence of user Id in > SecureBulkLoadEndpoint#secureBulkLoadHFiles() is inaccurate > > > Key: HBASE-12164 > URL: https://issues.apache.org/jira/browse/HBASE-12164 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 12164-v1.txt, 12164-v1.txt > > > Here is the code: > {code} > if (request.getFsToken().hasIdentifier() && > request.getFsToken().hasPassword()) { > {code} > In test case, request.getFsToken().hasIdentifier() returns false, leading to > userToken being null. > This would make secure bulk load unsuccessful because the body of > secureBulkLoadHFiles() is skipped. -- This message was sent by Atlassian JIRA (v6.3.4#6332)