[jira] [Updated] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-12422: -- Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to branch-1+ > Use ConnectionFactory in HTable constructors > > > Key: HBASE-12422 > URL: https://issues.apache.org/jira/browse/HBASE-12422 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: Solomon Duskis >Assignee: stack >Priority: Minor > Fix For: 1.0.0, 2.0.0 > > Attachments: 12422v2.txt, 12422v3.txt, 12422v4.txt, 12422v5.txt, > HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, > HBASE-12422.patch > > > Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-12422: -- Attachment: 12422v5.txt Looks like the fixup in the test deletetable in TestHBaseFsck fixed all failures, not just a few. The other failure looks like my changing a signature in a test override of incremental bulk load. Lets see how this patch does. > Use ConnectionFactory in HTable constructors > > > Key: HBASE-12422 > URL: https://issues.apache.org/jira/browse/HBASE-12422 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: Solomon Duskis >Assignee: stack >Priority: Minor > Fix For: 1.0.0, 2.0.0 > > Attachments: 12422v2.txt, 12422v3.txt, 12422v4.txt, 12422v5.txt, > HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, > HBASE-12422.patch > > > Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-12422: -- Attachment: 12422v4.txt Rebase > Use ConnectionFactory in HTable constructors > > > Key: HBASE-12422 > URL: https://issues.apache.org/jira/browse/HBASE-12422 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: Solomon Duskis >Assignee: stack >Priority: Minor > Fix For: 1.0.0, 2.0.0 > > Attachments: 12422v2.txt, 12422v3.txt, 12422v4.txt, > HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, > HBASE-12422.patch > > > Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12422) Use ConnectionFactory in HTable constructors
[
https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-12422:
--
Attachment: 12422v3.txt
Try this patch. Should fix the TestSecureLoadIncrementalHFilesSplitRecovery.
More work to do on the TestHBaseFsck failure (should have fixes one test
failure).
Here is fix for the TestSecureLoadIncremental...
45 -Table table = new HTable(conn.getConfiguration(),
getTableName());
46 -secureClient = new SecureBulkLoadClient(table);
47 -success = secureClient.bulkLoadHFiles(famPaths,
fsDelegationToken.getUserToken(),
48 - bulkToken, getLocation().getRegionInfo().getStartKey());
49 +try (Table table = conn.getTable(getTableName())) {
50 + secureClient = new SecureBulkLoadClient(table);
51 + success = secureClient.bulkLoadHFiles(famPaths,
fsDelegationToken.getUserToken(),
52 +bulkToken, getLocation().getRegionInfo().getStartKey());
53 +}
Use existing Connection rather than create new one w/ 'wrong' zk config -- so
fail to connect to zk.
Patch is big because some of the tests have been refactored to use new idiom
just so we do clean up of resources, action that was not there previous.
Also includes addition of timeout on tests so they fail rather than go zombie.
Lets see how this does one hadoopqa.
> Use ConnectionFactory in HTable constructors
>
>
> Key: HBASE-12422
> URL: https://issues.apache.org/jira/browse/HBASE-12422
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: Solomon Duskis
>Assignee: stack
>Priority: Minor
> Fix For: 1.0.0, 2.0.0
>
> Attachments: 12422v2.txt, 12422v3.txt, HBASE-12422.patch,
> HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch
>
>
> Use ConnectionFactory in HTable instead of ConnectionManager.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-12422: -- Attachment: 12422v2.txt Try this. Its [~sduskis]'s patch with timeouts added to testhbasefsck (its missing loads) and to the other test that timedout. When I run these tests locally I am running out of memory and unable to create native thread. Lets see if same up on hadoopqa. If so, will dig in more on why this small change makes this much diff. > Use ConnectionFactory in HTable constructors > > > Key: HBASE-12422 > URL: https://issues.apache.org/jira/browse/HBASE-12422 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: Solomon Duskis >Assignee: stack >Priority: Minor > Fix For: 1.0.0, 2.0.0 > > Attachments: 12422v2.txt, HBASE-12422.patch, HBASE-12422.patch, > HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch > > > Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Solomon Duskis updated HBASE-12422: --- Attachment: HBASE-12422.patch There was a fixed committed in another patch that seems to have fixed the test cases. Trying one more time. > Use ConnectionFactory in HTable constructors > > > Key: HBASE-12422 > URL: https://issues.apache.org/jira/browse/HBASE-12422 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: Solomon Duskis >Assignee: stack >Priority: Minor > Fix For: 1.0.0, 2.0.0 > > Attachments: HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, > HBASE-12422.patch, HBASE-12422.patch > > > Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Solomon Duskis updated HBASE-12422: --- Assignee: stack (was: Solomon Duskis) > Use ConnectionFactory in HTable constructors > > > Key: HBASE-12422 > URL: https://issues.apache.org/jira/browse/HBASE-12422 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: Solomon Duskis >Assignee: stack >Priority: Minor > Fix For: 1.0.0, 2.0.0 > > Attachments: HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, > HBASE-12422.patch > > > Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Solomon Duskis updated HBASE-12422: --- Attachment: HBASE-12422.patch Trying one more time. > Use ConnectionFactory in HTable constructors > > > Key: HBASE-12422 > URL: https://issues.apache.org/jira/browse/HBASE-12422 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: Solomon Duskis >Assignee: Solomon Duskis >Priority: Minor > Fix For: 1.0.0, 2.0.0 > > Attachments: HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, > HBASE-12422.patch > > > Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-12422: -- Attachment: HBASE-12422.patch Agree, these should be fine if their close is going to clean up the connection. Retry hadoopqa. > Use ConnectionFactory in HTable constructors > > > Key: HBASE-12422 > URL: https://issues.apache.org/jira/browse/HBASE-12422 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: Solomon Duskis >Assignee: Solomon Duskis >Priority: Minor > Fix For: 1.0.0, 2.0.0 > > Attachments: HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch > > > Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enis Soztutar updated HBASE-12422: -- Fix Version/s: (was: 0.99.2) 1.0.0 > Use ConnectionFactory in HTable constructors > > > Key: HBASE-12422 > URL: https://issues.apache.org/jira/browse/HBASE-12422 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: Solomon Duskis >Assignee: Solomon Duskis >Priority: Minor > Fix For: 1.0.0, 2.0.0 > > Attachments: HBASE-12422.patch, HBASE-12422.patch > > > Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-12422: - Priority: Minor (was: Major) > Use ConnectionFactory in HTable constructors > > > Key: HBASE-12422 > URL: https://issues.apache.org/jira/browse/HBASE-12422 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: Solomon Duskis >Assignee: Solomon Duskis >Priority: Minor > Fix For: 2.0.0, 0.99.2 > > Attachments: HBASE-12422.patch, HBASE-12422.patch > > > Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-12422: - Assignee: Solomon Duskis > Use ConnectionFactory in HTable constructors > > > Key: HBASE-12422 > URL: https://issues.apache.org/jira/browse/HBASE-12422 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: Solomon Duskis >Assignee: Solomon Duskis > Fix For: 2.0.0, 0.99.2 > > Attachments: HBASE-12422.patch, HBASE-12422.patch > > > Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-12422: - Attachment: HBASE-12422.patch Reattaching patch for HadoopQA. > Use ConnectionFactory in HTable constructors > > > Key: HBASE-12422 > URL: https://issues.apache.org/jira/browse/HBASE-12422 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: Solomon Duskis > Fix For: 2.0.0, 0.99.2 > > Attachments: HBASE-12422.patch, HBASE-12422.patch > > > Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-12422: - Fix Version/s: 0.99.2 2.0.0 > Use ConnectionFactory in HTable constructors > > > Key: HBASE-12422 > URL: https://issues.apache.org/jira/browse/HBASE-12422 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: Solomon Duskis > Fix For: 2.0.0, 0.99.2 > > Attachments: HBASE-12422.patch, HBASE-12422.patch > > > Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-12422: - Affects Version/s: (was: 0.99.2) (was: 2.0.0) > Use ConnectionFactory in HTable constructors > > > Key: HBASE-12422 > URL: https://issues.apache.org/jira/browse/HBASE-12422 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: Solomon Duskis > Fix For: 2.0.0, 0.99.2 > > Attachments: HBASE-12422.patch, HBASE-12422.patch > > > Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-12422: - Component/s: Client > Use ConnectionFactory in HTable constructors > > > Key: HBASE-12422 > URL: https://issues.apache.org/jira/browse/HBASE-12422 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: Solomon Duskis > Fix For: 2.0.0, 0.99.2 > > Attachments: HBASE-12422.patch, HBASE-12422.patch > > > Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Solomon Duskis updated HBASE-12422: --- Assignee: (was: Solomon Duskis) Status: Patch Available (was: In Progress) > Use ConnectionFactory in HTable constructors > > > Key: HBASE-12422 > URL: https://issues.apache.org/jira/browse/HBASE-12422 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 0.99.2 >Reporter: Solomon Duskis > Attachments: HBASE-12422.patch > > > Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Solomon Duskis updated HBASE-12422: --- Attachment: HBASE-12422.patch > Use ConnectionFactory in HTable constructors > > > Key: HBASE-12422 > URL: https://issues.apache.org/jira/browse/HBASE-12422 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 0.99.2 >Reporter: Solomon Duskis >Assignee: Solomon Duskis > Attachments: HBASE-12422.patch > > > Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
