[jira] [Updated] (HBASE-12925) Use acl cache for doing access control checks in prepare and clean phases of Bulkloading.
[
https://issues.apache.org/jira/browse/HBASE-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell updated HBASE-12925:
---
Fix Version/s: (was: 0.98.11)
0.98.10
> Use acl cache for doing access control checks in prepare and clean phases of
> Bulkloading.
> -
>
> Key: HBASE-12925
> URL: https://issues.apache.org/jira/browse/HBASE-12925
> Project: HBase
> Issue Type: Bug
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
> Fix For: 1.0.0, 2.0.0, 0.98.10
>
> Attachments: HBASE-12925.patch, HBASE-12925_v2.patch
>
>
> Currently, prepareBulkLoad and cleanupBulkLoad are using "hasSomeAccess",
> which performs scan on ACL table, instead of using TableAuthManager. Also,
> the method "hasSomeAccess" has a logical error, as it doesn't filter the acl
> scan results by the current active user. More specifically
> {code}
> for (UserPermission userPerm: perms) {
> for (Action userAction: userPerm.getActions()) {
> if (userAction.equals(action)) {
> return AuthResult.allow(method, "Access allowed", requestUser,
> action, tableName, null, null);
> }
> }
> }
> {code}
> The if clause ideally should be having something like
> userPerm.getUser.equals(requestUser). This issue will help us in getting rid
> of this problematic implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12925) Use acl cache for doing access control checks in prepare and clean phases of Bulkloading.
[
https://issues.apache.org/jira/browse/HBASE-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matteo Bertozzi updated HBASE-12925:
Resolution: Fixed
Fix Version/s: 0.98.11
2.0.0
1.0.0
Status: Resolved (was: Patch Available)
committed to 98, branch-1* and master
> Use acl cache for doing access control checks in prepare and clean phases of
> Bulkloading.
> -
>
> Key: HBASE-12925
> URL: https://issues.apache.org/jira/browse/HBASE-12925
> Project: HBase
> Issue Type: Bug
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
> Fix For: 1.0.0, 2.0.0, 0.98.11
>
> Attachments: HBASE-12925.patch, HBASE-12925_v2.patch
>
>
> Currently, prepareBulkLoad and cleanupBulkLoad are using "hasSomeAccess",
> which performs scan on ACL table, instead of using TableAuthManager. Also,
> the method "hasSomeAccess" has a logical error, as it doesn't filter the acl
> scan results by the current active user. More specifically
> {code}
> for (UserPermission userPerm: perms) {
> for (Action userAction: userPerm.getActions()) {
> if (userAction.equals(action)) {
> return AuthResult.allow(method, "Access allowed", requestUser,
> action, tableName, null, null);
> }
> }
> }
> {code}
> The if clause ideally should be having something like
> userPerm.getUser.equals(requestUser). This issue will help us in getting rid
> of this problematic implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12925) Use acl cache for doing access control checks in prepare and clean phases of Bulkloading.
[
https://issues.apache.org/jira/browse/HBASE-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-12925:
Attachment: HBASE-12925_v2.patch
> Use acl cache for doing access control checks in prepare and clean phases of
> Bulkloading.
> -
>
> Key: HBASE-12925
> URL: https://issues.apache.org/jira/browse/HBASE-12925
> Project: HBase
> Issue Type: Bug
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
> Attachments: HBASE-12925.patch, HBASE-12925_v2.patch
>
>
> Currently, prepareBulkLoad and cleanupBulkLoad are using "hasSomeAccess",
> which performs scan on ACL table, instead of using TableAuthManager. Also,
> the method "hasSomeAccess" has a logical error, as it doesn't filter the acl
> scan results by the current active user. More specifically
> {code}
> for (UserPermission userPerm: perms) {
> for (Action userAction: userPerm.getActions()) {
> if (userAction.equals(action)) {
> return AuthResult.allow(method, "Access allowed", requestUser,
> action, tableName, null, null);
> }
> }
> }
> {code}
> The if clause ideally should be having something like
> userPerm.getUser.equals(requestUser). This issue will help us in getting rid
> of this problematic implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12925) Use acl cache for doing access control checks in prepare and clean phases of Bulkloading.
[
https://issues.apache.org/jira/browse/HBASE-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-12925:
Attachment: (was: HBASE-12925_v2.patch)
> Use acl cache for doing access control checks in prepare and clean phases of
> Bulkloading.
> -
>
> Key: HBASE-12925
> URL: https://issues.apache.org/jira/browse/HBASE-12925
> Project: HBase
> Issue Type: Bug
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
> Attachments: HBASE-12925.patch, HBASE-12925_v2.patch
>
>
> Currently, prepareBulkLoad and cleanupBulkLoad are using "hasSomeAccess",
> which performs scan on ACL table, instead of using TableAuthManager. Also,
> the method "hasSomeAccess" has a logical error, as it doesn't filter the acl
> scan results by the current active user. More specifically
> {code}
> for (UserPermission userPerm: perms) {
> for (Action userAction: userPerm.getActions()) {
> if (userAction.equals(action)) {
> return AuthResult.allow(method, "Access allowed", requestUser,
> action, tableName, null, null);
> }
> }
> }
> {code}
> The if clause ideally should be having something like
> userPerm.getUser.equals(requestUser). This issue will help us in getting rid
> of this problematic implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12925) Use acl cache for doing access control checks in prepare and clean phases of Bulkloading.
[
https://issues.apache.org/jira/browse/HBASE-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-12925:
Attachment: HBASE-12925_v2.patch
Addressed the nit. Thanks Matteo, for the offline feedback too.
> Use acl cache for doing access control checks in prepare and clean phases of
> Bulkloading.
> -
>
> Key: HBASE-12925
> URL: https://issues.apache.org/jira/browse/HBASE-12925
> Project: HBase
> Issue Type: Bug
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
> Attachments: HBASE-12925.patch, HBASE-12925_v2.patch
>
>
> Currently, prepareBulkLoad and cleanupBulkLoad are using "hasSomeAccess",
> which performs scan on ACL table, instead of using TableAuthManager. Also,
> the method "hasSomeAccess" has a logical error, as it doesn't filter the acl
> scan results by the current active user. More specifically
> {code}
> for (UserPermission userPerm: perms) {
> for (Action userAction: userPerm.getActions()) {
> if (userAction.equals(action)) {
> return AuthResult.allow(method, "Access allowed", requestUser,
> action, tableName, null, null);
> }
> }
> }
> {code}
> The if clause ideally should be having something like
> userPerm.getUser.equals(requestUser). This issue will help us in getting rid
> of this problematic implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12925) Use acl cache for doing access control checks in prepare and clean phases of Bulkloading.
[
https://issues.apache.org/jira/browse/HBASE-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-12925:
Attachment: HBASE-12925.patch
> Use acl cache for doing access control checks in prepare and clean phases of
> Bulkloading.
> -
>
> Key: HBASE-12925
> URL: https://issues.apache.org/jira/browse/HBASE-12925
> Project: HBase
> Issue Type: Bug
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
> Attachments: HBASE-12925.patch
>
>
> Currently, prepareBulkLoad and cleanupBulkLoad are using "hasSomeAccess",
> which performs scan on ACL table, instead of using TableAuthManager. Also,
> the method "hasSomeAccess" has a logical error, as it doesn't filter the acl
> scan results by the current active user. More specifically
> {code}
> for (UserPermission userPerm: perms) {
> for (Action userAction: userPerm.getActions()) {
> if (userAction.equals(action)) {
> return AuthResult.allow(method, "Access allowed", requestUser,
> action, tableName, null, null);
> }
> }
> }
> {code}
> The if clause ideally should be having something like
> userPerm.getUser.equals(requestUser). This issue will help us in getting rid
> of this problematic implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12925) Use acl cache for doing access control checks in prepare and clean phases of Bulkloading.
[
https://issues.apache.org/jira/browse/HBASE-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-12925:
Status: Patch Available (was: Open)
> Use acl cache for doing access control checks in prepare and clean phases of
> Bulkloading.
> -
>
> Key: HBASE-12925
> URL: https://issues.apache.org/jira/browse/HBASE-12925
> Project: HBase
> Issue Type: Bug
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
> Attachments: HBASE-12925.patch
>
>
> Currently, prepareBulkLoad and cleanupBulkLoad are using "hasSomeAccess",
> which performs scan on ACL table, instead of using TableAuthManager. Also,
> the method "hasSomeAccess" has a logical error, as it doesn't filter the acl
> scan results by the current active user. More specifically
> {code}
> for (UserPermission userPerm: perms) {
> for (Action userAction: userPerm.getActions()) {
> if (userAction.equals(action)) {
> return AuthResult.allow(method, "Access allowed", requestUser,
> action, tableName, null, null);
> }
> }
> }
> {code}
> The if clause ideally should be having something like
> userPerm.getUser.equals(requestUser). This issue will help us in getting rid
> of this problematic implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12925) Use acl cache for doing access control checks in prepare and clean phases of Bulkloading.
[
https://issues.apache.org/jira/browse/HBASE-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-12925:
Attachment: (was: HBASE-12925.patch)
> Use acl cache for doing access control checks in prepare and clean phases of
> Bulkloading.
> -
>
> Key: HBASE-12925
> URL: https://issues.apache.org/jira/browse/HBASE-12925
> Project: HBase
> Issue Type: Bug
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
>
> Currently, prepareBulkLoad and cleanupBulkLoad are using "hasSomeAccess",
> which performs scan on ACL table, instead of using TableAuthManager. Also,
> the method "hasSomeAccess" has a logical error, as it doesn't filter the acl
> scan results by the current active user. More specifically
> {code}
> for (UserPermission userPerm: perms) {
> for (Action userAction: userPerm.getActions()) {
> if (userAction.equals(action)) {
> return AuthResult.allow(method, "Access allowed", requestUser,
> action, tableName, null, null);
> }
> }
> }
> {code}
> The if clause ideally should be having something like
> userPerm.getUser.equals(requestUser). This issue will help us in getting rid
> of this problematic implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12925) Use acl cache for doing access control checks in prepare and clean phases of Bulkloading.
[
https://issues.apache.org/jira/browse/HBASE-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-12925:
Status: Open (was: Patch Available)
> Use acl cache for doing access control checks in prepare and clean phases of
> Bulkloading.
> -
>
> Key: HBASE-12925
> URL: https://issues.apache.org/jira/browse/HBASE-12925
> Project: HBase
> Issue Type: Bug
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
>
> Currently, prepareBulkLoad and cleanupBulkLoad are using "hasSomeAccess",
> which performs scan on ACL table, instead of using TableAuthManager. Also,
> the method "hasSomeAccess" has a logical error, as it doesn't filter the acl
> scan results by the current active user. More specifically
> {code}
> for (UserPermission userPerm: perms) {
> for (Action userAction: userPerm.getActions()) {
> if (userAction.equals(action)) {
> return AuthResult.allow(method, "Access allowed", requestUser,
> action, tableName, null, null);
> }
> }
> }
> {code}
> The if clause ideally should be having something like
> userPerm.getUser.equals(requestUser). This issue will help us in getting rid
> of this problematic implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12925) Use acl cache for doing access control checks in prepare and clean phases of Bulkloading.
[
https://issues.apache.org/jira/browse/HBASE-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-12925:
Attachment: HBASE-12925.patch
> Use acl cache for doing access control checks in prepare and clean phases of
> Bulkloading.
> -
>
> Key: HBASE-12925
> URL: https://issues.apache.org/jira/browse/HBASE-12925
> Project: HBase
> Issue Type: Bug
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
> Attachments: HBASE-12925.patch
>
>
> Currently, prepareBulkLoad and cleanupBulkLoad are using "hasSomeAccess",
> which performs scan on ACL table, instead of using TableAuthManager. Also,
> the method "hasSomeAccess" has a logical error, as it doesn't filter the acl
> scan results by the current active user. More specifically
> {code}
> for (UserPermission userPerm: perms) {
> for (Action userAction: userPerm.getActions()) {
> if (userAction.equals(action)) {
> return AuthResult.allow(method, "Access allowed", requestUser,
> action, tableName, null, null);
> }
> }
> }
> {code}
> The if clause ideally should be having something like
> userPerm.getUser.equals(requestUser). This issue will help us in getting rid
> of this problematic implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12925) Use acl cache for doing access control checks in prepare and clean phases of Bulkloading.
[
https://issues.apache.org/jira/browse/HBASE-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-12925:
Attachment: (was: HBASE-12925.patch)
> Use acl cache for doing access control checks in prepare and clean phases of
> Bulkloading.
> -
>
> Key: HBASE-12925
> URL: https://issues.apache.org/jira/browse/HBASE-12925
> Project: HBase
> Issue Type: Bug
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
>
> Currently, prepareBulkLoad and cleanupBulkLoad are using "hasSomeAccess",
> which performs scan on ACL table, instead of using TableAuthManager. Also,
> the method "hasSomeAccess" has a logical error, as it doesn't filter the acl
> scan results by the current active user. More specifically
> {code}
> for (UserPermission userPerm: perms) {
> for (Action userAction: userPerm.getActions()) {
> if (userAction.equals(action)) {
> return AuthResult.allow(method, "Access allowed", requestUser,
> action, tableName, null, null);
> }
> }
> }
> {code}
> The if clause ideally should be having something like
> userPerm.getUser.equals(requestUser). This issue will help us in getting rid
> of this problematic implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12925) Use acl cache for doing access control checks in prepare and clean phases of Bulkloading.
[
https://issues.apache.org/jira/browse/HBASE-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-12925:
Attachment: HBASE-12925.patch
> Use acl cache for doing access control checks in prepare and clean phases of
> Bulkloading.
> -
>
> Key: HBASE-12925
> URL: https://issues.apache.org/jira/browse/HBASE-12925
> Project: HBase
> Issue Type: Bug
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
> Attachments: HBASE-12925.patch
>
>
> Currently, prepareBulkLoad and cleanupBulkLoad are using "hasSomeAccess",
> which performs scan on ACL table, instead of using TableAuthManager. Also,
> the method "hasSomeAccess" has a logical error, as it doesn't filter the acl
> scan results by the current active user. More specifically
> {code}
> for (UserPermission userPerm: perms) {
> for (Action userAction: userPerm.getActions()) {
> if (userAction.equals(action)) {
> return AuthResult.allow(method, "Access allowed", requestUser,
> action, tableName, null, null);
> }
> }
> }
> {code}
> The if clause ideally should be having something like
> userPerm.getUser.equals(requestUser). This issue will help us in getting rid
> of this problematic implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12925) Use acl cache for doing access control checks in prepare and clean phases of Bulkloading.
[
https://issues.apache.org/jira/browse/HBASE-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-12925:
Status: Patch Available (was: Open)
> Use acl cache for doing access control checks in prepare and clean phases of
> Bulkloading.
> -
>
> Key: HBASE-12925
> URL: https://issues.apache.org/jira/browse/HBASE-12925
> Project: HBase
> Issue Type: Bug
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
> Attachments: HBASE-12925.patch
>
>
> Currently, prepareBulkLoad and cleanupBulkLoad are using "hasSomeAccess",
> which performs scan on ACL table, instead of using TableAuthManager. Also,
> the method "hasSomeAccess" has a logical error, as it doesn't filter the acl
> scan results by the current active user. More specifically
> {code}
> for (UserPermission userPerm: perms) {
> for (Action userAction: userPerm.getActions()) {
> if (userAction.equals(action)) {
> return AuthResult.allow(method, "Access allowed", requestUser,
> action, tableName, null, null);
> }
> }
> }
> {code}
> The if clause ideally should be having something like
> userPerm.getUser.equals(requestUser). This issue will help us in getting rid
> of this problematic implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
