[jira] [Updated] (HBASE-13885) ZK watches leaks during snapshots
[ https://issues.apache.org/jira/browse/HBASE-13885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-13885: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Oh... The isEmpty part from HBASE-13901 didn't work here, since I'd have to create a NodeAndData object, which does not make sense here, because I am enumerating nodes. > ZK watches leaks during snapshots > - > > Key: HBASE-13885 > URL: https://issues.apache.org/jira/browse/HBASE-13885 > Project: HBase > Issue Type: Bug > Components: snapshots >Affects Versions: 0.98.12 >Reporter: Abhishek Singh Chouhan >Assignee: Lars Hofhansl >Priority: Critical > Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1, 1.3.0 > > Attachments: 13885-0.98-v2.txt, 13885-0.98-v3.txt, 13885-master.txt > > > When taking snapshot of a table a watcher over > /hbase/online-snapshot/abort/snapshot-name is created which is never cleared > when the snapshot is successful. If we use snapshots to take backups daily we > accumulate a lot of watches. > Steps to reproduce - > 1) Take snapshot of a table - snapshot 'table_1', 'abc' > 2) Run the following on zk node or alternatively observe zk watches metric > echo "wchc" | nc localhost 2181 > /hbase/online-snapshot/abort/abc can be found. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13885) ZK watches leaks during snapshots
[ https://issues.apache.org/jira/browse/HBASE-13885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-13885: -- Fix Version/s: 1.3.0 > ZK watches leaks during snapshots > - > > Key: HBASE-13885 > URL: https://issues.apache.org/jira/browse/HBASE-13885 > Project: HBase > Issue Type: Bug > Components: snapshots >Affects Versions: 0.98.12 >Reporter: Abhishek Singh Chouhan >Assignee: Lars Hofhansl >Priority: Critical > Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1, 1.3.0 > > Attachments: 13885-0.98-v2.txt, 13885-0.98-v3.txt, 13885-master.txt > > > When taking snapshot of a table a watcher over > /hbase/online-snapshot/abort/snapshot-name is created which is never cleared > when the snapshot is successful. If we use snapshots to take backups daily we > accumulate a lot of watches. > Steps to reproduce - > 1) Take snapshot of a table - snapshot 'table_1', 'abc' > 2) Run the following on zk node or alternatively observe zk watches metric > echo "wchc" | nc localhost 2181 > /hbase/online-snapshot/abort/abc can be found. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13885) ZK watches leaks during snapshots
[ https://issues.apache.org/jira/browse/HBASE-13885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-13885: -- Fix Version/s: 1.1.1 1.2.0 1.0.2 0.98.14 2.0.0 Assignee: Lars Hofhansl Status: Patch Available (was: Open) > ZK watches leaks during snapshots > - > > Key: HBASE-13885 > URL: https://issues.apache.org/jira/browse/HBASE-13885 > Project: HBase > Issue Type: Bug > Components: snapshots >Affects Versions: 0.98.12 >Reporter: Abhishek Singh Chouhan >Assignee: Lars Hofhansl >Priority: Critical > Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1 > > Attachments: 13885-0.98-v2.txt, 13885-0.98-v3.txt, 13885-master.txt > > > When taking snapshot of a table a watcher over > /hbase/online-snapshot/abort/snapshot-name is created which is never cleared > when the snapshot is successful. If we use snapshots to take backups daily we > accumulate a lot of watches. > Steps to reproduce - > 1) Take snapshot of a table - snapshot 'table_1', 'abc' > 2) Run the following on zk node or alternatively observe zk watches metric > echo "wchc" | nc localhost 2181 > /hbase/online-snapshot/abort/abc can be found. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13885) ZK watches leaks during snapshots
[ https://issues.apache.org/jira/browse/HBASE-13885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-13885: -- Attachment: 13885-master.txt Patch against master. I verified manually that without the patch the abort watcher hangs around. With the patch it doesn't. > ZK watches leaks during snapshots > - > > Key: HBASE-13885 > URL: https://issues.apache.org/jira/browse/HBASE-13885 > Project: HBase > Issue Type: Bug > Components: snapshots >Affects Versions: 0.98.12 >Reporter: Abhishek Singh Chouhan >Priority: Critical > Attachments: 13885-0.98-v2.txt, 13885-0.98-v3.txt, 13885-master.txt > > > When taking snapshot of a table a watcher over > /hbase/online-snapshot/abort/snapshot-name is created which is never cleared > when the snapshot is successful. If we use snapshots to take backups daily we > accumulate a lot of watches. > Steps to reproduce - > 1) Take snapshot of a table - snapshot 'table_1', 'abc' > 2) Run the following on zk node or alternatively observe zk watches metric > echo "wchc" | nc localhost 2181 > /hbase/online-snapshot/abort/abc can be found. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13885) ZK watches leaks during snapshots
[ https://issues.apache.org/jira/browse/HBASE-13885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-13885: -- Attachment: 13885-0.98-v3.txt This one does work. The idea is to always create the abort and acquired znodes. The patch does that at the time we're ready to clear the existing znodes. It simply creates them if they don't exist, before deleting them. The watches then simply ignore an empty data znode. Please have a look. > ZK watches leaks during snapshots > - > > Key: HBASE-13885 > URL: https://issues.apache.org/jira/browse/HBASE-13885 > Project: HBase > Issue Type: Bug > Components: snapshots >Affects Versions: 0.98.12 >Reporter: Abhishek Singh Chouhan >Priority: Critical > Attachments: 13885-0.98-v2.txt, 13885-0.98-v3.txt > > > When taking snapshot of a table a watcher over > /hbase/online-snapshot/abort/snapshot-name is created which is never cleared > when the snapshot is successful. If we use snapshots to take backups daily we > accumulate a lot of watches. > Steps to reproduce - > 1) Take snapshot of a table - snapshot 'table_1', 'abc' > 2) Run the following on zk node or alternatively observe zk watches metric > echo "wchc" | nc localhost 2181 > /hbase/online-snapshot/abort/abc can be found. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13885) ZK watches leaks during snapshots
[ https://issues.apache.org/jira/browse/HBASE-13885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-13885: -- Attachment: 13885-0.98-v2.txt Non-working-patch... Just parking... DOES NOT WORK, but shows the idea. > ZK watches leaks during snapshots > - > > Key: HBASE-13885 > URL: https://issues.apache.org/jira/browse/HBASE-13885 > Project: HBase > Issue Type: Bug > Components: snapshots >Affects Versions: 0.98.12 >Reporter: Abhishek Singh Chouhan >Priority: Critical > Attachments: 13885-0.98-v2.txt > > > When taking snapshot of a table a watcher over > /hbase/online-snapshot/abort/snapshot-name is created which is never cleared > when the snapshot is successful. If we use snapshots to take backups daily we > accumulate a lot of watches. > Steps to reproduce - > 1) Take snapshot of a table - snapshot 'table_1', 'abc' > 2) Run the following on zk node or alternatively observe zk watches metric > echo "wchc" | nc localhost 2181 > /hbase/online-snapshot/abort/abc can be found. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13885) ZK watches leaks during snapshots
[ https://issues.apache.org/jira/browse/HBASE-13885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-13885: -- Priority: Critical (was: Major) > ZK watches leaks during snapshots > - > > Key: HBASE-13885 > URL: https://issues.apache.org/jira/browse/HBASE-13885 > Project: HBase > Issue Type: Bug > Components: snapshots >Affects Versions: 0.98.12 >Reporter: Abhishek Singh Chouhan >Priority: Critical > > When taking snapshot of a table a watcher over > /hbase/online-snapshot/abort/snapshot-name is created which is never cleared > when the snapshot is successful. If we use snapshots to take backups daily we > accumulate a lot of watches. > Steps to reproduce - > 1) Take snapshot of a table - snapshot 'table_1', 'abc' > 2) Run the following on zk node or alternatively observe zk watches metric > echo "wchc" | nc localhost 2181 > /hbase/online-snapshot/abort/abc can be found. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
