[jira] [Updated] (HBASE-14144) Bloomfilter path to work with Byte buffered cells
[ https://issues.apache.org/jira/browse/HBASE-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-14144: --- Status: Open (was: Patch Available) Bloomfilter path to work with Byte buffered cells - Key: HBASE-14144 URL: https://issues.apache.org/jira/browse/HBASE-14144 Project: HBase Issue Type: Sub-task Components: regionserver, Scanners Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 2.0.0 Attachments: HBASE-14144.patch, HBASE-14144_1.patch, HBASE-14144_2.patch, HBASE-14144_3.patch, HBASE-14144_4.patch, HBASE-14144_5.patch This JIRA is to check if there will be a need to make the bloom filters to work with ByteBuffer cells. During POC this path created lot of duplicated code but considering other refactorings done in this path may lead to less duplication. This JIRA is a placeholder. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14144) Bloomfilter path to work with Byte buffered cells
[ https://issues.apache.org/jira/browse/HBASE-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-14144: --- Status: Patch Available (was: Open) Bloomfilter path to work with Byte buffered cells - Key: HBASE-14144 URL: https://issues.apache.org/jira/browse/HBASE-14144 Project: HBase Issue Type: Sub-task Components: regionserver, Scanners Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 2.0.0 Attachments: HBASE-14144.patch, HBASE-14144_1.patch, HBASE-14144_2.patch, HBASE-14144_3.patch, HBASE-14144_4.patch, HBASE-14144_5.patch, HBASE-14144_6.patch This JIRA is to check if there will be a need to make the bloom filters to work with ByteBuffer cells. During POC this path created lot of duplicated code but considering other refactorings done in this path may lead to less duplication. This JIRA is a placeholder. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14144) Bloomfilter path to work with Byte buffered cells
[ https://issues.apache.org/jira/browse/HBASE-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-14144: --- Attachment: HBASE-14144_6.patch Renames the FakeCell and FakeBBCell to EmptyCell and EmptyByteBufferedCell. This is what I will commit. [~anoopsamjohn] You fine with this? Bloomfilter path to work with Byte buffered cells - Key: HBASE-14144 URL: https://issues.apache.org/jira/browse/HBASE-14144 Project: HBase Issue Type: Sub-task Components: regionserver, Scanners Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 2.0.0 Attachments: HBASE-14144.patch, HBASE-14144_1.patch, HBASE-14144_2.patch, HBASE-14144_3.patch, HBASE-14144_4.patch, HBASE-14144_5.patch, HBASE-14144_6.patch This JIRA is to check if there will be a need to make the bloom filters to work with ByteBuffer cells. During POC this path created lot of duplicated code but considering other refactorings done in this path may lead to less duplication. This JIRA is a placeholder. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14144) Bloomfilter path to work with Byte buffered cells
[ https://issues.apache.org/jira/browse/HBASE-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-14144: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Pushed to master. Thanks for the reviews Stack and Anoop. Added the comment as suggested on commit. Bloomfilter path to work with Byte buffered cells - Key: HBASE-14144 URL: https://issues.apache.org/jira/browse/HBASE-14144 Project: HBase Issue Type: Sub-task Components: regionserver, Scanners Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 2.0.0 Attachments: HBASE-14144.patch, HBASE-14144_1.patch, HBASE-14144_2.patch, HBASE-14144_3.patch, HBASE-14144_4.patch, HBASE-14144_5.patch, HBASE-14144_6.patch This JIRA is to check if there will be a need to make the bloom filters to work with ByteBuffer cells. During POC this path created lot of duplicated code but considering other refactorings done in this path may lead to less duplication. This JIRA is a placeholder. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14144) Bloomfilter path to work with Byte buffered cells
[ https://issues.apache.org/jira/browse/HBASE-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-14144: --- Status: Open (was: Patch Available) Bloomfilter path to work with Byte buffered cells - Key: HBASE-14144 URL: https://issues.apache.org/jira/browse/HBASE-14144 Project: HBase Issue Type: Sub-task Components: regionserver, Scanners Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 2.0.0 Attachments: HBASE-14144.patch, HBASE-14144_1.patch, HBASE-14144_2.patch, HBASE-14144_3.patch, HBASE-14144_4.patch This JIRA is to check if there will be a need to make the bloom filters to work with ByteBuffer cells. During POC this path created lot of duplicated code but considering other refactorings done in this path may lead to less duplication. This JIRA is a placeholder. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14144) Bloomfilter path to work with Byte buffered cells
[ https://issues.apache.org/jira/browse/HBASE-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-14144: --- Attachment: HBASE-14144_4.patch Updated patch that adds CloneXXX methods in the FakeBBCell. Bloomfilter path to work with Byte buffered cells - Key: HBASE-14144 URL: https://issues.apache.org/jira/browse/HBASE-14144 Project: HBase Issue Type: Sub-task Components: regionserver, Scanners Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 2.0.0 Attachments: HBASE-14144.patch, HBASE-14144_1.patch, HBASE-14144_2.patch, HBASE-14144_3.patch, HBASE-14144_4.patch This JIRA is to check if there will be a need to make the bloom filters to work with ByteBuffer cells. During POC this path created lot of duplicated code but considering other refactorings done in this path may lead to less duplication. This JIRA is a placeholder. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14144) Bloomfilter path to work with Byte buffered cells
[ https://issues.apache.org/jira/browse/HBASE-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-14144: --- Status: Patch Available (was: Open) Bloomfilter path to work with Byte buffered cells - Key: HBASE-14144 URL: https://issues.apache.org/jira/browse/HBASE-14144 Project: HBase Issue Type: Sub-task Components: regionserver, Scanners Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 2.0.0 Attachments: HBASE-14144.patch, HBASE-14144_1.patch, HBASE-14144_2.patch, HBASE-14144_3.patch, HBASE-14144_4.patch, HBASE-14144_5.patch This JIRA is to check if there will be a need to make the bloom filters to work with ByteBuffer cells. During POC this path created lot of duplicated code but considering other refactorings done in this path may lead to less duplication. This JIRA is a placeholder. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14144) Bloomfilter path to work with Byte buffered cells
[ https://issues.apache.org/jira/browse/HBASE-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-14144: --- Attachment: HBASE-14144_5.patch Updated patch. Removes the redundant 'Fake' word from the name. Also expands BB as ByteBuffered Cell. Bloomfilter path to work with Byte buffered cells - Key: HBASE-14144 URL: https://issues.apache.org/jira/browse/HBASE-14144 Project: HBase Issue Type: Sub-task Components: regionserver, Scanners Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 2.0.0 Attachments: HBASE-14144.patch, HBASE-14144_1.patch, HBASE-14144_2.patch, HBASE-14144_3.patch, HBASE-14144_4.patch, HBASE-14144_5.patch This JIRA is to check if there will be a need to make the bloom filters to work with ByteBuffer cells. During POC this path created lot of duplicated code but considering other refactorings done in this path may lead to less duplication. This JIRA is a placeholder. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14144) Bloomfilter path to work with Byte buffered cells
[ https://issues.apache.org/jira/browse/HBASE-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-14144: --- Status: Open (was: Patch Available) Bloomfilter path to work with Byte buffered cells - Key: HBASE-14144 URL: https://issues.apache.org/jira/browse/HBASE-14144 Project: HBase Issue Type: Sub-task Components: regionserver, Scanners Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 2.0.0 Attachments: HBASE-14144.patch, HBASE-14144_1.patch, HBASE-14144_2.patch This JIRA is to check if there will be a need to make the bloom filters to work with ByteBuffer cells. During POC this path created lot of duplicated code but considering other refactorings done in this path may lead to less duplication. This JIRA is a placeholder. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14144) Bloomfilter path to work with Byte buffered cells
[ https://issues.apache.org/jira/browse/HBASE-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-14144: --- Status: Patch Available (was: Open) Bloomfilter path to work with Byte buffered cells - Key: HBASE-14144 URL: https://issues.apache.org/jira/browse/HBASE-14144 Project: HBase Issue Type: Sub-task Components: regionserver, Scanners Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 2.0.0 Attachments: HBASE-14144.patch, HBASE-14144_1.patch, HBASE-14144_2.patch, HBASE-14144_3.patch This JIRA is to check if there will be a need to make the bloom filters to work with ByteBuffer cells. During POC this path created lot of duplicated code but considering other refactorings done in this path may lead to less duplication. This JIRA is a placeholder. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14144) Bloomfilter path to work with Byte buffered cells
[ https://issues.apache.org/jira/browse/HBASE-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-14144: --- Attachment: HBASE-14144_3.patch Updated patch. Changes all the fake cells with 'column' to 'col'. The ByteBufferedCell is changed to BBCell to make it small. The term fake represents that we try to create the first on row or last on row type of Cells using the existing cell's components. Previously these type of Kvs where created by copying the contents every time and now as we are having the concept of cell such copies are not required. Anyway these things are just used for doing sort of seek and reseeks and they are not going to be returned to the clients. Bloomfilter path to work with Byte buffered cells - Key: HBASE-14144 URL: https://issues.apache.org/jira/browse/HBASE-14144 Project: HBase Issue Type: Sub-task Components: regionserver, Scanners Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 2.0.0 Attachments: HBASE-14144.patch, HBASE-14144_1.patch, HBASE-14144_2.patch, HBASE-14144_3.patch This JIRA is to check if there will be a need to make the bloom filters to work with ByteBuffer cells. During POC this path created lot of duplicated code but considering other refactorings done in this path may lead to less duplication. This JIRA is a placeholder. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14144) Bloomfilter path to work with Byte buffered cells
[ https://issues.apache.org/jira/browse/HBASE-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-14144: --- Status: Open (was: Patch Available) Bloomfilter path to work with Byte buffered cells - Key: HBASE-14144 URL: https://issues.apache.org/jira/browse/HBASE-14144 Project: HBase Issue Type: Sub-task Components: regionserver, Scanners Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 2.0.0 Attachments: HBASE-14144.patch, HBASE-14144_1.patch This JIRA is to check if there will be a need to make the bloom filters to work with ByteBuffer cells. During POC this path created lot of duplicated code but considering other refactorings done in this path may lead to less duplication. This JIRA is a placeholder. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14144) Bloomfilter path to work with Byte buffered cells
[ https://issues.apache.org/jira/browse/HBASE-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-14144: --- Attachment: HBASE-14144_2.patch Updated patch with rename. For QA. Bloomfilter path to work with Byte buffered cells - Key: HBASE-14144 URL: https://issues.apache.org/jira/browse/HBASE-14144 Project: HBase Issue Type: Sub-task Components: regionserver, Scanners Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 2.0.0 Attachments: HBASE-14144.patch, HBASE-14144_1.patch, HBASE-14144_2.patch This JIRA is to check if there will be a need to make the bloom filters to work with ByteBuffer cells. During POC this path created lot of duplicated code but considering other refactorings done in this path may lead to less duplication. This JIRA is a placeholder. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14144) Bloomfilter path to work with Byte buffered cells
[ https://issues.apache.org/jira/browse/HBASE-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-14144: --- Status: Patch Available (was: Open) Bloomfilter path to work with Byte buffered cells - Key: HBASE-14144 URL: https://issues.apache.org/jira/browse/HBASE-14144 Project: HBase Issue Type: Sub-task Components: regionserver, Scanners Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 2.0.0 Attachments: HBASE-14144.patch, HBASE-14144_1.patch This JIRA is to check if there will be a need to make the bloom filters to work with ByteBuffer cells. During POC this path created lot of duplicated code but considering other refactorings done in this path may lead to less duplication. This JIRA is a placeholder. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14144) Bloomfilter path to work with Byte buffered cells
[ https://issues.apache.org/jira/browse/HBASE-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-14144: --- Status: Open (was: Patch Available) Bloomfilter path to work with Byte buffered cells - Key: HBASE-14144 URL: https://issues.apache.org/jira/browse/HBASE-14144 Project: HBase Issue Type: Sub-task Components: regionserver, Scanners Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 2.0.0 Attachments: HBASE-14144.patch This JIRA is to check if there will be a need to make the bloom filters to work with ByteBuffer cells. During POC this path created lot of duplicated code but considering other refactorings done in this path may lead to less duplication. This JIRA is a placeholder. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14144) Bloomfilter path to work with Byte buffered cells
[ https://issues.apache.org/jira/browse/HBASE-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-14144: --- Attachment: HBASE-14144_1.patch Updated patch where in case of Keyvalue type cells we don do a copy to create the key part of the cell. Bloomfilter path to work with Byte buffered cells - Key: HBASE-14144 URL: https://issues.apache.org/jira/browse/HBASE-14144 Project: HBase Issue Type: Sub-task Components: regionserver, Scanners Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 2.0.0 Attachments: HBASE-14144.patch, HBASE-14144_1.patch This JIRA is to check if there will be a need to make the bloom filters to work with ByteBuffer cells. During POC this path created lot of duplicated code but considering other refactorings done in this path may lead to less duplication. This JIRA is a placeholder. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14144) Bloomfilter path to work with Byte buffered cells
[ https://issues.apache.org/jira/browse/HBASE-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-14144: --- Attachment: HBASE-14144.patch Patch to make use of BB cells. The final place where we do the contains() check in BloomFilter uses the byte[] only by copying the key part of the cell to byte[]. Currently Hash algo works with the key byte[] only. So better not to change that now. Bloomfilter path to work with Byte buffered cells - Key: HBASE-14144 URL: https://issues.apache.org/jira/browse/HBASE-14144 Project: HBase Issue Type: Sub-task Components: regionserver, Scanners Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 2.0.0 Attachments: HBASE-14144.patch This JIRA is to check if there will be a need to make the bloom filters to work with ByteBuffer cells. During POC this path created lot of duplicated code but considering other refactorings done in this path may lead to less duplication. This JIRA is a placeholder. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14144) Bloomfilter path to work with Byte buffered cells
[ https://issues.apache.org/jira/browse/HBASE-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-14144: --- Status: Patch Available (was: Open) Bloomfilter path to work with Byte buffered cells - Key: HBASE-14144 URL: https://issues.apache.org/jira/browse/HBASE-14144 Project: HBase Issue Type: Sub-task Components: regionserver, Scanners Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 2.0.0 Attachments: HBASE-14144.patch This JIRA is to check if there will be a need to make the bloom filters to work with ByteBuffer cells. During POC this path created lot of duplicated code but considering other refactorings done in this path may lead to less duplication. This JIRA is a placeholder. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
