[jira] [Updated] (HBASE-14989) Implementation of Mutation.getWriteToWAL() is backwards
[ https://issues.apache.org/jira/browse/HBASE-14989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enis Soztutar updated HBASE-14989: -- Fix Version/s: (was: 1.0.4) 1.0.3 > Implementation of Mutation.getWriteToWAL() is backwards > --- > > Key: HBASE-14989 > URL: https://issues.apache.org/jira/browse/HBASE-14989 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: James Taylor >Assignee: Enis Soztutar > Fix For: 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.17 > > Attachments: HBASE-14989.1.branch-1.patch, > hbase-14989-branch-1_v1.patch > > > The implementation of the deprecated getWriteToWAL is backwards. It should > return true if this.durability == Durability.SYNC_WAL: > {code} > /** >* @deprecated Use {@link #getDurability()} instead. >* @return true if edits should be applied to WAL, false if not >*/ > @Deprecated > public boolean getWriteToWAL() { > return this.durability == Durability.SKIP_WAL; > } > {code} > For example, if mutation.durability is Durability.SYNC_WAL and the following > code is called {{clonedMutation.setWriteToWAL(mutation.getWriteToWAL())}}, it > will disable writing to the WAL for clonedMutation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14989) Implementation of Mutation.getWriteToWAL() is backwards
[ https://issues.apache.org/jira/browse/HBASE-14989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-14989: - Fix Version/s: (was: 1.1.4) 1.1.3 > Implementation of Mutation.getWriteToWAL() is backwards > --- > > Key: HBASE-14989 > URL: https://issues.apache.org/jira/browse/HBASE-14989 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: James Taylor >Assignee: Enis Soztutar > Fix For: 1.2.0, 1.3.0, 1.1.3, 0.98.17, 1.0.4 > > Attachments: HBASE-14989.1.branch-1.patch, > hbase-14989-branch-1_v1.patch > > > The implementation of the deprecated getWriteToWAL is backwards. It should > return true if this.durability == Durability.SYNC_WAL: > {code} > /** >* @deprecated Use {@link #getDurability()} instead. >* @return true if edits should be applied to WAL, false if not >*/ > @Deprecated > public boolean getWriteToWAL() { > return this.durability == Durability.SKIP_WAL; > } > {code} > For example, if mutation.durability is Durability.SYNC_WAL and the following > code is called {{clonedMutation.setWriteToWAL(mutation.getWriteToWAL())}}, it > will disable writing to the WAL for clonedMutation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14989) Implementation of Mutation.getWriteToWAL() is backwards
[ https://issues.apache.org/jira/browse/HBASE-14989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-14989: Component/s: Client > Implementation of Mutation.getWriteToWAL() is backwards > --- > > Key: HBASE-14989 > URL: https://issues.apache.org/jira/browse/HBASE-14989 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: James Taylor >Assignee: Enis Soztutar > Fix For: 1.2.0, 1.3.0, 1.1.4, 0.98.17, 1.0.4 > > Attachments: HBASE-14989.1.branch-1.patch, > hbase-14989-branch-1_v1.patch > > > The implementation of the deprecated getWriteToWAL is backwards. It should > return true if this.durability == Durability.SYNC_WAL: > {code} > /** >* @deprecated Use {@link #getDurability()} instead. >* @return true if edits should be applied to WAL, false if not >*/ > @Deprecated > public boolean getWriteToWAL() { > return this.durability == Durability.SKIP_WAL; > } > {code} > For example, if mutation.durability is Durability.SYNC_WAL and the following > code is called {{clonedMutation.setWriteToWAL(mutation.getWriteToWAL())}}, it > will disable writing to the WAL for clonedMutation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14989) Implementation of Mutation.getWriteToWAL() is backwards
[ https://issues.apache.org/jira/browse/HBASE-14989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enis Soztutar updated HBASE-14989: -- Resolution: Fixed Assignee: Enis Soztutar Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Thanks all. Committed this to 0.98-1.3. > Implementation of Mutation.getWriteToWAL() is backwards > --- > > Key: HBASE-14989 > URL: https://issues.apache.org/jira/browse/HBASE-14989 > Project: HBase > Issue Type: Bug >Reporter: James Taylor >Assignee: Enis Soztutar > Fix For: 1.2.0, 1.3.0, 1.1.4, 0.98.17, 1.0.4 > > Attachments: HBASE-14989.1.branch-1.patch, > hbase-14989-branch-1_v1.patch > > > The implementation of the deprecated getWriteToWAL is backwards. It should > return true if this.durability == Durability.SYNC_WAL: > {code} > /** >* @deprecated Use {@link #getDurability()} instead. >* @return true if edits should be applied to WAL, false if not >*/ > @Deprecated > public boolean getWriteToWAL() { > return this.durability == Durability.SKIP_WAL; > } > {code} > For example, if mutation.durability is Durability.SYNC_WAL and the following > code is called {{clonedMutation.setWriteToWAL(mutation.getWriteToWAL())}}, it > will disable writing to the WAL for clonedMutation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14989) Implementation of Mutation.getWriteToWAL() is backwards
[ https://issues.apache.org/jira/browse/HBASE-14989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-14989: Attachment: HBASE-14989.1.branch-1.patch one more time, since that last one was parsed as "branch-1.1" > Implementation of Mutation.getWriteToWAL() is backwards > --- > > Key: HBASE-14989 > URL: https://issues.apache.org/jira/browse/HBASE-14989 > Project: HBase > Issue Type: Bug >Reporter: James Taylor > Fix For: 1.2.0, 1.3.0, 1.1.4, 0.98.17, 1.0.4 > > Attachments: HBASE-14989.1.branch-1.patch, > hbase-14989-branch-1_v1.patch > > > The implementation of the deprecated getWriteToWAL is backwards. It should > return true if this.durability == Durability.SYNC_WAL: > {code} > /** >* @deprecated Use {@link #getDurability()} instead. >* @return true if edits should be applied to WAL, false if not >*/ > @Deprecated > public boolean getWriteToWAL() { > return this.durability == Durability.SKIP_WAL; > } > {code} > For example, if mutation.durability is Durability.SYNC_WAL and the following > code is called {{clonedMutation.setWriteToWAL(mutation.getWriteToWAL())}}, it > will disable writing to the WAL for clonedMutation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14989) Implementation of Mutation.getWriteToWAL() is backwards
[ https://issues.apache.org/jira/browse/HBASE-14989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-14989: Attachment: (was: HBASE-14989.branch-1.1.patch) > Implementation of Mutation.getWriteToWAL() is backwards > --- > > Key: HBASE-14989 > URL: https://issues.apache.org/jira/browse/HBASE-14989 > Project: HBase > Issue Type: Bug >Reporter: James Taylor > Fix For: 1.2.0, 1.3.0, 1.1.4, 0.98.17, 1.0.4 > > Attachments: hbase-14989-branch-1_v1.patch > > > The implementation of the deprecated getWriteToWAL is backwards. It should > return true if this.durability == Durability.SYNC_WAL: > {code} > /** >* @deprecated Use {@link #getDurability()} instead. >* @return true if edits should be applied to WAL, false if not >*/ > @Deprecated > public boolean getWriteToWAL() { > return this.durability == Durability.SKIP_WAL; > } > {code} > For example, if mutation.durability is Durability.SYNC_WAL and the following > code is called {{clonedMutation.setWriteToWAL(mutation.getWriteToWAL())}}, it > will disable writing to the WAL for clonedMutation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14989) Implementation of Mutation.getWriteToWAL() is backwards
[ https://issues.apache.org/jira/browse/HBASE-14989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-14989: Attachment: HBASE-14989.branch-1.1.patch re-uploading > Implementation of Mutation.getWriteToWAL() is backwards > --- > > Key: HBASE-14989 > URL: https://issues.apache.org/jira/browse/HBASE-14989 > Project: HBase > Issue Type: Bug >Reporter: James Taylor > Fix For: 1.2.0, 1.3.0, 1.1.4, 0.98.17, 1.0.4 > > Attachments: HBASE-14989.branch-1.1.patch, > hbase-14989-branch-1_v1.patch > > > The implementation of the deprecated getWriteToWAL is backwards. It should > return true if this.durability == Durability.SYNC_WAL: > {code} > /** >* @deprecated Use {@link #getDurability()} instead. >* @return true if edits should be applied to WAL, false if not >*/ > @Deprecated > public boolean getWriteToWAL() { > return this.durability == Durability.SKIP_WAL; > } > {code} > For example, if mutation.durability is Durability.SYNC_WAL and the following > code is called {{clonedMutation.setWriteToWAL(mutation.getWriteToWAL())}}, it > will disable writing to the WAL for clonedMutation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14989) Implementation of Mutation.getWriteToWAL() is backwards
[ https://issues.apache.org/jira/browse/HBASE-14989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-14989: Fix Version/s: (was: 1.2.1) 1.2.0 > Implementation of Mutation.getWriteToWAL() is backwards > --- > > Key: HBASE-14989 > URL: https://issues.apache.org/jira/browse/HBASE-14989 > Project: HBase > Issue Type: Bug >Reporter: James Taylor > Fix For: 1.2.0, 1.3.0, 1.1.4, 0.98.17, 1.0.4 > > Attachments: hbase-14989-branch-1_v1.patch > > > The implementation of the deprecated getWriteToWAL is backwards. It should > return true if this.durability == Durability.SYNC_WAL: > {code} > /** >* @deprecated Use {@link #getDurability()} instead. >* @return true if edits should be applied to WAL, false if not >*/ > @Deprecated > public boolean getWriteToWAL() { > return this.durability == Durability.SKIP_WAL; > } > {code} > For example, if mutation.durability is Durability.SYNC_WAL and the following > code is called {{clonedMutation.setWriteToWAL(mutation.getWriteToWAL())}}, it > will disable writing to the WAL for clonedMutation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14989) Implementation of Mutation.getWriteToWAL() is backwards
[ https://issues.apache.org/jira/browse/HBASE-14989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enis Soztutar updated HBASE-14989: -- Attachment: hbase-14989-branch-1_v1.patch Attaching v1. > Implementation of Mutation.getWriteToWAL() is backwards > --- > > Key: HBASE-14989 > URL: https://issues.apache.org/jira/browse/HBASE-14989 > Project: HBase > Issue Type: Bug >Reporter: James Taylor > Fix For: 1.3.0, 1.2.1, 1.1.4, 0.98.17, 1.0.4 > > Attachments: hbase-14989-branch-1_v1.patch > > > The implementation of the deprecated getWriteToWAL is backwards. It should > return true if this.durability == Durability.SYNC_WAL: > {code} > /** >* @deprecated Use {@link #getDurability()} instead. >* @return true if edits should be applied to WAL, false if not >*/ > @Deprecated > public boolean getWriteToWAL() { > return this.durability == Durability.SKIP_WAL; > } > {code} > For example, if mutation.durability is Durability.SYNC_WAL and the following > code is called {{clonedMutation.setWriteToWAL(mutation.getWriteToWAL())}}, it > will disable writing to the WAL for clonedMutation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14989) Implementation of Mutation.getWriteToWAL() is backwards
[ https://issues.apache.org/jira/browse/HBASE-14989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enis Soztutar updated HBASE-14989: -- Status: Patch Available (was: Open) > Implementation of Mutation.getWriteToWAL() is backwards > --- > > Key: HBASE-14989 > URL: https://issues.apache.org/jira/browse/HBASE-14989 > Project: HBase > Issue Type: Bug >Reporter: James Taylor > Fix For: 1.3.0, 1.2.1, 1.1.4, 0.98.17, 1.0.4 > > Attachments: hbase-14989-branch-1_v1.patch > > > The implementation of the deprecated getWriteToWAL is backwards. It should > return true if this.durability == Durability.SYNC_WAL: > {code} > /** >* @deprecated Use {@link #getDurability()} instead. >* @return true if edits should be applied to WAL, false if not >*/ > @Deprecated > public boolean getWriteToWAL() { > return this.durability == Durability.SKIP_WAL; > } > {code} > For example, if mutation.durability is Durability.SYNC_WAL and the following > code is called {{clonedMutation.setWriteToWAL(mutation.getWriteToWAL())}}, it > will disable writing to the WAL for clonedMutation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14989) Implementation of Mutation.getWriteToWAL() is backwards
[ https://issues.apache.org/jira/browse/HBASE-14989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-14989: Fix Version/s: (was: 1.2.0) 1.2.1 > Implementation of Mutation.getWriteToWAL() is backwards > --- > > Key: HBASE-14989 > URL: https://issues.apache.org/jira/browse/HBASE-14989 > Project: HBase > Issue Type: Bug >Reporter: James Taylor > Fix For: 1.3.0, 1.2.1, 1.1.4, 0.98.17, 1.0.4 > > > The implementation of the deprecated getWriteToWAL is backwards. It should > return true if this.durability == Durability.SYNC_WAL: > {code} > /** >* @deprecated Use {@link #getDurability()} instead. >* @return true if edits should be applied to WAL, false if not >*/ > @Deprecated > public boolean getWriteToWAL() { > return this.durability == Durability.SKIP_WAL; > } > {code} > For example, if mutation.durability is Durability.SYNC_WAL and the following > code is called {{clonedMutation.setWriteToWAL(mutation.getWriteToWAL())}}, it > will disable writing to the WAL for clonedMutation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14989) Implementation of Mutation.getWriteToWAL() is backwards
[ https://issues.apache.org/jira/browse/HBASE-14989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enis Soztutar updated HBASE-14989: -- Fix Version/s: 1.0.4 0.98.17 1.1.4 1.3.0 1.2.0 > Implementation of Mutation.getWriteToWAL() is backwards > --- > > Key: HBASE-14989 > URL: https://issues.apache.org/jira/browse/HBASE-14989 > Project: HBase > Issue Type: Bug >Reporter: James Taylor > Fix For: 1.2.0, 1.3.0, 1.1.4, 0.98.17, 1.0.4 > > > The implementation of the deprecated getWriteToWAL is backwards. It should > return true if this.durability == Durability.SYNC_WAL: > {code} > /** >* @deprecated Use {@link #getDurability()} instead. >* @return true if edits should be applied to WAL, false if not >*/ > @Deprecated > public boolean getWriteToWAL() { > return this.durability == Durability.SKIP_WAL; > } > {code} > For example, if mutation.durability is Durability.SYNC_WAL and the following > code is called {{clonedMutation.setWriteToWAL(mutation.getWriteToWAL())}}, it > will disable writing to the WAL for clonedMutation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14989) Implementation of Mutation.getWriteToWAL() is backwards
[ https://issues.apache.org/jira/browse/HBASE-14989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated HBASE-14989: - Summary: Implementation of Mutation.getWriteToWAL() is backwards (was: Mutation.getWriteToWAL is backwards) > Implementation of Mutation.getWriteToWAL() is backwards > --- > > Key: HBASE-14989 > URL: https://issues.apache.org/jira/browse/HBASE-14989 > Project: HBase > Issue Type: Bug >Reporter: James Taylor > > The implementation of the deprecated getWriteToWAL is backwards. It should > return true if this.durability == Durability.SYNC_WAL: > {code} > /** >* @deprecated Use {@link #getDurability()} instead. >* @return true if edits should be applied to WAL, false if not >*/ > @Deprecated > public boolean getWriteToWAL() { > return this.durability == Durability.SKIP_WAL; > } > {code} > For example, if mutation.durability is Durability.SYNC_WAL and the following > code is called {{clonedMutation.setWriteToWAL(mutation.getWriteToWAL())}}, it > will disable writing to the WAL for clonedMutation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)