[jira] [Updated] (HBASE-15645) hbase.rpc.timeout is not used in operations of HTable
[
https://issues.apache.org/jira/browse/HBASE-15645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell updated HBASE-15645:
---
Fix Version/s: (was: 1.4.0)
> hbase.rpc.timeout is not used in operations of HTable
> -
>
> Key: HBASE-15645
> URL: https://issues.apache.org/jira/browse/HBASE-15645
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0, 1.3.0, 1.2.1, 1.0.3, 1.1.4
>Reporter: Phil Yang
>Assignee: Phil Yang
>Priority: Critical
> Fix For: 2.0.0, 1.3.0, 1.0.4, 1.1.5, 1.2.2
>
> Attachments: HBASE-15645-branch-1-v1.patch,
> HBASE-15645-branch-1.0-v1.patch, HBASE-15645-branch-1.1-v1.patch,
> HBASE-15645-branch-1.2-v1.patch, HBASE-15645-v1.patch, HBASE-15645-v2.patch,
> HBASE-15645-v3.patch, HBASE-15645-v4.patch, lable.patch
>
>
> While fixing HBASE-15593, I find that we use operationTimeout as the timeout
> of Get operation rpc call (hbase.client.scanner.timeout.period is used in
> scan rpc), not the hbase.rpc.timeout.
> This can be verified by add one line in TestHCM.setUpBeforeClass():
> {code}
> TEST_UTIL.getConfiguration().setLong(HConstants.HBASE_RPC_TIMEOUT_KEY, 3000);
> {code}
> and then run testOperationTimeout(), the test passes but it should have
> failed because we should get rpc timeout first after 3 seconds then client
> should retry and timeout again and again until operationTimeout or max
> retries reached.
> If I port this test to 0.98, it will fail as expected.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-15645) hbase.rpc.timeout is not used in operations of HTable
[
https://issues.apache.org/jira/browse/HBASE-15645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Yang updated HBASE-15645:
--
Release Note:
Fixes regression where hbase.rpc.timeout configuration was ignored in
branch-1.0+
Adds new methods setOperationTimeout, getOperationTimeout, setRpcTimeout, and
getRpcTimeout to Table. In branch-1.3+ they are public interfaces and in
1.0-1.2 they are labeled as @InterfaceAudience.Private.
Adds hbase.client.operation.timeout to hbase-default.xml with default of 120
was:
Fixes regression where hbase.rpc.timeout configuration was ignored in
branch-1.0+
Adds new methods setOperationTimeout, getOperationTimeout, setRpcTimeout, and
getRpcTimeout to Table
Adds hbase.client.operation.timeout to hbase-default.xml with default of 120
> hbase.rpc.timeout is not used in operations of HTable
> -
>
> Key: HBASE-15645
> URL: https://issues.apache.org/jira/browse/HBASE-15645
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0, 1.3.0, 1.2.1, 1.0.3, 1.1.4
>Reporter: Phil Yang
>Assignee: Phil Yang
>Priority: Critical
> Fix For: 2.0.0, 1.3.0, 1.0.4, 1.4.0, 1.1.5, 1.2.2
>
> Attachments: HBASE-15645-branch-1-v1.patch,
> HBASE-15645-branch-1.0-v1.patch, HBASE-15645-branch-1.1-v1.patch,
> HBASE-15645-branch-1.2-v1.patch, HBASE-15645-v1.patch, HBASE-15645-v2.patch,
> HBASE-15645-v3.patch, HBASE-15645-v4.patch, lable.patch
>
>
> While fixing HBASE-15593, I find that we use operationTimeout as the timeout
> of Get operation rpc call (hbase.client.scanner.timeout.period is used in
> scan rpc), not the hbase.rpc.timeout.
> This can be verified by add one line in TestHCM.setUpBeforeClass():
> {code}
> TEST_UTIL.getConfiguration().setLong(HConstants.HBASE_RPC_TIMEOUT_KEY, 3000);
> {code}
> and then run testOperationTimeout(), the test passes but it should have
> failed because we should get rpc timeout first after 3 seconds then client
> should retry and timeout again and again until operationTimeout or max
> retries reached.
> If I port this test to 0.98, it will fail as expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-15645) hbase.rpc.timeout is not used in operations of HTable
[
https://issues.apache.org/jira/browse/HBASE-15645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Yang updated HBASE-15645:
--
Attachment: lable.patch
Upload a small patch based on current committed branches, add four
@InterfaceAudience.Private annotations. [~stack] Does it work for you?
> hbase.rpc.timeout is not used in operations of HTable
> -
>
> Key: HBASE-15645
> URL: https://issues.apache.org/jira/browse/HBASE-15645
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0, 1.3.0, 1.2.1, 1.0.3, 1.1.4
>Reporter: Phil Yang
>Assignee: Phil Yang
>Priority: Critical
> Fix For: 2.0.0, 1.3.0, 1.0.4, 1.4.0, 1.1.5, 1.2.2
>
> Attachments: HBASE-15645-branch-1-v1.patch,
> HBASE-15645-branch-1.0-v1.patch, HBASE-15645-branch-1.1-v1.patch,
> HBASE-15645-branch-1.2-v1.patch, HBASE-15645-v1.patch, HBASE-15645-v2.patch,
> HBASE-15645-v3.patch, HBASE-15645-v4.patch, lable.patch
>
>
> While fixing HBASE-15593, I find that we use operationTimeout as the timeout
> of Get operation rpc call (hbase.client.scanner.timeout.period is used in
> scan rpc), not the hbase.rpc.timeout.
> This can be verified by add one line in TestHCM.setUpBeforeClass():
> {code}
> TEST_UTIL.getConfiguration().setLong(HConstants.HBASE_RPC_TIMEOUT_KEY, 3000);
> {code}
> and then run testOperationTimeout(), the test passes but it should have
> failed because we should get rpc timeout first after 3 seconds then client
> should retry and timeout again and again until operationTimeout or max
> retries reached.
> If I port this test to 0.98, it will fail as expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-15645) hbase.rpc.timeout is not used in operations of HTable
[
https://issues.apache.org/jira/browse/HBASE-15645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-15645:
--
Release Note:
Fixes regression where hbase.rpc.timeout configuration was ignored in
branch-1.0+
Adds new methods setOperationTimeout, getOperationTimeout, setRpcTimeout, and
getRpcTimeout to Table
Adds hbase.client.operation.timeout to hbase-default.xml with default of 120
was:Fixes regression where hbase.rpc.timeout configuration was ignored in
branch-1.0+
> hbase.rpc.timeout is not used in operations of HTable
> -
>
> Key: HBASE-15645
> URL: https://issues.apache.org/jira/browse/HBASE-15645
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0, 1.3.0, 1.2.1, 1.0.3, 1.1.4
>Reporter: Phil Yang
>Assignee: Phil Yang
>Priority: Critical
> Fix For: 2.0.0, 1.3.0, 1.0.4, 1.4.0, 1.1.5, 1.2.2
>
> Attachments: HBASE-15645-branch-1-v1.patch,
> HBASE-15645-branch-1.0-v1.patch, HBASE-15645-branch-1.1-v1.patch,
> HBASE-15645-branch-1.2-v1.patch, HBASE-15645-v1.patch, HBASE-15645-v2.patch,
> HBASE-15645-v3.patch, HBASE-15645-v4.patch
>
>
> While fixing HBASE-15593, I find that we use operationTimeout as the timeout
> of Get operation rpc call (hbase.client.scanner.timeout.period is used in
> scan rpc), not the hbase.rpc.timeout.
> This can be verified by add one line in TestHCM.setUpBeforeClass():
> {code}
> TEST_UTIL.getConfiguration().setLong(HConstants.HBASE_RPC_TIMEOUT_KEY, 3000);
> {code}
> and then run testOperationTimeout(), the test passes but it should have
> failed because we should get rpc timeout first after 3 seconds then client
> should retry and timeout again and again until operationTimeout or max
> retries reached.
> If I port this test to 0.98, it will fail as expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-15645) hbase.rpc.timeout is not used in operations of HTable
[
https://issues.apache.org/jira/browse/HBASE-15645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-15645:
--
Resolution: Fixed
Hadoop Flags: Reviewed
Release Note: Fixes regression where hbase.rpc.timeout configuration was
ignored in branch-1.0+
Status: Resolved (was: Patch Available)
Pushed to branch-1.0+. Thanks for the nice fix [~yangzhe1991]
> hbase.rpc.timeout is not used in operations of HTable
> -
>
> Key: HBASE-15645
> URL: https://issues.apache.org/jira/browse/HBASE-15645
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0, 1.3.0, 1.2.1, 1.0.3, 1.1.4
>Reporter: Phil Yang
>Assignee: Phil Yang
>Priority: Critical
> Fix For: 2.0.0, 1.3.0, 1.0.4, 1.4.0, 1.1.5, 1.2.2
>
> Attachments: HBASE-15645-branch-1-v1.patch,
> HBASE-15645-branch-1.0-v1.patch, HBASE-15645-branch-1.1-v1.patch,
> HBASE-15645-branch-1.2-v1.patch, HBASE-15645-v1.patch, HBASE-15645-v2.patch,
> HBASE-15645-v3.patch, HBASE-15645-v4.patch
>
>
> While fixing HBASE-15593, I find that we use operationTimeout as the timeout
> of Get operation rpc call (hbase.client.scanner.timeout.period is used in
> scan rpc), not the hbase.rpc.timeout.
> This can be verified by add one line in TestHCM.setUpBeforeClass():
> {code}
> TEST_UTIL.getConfiguration().setLong(HConstants.HBASE_RPC_TIMEOUT_KEY, 3000);
> {code}
> and then run testOperationTimeout(), the test passes but it should have
> failed because we should get rpc timeout first after 3 seconds then client
> should retry and timeout again and again until operationTimeout or max
> retries reached.
> If I port this test to 0.98, it will fail as expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-15645) hbase.rpc.timeout is not used in operations of HTable
[
https://issues.apache.org/jira/browse/HBASE-15645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Yang updated HBASE-15645:
--
Attachment: HBASE-15645-branch-1.1-v1.patch
javadoc/findbugs looks unrelated. Failed TestReplicationEndpoint in branch-1.0
is timeout and can pass locally. Reupload branch-1.1 to retry QA
> hbase.rpc.timeout is not used in operations of HTable
> -
>
> Key: HBASE-15645
> URL: https://issues.apache.org/jira/browse/HBASE-15645
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0, 1.3.0, 1.2.1, 1.0.3, 1.1.4
>Reporter: Phil Yang
>Assignee: Phil Yang
>Priority: Critical
> Fix For: 2.0.0, 1.3.0, 1.0.4, 1.4.0, 1.1.5, 1.2.2
>
> Attachments: HBASE-15645-branch-1-v1.patch,
> HBASE-15645-branch-1.0-v1.patch, HBASE-15645-branch-1.1-v1.patch,
> HBASE-15645-branch-1.2-v1.patch, HBASE-15645-v1.patch, HBASE-15645-v2.patch,
> HBASE-15645-v3.patch, HBASE-15645-v4.patch
>
>
> While fixing HBASE-15593, I find that we use operationTimeout as the timeout
> of Get operation rpc call (hbase.client.scanner.timeout.period is used in
> scan rpc), not the hbase.rpc.timeout.
> This can be verified by add one line in TestHCM.setUpBeforeClass():
> {code}
> TEST_UTIL.getConfiguration().setLong(HConstants.HBASE_RPC_TIMEOUT_KEY, 3000);
> {code}
> and then run testOperationTimeout(), the test passes but it should have
> failed because we should get rpc timeout first after 3 seconds then client
> should retry and timeout again and again until operationTimeout or max
> retries reached.
> If I port this test to 0.98, it will fail as expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-15645) hbase.rpc.timeout is not used in operations of HTable
[
https://issues.apache.org/jira/browse/HBASE-15645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Yang updated HBASE-15645:
--
Attachment: (was: HBASE-15645-branch-1.1-v1.patch)
> hbase.rpc.timeout is not used in operations of HTable
> -
>
> Key: HBASE-15645
> URL: https://issues.apache.org/jira/browse/HBASE-15645
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0, 1.3.0, 1.2.1, 1.0.3, 1.1.4
>Reporter: Phil Yang
>Assignee: Phil Yang
>Priority: Critical
> Fix For: 2.0.0, 1.3.0, 1.0.4, 1.4.0, 1.1.5, 1.2.2
>
> Attachments: HBASE-15645-branch-1-v1.patch,
> HBASE-15645-branch-1.0-v1.patch, HBASE-15645-branch-1.2-v1.patch,
> HBASE-15645-v1.patch, HBASE-15645-v2.patch, HBASE-15645-v3.patch,
> HBASE-15645-v4.patch
>
>
> While fixing HBASE-15593, I find that we use operationTimeout as the timeout
> of Get operation rpc call (hbase.client.scanner.timeout.period is used in
> scan rpc), not the hbase.rpc.timeout.
> This can be verified by add one line in TestHCM.setUpBeforeClass():
> {code}
> TEST_UTIL.getConfiguration().setLong(HConstants.HBASE_RPC_TIMEOUT_KEY, 3000);
> {code}
> and then run testOperationTimeout(), the test passes but it should have
> failed because we should get rpc timeout first after 3 seconds then client
> should retry and timeout again and again until operationTimeout or max
> retries reached.
> If I port this test to 0.98, it will fail as expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-15645) hbase.rpc.timeout is not used in operations of HTable
[
https://issues.apache.org/jira/browse/HBASE-15645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Yang updated HBASE-15645:
--
Attachment: HBASE-15645-branch-1.0-v1.patch
Upload patch for branch-1.0, all patches are uploaded. Thanks.
> hbase.rpc.timeout is not used in operations of HTable
> -
>
> Key: HBASE-15645
> URL: https://issues.apache.org/jira/browse/HBASE-15645
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0, 1.3.0, 1.2.1, 1.0.3, 1.1.4
>Reporter: Phil Yang
>Assignee: Phil Yang
>Priority: Critical
> Fix For: 2.0.0, 1.3.0, 1.0.4, 1.4.0, 1.1.5, 1.2.2
>
> Attachments: HBASE-15645-branch-1-v1.patch,
> HBASE-15645-branch-1.0-v1.patch, HBASE-15645-branch-1.1-v1.patch,
> HBASE-15645-branch-1.2-v1.patch, HBASE-15645-v1.patch, HBASE-15645-v2.patch,
> HBASE-15645-v3.patch, HBASE-15645-v4.patch
>
>
> While fixing HBASE-15593, I find that we use operationTimeout as the timeout
> of Get operation rpc call (hbase.client.scanner.timeout.period is used in
> scan rpc), not the hbase.rpc.timeout.
> This can be verified by add one line in TestHCM.setUpBeforeClass():
> {code}
> TEST_UTIL.getConfiguration().setLong(HConstants.HBASE_RPC_TIMEOUT_KEY, 3000);
> {code}
> and then run testOperationTimeout(), the test passes but it should have
> failed because we should get rpc timeout first after 3 seconds then client
> should retry and timeout again and again until operationTimeout or max
> retries reached.
> If I port this test to 0.98, it will fail as expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-15645) hbase.rpc.timeout is not used in operations of HTable
[
https://issues.apache.org/jira/browse/HBASE-15645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Yang updated HBASE-15645:
--
Attachment: HBASE-15645-branch-1.1-v1.patch
upload patch for branch-1.1
> hbase.rpc.timeout is not used in operations of HTable
> -
>
> Key: HBASE-15645
> URL: https://issues.apache.org/jira/browse/HBASE-15645
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0, 1.3.0, 1.2.1, 1.0.3, 1.1.4
>Reporter: Phil Yang
>Assignee: Phil Yang
>Priority: Critical
> Fix For: 2.0.0, 1.3.0, 1.0.4, 1.4.0, 1.1.5, 1.2.2
>
> Attachments: HBASE-15645-branch-1-v1.patch,
> HBASE-15645-branch-1.1-v1.patch, HBASE-15645-branch-1.2-v1.patch,
> HBASE-15645-v1.patch, HBASE-15645-v2.patch, HBASE-15645-v3.patch,
> HBASE-15645-v4.patch
>
>
> While fixing HBASE-15593, I find that we use operationTimeout as the timeout
> of Get operation rpc call (hbase.client.scanner.timeout.period is used in
> scan rpc), not the hbase.rpc.timeout.
> This can be verified by add one line in TestHCM.setUpBeforeClass():
> {code}
> TEST_UTIL.getConfiguration().setLong(HConstants.HBASE_RPC_TIMEOUT_KEY, 3000);
> {code}
> and then run testOperationTimeout(), the test passes but it should have
> failed because we should get rpc timeout first after 3 seconds then client
> should retry and timeout again and again until operationTimeout or max
> retries reached.
> If I port this test to 0.98, it will fail as expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-15645) hbase.rpc.timeout is not used in operations of HTable
[
https://issues.apache.org/jira/browse/HBASE-15645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Yang updated HBASE-15645:
--
Attachment: HBASE-15645-branch-1.2-v1.patch
patch for branch-1 can also be applied to branch-1.3, upload patch for
branch-1.2
> hbase.rpc.timeout is not used in operations of HTable
> -
>
> Key: HBASE-15645
> URL: https://issues.apache.org/jira/browse/HBASE-15645
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0, 1.3.0, 1.2.1, 1.0.3, 1.1.4
>Reporter: Phil Yang
>Assignee: Phil Yang
>Priority: Critical
> Fix For: 2.0.0, 1.3.0, 1.0.4, 1.4.0, 1.1.5, 1.2.2
>
> Attachments: HBASE-15645-branch-1-v1.patch,
> HBASE-15645-branch-1.2-v1.patch, HBASE-15645-v1.patch, HBASE-15645-v2.patch,
> HBASE-15645-v3.patch, HBASE-15645-v4.patch
>
>
> While fixing HBASE-15593, I find that we use operationTimeout as the timeout
> of Get operation rpc call (hbase.client.scanner.timeout.period is used in
> scan rpc), not the hbase.rpc.timeout.
> This can be verified by add one line in TestHCM.setUpBeforeClass():
> {code}
> TEST_UTIL.getConfiguration().setLong(HConstants.HBASE_RPC_TIMEOUT_KEY, 3000);
> {code}
> and then run testOperationTimeout(), the test passes but it should have
> failed because we should get rpc timeout first after 3 seconds then client
> should retry and timeout again and again until operationTimeout or max
> retries reached.
> If I port this test to 0.98, it will fail as expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-15645) hbase.rpc.timeout is not used in operations of HTable
[
https://issues.apache.org/jira/browse/HBASE-15645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Yang updated HBASE-15645:
--
Attachment: HBASE-15645-branch-1-v1.patch
upload patch for branch-1
> hbase.rpc.timeout is not used in operations of HTable
> -
>
> Key: HBASE-15645
> URL: https://issues.apache.org/jira/browse/HBASE-15645
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0, 1.3.0, 1.2.1, 1.0.3, 1.1.4
>Reporter: Phil Yang
>Assignee: Phil Yang
>Priority: Critical
> Fix For: 2.0.0, 1.3.0, 1.0.4, 1.4.0, 1.1.5, 1.2.2
>
> Attachments: HBASE-15645-branch-1-v1.patch, HBASE-15645-v1.patch,
> HBASE-15645-v2.patch, HBASE-15645-v3.patch, HBASE-15645-v4.patch
>
>
> While fixing HBASE-15593, I find that we use operationTimeout as the timeout
> of Get operation rpc call (hbase.client.scanner.timeout.period is used in
> scan rpc), not the hbase.rpc.timeout.
> This can be verified by add one line in TestHCM.setUpBeforeClass():
> {code}
> TEST_UTIL.getConfiguration().setLong(HConstants.HBASE_RPC_TIMEOUT_KEY, 3000);
> {code}
> and then run testOperationTimeout(), the test passes but it should have
> failed because we should get rpc timeout first after 3 seconds then client
> should retry and timeout again and again until operationTimeout or max
> retries reached.
> If I port this test to 0.98, it will fail as expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-15645) hbase.rpc.timeout is not used in operations of HTable
[
https://issues.apache.org/jira/browse/HBASE-15645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Yang updated HBASE-15645:
--
Attachment: HBASE-15645-v4.patch
> hbase.rpc.timeout is not used in operations of HTable
> -
>
> Key: HBASE-15645
> URL: https://issues.apache.org/jira/browse/HBASE-15645
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0, 1.3.0, 1.2.1, 1.0.3, 1.1.4
>Reporter: Phil Yang
>Assignee: Phil Yang
>Priority: Critical
> Fix For: 2.0.0, 1.3.0, 1.0.4, 1.4.0, 1.1.5, 1.2.2
>
> Attachments: HBASE-15645-v1.patch, HBASE-15645-v2.patch,
> HBASE-15645-v3.patch, HBASE-15645-v4.patch
>
>
> While fixing HBASE-15593, I find that we use operationTimeout as the timeout
> of Get operation rpc call (hbase.client.scanner.timeout.period is used in
> scan rpc), not the hbase.rpc.timeout.
> This can be verified by add one line in TestHCM.setUpBeforeClass():
> {code}
> TEST_UTIL.getConfiguration().setLong(HConstants.HBASE_RPC_TIMEOUT_KEY, 3000);
> {code}
> and then run testOperationTimeout(), the test passes but it should have
> failed because we should get rpc timeout first after 3 seconds then client
> should retry and timeout again and again until operationTimeout or max
> retries reached.
> If I port this test to 0.98, it will fail as expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-15645) hbase.rpc.timeout is not used in operations of HTable
[
https://issues.apache.org/jira/browse/HBASE-15645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Yang updated HBASE-15645:
--
Attachment: HBASE-15645-v3.patch
Fix checkstyle/javadoc warning. Add four methods in Table and draft some docs
on them. And add hbase.client.operation.timeout in hbase-default.xml so we can
see it in HBase Book.
> hbase.rpc.timeout is not used in operations of HTable
> -
>
> Key: HBASE-15645
> URL: https://issues.apache.org/jira/browse/HBASE-15645
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0, 1.3.0, 1.2.1, 1.0.3, 1.1.4
>Reporter: Phil Yang
>Assignee: Phil Yang
>Priority: Critical
> Fix For: 2.0.0, 1.3.0, 1.0.4, 1.4.0, 1.1.5, 1.2.2
>
> Attachments: HBASE-15645-v1.patch, HBASE-15645-v2.patch,
> HBASE-15645-v3.patch
>
>
> While fixing HBASE-15593, I find that we use operationTimeout as the timeout
> of Get operation rpc call (hbase.client.scanner.timeout.period is used in
> scan rpc), not the hbase.rpc.timeout.
> This can be verified by add one line in TestHCM.setUpBeforeClass():
> {code}
> TEST_UTIL.getConfiguration().setLong(HConstants.HBASE_RPC_TIMEOUT_KEY, 3000);
> {code}
> and then run testOperationTimeout(), the test passes but it should have
> failed because we should get rpc timeout first after 3 seconds then client
> should retry and timeout again and again until operationTimeout or max
> retries reached.
> If I port this test to 0.98, it will fail as expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-15645) hbase.rpc.timeout is not used in operations of HTable
[
https://issues.apache.org/jira/browse/HBASE-15645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Yang updated HBASE-15645:
--
Attachment: HBASE-15645-v2.patch
Fix compiling error
> hbase.rpc.timeout is not used in operations of HTable
> -
>
> Key: HBASE-15645
> URL: https://issues.apache.org/jira/browse/HBASE-15645
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0, 1.3.0, 1.2.1, 1.0.3, 1.1.4
>Reporter: Phil Yang
>Assignee: Phil Yang
>Priority: Critical
> Fix For: 2.0.0, 1.3.0, 1.0.4, 1.4.0, 1.1.5, 1.2.2
>
> Attachments: HBASE-15645-v1.patch, HBASE-15645-v2.patch
>
>
> While fixing HBASE-15593, I find that we use operationTimeout as the timeout
> of Get operation rpc call (hbase.client.scanner.timeout.period is used in
> scan rpc), not the hbase.rpc.timeout.
> This can be verified by add one line in TestHCM.setUpBeforeClass():
> {code}
> TEST_UTIL.getConfiguration().setLong(HConstants.HBASE_RPC_TIMEOUT_KEY, 3000);
> {code}
> and then run testOperationTimeout(), the test passes but it should have
> failed because we should get rpc timeout first after 3 seconds then client
> should retry and timeout again and again until operationTimeout or max
> retries reached.
> If I port this test to 0.98, it will fail as expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-15645) hbase.rpc.timeout is not used in operations of HTable
[
https://issues.apache.org/jira/browse/HBASE-15645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Yang updated HBASE-15645:
--
Fix Version/s: 1.2.2
1.1.5
1.4.0
1.0.4
1.3.0
2.0.0
> hbase.rpc.timeout is not used in operations of HTable
> -
>
> Key: HBASE-15645
> URL: https://issues.apache.org/jira/browse/HBASE-15645
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0, 1.3.0, 1.2.1, 1.0.3, 1.1.4
>Reporter: Phil Yang
>Assignee: Phil Yang
>Priority: Critical
> Fix For: 2.0.0, 1.3.0, 1.0.4, 1.4.0, 1.1.5, 1.2.2
>
> Attachments: HBASE-15645-v1.patch
>
>
> While fixing HBASE-15593, I find that we use operationTimeout as the timeout
> of Get operation rpc call (hbase.client.scanner.timeout.period is used in
> scan rpc), not the hbase.rpc.timeout.
> This can be verified by add one line in TestHCM.setUpBeforeClass():
> {code}
> TEST_UTIL.getConfiguration().setLong(HConstants.HBASE_RPC_TIMEOUT_KEY, 3000);
> {code}
> and then run testOperationTimeout(), the test passes but it should have
> failed because we should get rpc timeout first after 3 seconds then client
> should retry and timeout again and again until operationTimeout or max
> retries reached.
> If I port this test to 0.98, it will fail as expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-15645) hbase.rpc.timeout is not used in operations of HTable
[
https://issues.apache.org/jira/browse/HBASE-15645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Yang updated HBASE-15645:
--
Affects Version/s: 1.3.0
2.0.0
1.2.1
1.0.3
1.1.4
> hbase.rpc.timeout is not used in operations of HTable
> -
>
> Key: HBASE-15645
> URL: https://issues.apache.org/jira/browse/HBASE-15645
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0, 1.3.0, 1.2.1, 1.0.3, 1.1.4
>Reporter: Phil Yang
>Assignee: Phil Yang
>Priority: Critical
> Attachments: HBASE-15645-v1.patch
>
>
> While fixing HBASE-15593, I find that we use operationTimeout as the timeout
> of Get operation rpc call (hbase.client.scanner.timeout.period is used in
> scan rpc), not the hbase.rpc.timeout.
> This can be verified by add one line in TestHCM.setUpBeforeClass():
> {code}
> TEST_UTIL.getConfiguration().setLong(HConstants.HBASE_RPC_TIMEOUT_KEY, 3000);
> {code}
> and then run testOperationTimeout(), the test passes but it should have
> failed because we should get rpc timeout first after 3 seconds then client
> should retry and timeout again and again until operationTimeout or max
> retries reached.
> If I port this test to 0.98, it will fail as expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-15645) hbase.rpc.timeout is not used in operations of HTable
[
https://issues.apache.org/jira/browse/HBASE-15645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Yang updated HBASE-15645:
--
Status: Patch Available (was: Open)
> hbase.rpc.timeout is not used in operations of HTable
> -
>
> Key: HBASE-15645
> URL: https://issues.apache.org/jira/browse/HBASE-15645
> Project: HBase
> Issue Type: Bug
>Reporter: Phil Yang
>Assignee: Phil Yang
>Priority: Critical
> Attachments: HBASE-15645-v1.patch
>
>
> While fixing HBASE-15593, I find that we use operationTimeout as the timeout
> of Get operation rpc call (hbase.client.scanner.timeout.period is used in
> scan rpc), not the hbase.rpc.timeout.
> This can be verified by add one line in TestHCM.setUpBeforeClass():
> {code}
> TEST_UTIL.getConfiguration().setLong(HConstants.HBASE_RPC_TIMEOUT_KEY, 3000);
> {code}
> and then run testOperationTimeout(), the test passes but it should have
> failed because we should get rpc timeout first after 3 seconds then client
> should retry and timeout again and again until operationTimeout or max
> retries reached.
> If I port this test to 0.98, it will fail as expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-15645) hbase.rpc.timeout is not used in operations of HTable
[
https://issues.apache.org/jira/browse/HBASE-15645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Yang updated HBASE-15645:
--
Attachment: HBASE-15645-v1.patch
Upload patch.
In HTable for each rpcCallerFactory. newCaller, add a rpcTimeout in it.
Timeout for scan and Table interface is not changed, I think we can open
another two issues and have more discussion.
> hbase.rpc.timeout is not used in operations of HTable
> -
>
> Key: HBASE-15645
> URL: https://issues.apache.org/jira/browse/HBASE-15645
> Project: HBase
> Issue Type: Bug
>Reporter: Phil Yang
>Assignee: Phil Yang
>Priority: Critical
> Attachments: HBASE-15645-v1.patch
>
>
> While fixing HBASE-15593, I find that we use operationTimeout as the timeout
> of Get operation rpc call (hbase.client.scanner.timeout.period is used in
> scan rpc), not the hbase.rpc.timeout.
> This can be verified by add one line in TestHCM.setUpBeforeClass():
> {code}
> TEST_UTIL.getConfiguration().setLong(HConstants.HBASE_RPC_TIMEOUT_KEY, 3000);
> {code}
> and then run testOperationTimeout(), the test passes but it should have
> failed because we should get rpc timeout first after 3 seconds then client
> should retry and timeout again and again until operationTimeout or max
> retries reached.
> If I port this test to 0.98, it will fail as expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-15645) hbase.rpc.timeout is not used in operations of HTable
[
https://issues.apache.org/jira/browse/HBASE-15645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Yang updated HBASE-15645:
--
Summary: hbase.rpc.timeout is not used in operations of HTable (was:
hbase.rpc.timeout is not used in get operation)
> hbase.rpc.timeout is not used in operations of HTable
> -
>
> Key: HBASE-15645
> URL: https://issues.apache.org/jira/browse/HBASE-15645
> Project: HBase
> Issue Type: Bug
>Reporter: Phil Yang
>Assignee: Phil Yang
>Priority: Critical
>
> While fixing HBASE-15593, I find that we use operationTimeout as the timeout
> of Get operation rpc call (hbase.client.scanner.timeout.period is used in
> scan rpc), not the hbase.rpc.timeout.
> This can be verified by add one line in TestHCM.setUpBeforeClass():
> {code}
> TEST_UTIL.getConfiguration().setLong(HConstants.HBASE_RPC_TIMEOUT_KEY, 3000);
> {code}
> and then run testOperationTimeout(), the test passes but it should have
> failed because we should get rpc timeout first after 3 seconds then client
> should retry and timeout again and again until operationTimeout or max
> retries reached.
> If I port this test to 0.98, it will fail as expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
