[jira] [Updated] (HBASE-16183) Correct errors in example program of coprocessor in Ref Guide
[ https://issues.apache.org/jira/browse/HBASE-16183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Misty Stanley-Jones updated HBASE-16183: Status: Open (was: Patch Available) Please re-create and re-attach the patch. > Correct errors in example program of coprocessor in Ref Guide > - > > Key: HBASE-16183 > URL: https://issues.apache.org/jira/browse/HBASE-16183 > Project: HBase > Issue Type: Bug > Components: documentation >Affects Versions: 1.2.0 >Reporter: Xiang Li >Assignee: Xiang Li >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-16183-master-v1.patch, HBASE-16183.patch > > > There are some errors in the example programs for coprocessor in Ref Guide. > Such as using deprecated APIs, generic... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16183) Correct errors in example program of coprocessor in Ref Guide
[ https://issues.apache.org/jira/browse/HBASE-16183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiang Li updated HBASE-16183: - Fix Version/s: 2.0.0 Affects Version/s: 1.2.0 Status: Patch Available (was: Open) > Correct errors in example program of coprocessor in Ref Guide > - > > Key: HBASE-16183 > URL: https://issues.apache.org/jira/browse/HBASE-16183 > Project: HBase > Issue Type: Bug > Components: documentation >Affects Versions: 1.2.0 >Reporter: Xiang Li >Assignee: Xiang Li >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-16183-master-v1.patch, HBASE-16183.patch > > > There are some errors in the example programs for coprocessor in Ref Guide. > Such as using deprecated APIs, generic... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16183) Correct errors in example program of coprocessor in Ref Guide
[ https://issues.apache.org/jira/browse/HBASE-16183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiang Li updated HBASE-16183: - Attachment: HBASE-16183-master-v1.patch Patch v1 for master branch. > Correct errors in example program of coprocessor in Ref Guide > - > > Key: HBASE-16183 > URL: https://issues.apache.org/jira/browse/HBASE-16183 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Xiang Li >Assignee: Xiang Li >Priority: Minor > Attachments: HBASE-16183-master-v1.patch, HBASE-16183.patch > > > There are some errors in the example programs for coprocessor in Ref Guide. > Such as using deprecated APIs, generic... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16183) Correct errors in example program of coprocessor in Ref Guide
[ https://issues.apache.org/jira/browse/HBASE-16183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiang Li updated HBASE-16183: - Description: There are some errors in the example programs for coprocessor in Ref Guide. Such as using deprecated APIs, generic... (was: There are some errors in the example programs for ) > Correct errors in example program of coprocessor in Ref Guide > - > > Key: HBASE-16183 > URL: https://issues.apache.org/jira/browse/HBASE-16183 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Xiang Li >Assignee: Xiang Li >Priority: Minor > Attachments: HBASE-16183.patch > > > There are some errors in the example programs for coprocessor in Ref Guide. > Such as using deprecated APIs, generic... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16183) Correct errors in example program of coprocessor in Ref Guide
[ https://issues.apache.org/jira/browse/HBASE-16183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiang Li updated HBASE-16183: - Description: There are some errors in the example programs for > Correct errors in example program of coprocessor in Ref Guide > - > > Key: HBASE-16183 > URL: https://issues.apache.org/jira/browse/HBASE-16183 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Xiang Li >Assignee: Xiang Li >Priority: Minor > Attachments: HBASE-16183.patch > > > There are some errors in the example programs for -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16183) Correct errors in example program of coprocessor in Ref Guide
[
https://issues.apache.org/jira/browse/HBASE-16183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HBASE-16183:
-
Description: (was: 1. In Section 89.3.3
change
{code}
String path = "hdfs://:/user//coprocessor.jar";
{code}
into
{code}
Path path = new
Path("hdfs://bdavm1506.svl.ibm.com:8020/user/hbase/coprocessor.jar");
{code}
Reason:
The second parameter of HTableDescriptor.addCoprocessor() is
org.apache.hadoop.fs.Path, not String.
See
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/HTableDescriptor.html
2. In Section 89.3.3
change
{code}
HBaseAdmin admin = new HBaseAdmin(conf);
{code}
into
{code}
Connection connection = ConnectionFactory.createConnection(conf);
Admin admin = connection.getAdmin();
{code}
Reason:
HBASE-12083 makes new HBaseAdmin() deprecated and the instance of Admin is
supposed to get from Connection.getAdmin()
Also see
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/client/HBaseAdmin.html
3. In section 90.1
change
{code}
public void preGetOp(final ObserverContext e, final Get get, final List results)
{code}
into
{code}
public void preGetOp(final ObserverContext e,
final Get get, final List results)
{code}
change
{code}
List kvs = new ArrayList(results.size());
{code}
into
{code}
List kvs = new ArrayList(results.size());
{code}
change
{code}
public RegionScanner preScannerOpen(final ObserverContext e, final Scan scan,
{code}
into
{code}
preScannerOpen(final ObserverContext e, final
Scan scan，
{code}
change
{code}
public boolean postScannerNext(final ObserverContext e, final InternalScanner
s, final List results, final int limit, final boolean hasMore) throws
IOException {
{code}
into
{code}
public boolean postScannerNext(final
ObserverContext e, final InternalScanner s, final
List results, final int limit, final boolean hasMore) throws
IOException {
{code}
change
{code}
Iterator iterator = results.iterator();
{code}
into
{code}
Iterator iterator = results.iterator();
{code}
Reason:
Generic
4. In section 90.1
change
{code}
preGet(e, get, kvs);
{code}
into
{code}
super.preGetOp(e, get, kvs);
{code}
Reason:
There is not a function called preGet() provided by BaseRegionObserver or its
super class/interface. I believe we need to call preGetOp() of the super class
of RegionObserverExample here.
5. In section 90.1
change
{code}
kvs.add(KeyValueUtil.ensureKeyValue(c));
{code}
into
{code}
kvs.add(c);
{code}
Reason:
KeyValueUtil.ensureKeyValue() is deprecated.
See
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/KeyValueUtil.html
and https://issues.apache.org/jira/browse/HBASE-12079)
> Correct errors in example program of coprocessor in Ref Guide
> -
>
> Key: HBASE-16183
> URL: https://issues.apache.org/jira/browse/HBASE-16183
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: Xiang Li
>Assignee: Xiang Li
>Priority: Minor
> Attachments: HBASE-16183.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-16183) Correct errors in example program of coprocessor in Ref Guide
[
https://issues.apache.org/jira/browse/HBASE-16183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yu Li updated HBASE-16183:
--
Assignee: Xiang Li (was: Yu Li)
Assign back to [~waterlx], please check the patch and do necessary supplement
if needed. Thanks for pointing this out.
> Correct errors in example program of coprocessor in Ref Guide
> -
>
> Key: HBASE-16183
> URL: https://issues.apache.org/jira/browse/HBASE-16183
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: Xiang Li
>Assignee: Xiang Li
>Priority: Minor
> Attachments: HBASE-16183.patch
>
>
> 1. In Section 89.3.3
> change
> {code}
> String path = "hdfs://:/user//coprocessor.jar";
> {code}
> into
> {code}
> Path path = new
> Path("hdfs://bdavm1506.svl.ibm.com:8020/user/hbase/coprocessor.jar");
> {code}
> Reason:
> The second parameter of HTableDescriptor.addCoprocessor() is
> org.apache.hadoop.fs.Path, not String.
> See
> http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/HTableDescriptor.html
> 2. In Section 89.3.3
> change
> {code}
> HBaseAdmin admin = new HBaseAdmin(conf);
> {code}
> into
> {code}
> Connection connection = ConnectionFactory.createConnection(conf);
> Admin admin = connection.getAdmin();
> {code}
> Reason:
> HBASE-12083 makes new HBaseAdmin() deprecated and the instance of Admin is
> supposed to get from Connection.getAdmin()
> Also see
> http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/client/HBaseAdmin.html
> 3. In section 90.1
> change
> {code}
> public void preGetOp(final ObserverContext e, final Get get, final List
> results)
> {code}
> into
> {code}
> public void preGetOp(final ObserverContext e,
> final Get get, final List results)
> {code}
> change
> {code}
> List kvs = new ArrayList(results.size());
> {code}
> into
> {code}
> List kvs = new ArrayList(results.size());
> {code}
> change
> {code}
> public RegionScanner preScannerOpen(final ObserverContext e, final Scan scan,
> {code}
> into
> {code}
> preScannerOpen(final ObserverContext e, final
> Scan scan，
> {code}
> change
> {code}
> public boolean postScannerNext(final ObserverContext e, final InternalScanner
> s, final List results, final int limit, final boolean hasMore) throws
> IOException {
> {code}
> into
> {code}
> public boolean postScannerNext(final
> ObserverContext e, final InternalScanner s,
> final List results, final int limit, final boolean hasMore) throws
> IOException {
> {code}
> change
> {code}
> Iterator iterator = results.iterator();
> {code}
> into
> {code}
> Iterator iterator = results.iterator();
> {code}
> Reason:
> Generic
> 4. In section 90.1
> change
> {code}
> preGet(e, get, kvs);
> {code}
> into
> {code}
> super.preGetOp(e, get, kvs);
> {code}
> Reason:
> There is not a function called preGet() provided by BaseRegionObserver or
> its super class/interface. I believe we need to call preGetOp() of the super
> class of RegionObserverExample here.
> 5. In section 90.1
> change
> {code}
> kvs.add(KeyValueUtil.ensureKeyValue(c));
> {code}
> into
> {code}
> kvs.add(c);
> {code}
> Reason:
> KeyValueUtil.ensureKeyValue() is deprecated.
> See
> http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/KeyValueUtil.html
> and https://issues.apache.org/jira/browse/HBASE-12079
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-16183) Correct errors in example program of coprocessor in Ref Guide
[
https://issues.apache.org/jira/browse/HBASE-16183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yu Li updated HBASE-16183:
--
Attachment: HBASE-16183.patch
Attaching a patch applying most of the changes mentioned in description, except
for removing the invocation of {{preGet(e, get, kvs);}} in {{preGetOp}} since
the preGet CP hook is already removed, refer to HBASE-11919 for more details
> Correct errors in example program of coprocessor in Ref Guide
> -
>
> Key: HBASE-16183
> URL: https://issues.apache.org/jira/browse/HBASE-16183
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: Xiang Li
>Assignee: Yu Li
>Priority: Minor
> Attachments: HBASE-16183.patch
>
>
> 1. In Section 89.3.3
> change
> {code}
> String path = "hdfs://:/user//coprocessor.jar";
> {code}
> into
> {code}
> Path path = new
> Path("hdfs://bdavm1506.svl.ibm.com:8020/user/hbase/coprocessor.jar");
> {code}
> Reason:
> The second parameter of HTableDescriptor.addCoprocessor() is
> org.apache.hadoop.fs.Path, not String.
> See
> http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/HTableDescriptor.html
> 2. In Section 89.3.3
> change
> {code}
> HBaseAdmin admin = new HBaseAdmin(conf);
> {code}
> into
> {code}
> Connection connection = ConnectionFactory.createConnection(conf);
> Admin admin = connection.getAdmin();
> {code}
> Reason:
> HBASE-12083 makes new HBaseAdmin() deprecated and the instance of Admin is
> supposed to get from Connection.getAdmin()
> Also see
> http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/client/HBaseAdmin.html
> 3. In section 90.1
> change
> {code}
> public void preGetOp(final ObserverContext e, final Get get, final List
> results)
> {code}
> into
> {code}
> public void preGetOp(final ObserverContext e,
> final Get get, final List results)
> {code}
> change
> {code}
> List kvs = new ArrayList(results.size());
> {code}
> into
> {code}
> List kvs = new ArrayList(results.size());
> {code}
> change
> {code}
> public RegionScanner preScannerOpen(final ObserverContext e, final Scan scan,
> {code}
> into
> {code}
> preScannerOpen(final ObserverContext e, final
> Scan scan，
> {code}
> change
> {code}
> public boolean postScannerNext(final ObserverContext e, final InternalScanner
> s, final List results, final int limit, final boolean hasMore) throws
> IOException {
> {code}
> into
> {code}
> public boolean postScannerNext(final
> ObserverContext e, final InternalScanner s,
> final List results, final int limit, final boolean hasMore) throws
> IOException {
> {code}
> change
> {code}
> Iterator iterator = results.iterator();
> {code}
> into
> {code}
> Iterator iterator = results.iterator();
> {code}
> Reason:
> Generic
> 4. In section 90.1
> change
> {code}
> preGet(e, get, kvs);
> {code}
> into
> {code}
> super.preGetOp(e, get, kvs);
> {code}
> Reason:
> There is not a function called preGet() provided by BaseRegionObserver or
> its super class/interface. I believe we need to call preGetOp() of the super
> class of RegionObserverExample here.
> 5. In section 90.1
> change
> {code}
> kvs.add(KeyValueUtil.ensureKeyValue(c));
> {code}
> into
> {code}
> kvs.add(c);
> {code}
> Reason:
> KeyValueUtil.ensureKeyValue() is deprecated.
> See
> http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/KeyValueUtil.html
> and https://issues.apache.org/jira/browse/HBASE-12079
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-16183) Correct errors in example program of coprocessor in Ref Guide
[
https://issues.apache.org/jira/browse/HBASE-16183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yu Li updated HBASE-16183:
--
Assignee: Yu Li (was: Xiang Li)
Temporarily assigned to myself to attach a patch according to the description
> Correct errors in example program of coprocessor in Ref Guide
> -
>
> Key: HBASE-16183
> URL: https://issues.apache.org/jira/browse/HBASE-16183
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: Xiang Li
>Assignee: Yu Li
>Priority: Minor
>
> 1. In Section 89.3.3
> change
> {code}
> String path = "hdfs://:/user//coprocessor.jar";
> {code}
> into
> {code}
> Path path = new
> Path("hdfs://bdavm1506.svl.ibm.com:8020/user/hbase/coprocessor.jar");
> {code}
> Reason:
> The second parameter of HTableDescriptor.addCoprocessor() is
> org.apache.hadoop.fs.Path, not String.
> See
> http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/HTableDescriptor.html
> 2. In Section 89.3.3
> change
> {code}
> HBaseAdmin admin = new HBaseAdmin(conf);
> {code}
> into
> {code}
> Connection connection = ConnectionFactory.createConnection(conf);
> Admin admin = connection.getAdmin();
> {code}
> Reason:
> HBASE-12083 makes new HBaseAdmin() deprecated and the instance of Admin is
> supposed to get from Connection.getAdmin()
> Also see
> http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/client/HBaseAdmin.html
> 3. In section 90.1
> change
> {code}
> public void preGetOp(final ObserverContext e, final Get get, final List
> results)
> {code}
> into
> {code}
> public void preGetOp(final ObserverContext e,
> final Get get, final List results)
> {code}
> change
> {code}
> List kvs = new ArrayList(results.size());
> {code}
> into
> {code}
> List kvs = new ArrayList(results.size());
> {code}
> change
> {code}
> public RegionScanner preScannerOpen(final ObserverContext e, final Scan scan,
> {code}
> into
> {code}
> preScannerOpen(final ObserverContext e, final
> Scan scan，
> {code}
> change
> {code}
> public boolean postScannerNext(final ObserverContext e, final InternalScanner
> s, final List results, final int limit, final boolean hasMore) throws
> IOException {
> {code}
> into
> {code}
> public boolean postScannerNext(final
> ObserverContext e, final InternalScanner s,
> final List results, final int limit, final boolean hasMore) throws
> IOException {
> {code}
> change
> {code}
> Iterator iterator = results.iterator();
> {code}
> into
> {code}
> Iterator iterator = results.iterator();
> {code}
> Reason:
> Generic
> 4. In section 90.1
> change
> {code}
> preGet(e, get, kvs);
> {code}
> into
> {code}
> super.preGetOp(e, get, kvs);
> {code}
> Reason:
> There is not a function called preGet() provided by BaseRegionObserver or
> its super class/interface. I believe we need to call preGetOp() of the super
> class of RegionObserverExample here.
> 5. In section 90.1
> change
> {code}
> kvs.add(KeyValueUtil.ensureKeyValue(c));
> {code}
> into
> {code}
> kvs.add(c);
> {code}
> Reason:
> KeyValueUtil.ensureKeyValue() is deprecated.
> See
> http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/KeyValueUtil.html
> and https://issues.apache.org/jira/browse/HBASE-12079
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-16183) Correct errors in example program of coprocessor in Ref Guide
[
https://issues.apache.org/jira/browse/HBASE-16183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
li xiang updated HBASE-16183:
-
Description:
1. In Section 89.3.3
change
{code}
String path = "hdfs://:/user//coprocessor.jar";
{code}
into
{code}
Path path = new
Path("hdfs://bdavm1506.svl.ibm.com:8020/user/hbase/coprocessor.jar");
{code}
Reason:
The second parameter of HTableDescriptor.addCoprocessor() is
org.apache.hadoop.fs.Path, not String.
See
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/HTableDescriptor.html
2. In Section 89.3.3
change
{code}
HBaseAdmin admin = new HBaseAdmin(conf);
{code}
into
{code}
Connection connection = ConnectionFactory.createConnection(conf);
Admin admin = connection.getAdmin();
{code}
Reason:
HBASE-12083 makes new HBaseAdmin() deprecated and the instance of Admin is
supposed to get from Connection.getAdmin()
Also see
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/client/HBaseAdmin.html
3. In section 90.1
change
{code}
public void preGetOp(final ObserverContext e, final Get get, final List results)
{code}
into
{code}
public void preGetOp(final ObserverContext e,
final Get get, final List results)
{code}
change
{code}
List kvs = new ArrayList(results.size());
{code}
into
{code}
List kvs = new ArrayList(results.size());
{code}
change
{code}
public RegionScanner preScannerOpen(final ObserverContext e, final Scan scan,
{code}
into
{code}
preScannerOpen(final ObserverContext e, final
Scan scan，
{code}
change
{code}
public boolean postScannerNext(final ObserverContext e, final InternalScanner
s, final List results, final int limit, final boolean hasMore) throws
IOException {
{code}
into
{code}
public boolean postScannerNext(final
ObserverContext e, final InternalScanner s, final
List results, final int limit, final boolean hasMore) throws
IOException {
{code}
change
{code}
Iterator iterator = results.iterator();
{code}
into
{code}
Iterator iterator = results.iterator();
{code}
Reason:
Generic
4. In section 90.1
change
{code}
preGet(e, get, kvs);
{code}
into
{code}
super.preGetOp(e, get, kvs);
{code}
Reason:
There is not a function called preGet() provided by BaseRegionObserver or its
super class/interface. I believe we need to call preGetOp() of the super class
of RegionObserverExample here.
5. In section 90.1
change
{code}
kvs.add(KeyValueUtil.ensureKeyValue(c));
{code}
into
{code}
kvs.add(c);
{code}
Reason:
KeyValueUtil.ensureKeyValue() is deprecated.
See
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/KeyValueUtil.html
and https://issues.apache.org/jira/browse/HBASE-12079
was:
1. In Section 89.3.3
change
{code}
String path = "hdfs://:/user//coprocessor.jar";
{code}
into
{code}
Path path = new
Path("hdfs://bdavm1506.svl.ibm.com:8020/user/hbase/coprocessor.jar");
{code}
reason
The second parameter of HTableDescriptor.addCoprocessor() is
org.apache.hadoop.fs.Path, not String.
See
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/HTableDescriptor.html
2. In Section 89.3.3
change
{code}
HBaseAdmin admin = new HBaseAdmin(conf);
{code}
into
{code}
Connection connection = ConnectionFactory.createConnection(conf);
Admin admin = connection.getAdmin();
{code}
reason
HBASE-12083 makes new HBaseAdmin() deprecated and the instance of Admin is
supposed to get from Connection.getAdmin()
Also see
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/client/HBaseAdmin.html
3. In section 90.1
change
{code}
public void preGetOp(final ObserverContext e, final Get get, final List results)
{code}
into
{code}
public void preGetOp(final ObserverContext e,
final Get get, final List results)
{code}
change
{code}
List kvs = new ArrayList(results.size());
{code}
into
{code}
List kvs = new ArrayList(results.size());
{code}
change
{code}
public RegionScanner preScannerOpen(final ObserverContext e, final Scan scan,
{code}
into
{code}
preScannerOpen(final ObserverContext e, final
Scan scan，
{code}
change
{code}
public boolean postScannerNext(final ObserverContext e, final InternalScanner
s, final List results, final int limit, final boolean hasMore) throws
IOException {
{code}
into
{code}
public boolean postScannerNext(final
ObserverContext e, final InternalScanner s, final
List results, final int limit, final boolean hasMore) throws
IOException {
{code}
change
{code}
Iterator iterator = results.iterator();
{code}
into
{code}
Iterator iterator = results.iterator();
{code}
reason
Generic
4. In section 90.1
change
{code}
preGet(e, get, kvs);
{code}
into
{code}
super.preGetOp(e, get, kvs);
{code}
reason
There is not a function called preGet() provided by BaseRegionObserver or its
super class/interface. I believe we need to call preGetOp() of the super class
of RegionObserverExample here.
5. In section 90.1
change
{code}
kvs.add(KeyValueUtil.ensureKeyValue(c));
{code}
into
{code}
kvs.add(c);
{code}
reason
KeyValueUtil.ensureKeyValue(
[jira] [Updated] (HBASE-16183) Correct errors in example program of coprocessor in Ref Guide
[
https://issues.apache.org/jira/browse/HBASE-16183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
li xiang updated HBASE-16183:
-
Description:
1. In Section 89.3.3
change
{code}
String path = "hdfs://:/user//coprocessor.jar";
{code}
into
{code}
Path path = new
Path("hdfs://bdavm1506.svl.ibm.com:8020/user/hbase/coprocessor.jar");
{code}
reason
The second parameter of HTableDescriptor.addCoprocessor() is
org.apache.hadoop.fs.Path, not String.
See
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/HTableDescriptor.html
2. In Section 89.3.3
change
{code}
HBaseAdmin admin = new HBaseAdmin(conf);
{code}
into
{code}
Connection connection = ConnectionFactory.createConnection(conf);
Admin admin = connection.getAdmin();
{code}
reason
HBASE-12083 makes new HBaseAdmin() deprecated and the instance of Admin is
supposed to get from Connection.getAdmin()
Also see
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/client/HBaseAdmin.html
3. In section 90.1
change
{code}
public void preGetOp(final ObserverContext e, final Get get, final List results)
{code}
into
{code}
public void preGetOp(final ObserverContext e,
final Get get, final List results)
{code}
change
{code}
List kvs = new ArrayList(results.size());
{code}
into
{code}
List kvs = new ArrayList(results.size());
{code}
change
{code}
public RegionScanner preScannerOpen(final ObserverContext e, final Scan scan,
{code}
into
{code}
preScannerOpen(final ObserverContext e, final
Scan scan，
{code}
change
{code}
public boolean postScannerNext(final ObserverContext e, final InternalScanner
s, final List results, final int limit, final boolean hasMore) throws
IOException {
{code}
into
{code}
public boolean postScannerNext(final
ObserverContext e, final InternalScanner s, final
List results, final int limit, final boolean hasMore) throws
IOException {
{code}
change
{code}
Iterator iterator = results.iterator();
{code}
into
{code}
Iterator iterator = results.iterator();
{code}
reason
Generic
4. In section 90.1
change
{code}
preGet(e, get, kvs);
{code}
into
{code}
super.preGetOp(e, get, kvs);
{code}
reason
There is not a function called preGet() provided by BaseRegionObserver or its
super class/interface. I believe we need to call preGetOp() of the super class
of RegionObserverExample here.
5. In section 90.1
change
{code}
kvs.add(KeyValueUtil.ensureKeyValue(c));
{code}
into
{code}
kvs.add(c);
{code}
reason
KeyValueUtil.ensureKeyValue() is deprecated.
See
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/KeyValueUtil.html
and https://issues.apache.org/jira/browse/HBASE-12079
was:
1. In Section 89.3.3
change
{code}
String path = "hdfs://:/user//coprocessor.jar";
{code}
into
{code}
Path path = new
Path("hdfs://bdavm1506.svl.ibm.com:8020/user/hbase/coprocessor.jar");
{code}
reason
The second parameter of HTableDescriptor.addCoprocessor() is
org.apache.hadoop.fs.Path, not String.
See
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/HTableDescriptor.html
2. In Section 89.3.3
change
{code}
HBaseAdmin admin = new HBaseAdmin(conf);
{code}
into
{code}
Connection connection = ConnectionFactory.createConnection(conf);
Admin admin = connection.getAdmin();
{code}
reason
HBASE-12083 makes new HBaseAdmin() deprecated and the instance of Admin is
supposed to get from Connection.getAdmin()
Also see
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/client/HBaseAdmin.html
3. In section 90.1
change
{code}
public void preGetOp(final ObserverContext e, final Get get, final List results)
{code}
into
{code}
public void preGetOp(final ObserverContext e,
final Get get, final List results)
{code}
change
{code}
List kvs = new ArrayList(results.size());
{code}
into
{code}
List kvs = new ArrayList(results.size());
{code}
change
{code}
public RegionScanner preScannerOpen(final ObserverContext e, final Scan scan,
{code}
into
{code}
preScannerOpen(final ObserverContext e, final
Scan scan，
{code}
change
{code}
public boolean postScannerNext(final ObserverContext e, final InternalScanner s,
final List results, final int limit, final boolean hasMore) throws IOException {
{code}
into
{code}
public boolean postScannerNext(final
ObserverContext e, final InternalScanner s,
final List results, final int limit, final boolean hasMore) throws
IOException {
{code}
change
{code}
Iterator iterator = results.iterator();
{code}
into
{code}
Iterator iterator = results.iterator();
{code}
reason
Generic
4. In section 90.1
change
{code}
preGet(e, get, kvs);
{code}
into
{code}
super.preGetOp(e, get, kvs);
{code}
reason
There is not a function called preGet() provided by BaseRegionObserver or its
super class/interface. I believe we need to call preGetOp() of the super class
of RegionObserverExample here.
5. In section 90.1
change
{code}
kvs.add(KeyValueUtil.ensureKeyValue(c));
{code}
into
{code}
kvs.add(c);
{code}
reason
KeyValueUtil.ensureKeyValue() is d
[jira] [Updated] (HBASE-16183) Correct errors in example program of coprocessor in Ref Guide
[
https://issues.apache.org/jira/browse/HBASE-16183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
li xiang updated HBASE-16183:
-
Description:
1. In Section 89.3.3
change
{code}
String path = "hdfs://:/user//coprocessor.jar";
{code}
into
{code}
Path path = new
Path("hdfs://bdavm1506.svl.ibm.com:8020/user/hbase/coprocessor.jar");
{code}
reason
The second parameter of HTableDescriptor.addCoprocessor() is
org.apache.hadoop.fs.Path, not String.
See
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/HTableDescriptor.html
2. In Section 89.3.3
change
{code}
HBaseAdmin admin = new HBaseAdmin(conf);
{code}
into
{code}
Connection connection = ConnectionFactory.createConnection(conf);
Admin admin = connection.getAdmin();
{code}
reason
HBASE-12083 makes new HBaseAdmin() deprecated and the instance of Admin is
supposed to get from Connection.getAdmin()
Also see
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/client/HBaseAdmin.html
3. In section 90.1
change
{code}
public void preGetOp(final ObserverContext e, final Get get, final List results)
{code}
into
{code}
public void preGetOp(final ObserverContext e,
final Get get, final List results)
{code}
change
{code}
List kvs = new ArrayList(results.size());
{code}
into
{code}
List kvs = new ArrayList(results.size());
{code}
change
{code}
public RegionScanner preScannerOpen(final ObserverContext e, final Scan scan,
{code}
into
{code}
preScannerOpen(final ObserverContext e, final
Scan scan，
{code}
change
{code}
public boolean postScannerNext(final ObserverContext e, final InternalScanner s,
final List results, final int limit, final boolean hasMore) throws IOException {
{code}
into
{code}
public boolean postScannerNext(final
ObserverContext e, final InternalScanner s,
final List results, final int limit, final boolean hasMore) throws
IOException {
{code}
change
{code}
Iterator iterator = results.iterator();
{code}
into
{code}
Iterator iterator = results.iterator();
{code}
reason
Generic
4. In section 90.1
change
{code}
preGet(e, get, kvs);
{code}
into
{code}
super.preGetOp(e, get, kvs);
{code}
reason
There is not a function called preGet() provided by BaseRegionObserver or its
super class/interface. I believe we need to call preGetOp() of the super class
of RegionObserverExample here.
5. In section 90.1
change
{code}
kvs.add(KeyValueUtil.ensureKeyValue(c));
{code}
into
{code}
kvs.add(c);
{code}
reason
KeyValueUtil.ensureKeyValue() is deprecated.
See
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/KeyValueUtil.html
and https://issues.apache.org/jira/browse/HBASE-12079
was:
1. In Section 89.3.3
change
{code}
String path = "hdfs://:/user//coprocessor.jar";
{code}
into
Path path = new
Path("hdfs://bdavm1506.svl.ibm.com:8020/user/hbase/coprocessor.jar");
reason
The second parameter of HTableDescriptor.addCoprocessor() is
org.apache.hadoop.fs.Path, not String.
See
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/HTableDescriptor.html
2. In Section 89.3.3
change
HBaseAdmin admin = new HBaseAdmin(conf);
into
Connection connection = ConnectionFactory.createConnection(conf);
Admin admin = connection.getAdmin();
reason
HBASE-12083 makes new HBaseAdmin() deprecated and the instance of Admin is
supposed to get from Connection.getAdmin()
Also see
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/client/HBaseAdmin.html
3. In section 90.1
change
public void preGetOp(final ObserverContext e, final Get get, final List
results)
into
public void preGetOp(final ObserverContext e,
final Get get, final List results)
change
List kvs = new ArrayList(results.size());
into
List kvs = new ArrayList(results.size());
change
public RegionScanner preScannerOpen(final ObserverContext e, final Scan scan,
into
preScannerOpen(final ObserverContext e, final
Scan scan，
change
public boolean postScannerNext(final ObserverContext e, final InternalScanner
s,
final List results, final int limit, final boolean hasMore) throws
IOException {
into
public boolean postScannerNext(final
ObserverContext e, final InternalScanner s,
inal List results, final int limit, final boolean hasMore) throws
IOException {
change
Iterator iterator = results.iterator();
into
Iterator iterator = results.iterator();
reason
Generic
4. In section 90.1
change
preGet(e, get, kvs);
into
super.preGetOp(e, get, kvs);
reason
There is not a function called preGet() provided by BaseRegionObserver or its
super class/interface. I believe we need to call preGetOp() of the super class
of RegionObserverExample here.
5. In section 90.1
change
kvs.add(KeyValueUtil.ensureKeyValue(c));
into
kvs.add(c);
reason
KeyValueUtil.ensureKeyValue() is deprecated.
See
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/KeyValueUtil.html
and https://issues.apache.org/jira/browse/HBASE-12079
> Correct errors in example program of
[jira] [Updated] (HBASE-16183) Correct errors in example program of coprocessor in Ref Guide
[
https://issues.apache.org/jira/browse/HBASE-16183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
li xiang updated HBASE-16183:
-
Description:
1. In Section 89.3.3
change
{code}
String path = "hdfs://:/user//coprocessor.jar";
{code}
into
Path path = new
Path("hdfs://bdavm1506.svl.ibm.com:8020/user/hbase/coprocessor.jar");
reason
The second parameter of HTableDescriptor.addCoprocessor() is
org.apache.hadoop.fs.Path, not String.
See
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/HTableDescriptor.html
2. In Section 89.3.3
change
HBaseAdmin admin = new HBaseAdmin(conf);
into
Connection connection = ConnectionFactory.createConnection(conf);
Admin admin = connection.getAdmin();
reason
HBASE-12083 makes new HBaseAdmin() deprecated and the instance of Admin is
supposed to get from Connection.getAdmin()
Also see
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/client/HBaseAdmin.html
3. In section 90.1
change
public void preGetOp(final ObserverContext e, final Get get, final List
results)
into
public void preGetOp(final ObserverContext e,
final Get get, final List results)
change
List kvs = new ArrayList(results.size());
into
List kvs = new ArrayList(results.size());
change
public RegionScanner preScannerOpen(final ObserverContext e, final Scan scan,
into
preScannerOpen(final ObserverContext e, final
Scan scan，
change
public boolean postScannerNext(final ObserverContext e, final InternalScanner
s,
final List results, final int limit, final boolean hasMore) throws
IOException {
into
public boolean postScannerNext(final
ObserverContext e, final InternalScanner s,
inal List results, final int limit, final boolean hasMore) throws
IOException {
change
Iterator iterator = results.iterator();
into
Iterator iterator = results.iterator();
reason
Generic
4. In section 90.1
change
preGet(e, get, kvs);
into
super.preGetOp(e, get, kvs);
reason
There is not a function called preGet() provided by BaseRegionObserver or its
super class/interface. I believe we need to call preGetOp() of the super class
of RegionObserverExample here.
5. In section 90.1
change
kvs.add(KeyValueUtil.ensureKeyValue(c));
into
kvs.add(c);
reason
KeyValueUtil.ensureKeyValue() is deprecated.
See
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/KeyValueUtil.html
and https://issues.apache.org/jira/browse/HBASE-12079
was:
1. In Section 89.3.3
change
String path = "hdfs://:/user//coprocessor.jar";
into
Path path = new
Path("hdfs://bdavm1506.svl.ibm.com:8020/user/hbase/coprocessor.jar");
reason
The second parameter of HTableDescriptor.addCoprocessor() is
org.apache.hadoop.fs.Path, not String.
See
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/HTableDescriptor.html
2. In Section 89.3.3
change
HBaseAdmin admin = new HBaseAdmin(conf);
into
Connection connection = ConnectionFactory.createConnection(conf);
Admin admin = connection.getAdmin();
reason
HBASE-12083 makes new HBaseAdmin() deprecated and the instance of Admin is
supposed to get from Connection.getAdmin()
Also see
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/client/HBaseAdmin.html
3. In section 90.1
change
public void preGetOp(final ObserverContext e, final Get get, final List
results)
into
public void preGetOp(final ObserverContext e,
final Get get, final List results)
change
List kvs = new ArrayList(results.size());
into
List kvs = new ArrayList(results.size());
change
public RegionScanner preScannerOpen(final ObserverContext e, final Scan scan,
into
preScannerOpen(final ObserverContext e, final
Scan scan，
change
public boolean postScannerNext(final ObserverContext e, final InternalScanner
s,
final List results, final int limit, final boolean hasMore) throws
IOException {
into
public boolean postScannerNext(final
ObserverContext e, final InternalScanner s,
inal List results, final int limit, final boolean hasMore) throws
IOException {
change
Iterator iterator = results.iterator();
into
Iterator iterator = results.iterator();
reason
Generic
4. In section 90.1
change
preGet(e, get, kvs);
into
super.preGetOp(e, get, kvs);
reason
There is not a function called preGet() provided by BaseRegionObserver or its
super class/interface. I believe we need to call preGetOp() of the super class
of RegionObserverExample here.
5. In section 90.1
change
kvs.add(KeyValueUtil.ensureKeyValue(c));
into
kvs.add(c);
reason
KeyValueUtil.ensureKeyValue() is deprecated.
See
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/KeyValueUtil.html
and https://issues.apache.org/jira/browse/HBASE-12079
> Correct errors in example program of coprocessor in Ref Guide
> -
>
> Key: HBASE-16183
> URL: https://issues.apache.org/jira/browse/HBASE-16183
[jira] [Updated] (HBASE-16183) Correct errors in example program of coprocessor in Ref Guide
[
https://issues.apache.org/jira/browse/HBASE-16183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
li xiang updated HBASE-16183:
-
Description:
1. In Section 89.3.3
change
String path = "hdfs://:/user//coprocessor.jar";
into
Path path = new
Path("hdfs://bdavm1506.svl.ibm.com:8020/user/hbase/coprocessor.jar");
reason
The second parameter of HTableDescriptor.addCoprocessor() is
org.apache.hadoop.fs.Path, not String.
See
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/HTableDescriptor.html
2. In Section 89.3.3
change
HBaseAdmin admin = new HBaseAdmin(conf);
into
Connection connection = ConnectionFactory.createConnection(conf);
Admin admin = connection.getAdmin();
reason
HBASE-12083 makes new HBaseAdmin() deprecated and the instance of Admin is
supposed to get from Connection.getAdmin()
Also see
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/client/HBaseAdmin.html
3. In section 90.1
change
public void preGetOp(final ObserverContext e, final Get get, final List
results)
into
public void preGetOp(final ObserverContext e,
final Get get, final List results)
change
List kvs = new ArrayList(results.size());
into
List kvs = new ArrayList(results.size());
change
public RegionScanner preScannerOpen(final ObserverContext e, final Scan scan,
into
preScannerOpen(final ObserverContext e, final
Scan scan，
change
public boolean postScannerNext(final ObserverContext e, final InternalScanner
s,
final List results, final int limit, final boolean hasMore) throws
IOException {
into
public boolean postScannerNext(final
ObserverContext e, final InternalScanner s,
inal List results, final int limit, final boolean hasMore) throws
IOException {
change
Iterator iterator = results.iterator();
into
Iterator iterator = results.iterator();
reason
Generic
4. In section 90.1
change
preGet(e, get, kvs);
into
super.preGetOp(e, get, kvs);
reason
There is not a function called preGet() provided by BaseRegionObserver or its
super class/interface. I believe we need to call preGetOp() of the super class
of RegionObserverExample here.
5. In section 90.1
change
kvs.add(KeyValueUtil.ensureKeyValue(c));
into
kvs.add(c);
reason
KeyValueUtil.ensureKeyValue() is deprecated.
See
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/KeyValueUtil.html
and https://issues.apache.org/jira/browse/HBASE-12079
> Correct errors in example program of coprocessor in Ref Guide
> -
>
> Key: HBASE-16183
> URL: https://issues.apache.org/jira/browse/HBASE-16183
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: li xiang
>Assignee: li xiang
>Priority: Minor
>
> 1. In Section 89.3.3
> change
> String path = "hdfs://:/user//coprocessor.jar";
> into
> Path path = new
> Path("hdfs://bdavm1506.svl.ibm.com:8020/user/hbase/coprocessor.jar");
> reason
> The second parameter of HTableDescriptor.addCoprocessor() is
> org.apache.hadoop.fs.Path, not String.
> See
> http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/HTableDescriptor.html
> 2. In Section 89.3.3
> change
> HBaseAdmin admin = new HBaseAdmin(conf);
> into
> Connection connection = ConnectionFactory.createConnection(conf);
> Admin admin = connection.getAdmin();
> reason
> HBASE-12083 makes new HBaseAdmin() deprecated and the instance of Admin is
> supposed to get from Connection.getAdmin()
> Also see
> http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/client/HBaseAdmin.html
> 3. In section 90.1
> change
> public void preGetOp(final ObserverContext e, final Get get, final List
> results)
> into
> public void preGetOp(final ObserverContext e,
> final Get get, final List results)
> change
> List kvs = new ArrayList(results.size());
> into
> List kvs = new ArrayList(results.size());
> change
> public RegionScanner preScannerOpen(final ObserverContext e, final Scan
> scan,
> into
> preScannerOpen(final ObserverContext e, final
> Scan scan，
> change
> public boolean postScannerNext(final ObserverContext e, final
> InternalScanner s,
> final List results, final int limit, final boolean hasMore) throws
> IOException {
> into
> public boolean postScannerNext(final
> ObserverContext e, final InternalScanner s,
> inal List results, final int limit, final boolean hasMore) throws
> IOException {
> change
> Iterator iterator = results.iterator();
> into
> Iterator iterator = results.iterator();
> reason
> Generic
> 4. In section 90.1
> change
> preGet(e, get, kvs);
> into
> super.preGetOp(e, get, kvs);
> reason
> There is not a function called preGet() provided by BaseRegionObserver or
> its super class/interface. I believe we need to call preGetOp() of the super
> class of RegionObserverExample
