[jira] [Updated] (HBASE-16363) Correct javadoc for qualifier length and value length in Cell interface
[ https://issues.apache.org/jira/browse/HBASE-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiang Li updated HBASE-16363: - Summary: Correct javadoc for qualifier length and value length in Cell interface (was: Length of column qualifier in Cell is a short or int) > Correct javadoc for qualifier length and value length in Cell interface > --- > > Key: HBASE-16363 > URL: https://issues.apache.org/jira/browse/HBASE-16363 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Xiang Li >Assignee: Xiang Li >Priority: Minor > > In Cell interface > (hbase-common/src/main/java/org/apache/hadoop/hbase/Cell.java) > In the comment, we have > {code} > /** > * Contiguous raw bytes that may start at any index in the containing array. > Max length is > * Short.MAX_VALUE which is 32,767 bytes. > * @return The array containing the qualifier bytes. > */ > {code} > The length of the qualifier is a short > But getQualifierLength() returns int > {code} > int getQualifierLength(); > {code} > Which one is correct? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16363) Correct javadoc for qualifier length and value length in Cell interface
[ https://issues.apache.org/jira/browse/HBASE-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiang Li updated HBASE-16363: - Description: In Cell interface (hbase-common/src/main/java/org/apache/hadoop/hbase/Cell.java) (1) We have the following comment for "qualifier" {code} /** * Contiguous raw bytes that may start at any index in the containing array. Max length is * Short.MAX_VALUE which is 32,767 bytes. * @return The array containing the qualifier bytes. */ {code} But getQualifierLength() returns int {code} int getQualifierLength(); {code} (2) We have the following comment for "value" {code} /** * Contiguous raw bytes that may start at any index in the containing array. Max length is * Integer.MAX_VALUE which is 2,147,483,648 bytes. * @return The array containing the value bytes. */ {code} Integer.MAX_VALUE is not 2,147,483,648 (2^31), but 2,147,483,647 (2^31-1) was: In Cell interface (hbase-common/src/main/java/org/apache/hadoop/hbase/Cell.java) (1) we have the following comment for "qualifier" {code} /** * Contiguous raw bytes that may start at any index in the containing array. Max length is * Short.MAX_VALUE which is 32,767 bytes. * @return The array containing the qualifier bytes. */ {code} But getQualifierLength() returns int {code} int getQualifierLength(); {code} (2) we have the following comment for "value" {code} /** * Contiguous raw bytes that may start at any index in the containing array. Max length is * Integer.MAX_VALUE which is 2,147,483,648 bytes. * @return The array containing the value bytes. */ {code} Integer.MAX_VALUE is not 2,147,483,648 (2^31), but 2,147,483,647 (2^31-1) > Correct javadoc for qualifier length and value length in Cell interface > --- > > Key: HBASE-16363 > URL: https://issues.apache.org/jira/browse/HBASE-16363 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Xiang Li >Assignee: Xiang Li >Priority: Minor > > In Cell interface > (hbase-common/src/main/java/org/apache/hadoop/hbase/Cell.java) > (1) We have the following comment for "qualifier" > {code} > /** > * Contiguous raw bytes that may start at any index in the containing array. > Max length is > * Short.MAX_VALUE which is 32,767 bytes. > * @return The array containing the qualifier bytes. > */ > {code} > But getQualifierLength() returns int > {code} > int getQualifierLength(); > {code} > (2) We have the following comment for "value" > {code} > /** >* Contiguous raw bytes that may start at any index in the containing > array. Max length is >* Integer.MAX_VALUE which is 2,147,483,648 bytes. >* @return The array containing the value bytes. >*/ > {code} > Integer.MAX_VALUE is not 2,147,483,648 (2^31), but 2,147,483,647 (2^31-1) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16363) Correct javadoc for qualifier length and value length in Cell interface
[ https://issues.apache.org/jira/browse/HBASE-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiang Li updated HBASE-16363: - Description: In Cell interface (hbase-common/src/main/java/org/apache/hadoop/hbase/Cell.java) (1) we have the following comment for "qualifier" {code} /** * Contiguous raw bytes that may start at any index in the containing array. Max length is * Short.MAX_VALUE which is 32,767 bytes. * @return The array containing the qualifier bytes. */ {code} But getQualifierLength() returns int {code} int getQualifierLength(); {code} (2) we have the following comment for "value" {code} /** * Contiguous raw bytes that may start at any index in the containing array. Max length is * Integer.MAX_VALUE which is 2,147,483,648 bytes. * @return The array containing the value bytes. */ {code} Integer.MAX_VALUE is not 2,147,483,648 (2^31), but 2,147,483,647 (2^31-1) was: In Cell interface (hbase-common/src/main/java/org/apache/hadoop/hbase/Cell.java) In the comment, we have {code} /** * Contiguous raw bytes that may start at any index in the containing array. Max length is * Short.MAX_VALUE which is 32,767 bytes. * @return The array containing the qualifier bytes. */ {code} The length of the qualifier is a short But getQualifierLength() returns int {code} int getQualifierLength(); {code} Which one is correct? > Correct javadoc for qualifier length and value length in Cell interface > --- > > Key: HBASE-16363 > URL: https://issues.apache.org/jira/browse/HBASE-16363 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Xiang Li >Assignee: Xiang Li >Priority: Minor > > In Cell interface > (hbase-common/src/main/java/org/apache/hadoop/hbase/Cell.java) > (1) we have the following comment for "qualifier" > {code} > /** > * Contiguous raw bytes that may start at any index in the containing array. > Max length is > * Short.MAX_VALUE which is 32,767 bytes. > * @return The array containing the qualifier bytes. > */ > {code} > But getQualifierLength() returns int > {code} > int getQualifierLength(); > {code} > (2) we have the following comment for "value" > {code} > /** >* Contiguous raw bytes that may start at any index in the containing > array. Max length is >* Integer.MAX_VALUE which is 2,147,483,648 bytes. >* @return The array containing the value bytes. >*/ > {code} > Integer.MAX_VALUE is not 2,147,483,648 (2^31), but 2,147,483,647 (2^31-1) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16363) Correct javadoc for qualifier length and value length in Cell interface
[ https://issues.apache.org/jira/browse/HBASE-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiang Li updated HBASE-16363: - Attachment: HBASE-16383.master.000.patch > Correct javadoc for qualifier length and value length in Cell interface > --- > > Key: HBASE-16363 > URL: https://issues.apache.org/jira/browse/HBASE-16363 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Xiang Li >Assignee: Xiang Li >Priority: Minor > Attachments: HBASE-16383.master.000.patch > > > In Cell interface > (hbase-common/src/main/java/org/apache/hadoop/hbase/Cell.java) > (1) We have the following comment for "qualifier" > {code} > /** > * Contiguous raw bytes that may start at any index in the containing array. > Max length is > * Short.MAX_VALUE which is 32,767 bytes. > * @return The array containing the qualifier bytes. > */ > {code} > But getQualifierLength() returns int > {code} > int getQualifierLength(); > {code} > (2) We have the following comment for "value" > {code} > /** >* Contiguous raw bytes that may start at any index in the containing > array. Max length is >* Integer.MAX_VALUE which is 2,147,483,648 bytes. >* @return The array containing the value bytes. >*/ > {code} > Integer.MAX_VALUE is not 2,147,483,648 (2^31), but 2,147,483,647 (2^31-1) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16363) Correct javadoc for qualifier length and value length in Cell interface
[ https://issues.apache.org/jira/browse/HBASE-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiang Li updated HBASE-16363: - Status: Patch Available (was: Open) > Correct javadoc for qualifier length and value length in Cell interface > --- > > Key: HBASE-16363 > URL: https://issues.apache.org/jira/browse/HBASE-16363 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Xiang Li >Assignee: Xiang Li >Priority: Minor > Attachments: HBASE-16383.master.000.patch > > > In Cell interface > (hbase-common/src/main/java/org/apache/hadoop/hbase/Cell.java) > (1) We have the following comment for "qualifier" > {code} > /** > * Contiguous raw bytes that may start at any index in the containing array. > Max length is > * Short.MAX_VALUE which is 32,767 bytes. > * @return The array containing the qualifier bytes. > */ > {code} > But getQualifierLength() returns int > {code} > int getQualifierLength(); > {code} > (2) We have the following comment for "value" > {code} > /** >* Contiguous raw bytes that may start at any index in the containing > array. Max length is >* Integer.MAX_VALUE which is 2,147,483,648 bytes. >* @return The array containing the value bytes. >*/ > {code} > Integer.MAX_VALUE is not 2,147,483,648 (2^31), but 2,147,483,647 (2^31-1) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16363) Correct javadoc for qualifier length and value length in Cell interface
[ https://issues.apache.org/jira/browse/HBASE-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiang Li updated HBASE-16363: - Attachment: (was: HBASE-16383.master.000.patch) > Correct javadoc for qualifier length and value length in Cell interface > --- > > Key: HBASE-16363 > URL: https://issues.apache.org/jira/browse/HBASE-16363 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Xiang Li >Assignee: Xiang Li >Priority: Minor > > In Cell interface > (hbase-common/src/main/java/org/apache/hadoop/hbase/Cell.java) > (1) We have the following comment for "qualifier" > {code} > /** > * Contiguous raw bytes that may start at any index in the containing array. > Max length is > * Short.MAX_VALUE which is 32,767 bytes. > * @return The array containing the qualifier bytes. > */ > {code} > But getQualifierLength() returns int > {code} > int getQualifierLength(); > {code} > (2) We have the following comment for "value" > {code} > /** >* Contiguous raw bytes that may start at any index in the containing > array. Max length is >* Integer.MAX_VALUE which is 2,147,483,648 bytes. >* @return The array containing the value bytes. >*/ > {code} > Integer.MAX_VALUE is not 2,147,483,648 (2^31), but 2,147,483,647 (2^31-1) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16363) Correct javadoc for qualifier length and value length in Cell interface
[ https://issues.apache.org/jira/browse/HBASE-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiang Li updated HBASE-16363: - Status: Open (was: Patch Available) > Correct javadoc for qualifier length and value length in Cell interface > --- > > Key: HBASE-16363 > URL: https://issues.apache.org/jira/browse/HBASE-16363 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Xiang Li >Assignee: Xiang Li >Priority: Minor > > In Cell interface > (hbase-common/src/main/java/org/apache/hadoop/hbase/Cell.java) > (1) We have the following comment for "qualifier" > {code} > /** > * Contiguous raw bytes that may start at any index in the containing array. > Max length is > * Short.MAX_VALUE which is 32,767 bytes. > * @return The array containing the qualifier bytes. > */ > {code} > But getQualifierLength() returns int > {code} > int getQualifierLength(); > {code} > (2) We have the following comment for "value" > {code} > /** >* Contiguous raw bytes that may start at any index in the containing > array. Max length is >* Integer.MAX_VALUE which is 2,147,483,648 bytes. >* @return The array containing the value bytes. >*/ > {code} > Integer.MAX_VALUE is not 2,147,483,648 (2^31), but 2,147,483,647 (2^31-1) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16363) Correct javadoc for qualifier length and value length in Cell interface
[ https://issues.apache.org/jira/browse/HBASE-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiang Li updated HBASE-16363: - Attachment: HBASE-16363.master.000.patch > Correct javadoc for qualifier length and value length in Cell interface > --- > > Key: HBASE-16363 > URL: https://issues.apache.org/jira/browse/HBASE-16363 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Xiang Li >Assignee: Xiang Li >Priority: Minor > Attachments: HBASE-16363.master.000.patch > > > In Cell interface > (hbase-common/src/main/java/org/apache/hadoop/hbase/Cell.java) > (1) We have the following comment for "qualifier" > {code} > /** > * Contiguous raw bytes that may start at any index in the containing array. > Max length is > * Short.MAX_VALUE which is 32,767 bytes. > * @return The array containing the qualifier bytes. > */ > {code} > But getQualifierLength() returns int > {code} > int getQualifierLength(); > {code} > (2) We have the following comment for "value" > {code} > /** >* Contiguous raw bytes that may start at any index in the containing > array. Max length is >* Integer.MAX_VALUE which is 2,147,483,648 bytes. >* @return The array containing the value bytes. >*/ > {code} > Integer.MAX_VALUE is not 2,147,483,648 (2^31), but 2,147,483,647 (2^31-1) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16363) Correct javadoc for qualifier length and value length in Cell interface
[ https://issues.apache.org/jira/browse/HBASE-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiang Li updated HBASE-16363: - Status: Patch Available (was: Open) To trigger Hadoop QA. The patch is only a javadoc change, no code changed. > Correct javadoc for qualifier length and value length in Cell interface > --- > > Key: HBASE-16363 > URL: https://issues.apache.org/jira/browse/HBASE-16363 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Xiang Li >Assignee: Xiang Li >Priority: Minor > Attachments: HBASE-16363.master.000.patch > > > In Cell interface > (hbase-common/src/main/java/org/apache/hadoop/hbase/Cell.java) > (1) We have the following comment for "qualifier" > {code} > /** > * Contiguous raw bytes that may start at any index in the containing array. > Max length is > * Short.MAX_VALUE which is 32,767 bytes. > * @return The array containing the qualifier bytes. > */ > {code} > But getQualifierLength() returns int > {code} > int getQualifierLength(); > {code} > (2) We have the following comment for "value" > {code} > /** >* Contiguous raw bytes that may start at any index in the containing > array. Max length is >* Integer.MAX_VALUE which is 2,147,483,648 bytes. >* @return The array containing the value bytes. >*/ > {code} > Integer.MAX_VALUE is not 2,147,483,648 (2^31), but 2,147,483,647 (2^31-1) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16363) Correct javadoc for qualifier length and value length in Cell interface
[ https://issues.apache.org/jira/browse/HBASE-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-16363: -- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 1.2.3 1.3.0 2.0.0 Status: Resolved (was: Patch Available) Nice. Thanks [~Octivian] > Correct javadoc for qualifier length and value length in Cell interface > --- > > Key: HBASE-16363 > URL: https://issues.apache.org/jira/browse/HBASE-16363 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Xiang Li >Assignee: Xiang Li >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.2.3 > > Attachments: HBASE-16363.master.000.patch > > > In Cell interface > (hbase-common/src/main/java/org/apache/hadoop/hbase/Cell.java) > (1) We have the following comment for "qualifier" > {code} > /** > * Contiguous raw bytes that may start at any index in the containing array. > Max length is > * Short.MAX_VALUE which is 32,767 bytes. > * @return The array containing the qualifier bytes. > */ > {code} > But getQualifierLength() returns int > {code} > int getQualifierLength(); > {code} > (2) We have the following comment for "value" > {code} > /** >* Contiguous raw bytes that may start at any index in the containing > array. Max length is >* Integer.MAX_VALUE which is 2,147,483,648 bytes. >* @return The array containing the value bytes. >*/ > {code} > Integer.MAX_VALUE is not 2,147,483,648 (2^31), but 2,147,483,647 (2^31-1) -- This message was sent by Atlassian JIRA (v6.3.4#6332)