[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.
[ https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enis Soztutar updated HBASE-17576: -- Attachment: hbase-17576-v13.patch v13 patch with some small fixes. > [C++] Implement request retry mechanism over RPC for Multi calls. > - > > Key: HBASE-17576 > URL: https://issues.apache.org/jira/browse/HBASE-17576 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-17576.HBASE-14850.v10.patch, > HBASE-17576.HBASE-14850.v11.patch, HBASE-17576.HBASE-14850.v12.patch, > HBASE-17576.HBASE-14850.v1.patch, HBASE-17576.HBASE-14850.v2.patch, > HBASE-17576.HBASE-14850.v3.patch, HBASE-17576.HBASE-14850.v4.patch, > HBASE-17576.HBASE-14850.v5.patch, HBASE-17576.HBASE-14850.v6.patch, > HBASE-17576.HBASE-14850.v7.patch, HBASE-17576.HBASE-14850.v8.patch, > HBASE-17576.HBASE-14850.v9.patch, hbase-17576-v13.patch > > > This work is based on top of HBASE-17465. Multi Calls will be based on this. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.
[ https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-17576: -- Attachment: HBASE-17576.HBASE-14850.v12.patch Resubmitting the patch as BUCK was missing for compilation of AsyncBatchRpcRetryingCaller Thanks > [C++] Implement request retry mechanism over RPC for Multi calls. > - > > Key: HBASE-17576 > URL: https://issues.apache.org/jira/browse/HBASE-17576 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-17576.HBASE-14850.v10.patch, > HBASE-17576.HBASE-14850.v11.patch, HBASE-17576.HBASE-14850.v12.patch, > HBASE-17576.HBASE-14850.v1.patch, HBASE-17576.HBASE-14850.v2.patch, > HBASE-17576.HBASE-14850.v3.patch, HBASE-17576.HBASE-14850.v4.patch, > HBASE-17576.HBASE-14850.v5.patch, HBASE-17576.HBASE-14850.v6.patch, > HBASE-17576.HBASE-14850.v7.patch, HBASE-17576.HBASE-14850.v8.patch, > HBASE-17576.HBASE-14850.v9.patch > > > This work is based on top of HBASE-17465. Multi Calls will be based on this. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.
[ https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-17576: -- Attachment: (was: HBASE-17576.HBASE-14850.v12.patch) > [C++] Implement request retry mechanism over RPC for Multi calls. > - > > Key: HBASE-17576 > URL: https://issues.apache.org/jira/browse/HBASE-17576 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-17576.HBASE-14850.v10.patch, > HBASE-17576.HBASE-14850.v11.patch, HBASE-17576.HBASE-14850.v1.patch, > HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch, > HBASE-17576.HBASE-14850.v4.patch, HBASE-17576.HBASE-14850.v5.patch, > HBASE-17576.HBASE-14850.v6.patch, HBASE-17576.HBASE-14850.v7.patch, > HBASE-17576.HBASE-14850.v8.patch, HBASE-17576.HBASE-14850.v9.patch > > > This work is based on top of HBASE-17465. Multi Calls will be based on this. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.
[ https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-17576: -- Attachment: HBASE-17576.HBASE-14850.v12.patch This patch consists of:- # AsyncBatchRpcRetryingCaller/Action classes have been changed to work with Get class @present. # wait()/get() have been removed from AsyncBatchRpcRetryingCaller. table->Get() handles the wait. # Tested Multigets on mini-cluster. # Removed unnecessary logging lines from simple-client. Thanks > [C++] Implement request retry mechanism over RPC for Multi calls. > - > > Key: HBASE-17576 > URL: https://issues.apache.org/jira/browse/HBASE-17576 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-17576.HBASE-14850.v10.patch, > HBASE-17576.HBASE-14850.v11.patch, HBASE-17576.HBASE-14850.v12.patch, > HBASE-17576.HBASE-14850.v1.patch, HBASE-17576.HBASE-14850.v2.patch, > HBASE-17576.HBASE-14850.v3.patch, HBASE-17576.HBASE-14850.v4.patch, > HBASE-17576.HBASE-14850.v5.patch, HBASE-17576.HBASE-14850.v6.patch, > HBASE-17576.HBASE-14850.v7.patch, HBASE-17576.HBASE-14850.v8.patch, > HBASE-17576.HBASE-14850.v9.patch > > > This work is based on top of HBASE-17465. Multi Calls will be based on this. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.
[ https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-17576: -- Attachment: HBASE-17576.HBASE-14850.v11.patch Hi [~enis], Thanks for your feedback. The attached patch consists of the foll changes * As suggested, I removed the get() while getting region location and making an async call as it was not asynchronous. But, on dong this the functions were returning instantly and the lambdas were not satisfied. I suspect, the duration in operation_timeout() in table.cc is not large enough and the call to get() doesn't wait long enough.. To test this, I turned on the glog logging, and due to the time taken for file i/o, the lambdas had some time to execute, but it was still not big enough. So before inserting the lambdas, I'm calling folly::Future::wait() and this ensures that the lambdas are executed. But, I'm still skeptical whether this is the correct thing to do as we are waiting for some 'x' amount of time in ms before the callbacks are executed. Need your further guidance on that part. * RawAsyncTable::Get() for multi requests now returns a Future>>. * action2promises_ in async-batch-rpc-retrying-caller.cc creates promises during construction and when AsyncBatchRpcRetryingCaller::Call() returns, we return those promises as a vector of futures. * There was a regression in last couple of patches where ActionsByServer was changed to std::map from std::unordered_map. Have fixed that as well in this patch. Thanks > [C++] Implement request retry mechanism over RPC for Multi calls. > - > > Key: HBASE-17576 > URL: https://issues.apache.org/jira/browse/HBASE-17576 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-17576.HBASE-14850.v10.patch, > HBASE-17576.HBASE-14850.v11.patch, HBASE-17576.HBASE-14850.v1.patch, > HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch, > HBASE-17576.HBASE-14850.v4.patch, HBASE-17576.HBASE-14850.v5.patch, > HBASE-17576.HBASE-14850.v6.patch, HBASE-17576.HBASE-14850.v7.patch, > HBASE-17576.HBASE-14850.v8.patch, HBASE-17576.HBASE-14850.v9.patch > > > This work is based on top of HBASE-17465. Multi Calls will be based on this. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.
[ https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-17576: -- Attachment: HBASE-17576.HBASE-14850.v10.patch V10 patch for Multi Requests > [C++] Implement request retry mechanism over RPC for Multi calls. > - > > Key: HBASE-17576 > URL: https://issues.apache.org/jira/browse/HBASE-17576 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-17576.HBASE-14850.v10.patch, > HBASE-17576.HBASE-14850.v1.patch, HBASE-17576.HBASE-14850.v2.patch, > HBASE-17576.HBASE-14850.v3.patch, HBASE-17576.HBASE-14850.v4.patch, > HBASE-17576.HBASE-14850.v5.patch, HBASE-17576.HBASE-14850.v6.patch, > HBASE-17576.HBASE-14850.v7.patch, HBASE-17576.HBASE-14850.v8.patch, > HBASE-17576.HBASE-14850.v9.patch > > > This work is based on top of HBASE-17465. Multi Calls will be based on this. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.
[ https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-17576: -- Attachment: HBASE-17576.HBASE-14850.v9.patch V9 patch addresses the below:- # Added statndalone HBase Gets() call to simple-client.cc # Methods for Gets() in raw-async-table.* return a Future # Added Gets() unit-tests for mini-cluster in client-test.cc # Sources hooked in core/BUCK Thanks > [C++] Implement request retry mechanism over RPC for Multi calls. > - > > Key: HBASE-17576 > URL: https://issues.apache.org/jira/browse/HBASE-17576 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-17576.HBASE-14850.v1.patch, > HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch, > HBASE-17576.HBASE-14850.v4.patch, HBASE-17576.HBASE-14850.v5.patch, > HBASE-17576.HBASE-14850.v6.patch, HBASE-17576.HBASE-14850.v7.patch, > HBASE-17576.HBASE-14850.v8.patch, HBASE-17576.HBASE-14850.v9.patch > > > This work is based on top of HBASE-17465. Multi Calls will be based on this. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.
[ https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-17576: -- Attachment: HBASE-17576.HBASE-14850.v8.patch This patch addresses the below points:- 1) Changed ActionsByServer to unirdered_map with hash and equals implementation 2) Changed raw-async-table Batch() call to the way Get() and Put() is being called 3) Added read/write locks Thanks > [C++] Implement request retry mechanism over RPC for Multi calls. > - > > Key: HBASE-17576 > URL: https://issues.apache.org/jira/browse/HBASE-17576 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-17576.HBASE-14850.v1.patch, > HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch, > HBASE-17576.HBASE-14850.v4.patch, HBASE-17576.HBASE-14850.v5.patch, > HBASE-17576.HBASE-14850.v6.patch, HBASE-17576.HBASE-14850.v7.patch, > HBASE-17576.HBASE-14850.v8.patch > > > This work is based on top of HBASE-17465. Multi Calls will be based on this. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.
[ https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-17576: -- Attachment: HBASE-17576.HBASE-14850.v7.patch This patch does the foll:- # Hooks the BatchCaller to RawAsyncTable. # Templatization removed and moved to AsyncConnection # Moved AsyncBatchRpcRetryingCaller src and header # Removed unnecessary looping in Send() method # Added unit-test. which runs on a standalone HBase instance and depends on HBASE-17830 Thanks > [C++] Implement request retry mechanism over RPC for Multi calls. > - > > Key: HBASE-17576 > URL: https://issues.apache.org/jira/browse/HBASE-17576 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-17576.HBASE-14850.v1.patch, > HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch, > HBASE-17576.HBASE-14850.v4.patch, HBASE-17576.HBASE-14850.v5.patch, > HBASE-17576.HBASE-14850.v6.patch, HBASE-17576.HBASE-14850.v7.patch > > > This work is based on top of HBASE-17465. Multi Calls will be based on this. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.
[ https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-17576: -- Attachment: HBASE-17576.HBASE-14850.v6.patch v6 patch consisting of only AsyncBatchRpcRetryingCaller class > [C++] Implement request retry mechanism over RPC for Multi calls. > - > > Key: HBASE-17576 > URL: https://issues.apache.org/jira/browse/HBASE-17576 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-17576.HBASE-14850.v1.patch, > HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch, > HBASE-17576.HBASE-14850.v4.patch, HBASE-17576.HBASE-14850.v5.patch, > HBASE-17576.HBASE-14850.v6.patch > > > This work is based on top of HBASE-17465. Multi Calls will be based on this. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.
[ https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-17576: -- Attachment: (was: HBASE-17576.HBASE-14850.v6.patch) > [C++] Implement request retry mechanism over RPC for Multi calls. > - > > Key: HBASE-17576 > URL: https://issues.apache.org/jira/browse/HBASE-17576 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-17576.HBASE-14850.v1.patch, > HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch, > HBASE-17576.HBASE-14850.v4.patch, HBASE-17576.HBASE-14850.v5.patch > > > This work is based on top of HBASE-17465. Multi Calls will be based on this. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.
[ https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-17576: -- Attachment: HBASE-17576.HBASE-14850.v6.patch This patch consists of classes required for BatchCallerBuilder > [C++] Implement request retry mechanism over RPC for Multi calls. > - > > Key: HBASE-17576 > URL: https://issues.apache.org/jira/browse/HBASE-17576 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-17576.HBASE-14850.v1.patch, > HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch, > HBASE-17576.HBASE-14850.v4.patch, HBASE-17576.HBASE-14850.v5.patch, > HBASE-17576.HBASE-14850.v6.patch > > > This work is based on top of HBASE-17465. Multi Calls will be based on this. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.
[ https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-17576: -- Attachment: HBASE-17576.HBASE-14850.v5.patch # v5 patch. which has callbacks added in GroupAndSend, Send. # Population of Results in vector of Futures. > [C++] Implement request retry mechanism over RPC for Multi calls. > - > > Key: HBASE-17576 > URL: https://issues.apache.org/jira/browse/HBASE-17576 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-17576.HBASE-14850.v1.patch, > HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch, > HBASE-17576.HBASE-14850.v4.patch, HBASE-17576.HBASE-14850.v5.patch > > > This work is based on top of HBASE-17465. Multi Calls will be based on this. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.
[ https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-17576: -- Attachment: HBASE-17576.HBASE-14850.v4.patch This patch consists of the foll changes:- 1) Row interface has a method to return the row; Get class inherits Row 2) HRegionLocation changed to RegionLocation 3) Removed AbstractResponse and moved ResponseType enum to MultiResponse class 4) ActionsByRegion map changed from hash_code(region_name)->Action to region_name->Action 5) GroupAndSend() logic updated > [C++] Implement request retry mechanism over RPC for Multi calls. > - > > Key: HBASE-17576 > URL: https://issues.apache.org/jira/browse/HBASE-17576 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-17576.HBASE-14850.v1.patch, > HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch, > HBASE-17576.HBASE-14850.v4.patch > > > This work is based on top of HBASE-17465. Multi Calls will be based on this. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.
[ https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-17576: -- Attachment: HBASE-17576.HBASE-14850.v3.patch V3 patch which adds more functionality. Subsequent patches will focus more on error handling and getting the response from Future. > [C++] Implement request retry mechanism over RPC for Multi calls. > - > > Key: HBASE-17576 > URL: https://issues.apache.org/jira/browse/HBASE-17576 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-17576.HBASE-14850.v1.patch, > HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch > > > This work is based on top of HBASE-17465. Multi Calls will be based on this. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.
[ https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-17576: -- Attachment: HBASE-17576.HBASE-14850.v2.patch V2 patch, which is taking shape on similar lines as Java API. Please comment if anything looks wrong. Thanks > [C++] Implement request retry mechanism over RPC for Multi calls. > - > > Key: HBASE-17576 > URL: https://issues.apache.org/jira/browse/HBASE-17576 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-17576.HBASE-14850.v1.patch, > HBASE-17576.HBASE-14850.v2.patch > > > This work is based on top of HBASE-17465. Multi Calls will be based on this. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.
[ https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-17576: -- Attachment: HBASE-17576.HBASE-14850.v1.patch V1 patch for Multi Calls. We will be adding retries and error handling in coming patches. > [C++] Implement request retry mechanism over RPC for Multi calls. > - > > Key: HBASE-17576 > URL: https://issues.apache.org/jira/browse/HBASE-17576 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-17576.HBASE-14850.v1.patch > > > This work is based on top of HBASE-17465. Multi Calls will be based on this. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.
[ https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-17576: -- Summary: [C++] Implement request retry mechanism over RPC for Multi calls. (was: Implement request retry mechanism over RPC for Multi calls.) > [C++] Implement request retry mechanism over RPC for Multi calls. > - > > Key: HBASE-17576 > URL: https://issues.apache.org/jira/browse/HBASE-17576 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > > This work is based on top of HBASE-17465. Multi Calls will be based on this. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
