[jira] [Updated] (HBASE-17937) Memstore size becomes negative in case of expensive postPut/Delete Coprocessor call
[ https://issues.apache.org/jira/browse/HBASE-17937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-17937: -- Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to branch-1.1+. Thanks [~abhishek.chouhan] for contributing. And thanks all for reviewing. > Memstore size becomes negative in case of expensive postPut/Delete > Coprocessor call > --- > > Key: HBASE-17937 > URL: https://issues.apache.org/jira/browse/HBASE-17937 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 2.0.0, 1.3.1, 0.98.24 >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0, 1.4.0, 1.2.6, 1.3.2, 1.1.11 > > Attachments: HBASE-17937.branch-1.001.patch, > HBASE-17937.branch-1.002.patch, HBASE-17937.master.001.patch, > HBASE-17937.master.002.patch, HBASE-17937.master.002.patch, > HBASE-17937.master.003.patch, HBASE-17937.master.003.patch > > > We ran into a situation where the memstore size became negative due to > expensive postPut/Delete Coprocessor calls in doMiniBatchMutate. We update > the memstore size in the finally block of doMiniBatchMutate, however a queued > flush can be triggered during the coprocessor calls(if they are taking time > eg. index updates) since we have released the locks and advanced mvcc at this > point. The flush will turn the memstore size negative since the value > subtracted is the actual value flushed from stores. The negative value > impacts the future flushes amongst others that depend on memstore size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17937) Memstore size becomes negative in case of expensive postPut/Delete Coprocessor call
[ https://issues.apache.org/jira/browse/HBASE-17937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-17937: -- Hadoop Flags: Reviewed Fix Version/s: 1.1.11 1.3.2 1.2.6 1.4.0 2.0.0 Component/s: regionserver > Memstore size becomes negative in case of expensive postPut/Delete > Coprocessor call > --- > > Key: HBASE-17937 > URL: https://issues.apache.org/jira/browse/HBASE-17937 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 2.0.0, 1.3.1, 0.98.24 >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0, 1.4.0, 1.2.6, 1.3.2, 1.1.11 > > Attachments: HBASE-17937.branch-1.001.patch, > HBASE-17937.branch-1.002.patch, HBASE-17937.master.001.patch, > HBASE-17937.master.002.patch, HBASE-17937.master.002.patch, > HBASE-17937.master.003.patch, HBASE-17937.master.003.patch > > > We ran into a situation where the memstore size became negative due to > expensive postPut/Delete Coprocessor calls in doMiniBatchMutate. We update > the memstore size in the finally block of doMiniBatchMutate, however a queued > flush can be triggered during the coprocessor calls(if they are taking time > eg. index updates) since we have released the locks and advanced mvcc at this > point. The flush will turn the memstore size negative since the value > subtracted is the actual value flushed from stores. The negative value > impacts the future flushes amongst others that depend on memstore size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17937) Memstore size becomes negative in case of expensive postPut/Delete Coprocessor call
[ https://issues.apache.org/jira/browse/HBASE-17937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Singh Chouhan updated HBASE-17937: --- Attachment: HBASE-17937.master.003.patch > Memstore size becomes negative in case of expensive postPut/Delete > Coprocessor call > --- > > Key: HBASE-17937 > URL: https://issues.apache.org/jira/browse/HBASE-17937 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 1.3.1, 0.98.24 >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Attachments: HBASE-17937.branch-1.001.patch, > HBASE-17937.branch-1.002.patch, HBASE-17937.master.001.patch, > HBASE-17937.master.002.patch, HBASE-17937.master.002.patch, > HBASE-17937.master.003.patch, HBASE-17937.master.003.patch > > > We ran into a situation where the memstore size became negative due to > expensive postPut/Delete Coprocessor calls in doMiniBatchMutate. We update > the memstore size in the finally block of doMiniBatchMutate, however a queued > flush can be triggered during the coprocessor calls(if they are taking time > eg. index updates) since we have released the locks and advanced mvcc at this > point. The flush will turn the memstore size negative since the value > subtracted is the actual value flushed from stores. The negative value > impacts the future flushes amongst others that depend on memstore size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17937) Memstore size becomes negative in case of expensive postPut/Delete Coprocessor call
[ https://issues.apache.org/jira/browse/HBASE-17937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Singh Chouhan updated HBASE-17937: --- Attachment: HBASE-17937.branch-1.002.patch Addressed comments. Added comments to test class. > Memstore size becomes negative in case of expensive postPut/Delete > Coprocessor call > --- > > Key: HBASE-17937 > URL: https://issues.apache.org/jira/browse/HBASE-17937 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 1.3.1, 0.98.24 >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Attachments: HBASE-17937.branch-1.001.patch, > HBASE-17937.branch-1.002.patch, HBASE-17937.master.001.patch, > HBASE-17937.master.002.patch, HBASE-17937.master.002.patch, > HBASE-17937.master.003.patch > > > We ran into a situation where the memstore size became negative due to > expensive postPut/Delete Coprocessor calls in doMiniBatchMutate. We update > the memstore size in the finally block of doMiniBatchMutate, however a queued > flush can be triggered during the coprocessor calls(if they are taking time > eg. index updates) since we have released the locks and advanced mvcc at this > point. The flush will turn the memstore size negative since the value > subtracted is the actual value flushed from stores. The negative value > impacts the future flushes amongst others that depend on memstore size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17937) Memstore size becomes negative in case of expensive postPut/Delete Coprocessor call
[ https://issues.apache.org/jira/browse/HBASE-17937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Singh Chouhan updated HBASE-17937: --- Attachment: HBASE-17937.master.003.patch > Memstore size becomes negative in case of expensive postPut/Delete > Coprocessor call > --- > > Key: HBASE-17937 > URL: https://issues.apache.org/jira/browse/HBASE-17937 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 1.3.1, 0.98.24 >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Attachments: HBASE-17937.branch-1.001.patch, > HBASE-17937.master.001.patch, HBASE-17937.master.002.patch, > HBASE-17937.master.002.patch, HBASE-17937.master.003.patch > > > We ran into a situation where the memstore size became negative due to > expensive postPut/Delete Coprocessor calls in doMiniBatchMutate. We update > the memstore size in the finally block of doMiniBatchMutate, however a queued > flush can be triggered during the coprocessor calls(if they are taking time > eg. index updates) since we have released the locks and advanced mvcc at this > point. The flush will turn the memstore size negative since the value > subtracted is the actual value flushed from stores. The negative value > impacts the future flushes amongst others that depend on memstore size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17937) Memstore size becomes negative in case of expensive postPut/Delete Coprocessor call
[ https://issues.apache.org/jira/browse/HBASE-17937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Singh Chouhan updated HBASE-17937: --- Attachment: HBASE-17937.master.002.patch Added category annotation to the test. > Memstore size becomes negative in case of expensive postPut/Delete > Coprocessor call > --- > > Key: HBASE-17937 > URL: https://issues.apache.org/jira/browse/HBASE-17937 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 1.3.1, 0.98.24 >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Attachments: HBASE-17937.branch-1.001.patch, > HBASE-17937.master.001.patch, HBASE-17937.master.002.patch, > HBASE-17937.master.002.patch > > > We ran into a situation where the memstore size became negative due to > expensive postPut/Delete Coprocessor calls in doMiniBatchMutate. We update > the memstore size in the finally block of doMiniBatchMutate, however a queued > flush can be triggered during the coprocessor calls(if they are taking time > eg. index updates) since we have released the locks and advanced mvcc at this > point. The flush will turn the memstore size negative since the value > subtracted is the actual value flushed from stores. The negative value > impacts the future flushes amongst others that depend on memstore size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17937) Memstore size becomes negative in case of expensive postPut/Delete Coprocessor call
[ https://issues.apache.org/jira/browse/HBASE-17937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Singh Chouhan updated HBASE-17937: --- Attachment: HBASE-17937.branch-1.001.patch > Memstore size becomes negative in case of expensive postPut/Delete > Coprocessor call > --- > > Key: HBASE-17937 > URL: https://issues.apache.org/jira/browse/HBASE-17937 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 1.3.1, 0.98.24 >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Attachments: HBASE-17937.branch-1.001.patch, > HBASE-17937.master.001.patch, HBASE-17937.master.002.patch > > > We ran into a situation where the memstore size became negative due to > expensive postPut/Delete Coprocessor calls in doMiniBatchMutate. We update > the memstore size in the finally block of doMiniBatchMutate, however a queued > flush can be triggered during the coprocessor calls(if they are taking time > eg. index updates) since we have released the locks and advanced mvcc at this > point. The flush will turn the memstore size negative since the value > subtracted is the actual value flushed from stores. The negative value > impacts the future flushes amongst others that depend on memstore size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17937) Memstore size becomes negative in case of expensive postPut/Delete Coprocessor call
[ https://issues.apache.org/jira/browse/HBASE-17937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Singh Chouhan updated HBASE-17937: --- Attachment: HBASE-17937.master.002.patch > Memstore size becomes negative in case of expensive postPut/Delete > Coprocessor call > --- > > Key: HBASE-17937 > URL: https://issues.apache.org/jira/browse/HBASE-17937 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 1.3.1, 0.98.24 >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Attachments: HBASE-17937.master.001.patch, > HBASE-17937.master.002.patch > > > We ran into a situation where the memstore size became negative due to > expensive postPut/Delete Coprocessor calls in doMiniBatchMutate. We update > the memstore size in the finally block of doMiniBatchMutate, however a queued > flush can be triggered during the coprocessor calls(if they are taking time > eg. index updates) since we have released the locks and advanced mvcc at this > point. The flush will turn the memstore size negative since the value > subtracted is the actual value flushed from stores. The negative value > impacts the future flushes amongst others that depend on memstore size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17937) Memstore size becomes negative in case of expensive postPut/Delete Coprocessor call
[ https://issues.apache.org/jira/browse/HBASE-17937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Singh Chouhan updated HBASE-17937: --- Status: Patch Available (was: Open) Getting a QA run > Memstore size becomes negative in case of expensive postPut/Delete > Coprocessor call > --- > > Key: HBASE-17937 > URL: https://issues.apache.org/jira/browse/HBASE-17937 > Project: HBase > Issue Type: Bug >Affects Versions: 0.98.24, 1.3.1, 2.0.0 >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Attachments: HBASE-17937.master.001.patch > > > We ran into a situation where the memstore size became negative due to > expensive postPut/Delete Coprocessor calls in doMiniBatchMutate. We update > the memstore size in the finally block of doMiniBatchMutate, however a queued > flush can be triggered during the coprocessor calls(if they are taking time > eg. index updates) since we have released the locks and advanced mvcc at this > point. The flush will turn the memstore size negative since the value > subtracted is the actual value flushed from stores. The negative value > impacts the future flushes amongst others that depend on memstore size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17937) Memstore size becomes negative in case of expensive postPut/Delete Coprocessor call
[ https://issues.apache.org/jira/browse/HBASE-17937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Singh Chouhan updated HBASE-17937: --- Attachment: HBASE-17937.master.001.patch > Memstore size becomes negative in case of expensive postPut/Delete > Coprocessor call > --- > > Key: HBASE-17937 > URL: https://issues.apache.org/jira/browse/HBASE-17937 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 1.3.1, 0.98.24 >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Attachments: HBASE-17937.master.001.patch > > > We ran into a situation where the memstore size became negative due to > expensive postPut/Delete Coprocessor calls in doMiniBatchMutate. We update > the memstore size in the finally block of doMiniBatchMutate, however a queued > flush can be triggered during the coprocessor calls(if they are taking time > eg. index updates) since we have released the locks and advanced mvcc at this > point. The flush will turn the memstore size negative since the value > subtracted is the actual value flushed from stores. The negative value > impacts the future flushes amongst others that depend on memstore size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
