[jira] [Updated] (HBASE-18407) [C++] make Configuration::Set/GetBool work for both true/false and 1/0

2017-07-21 Thread Enis Soztutar (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Enis Soztutar updated HBASE-18407:
--
   Resolution: Fixed
 Hadoop Flags: Reviewed
Fix Version/s: HBASE-14850
   Status: Resolved  (was: Patch Available)

I've committed this. Thanks [~xiaobingo]. 

> [C++] make Configuration::Set/GetBool work for both true/false and 1/0
> --
>
> Key: HBASE-18407
> URL: https://issues.apache.org/jira/browse/HBASE-18407
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Xiaobing Zhou
>Assignee: Xiaobing Zhou
> Fix For: HBASE-14850
>
> Attachments: HBASE-18407.000.patch, HBASE-18407-HBASE-14850.000.patch
>
>
> Configuration::SetBool internally converts true/false to 1/0 using 
> boost::lexical_cast(value), this results in runtime exception 
> with 'Unexpected value found while conversion to bool.' in 
> Configuration::GetBool since it only recognizes "true" or "false" as string 
> representation of true or false. 1/0 should be considered in the check in 
> GetBool.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18407) [C++] make Configuration::Set/GetBool work for both true/false and 1/0

2017-07-19 Thread Xiaobing Zhou (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiaobing Zhou updated HBASE-18407:
--
Attachment: HBASE-18407-HBASE-14850.000.patch

> [C++] make Configuration::Set/GetBool work for both true/false and 1/0
> --
>
> Key: HBASE-18407
> URL: https://issues.apache.org/jira/browse/HBASE-18407
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Xiaobing Zhou
>Assignee: Xiaobing Zhou
> Attachments: HBASE-18407.000.patch, HBASE-18407-HBASE-14850.000.patch
>
>
> Configuration::SetBool internally converts true/false to 1/0 using 
> boost::lexical_cast(value), this results in runtime exception 
> with 'Unexpected value found while conversion to bool.' in 
> Configuration::GetBool since it only recognizes "true" or "false" as string 
> representation of true or false. 1/0 should be considered in the check in 
> GetBool.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18407) [C++] make Configuration::Set/GetBool work for both true/false and 1/0

2017-07-19 Thread Xiaobing Zhou (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiaobing Zhou updated HBASE-18407:
--
Status: Patch Available  (was: Open)

> [C++] make Configuration::Set/GetBool work for both true/false and 1/0
> --
>
> Key: HBASE-18407
> URL: https://issues.apache.org/jira/browse/HBASE-18407
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Xiaobing Zhou
>Assignee: Xiaobing Zhou
> Attachments: HBASE-18407.000.patch
>
>
> Configuration::SetBool internally converts true/false to 1/0 using 
> boost::lexical_cast(value), this results in runtime exception 
> with 'Unexpected value found while conversion to bool.' in 
> Configuration::GetBool since it only recognizes "true" or "false" as string 
> representation of true or false. 1/0 should be considered in the check in 
> GetBool.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18407) [C++] make Configuration::Set/GetBool work for both true/false and 1/0

2017-07-19 Thread Xiaobing Zhou (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiaobing Zhou updated HBASE-18407:
--
Attachment: HBASE-18407.000.patch

> [C++] make Configuration::Set/GetBool work for both true/false and 1/0
> --
>
> Key: HBASE-18407
> URL: https://issues.apache.org/jira/browse/HBASE-18407
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Xiaobing Zhou
>Assignee: Xiaobing Zhou
> Attachments: HBASE-18407.000.patch
>
>
> Configuration::SetBool internally converts true/false to 1/0 using 
> boost::lexical_cast(value), this results in runtime exception 
> with 'Unexpected value found while conversion to bool.' in 
> Configuration::GetBool since it only recognizes "true" or "false" as string 
> representation of true or false. 1/0 should be considered in the check in 
> GetBool.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18407) [C++] make Configuration::Set/GetBool work for both true/false and 1/0

2017-07-19 Thread Xiaobing Zhou (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiaobing Zhou updated HBASE-18407:
--
Summary: [C++] make Configuration::Set/GetBool work for both true/false and 
1/0  (was: [C++] make Configuration::Set/GetBool work for both true/false and 
1/0 )

> [C++] make Configuration::Set/GetBool work for both true/false and 1/0
> --
>
> Key: HBASE-18407
> URL: https://issues.apache.org/jira/browse/HBASE-18407
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Xiaobing Zhou
>Assignee: Xiaobing Zhou
> Attachments: HBASE-18407.000.patch
>
>
> Configuration::SetBool internally converts true/false to 1/0 using 
> boost::lexical_cast(value), this results in runtime exception 
> with 'Unexpected value found while conversion to bool.' in 
> Configuration::GetBool since it only recognizes "true" or "false" as string 
> representation of true or false. 1/0 should be considered in the check in 
> GetBool.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18407) [C++] make Configuration::Set/GetBool work for both true/false and 1/0

2017-07-19 Thread Xiaobing Zhou (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiaobing Zhou updated HBASE-18407:
--
Description: Configuration::SetBool internally converts true/false to 1/0 
using boost::lexical_cast(value), this results in runtime 
exception with 'Unexpected value found while conversion to bool.' in 
Configuration::GetBool since it only recognizes "true" or "false" as string 
representation of true or false. 1/0 should be considered in the check in 
GetBool.  (was: Configuration::SetBool internally converts true/false to 1/0 
using boost::lexical_cast(value), this results in runtime 
exception with 'Unexpected value found while conversion to bool.' in 
Configuration::GetBool since it only recognizes "true" or "false" as string 
representation of true or false.)

> [C++] make Configuration::Set/GetBool work for both true/false and 1/0 
> ---
>
> Key: HBASE-18407
> URL: https://issues.apache.org/jira/browse/HBASE-18407
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Xiaobing Zhou
>Assignee: Xiaobing Zhou
>
> Configuration::SetBool internally converts true/false to 1/0 using 
> boost::lexical_cast(value), this results in runtime exception 
> with 'Unexpected value found while conversion to bool.' in 
> Configuration::GetBool since it only recognizes "true" or "false" as string 
> representation of true or false. 1/0 should be considered in the check in 
> GetBool.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18407) [C++] make Configuration::Set/GetBool work for both true/false and 1/0

2017-07-19 Thread Xiaobing Zhou (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiaobing Zhou updated HBASE-18407:
--
Summary: [C++] make Configuration::Set/GetBool work for both true/false and 
1/0   (was: [C++] Configuration::SetBool should convert bool value to "true" or 
"false")

> [C++] make Configuration::Set/GetBool work for both true/false and 1/0 
> ---
>
> Key: HBASE-18407
> URL: https://issues.apache.org/jira/browse/HBASE-18407
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Xiaobing Zhou
>Assignee: Xiaobing Zhou
>
> Configuration::SetBool internally converts true/false to 1/0 using 
> boost::lexical_cast(value), this results in runtime exception 
> with 'Unexpected value found while conversion to bool.' in 
> Configuration::GetBool since it only recognizes "true" or "false" as string 
> representation of true or false.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)