[jira] [Updated] (HBASE-18842) The hbase shell clone_snaphost command returns bad error message
[ https://issues.apache.org/jira/browse/HBASE-18842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-18842: --- Fix Version/s: (was: 1.5.0) > The hbase shell clone_snaphost command returns bad error message > > > Key: HBASE-18842 > URL: https://issues.apache.org/jira/browse/HBASE-18842 > Project: HBase > Issue Type: Bug > Components: shell >Reporter: Thoralf Gutierrez >Assignee: Thoralf Gutierrez >Priority: Minor > Fix For: 3.0.0, 2.1.0, 1.3.3, 2.0.1, 1.4.5, 1.2.7 > > Attachments: > 0001-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0002-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0003-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0004-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0005-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch > > > When you call the hbase shell clone_snapshot command with a target namespace > that doesn't exist, you get an error message, but the variable used to > identify the inexistent namespace is wrong: > {noformat} > hbase(main):001:0> clone_snapshot 'someSnapshotName', > 'someNamespaceName:someTableName' > ERROR: Unknown namespace someSnapshotName! > Create a new table by cloning the snapshot content. > There're no copies of data involved. > And writing on the newly created table will not influence the snapshot data. > Examples: > hbase> clone_snapshot 'snapshotName', 'tableName' > hbase> clone_snapshot 'snapshotName', 'namespace:tableName' > {noformat} > It should rather say: > {noformat} > ERROR: Unknown namespace someNamespaceName! > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-18842) The hbase shell clone_snaphost command returns bad error message
[ https://issues.apache.org/jira/browse/HBASE-18842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-18842: Component/s: shell > The hbase shell clone_snaphost command returns bad error message > > > Key: HBASE-18842 > URL: https://issues.apache.org/jira/browse/HBASE-18842 > Project: HBase > Issue Type: Bug > Components: shell >Reporter: Thoralf Gutierrez >Assignee: Thoralf Gutierrez >Priority: Minor > Fix For: 3.0.0 > > Attachments: > 0001-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0002-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0003-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0004-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0005-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch > > > When you call the hbase shell clone_snapshot command with a target namespace > that doesn't exist, you get an error message, but the variable used to > identify the inexistent namespace is wrong: > {noformat} > hbase(main):001:0> clone_snapshot 'someSnapshotName', > 'someNamespaceName:someTableName' > ERROR: Unknown namespace someSnapshotName! > Create a new table by cloning the snapshot content. > There're no copies of data involved. > And writing on the newly created table will not influence the snapshot data. > Examples: > hbase> clone_snapshot 'snapshotName', 'tableName' > hbase> clone_snapshot 'snapshotName', 'namespace:tableName' > {noformat} > It should rather say: > {noformat} > ERROR: Unknown namespace someNamespaceName! > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-18842) The hbase shell clone_snaphost command returns bad error message
[ https://issues.apache.org/jira/browse/HBASE-18842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18842: -- Fix Version/s: (was: 2.0.0) 3.0.0 > The hbase shell clone_snaphost command returns bad error message > > > Key: HBASE-18842 > URL: https://issues.apache.org/jira/browse/HBASE-18842 > Project: HBase > Issue Type: Bug >Reporter: Thoralf Gutierrez >Assignee: Jesse Yates >Priority: Minor > Fix For: 3.0.0 > > Attachments: > 0001-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0002-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0003-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0004-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0005-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch > > > When you call the hbase shell clone_snapshot command with a target namespace > that doesn't exist, you get an error message, but the variable used to > identify the inexistent namespace is wrong: > {noformat} > hbase(main):001:0> clone_snapshot 'someSnapshotName', > 'someNamespaceName:someTableName' > ERROR: Unknown namespace someSnapshotName! > Create a new table by cloning the snapshot content. > There're no copies of data involved. > And writing on the newly created table will not influence the snapshot data. > Examples: > hbase> clone_snapshot 'snapshotName', 'tableName' > hbase> clone_snapshot 'snapshotName', 'namespace:tableName' > {noformat} > It should rather say: > {noformat} > ERROR: Unknown namespace someNamespaceName! > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-18842) The hbase shell clone_snaphost command returns bad error message
[ https://issues.apache.org/jira/browse/HBASE-18842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18842: -- Fix Version/s: (was: 3.0.0) > The hbase shell clone_snaphost command returns bad error message > > > Key: HBASE-18842 > URL: https://issues.apache.org/jira/browse/HBASE-18842 > Project: HBase > Issue Type: Bug >Reporter: Thoralf Gutierrez >Assignee: Jesse Yates >Priority: Minor > Fix For: 2.0.0 > > Attachments: > 0001-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0002-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0003-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0004-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0005-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch > > > When you call the hbase shell clone_snapshot command with a target namespace > that doesn't exist, you get an error message, but the variable used to > identify the inexistent namespace is wrong: > {noformat} > hbase(main):001:0> clone_snapshot 'someSnapshotName', > 'someNamespaceName:someTableName' > ERROR: Unknown namespace someSnapshotName! > Create a new table by cloning the snapshot content. > There're no copies of data involved. > And writing on the newly created table will not influence the snapshot data. > Examples: > hbase> clone_snapshot 'snapshotName', 'tableName' > hbase> clone_snapshot 'snapshotName', 'namespace:tableName' > {noformat} > It should rather say: > {noformat} > ERROR: Unknown namespace someNamespaceName! > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-18842) The hbase shell clone_snaphost command returns bad error message
[ https://issues.apache.org/jira/browse/HBASE-18842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jesse Yates updated HBASE-18842: Fix Version/s: 2.0.0 > The hbase shell clone_snaphost command returns bad error message > > > Key: HBASE-18842 > URL: https://issues.apache.org/jira/browse/HBASE-18842 > Project: HBase > Issue Type: Bug >Reporter: Thoralf Gutierrez >Assignee: Jesse Yates >Priority: Minor > Fix For: 2.0.0, 3.0.0 > > Attachments: > 0001-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0002-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0003-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0004-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0005-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch > > > When you call the hbase shell clone_snapshot command with a target namespace > that doesn't exist, you get an error message, but the variable used to > identify the inexistent namespace is wrong: > {noformat} > hbase(main):001:0> clone_snapshot 'someSnapshotName', > 'someNamespaceName:someTableName' > ERROR: Unknown namespace someSnapshotName! > Create a new table by cloning the snapshot content. > There're no copies of data involved. > And writing on the newly created table will not influence the snapshot data. > Examples: > hbase> clone_snapshot 'snapshotName', 'tableName' > hbase> clone_snapshot 'snapshotName', 'namespace:tableName' > {noformat} > It should rather say: > {noformat} > ERROR: Unknown namespace someNamespaceName! > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18842) The hbase shell clone_snaphost command returns bad error message
[ https://issues.apache.org/jira/browse/HBASE-18842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jesse Yates updated HBASE-18842: Resolution: Fixed Fix Version/s: 3.0.0 Status: Resolved (was: Patch Available) > The hbase shell clone_snaphost command returns bad error message > > > Key: HBASE-18842 > URL: https://issues.apache.org/jira/browse/HBASE-18842 > Project: HBase > Issue Type: Bug >Reporter: Thoralf Gutierrez >Assignee: Jesse Yates >Priority: Minor > Fix For: 3.0.0 > > Attachments: > 0001-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0002-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0003-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0004-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0005-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch > > > When you call the hbase shell clone_snapshot command with a target namespace > that doesn't exist, you get an error message, but the variable used to > identify the inexistent namespace is wrong: > {noformat} > hbase(main):001:0> clone_snapshot 'someSnapshotName', > 'someNamespaceName:someTableName' > ERROR: Unknown namespace someSnapshotName! > Create a new table by cloning the snapshot content. > There're no copies of data involved. > And writing on the newly created table will not influence the snapshot data. > Examples: > hbase> clone_snapshot 'snapshotName', 'tableName' > hbase> clone_snapshot 'snapshotName', 'namespace:tableName' > {noformat} > It should rather say: > {noformat} > ERROR: Unknown namespace someNamespaceName! > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18842) The hbase shell clone_snaphost command returns bad error message
[ https://issues.apache.org/jira/browse/HBASE-18842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thoralf Gutierrez updated HBASE-18842: -- Attachment: 0005-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch Added more documentation for the other class that was already in the file. > The hbase shell clone_snaphost command returns bad error message > > > Key: HBASE-18842 > URL: https://issues.apache.org/jira/browse/HBASE-18842 > Project: HBase > Issue Type: Bug >Reporter: Thoralf Gutierrez >Assignee: Jesse Yates >Priority: Minor > Attachments: > 0001-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0002-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0003-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0004-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0005-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch > > > When you call the hbase shell clone_snapshot command with a target namespace > that doesn't exist, you get an error message, but the variable used to > identify the inexistent namespace is wrong: > {noformat} > hbase(main):001:0> clone_snapshot 'someSnapshotName', > 'someNamespaceName:someTableName' > ERROR: Unknown namespace someSnapshotName! > Create a new table by cloning the snapshot content. > There're no copies of data involved. > And writing on the newly created table will not influence the snapshot data. > Examples: > hbase> clone_snapshot 'snapshotName', 'tableName' > hbase> clone_snapshot 'snapshotName', 'namespace:tableName' > {noformat} > It should rather say: > {noformat} > ERROR: Unknown namespace someNamespaceName! > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18842) The hbase shell clone_snaphost command returns bad error message
[ https://issues.apache.org/jira/browse/HBASE-18842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thoralf Gutierrez updated HBASE-18842: -- Attachment: 0004-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch I've fixed the trivial class documentation but can't seem to understand what is going on with ruby-lint not being able to find definitions from the included `Hbase::TestHelpers`, though the tests run fine. I have looked into [configuring ruby-lint](https://github.com/YorickPeterse/ruby-lint/blob/master/doc/configuration.md) locally with no luck. I would love some guidance if someone is a bit more knowledgeable on the shell project structure. > The hbase shell clone_snaphost command returns bad error message > > > Key: HBASE-18842 > URL: https://issues.apache.org/jira/browse/HBASE-18842 > Project: HBase > Issue Type: Bug >Reporter: Thoralf Gutierrez >Assignee: Jesse Yates >Priority: Minor > Attachments: > 0001-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0002-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0003-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0004-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch > > > When you call the hbase shell clone_snapshot command with a target namespace > that doesn't exist, you get an error message, but the variable used to > identify the inexistent namespace is wrong: > {noformat} > hbase(main):001:0> clone_snapshot 'someSnapshotName', > 'someNamespaceName:someTableName' > ERROR: Unknown namespace someSnapshotName! > Create a new table by cloning the snapshot content. > There're no copies of data involved. > And writing on the newly created table will not influence the snapshot data. > Examples: > hbase> clone_snapshot 'snapshotName', 'tableName' > hbase> clone_snapshot 'snapshotName', 'namespace:tableName' > {noformat} > It should rather say: > {noformat} > ERROR: Unknown namespace someNamespaceName! > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18842) The hbase shell clone_snaphost command returns bad error message
[ https://issues.apache.org/jira/browse/HBASE-18842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thoralf Gutierrez updated HBASE-18842: -- Attachment: 0003-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch Yes. Here is a patch with the added test (and a bonus test for the other handled exception of clone_snapshot). I tried to find the best place to put it as there doesn't seem to be other tests of the kind, i.e. tests that test the commands from the point of view of the shell. (We have to take that point of view if we want to catch the error that would be returned to the user and not the error returned by the Java exception). You will notice that the tests clean up after themselves but before as well. This is a bit annoying but the only way I could get my tests to work without going to fix all of the other tests that already exist by making sure they clean up after themselves too. I started doing that but the commit was becoming ugly and difficult to cherrypick on older branches. Tests pass locally on master and branch-1.4, I did not go further in the past. > The hbase shell clone_snaphost command returns bad error message > > > Key: HBASE-18842 > URL: https://issues.apache.org/jira/browse/HBASE-18842 > Project: HBase > Issue Type: Bug >Reporter: Thoralf Gutierrez >Assignee: Jesse Yates >Priority: Minor > Attachments: > 0001-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0002-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0003-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch > > > When you call the hbase shell clone_snapshot command with a target namespace > that doesn't exist, you get an error message, but the variable used to > identify the inexistent namespace is wrong: > {noformat} > hbase(main):001:0> clone_snapshot 'someSnapshotName', > 'someNamespaceName:someTableName' > ERROR: Unknown namespace someSnapshotName! > Create a new table by cloning the snapshot content. > There're no copies of data involved. > And writing on the newly created table will not influence the snapshot data. > Examples: > hbase> clone_snapshot 'snapshotName', 'tableName' > hbase> clone_snapshot 'snapshotName', 'namespace:tableName' > {noformat} > It should rather say: > {noformat} > ERROR: Unknown namespace someNamespaceName! > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18842) The hbase shell clone_snaphost command returns bad error message
[ https://issues.apache.org/jira/browse/HBASE-18842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thoralf Gutierrez updated HBASE-18842: -- Attachment: 0002-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch This second version complies a bit more with rubocop and ruby-lint. To be more explicit about the tests performed: I have built the `branch-1.4` branch locally with my change, and tested the `clone_snapshot` command on an unknown namespace on an HBase 1.4 cluster. The error give the expected message: {noformat} hbase(main):001:0> clone_snapshot 'tmp_snap', 'bad_namespace:some_table' ERROR: Unknown namespace 'bad_namespace'! {noformat} > The hbase shell clone_snaphost command returns bad error message > > > Key: HBASE-18842 > URL: https://issues.apache.org/jira/browse/HBASE-18842 > Project: HBase > Issue Type: Bug >Reporter: Thoralf Gutierrez >Assignee: Jesse Yates >Priority: Minor > Attachments: > 0001-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch, > 0002-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch > > > When you call the hbase shell clone_snapshot command with a target namespace > that doesn't exist, you get an error message, but the variable used to > identify the inexistent namespace is wrong: > {noformat} > hbase(main):001:0> clone_snapshot 'someSnapshotName', > 'someNamespaceName:someTableName' > ERROR: Unknown namespace someSnapshotName! > Create a new table by cloning the snapshot content. > There're no copies of data involved. > And writing on the newly created table will not influence the snapshot data. > Examples: > hbase> clone_snapshot 'snapshotName', 'tableName' > hbase> clone_snapshot 'snapshotName', 'namespace:tableName' > {noformat} > It should rather say: > {noformat} > ERROR: Unknown namespace someNamespaceName! > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18842) The hbase shell clone_snaphost command returns bad error message
[ https://issues.apache.org/jira/browse/HBASE-18842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thoralf Gutierrez updated HBASE-18842: -- Attachment: 0001-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch > The hbase shell clone_snaphost command returns bad error message > > > Key: HBASE-18842 > URL: https://issues.apache.org/jira/browse/HBASE-18842 > Project: HBase > Issue Type: Bug >Reporter: Thoralf Gutierrez >Assignee: Jesse Yates >Priority: Minor > Attachments: > 0001-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch > > > When you call the hbase shell clone_snapshot command with a target namespace > that doesn't exist, you get an error message, but the variable used to > identify the inexistent namespace is wrong: > {noformat} > hbase(main):001:0> clone_snapshot 'someSnapshotName', > 'someNamespaceName:someTableName' > ERROR: Unknown namespace someSnapshotName! > Create a new table by cloning the snapshot content. > There're no copies of data involved. > And writing on the newly created table will not influence the snapshot data. > Examples: > hbase> clone_snapshot 'snapshotName', 'tableName' > hbase> clone_snapshot 'snapshotName', 'namespace:tableName' > {noformat} > It should rather say: > {noformat} > ERROR: Unknown namespace someNamespaceName! > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18842) The hbase shell clone_snaphost command returns bad error message
[ https://issues.apache.org/jira/browse/HBASE-18842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thoralf Gutierrez updated HBASE-18842: -- Status: Patch Available (was: Open) This patch adds a handler for the `NamespaceNotFoundException` in the `clone_snapshot` command. > The hbase shell clone_snaphost command returns bad error message > > > Key: HBASE-18842 > URL: https://issues.apache.org/jira/browse/HBASE-18842 > Project: HBase > Issue Type: Bug >Reporter: Thoralf Gutierrez >Assignee: Jesse Yates >Priority: Minor > Attachments: > 0001-HBASE-18842-Fix-unknown-namespace-message-in-clone_s.patch > > > When you call the hbase shell clone_snapshot command with a target namespace > that doesn't exist, you get an error message, but the variable used to > identify the inexistent namespace is wrong: > {noformat} > hbase(main):001:0> clone_snapshot 'someSnapshotName', > 'someNamespaceName:someTableName' > ERROR: Unknown namespace someSnapshotName! > Create a new table by cloning the snapshot content. > There're no copies of data involved. > And writing on the newly created table will not influence the snapshot data. > Examples: > hbase> clone_snapshot 'snapshotName', 'tableName' > hbase> clone_snapshot 'snapshotName', 'namespace:tableName' > {noformat} > It should rather say: > {noformat} > ERROR: Unknown namespace someNamespaceName! > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)