[jira] [Updated] (HBASE-19505) Disable ByteBufferPool by default at HM
[ https://issues.apache.org/jira/browse/HBASE-19505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19505: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Pushed to branch-2+. Thanks for the reviews. (Fixed chestyle while commit) > Disable ByteBufferPool by default at HM > --- > > Key: HBASE-19505 > URL: https://issues.apache.org/jira/browse/HBASE-19505 > Project: HBase > Issue Type: Sub-task >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19505.patch, HBASE-19505_V2.patch, > HBASE-19505_V3.patch > > > The main usage of the pool is while accepting bigger sized requests ie. > Mutation requests. HM do not have any regions by default. So we can make > this pool OFF in HM side. Still add a config to turn this ON. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19505) Disable ByteBufferPool by default at HM
[ https://issues.apache.org/jira/browse/HBASE-19505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19505: --- Attachment: HBASE-19505_V3.patch > Disable ByteBufferPool by default at HM > --- > > Key: HBASE-19505 > URL: https://issues.apache.org/jira/browse/HBASE-19505 > Project: HBase > Issue Type: Sub-task >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19505.patch, HBASE-19505_V2.patch, > HBASE-19505_V3.patch > > > The main usage of the pool is while accepting bigger sized requests ie. > Mutation requests. HM do not have any regions by default. So we can make > this pool OFF in HM side. Still add a config to turn this ON. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19505) Disable ByteBufferPool by default at HM
[ https://issues.apache.org/jira/browse/HBASE-19505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19505: --- Attachment: HBASE-19505_V2.patch As per the discussion, in HM side the BBPool is by default enabled iff we have non system tables there. If HM is configured not to take any regions or take only system table regions, the BBPool is by default disable. One can always enable the BBPool at HM by explicitly configuring 'hbase.ipc.server.reservoir.enabled' as true. Also in this patch changed the InterfaceAudience of few classes. 1. NettyRpcServer and SimpleRpcServer were configured with Private audience. But these has to be LimitedPrivate for CONFIG as we have a config , whose value is these class names. 2. RpcServer and RpcServerInterface changed to be Private. For Phoenix we made this LP. Phoenix was/is using the Call inside this (1.x) For 2.0 we have moved the Call (Now ServerCall) class outside and which is LP now. There is no way a CP can work on this RpcServer . No need to expose. RpcScheduler is the one which Phoenix changes and that in turn uses using Call only. > Disable ByteBufferPool by default at HM > --- > > Key: HBASE-19505 > URL: https://issues.apache.org/jira/browse/HBASE-19505 > Project: HBase > Issue Type: Sub-task >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19505.patch, HBASE-19505_V2.patch > > > The main usage of the pool is while accepting bigger sized requests ie. > Mutation requests. HM do not have any regions by default. So we can make > this pool OFF in HM side. Still add a config to turn this ON. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19505) Disable ByteBufferPool by default at HM
[ https://issues.apache.org/jira/browse/HBASE-19505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19505: --- Status: Patch Available (was: Open) > Disable ByteBufferPool by default at HM > --- > > Key: HBASE-19505 > URL: https://issues.apache.org/jira/browse/HBASE-19505 > Project: HBase > Issue Type: Sub-task >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19505.patch > > > The main usage of the pool is while accepting bigger sized requests ie. > Mutation requests. HM do not have any regions by default. So we can make > this pool OFF in HM side. Still add a config to turn this ON. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19505) Disable ByteBufferPool by default at HM
[ https://issues.apache.org/jira/browse/HBASE-19505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19505: --- Attachment: HBASE-19505.patch > Disable ByteBufferPool by default at HM > --- > > Key: HBASE-19505 > URL: https://issues.apache.org/jira/browse/HBASE-19505 > Project: HBase > Issue Type: Sub-task >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19505.patch > > > The main usage of the pool is while accepting bigger sized requests ie. > Mutation requests. HM do not have any regions by default. So we can make > this pool OFF in HM side. Still add a config to turn this ON. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19505) Disable ByteBufferPool by default at HM
[ https://issues.apache.org/jira/browse/HBASE-19505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19505: --- Description: The main usage of the pool is while accepting bigger sized requests ie. Mutation requests. HM do not have any regions by default. So we can make this pool OFF in HM side. Still add a config to turn this ON. > Disable ByteBufferPool by default at HM > --- > > Key: HBASE-19505 > URL: https://issues.apache.org/jira/browse/HBASE-19505 > Project: HBase > Issue Type: Sub-task >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 2.0.0-beta-1 > > > The main usage of the pool is while accepting bigger sized requests ie. > Mutation requests. HM do not have any regions by default. So we can make > this pool OFF in HM side. Still add a config to turn this ON. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
