[jira] [Updated] (HBASE-20276) [shell] Revert shell REPL change and document
[
https://issues.apache.org/jira/browse/HBASE-20276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-20276:
Fix Version/s: 1.4.4
> [shell] Revert shell REPL change and document
> -
>
> Key: HBASE-20276
> URL: https://issues.apache.org/jira/browse/HBASE-20276
> Project: HBase
> Issue Type: Sub-task
> Components: documentation, shell
>Affects Versions: 1.4.0, 2.0.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 1.4.4, 2.0.0
>
> Attachments: HBASE-20276-branch-1.v4.patch, HBASE-20276.0.patch,
> HBASE-20276.1.patch, HBASE-20276.2.patch, HBASE-20276.3.patch
>
>
> Feedback from [~mdrob] on HBASE-19158:
> {quote}
> Shell:
> HBASE-19770. There was another issue opened where this was identified as a
> problem so maybe the shape will change further, but I can't find it now.
> {quote}
> New commentary from [~busbey]:
> This was a follow on to HBASE-15965. That change effectively makes it so none
> of our ruby wrappers can be used to build expressions in an interactive REPL.
> This is a pretty severe change (most of my tips on HBASE-15611 will break, I
> think).
> I think we should
> a) Have a DISCUSS thread, spanning dev@ and user@
> b) based on the outcome of that thread, either default to the new behavior or
> the old behavior
> c) if we keep the HBASE-15965 behavior as the default, flag it as
> incompatible, call it out in the hbase 2.0 upgrade section, and update docs
> (two examples: the output in the shell_exercises sections would be wrong, and
> the _table_variables section won't work)
> d) In either case document the new flag in the ref guide
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20276) [shell] Revert shell REPL change and document
[
https://issues.apache.org/jira/browse/HBASE-20276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-20276:
--
Resolution: Fixed
Fix Version/s: (was: 1.4.4)
Status: Resolved (was: Patch Available)
Opening subissue for branch-1 fix. Resolving this so it makes it into the RC1
of 2.0.0 release notes.
> [shell] Revert shell REPL change and document
> -
>
> Key: HBASE-20276
> URL: https://issues.apache.org/jira/browse/HBASE-20276
> Project: HBase
> Issue Type: Sub-task
> Components: documentation, shell
>Affects Versions: 1.4.0, 2.0.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-20276-branch-1.v4.patch, HBASE-20276.0.patch,
> HBASE-20276.1.patch, HBASE-20276.2.patch, HBASE-20276.3.patch
>
>
> Feedback from [~mdrob] on HBASE-19158:
> {quote}
> Shell:
> HBASE-19770. There was another issue opened where this was identified as a
> problem so maybe the shape will change further, but I can't find it now.
> {quote}
> New commentary from [~busbey]:
> This was a follow on to HBASE-15965. That change effectively makes it so none
> of our ruby wrappers can be used to build expressions in an interactive REPL.
> This is a pretty severe change (most of my tips on HBASE-15611 will break, I
> think).
> I think we should
> a) Have a DISCUSS thread, spanning dev@ and user@
> b) based on the outcome of that thread, either default to the new behavior or
> the old behavior
> c) if we keep the HBASE-15965 behavior as the default, flag it as
> incompatible, call it out in the hbase 2.0 upgrade section, and update docs
> (two examples: the output in the shell_exercises sections would be wrong, and
> the _table_variables section won't work)
> d) In either case document the new flag in the ref guide
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20276) [shell] Revert shell REPL change and document
[
https://issues.apache.org/jira/browse/HBASE-20276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-20276:
Status: Patch Available (was: In Progress)
(I attached the addendum so I don't lose track of it)
> [shell] Revert shell REPL change and document
> -
>
> Key: HBASE-20276
> URL: https://issues.apache.org/jira/browse/HBASE-20276
> Project: HBase
> Issue Type: Sub-task
> Components: documentation, shell
>Affects Versions: 1.4.0, 2.0.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 1.4.4, 2.0.0
>
> Attachments: HBASE-20276-branch-1.v4.patch, HBASE-20276.0.patch,
> HBASE-20276.1.patch, HBASE-20276.2.patch, HBASE-20276.3.patch
>
>
> Feedback from [~mdrob] on HBASE-19158:
> {quote}
> Shell:
> HBASE-19770. There was another issue opened where this was identified as a
> problem so maybe the shape will change further, but I can't find it now.
> {quote}
> New commentary from [~busbey]:
> This was a follow on to HBASE-15965. That change effectively makes it so none
> of our ruby wrappers can be used to build expressions in an interactive REPL.
> This is a pretty severe change (most of my tips on HBASE-15611 will break, I
> think).
> I think we should
> a) Have a DISCUSS thread, spanning dev@ and user@
> b) based on the outcome of that thread, either default to the new behavior or
> the old behavior
> c) if we keep the HBASE-15965 behavior as the default, flag it as
> incompatible, call it out in the hbase 2.0 upgrade section, and update docs
> (two examples: the output in the shell_exercises sections would be wrong, and
> the _table_variables section won't work)
> d) In either case document the new flag in the ref guide
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20276) [shell] Revert shell REPL change and document
[
https://issues.apache.org/jira/browse/HBASE-20276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-20276:
Attachment: HBASE-20276-branch-1.v4.patch
> [shell] Revert shell REPL change and document
> -
>
> Key: HBASE-20276
> URL: https://issues.apache.org/jira/browse/HBASE-20276
> Project: HBase
> Issue Type: Sub-task
> Components: documentation, shell
>Affects Versions: 1.4.0, 2.0.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 1.4.4, 2.0.0
>
> Attachments: HBASE-20276-branch-1.v4.patch, HBASE-20276.0.patch,
> HBASE-20276.1.patch, HBASE-20276.2.patch, HBASE-20276.3.patch
>
>
> Feedback from [~mdrob] on HBASE-19158:
> {quote}
> Shell:
> HBASE-19770. There was another issue opened where this was identified as a
> problem so maybe the shape will change further, but I can't find it now.
> {quote}
> New commentary from [~busbey]:
> This was a follow on to HBASE-15965. That change effectively makes it so none
> of our ruby wrappers can be used to build expressions in an interactive REPL.
> This is a pretty severe change (most of my tips on HBASE-15611 will break, I
> think).
> I think we should
> a) Have a DISCUSS thread, spanning dev@ and user@
> b) based on the outcome of that thread, either default to the new behavior or
> the old behavior
> c) if we keep the HBASE-15965 behavior as the default, flag it as
> incompatible, call it out in the hbase 2.0 upgrade section, and update docs
> (two examples: the output in the shell_exercises sections would be wrong, and
> the _table_variables section won't work)
> d) In either case document the new flag in the ref guide
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20276) [shell] Revert shell REPL change and document
[
https://issues.apache.org/jira/browse/HBASE-20276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-20276:
Resolution: Fixed
Hadoop Flags: Incompatible change
Release Note:
The HBase shell now behaves as it did prior to the changes that started in
HBASE-15965. Namely, some shell commands return values that may be further
manipulated within the shell's IRB session.
The command line option `--return-values` is no longer acted on by the shell
since it now always behaves as it did when passed this parameter. Passing the
option results in a harmless warning about this change.
Users who wish to maintain the behavior seen in the 1.4.0-1.4.2 releases of the
HBase shell should refer to the section _irbrc_ in the reference guide for how
to configure their IRB session to avoid echoing expression results to the
console.
Status: Resolved (was: Patch Available)
pushed to branch-1.4+. Marking as incompatible since we're ignoring the flag
and in theory folks in the 1.4.0-1.4.2 range could have started checking that
we return `nil` from commands (e.g. to figure out if we're in interactive mode
or not).
> [shell] Revert shell REPL change and document
> -
>
> Key: HBASE-20276
> URL: https://issues.apache.org/jira/browse/HBASE-20276
> Project: HBase
> Issue Type: Sub-task
> Components: documentation, shell
>Affects Versions: 1.4.0, 2.0.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 1.4.4, 2.0.0
>
> Attachments: HBASE-20276.0.patch, HBASE-20276.1.patch,
> HBASE-20276.2.patch, HBASE-20276.3.patch
>
>
> Feedback from [~mdrob] on HBASE-19158:
> {quote}
> Shell:
> HBASE-19770. There was another issue opened where this was identified as a
> problem so maybe the shape will change further, but I can't find it now.
> {quote}
> New commentary from [~busbey]:
> This was a follow on to HBASE-15965. That change effectively makes it so none
> of our ruby wrappers can be used to build expressions in an interactive REPL.
> This is a pretty severe change (most of my tips on HBASE-15611 will break, I
> think).
> I think we should
> a) Have a DISCUSS thread, spanning dev@ and user@
> b) based on the outcome of that thread, either default to the new behavior or
> the old behavior
> c) if we keep the HBASE-15965 behavior as the default, flag it as
> incompatible, call it out in the hbase 2.0 upgrade section, and update docs
> (two examples: the output in the shell_exercises sections would be wrong, and
> the _table_variables section won't work)
> d) In either case document the new flag in the ref guide
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20276) [shell] Revert shell REPL change and document
[
https://issues.apache.org/jira/browse/HBASE-20276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-20276:
Status: Patch Available (was: In Progress)
I think this is better than using v1:
-v3
- go back to not messing with most of table.rb
- make an explicit java_import for Bytes (I'm not sure why things worked
without this)
- fix rubodoc complaints
Locally, this gets a clean bill of health from rubocop. ruby-lint actually
complains more, but it looks like that's because it doesn't understand jruby.
> [shell] Revert shell REPL change and document
> -
>
> Key: HBASE-20276
> URL: https://issues.apache.org/jira/browse/HBASE-20276
> Project: HBase
> Issue Type: Sub-task
> Components: documentation, shell
>Affects Versions: 1.4.0, 2.0.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 1.4.4, 2.0.0
>
> Attachments: HBASE-20276.0.patch, HBASE-20276.1.patch,
> HBASE-20276.2.patch, HBASE-20276.3.patch
>
>
> Feedback from [~mdrob] on HBASE-19158:
> {quote}
> Shell:
> HBASE-19770. There was another issue opened where this was identified as a
> problem so maybe the shape will change further, but I can't find it now.
> {quote}
> New commentary from [~busbey]:
> This was a follow on to HBASE-15965. That change effectively makes it so none
> of our ruby wrappers can be used to build expressions in an interactive REPL.
> This is a pretty severe change (most of my tips on HBASE-15611 will break, I
> think).
> I think we should
> a) Have a DISCUSS thread, spanning dev@ and user@
> b) based on the outcome of that thread, either default to the new behavior or
> the old behavior
> c) if we keep the HBASE-15965 behavior as the default, flag it as
> incompatible, call it out in the hbase 2.0 upgrade section, and update docs
> (two examples: the output in the shell_exercises sections would be wrong, and
> the _table_variables section won't work)
> d) In either case document the new flag in the ref guide
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20276) [shell] Revert shell REPL change and document
[
https://issues.apache.org/jira/browse/HBASE-20276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-20276:
Attachment: HBASE-20276.3.patch
> [shell] Revert shell REPL change and document
> -
>
> Key: HBASE-20276
> URL: https://issues.apache.org/jira/browse/HBASE-20276
> Project: HBase
> Issue Type: Sub-task
> Components: documentation, shell
>Affects Versions: 1.4.0, 2.0.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 1.4.4, 2.0.0
>
> Attachments: HBASE-20276.0.patch, HBASE-20276.1.patch,
> HBASE-20276.2.patch, HBASE-20276.3.patch
>
>
> Feedback from [~mdrob] on HBASE-19158:
> {quote}
> Shell:
> HBASE-19770. There was another issue opened where this was identified as a
> problem so maybe the shape will change further, but I can't find it now.
> {quote}
> New commentary from [~busbey]:
> This was a follow on to HBASE-15965. That change effectively makes it so none
> of our ruby wrappers can be used to build expressions in an interactive REPL.
> This is a pretty severe change (most of my tips on HBASE-15611 will break, I
> think).
> I think we should
> a) Have a DISCUSS thread, spanning dev@ and user@
> b) based on the outcome of that thread, either default to the new behavior or
> the old behavior
> c) if we keep the HBASE-15965 behavior as the default, flag it as
> incompatible, call it out in the hbase 2.0 upgrade section, and update docs
> (two examples: the output in the shell_exercises sections would be wrong, and
> the _table_variables section won't work)
> d) In either case document the new flag in the ref guide
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20276) [shell] Revert shell REPL change and document
[
https://issues.apache.org/jira/browse/HBASE-20276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-20276:
Attachment: (was: HBASE-20276.3.patch)
> [shell] Revert shell REPL change and document
> -
>
> Key: HBASE-20276
> URL: https://issues.apache.org/jira/browse/HBASE-20276
> Project: HBase
> Issue Type: Sub-task
> Components: documentation, shell
>Affects Versions: 1.4.0, 2.0.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 1.4.4, 2.0.0
>
> Attachments: HBASE-20276.0.patch, HBASE-20276.1.patch,
> HBASE-20276.2.patch
>
>
> Feedback from [~mdrob] on HBASE-19158:
> {quote}
> Shell:
> HBASE-19770. There was another issue opened where this was identified as a
> problem so maybe the shape will change further, but I can't find it now.
> {quote}
> New commentary from [~busbey]:
> This was a follow on to HBASE-15965. That change effectively makes it so none
> of our ruby wrappers can be used to build expressions in an interactive REPL.
> This is a pretty severe change (most of my tips on HBASE-15611 will break, I
> think).
> I think we should
> a) Have a DISCUSS thread, spanning dev@ and user@
> b) based on the outcome of that thread, either default to the new behavior or
> the old behavior
> c) if we keep the HBASE-15965 behavior as the default, flag it as
> incompatible, call it out in the hbase 2.0 upgrade section, and update docs
> (two examples: the output in the shell_exercises sections would be wrong, and
> the _table_variables section won't work)
> d) In either case document the new flag in the ref guide
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20276) [shell] Revert shell REPL change and document
[
https://issues.apache.org/jira/browse/HBASE-20276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-20276:
Attachment: HBASE-20276.3.patch
> [shell] Revert shell REPL change and document
> -
>
> Key: HBASE-20276
> URL: https://issues.apache.org/jira/browse/HBASE-20276
> Project: HBase
> Issue Type: Sub-task
> Components: documentation, shell
>Affects Versions: 1.4.0, 2.0.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 1.4.4, 2.0.0
>
> Attachments: HBASE-20276.0.patch, HBASE-20276.1.patch,
> HBASE-20276.2.patch, HBASE-20276.3.patch
>
>
> Feedback from [~mdrob] on HBASE-19158:
> {quote}
> Shell:
> HBASE-19770. There was another issue opened where this was identified as a
> problem so maybe the shape will change further, but I can't find it now.
> {quote}
> New commentary from [~busbey]:
> This was a follow on to HBASE-15965. That change effectively makes it so none
> of our ruby wrappers can be used to build expressions in an interactive REPL.
> This is a pretty severe change (most of my tips on HBASE-15611 will break, I
> think).
> I think we should
> a) Have a DISCUSS thread, spanning dev@ and user@
> b) based on the outcome of that thread, either default to the new behavior or
> the old behavior
> c) if we keep the HBASE-15965 behavior as the default, flag it as
> incompatible, call it out in the hbase 2.0 upgrade section, and update docs
> (two examples: the output in the shell_exercises sections would be wrong, and
> the _table_variables section won't work)
> d) In either case document the new flag in the ref guide
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20276) [shell] Revert shell REPL change and document
[
https://issues.apache.org/jira/browse/HBASE-20276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-20276:
Status: In Progress (was: Patch Available)
taking out of PA. on second thought I'd rather not alter so much of table.rb
> [shell] Revert shell REPL change and document
> -
>
> Key: HBASE-20276
> URL: https://issues.apache.org/jira/browse/HBASE-20276
> Project: HBase
> Issue Type: Sub-task
> Components: documentation, shell
>Affects Versions: 1.4.0, 2.0.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 1.4.4, 2.0.0
>
> Attachments: HBASE-20276.0.patch, HBASE-20276.1.patch,
> HBASE-20276.2.patch
>
>
> Feedback from [~mdrob] on HBASE-19158:
> {quote}
> Shell:
> HBASE-19770. There was another issue opened where this was identified as a
> problem so maybe the shape will change further, but I can't find it now.
> {quote}
> New commentary from [~busbey]:
> This was a follow on to HBASE-15965. That change effectively makes it so none
> of our ruby wrappers can be used to build expressions in an interactive REPL.
> This is a pretty severe change (most of my tips on HBASE-15611 will break, I
> think).
> I think we should
> a) Have a DISCUSS thread, spanning dev@ and user@
> b) based on the outcome of that thread, either default to the new behavior or
> the old behavior
> c) if we keep the HBASE-15965 behavior as the default, flag it as
> incompatible, call it out in the hbase 2.0 upgrade section, and update docs
> (two examples: the output in the shell_exercises sections would be wrong, and
> the _table_variables section won't work)
> d) In either case document the new flag in the ref guide
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20276) [shell] Revert shell REPL change and document
[
https://issues.apache.org/jira/browse/HBASE-20276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-20276:
Status: Patch Available (was: In Progress)
-2
- fix additional rubocop complaints
- fix rubylint complaint by switching uses of Bytes in table.rb to rely on an
import (which also fixes some line length stuff.)
> [shell] Revert shell REPL change and document
> -
>
> Key: HBASE-20276
> URL: https://issues.apache.org/jira/browse/HBASE-20276
> Project: HBase
> Issue Type: Sub-task
> Components: documentation, shell
>Affects Versions: 1.4.0, 2.0.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 1.4.4, 2.0.0
>
> Attachments: HBASE-20276.0.patch, HBASE-20276.1.patch,
> HBASE-20276.2.patch
>
>
> Feedback from [~mdrob] on HBASE-19158:
> {quote}
> Shell:
> HBASE-19770. There was another issue opened where this was identified as a
> problem so maybe the shape will change further, but I can't find it now.
> {quote}
> New commentary from [~busbey]:
> This was a follow on to HBASE-15965. That change effectively makes it so none
> of our ruby wrappers can be used to build expressions in an interactive REPL.
> This is a pretty severe change (most of my tips on HBASE-15611 will break, I
> think).
> I think we should
> a) Have a DISCUSS thread, spanning dev@ and user@
> b) based on the outcome of that thread, either default to the new behavior or
> the old behavior
> c) if we keep the HBASE-15965 behavior as the default, flag it as
> incompatible, call it out in the hbase 2.0 upgrade section, and update docs
> (two examples: the output in the shell_exercises sections would be wrong, and
> the _table_variables section won't work)
> d) In either case document the new flag in the ref guide
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20276) [shell] Revert shell REPL change and document
[
https://issues.apache.org/jira/browse/HBASE-20276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-20276:
Attachment: HBASE-20276.2.patch
> [shell] Revert shell REPL change and document
> -
>
> Key: HBASE-20276
> URL: https://issues.apache.org/jira/browse/HBASE-20276
> Project: HBase
> Issue Type: Sub-task
> Components: documentation, shell
>Affects Versions: 1.4.0, 2.0.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 1.4.4, 2.0.0
>
> Attachments: HBASE-20276.0.patch, HBASE-20276.1.patch,
> HBASE-20276.2.patch
>
>
> Feedback from [~mdrob] on HBASE-19158:
> {quote}
> Shell:
> HBASE-19770. There was another issue opened where this was identified as a
> problem so maybe the shape will change further, but I can't find it now.
> {quote}
> New commentary from [~busbey]:
> This was a follow on to HBASE-15965. That change effectively makes it so none
> of our ruby wrappers can be used to build expressions in an interactive REPL.
> This is a pretty severe change (most of my tips on HBASE-15611 will break, I
> think).
> I think we should
> a) Have a DISCUSS thread, spanning dev@ and user@
> b) based on the outcome of that thread, either default to the new behavior or
> the old behavior
> c) if we keep the HBASE-15965 behavior as the default, flag it as
> incompatible, call it out in the hbase 2.0 upgrade section, and update docs
> (two examples: the output in the shell_exercises sections would be wrong, and
> the _table_variables section won't work)
> d) In either case document the new flag in the ref guide
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20276) [shell] Revert shell REPL change and document
[
https://issues.apache.org/jira/browse/HBASE-20276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-20276:
Status: In Progress (was: Patch Available)
I think I can fix these. new patch once I check my results.
> [shell] Revert shell REPL change and document
> -
>
> Key: HBASE-20276
> URL: https://issues.apache.org/jira/browse/HBASE-20276
> Project: HBase
> Issue Type: Sub-task
> Components: documentation, shell
>Affects Versions: 1.4.0, 2.0.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 1.4.4, 2.0.0
>
> Attachments: HBASE-20276.0.patch, HBASE-20276.1.patch
>
>
> Feedback from [~mdrob] on HBASE-19158:
> {quote}
> Shell:
> HBASE-19770. There was another issue opened where this was identified as a
> problem so maybe the shape will change further, but I can't find it now.
> {quote}
> New commentary from [~busbey]:
> This was a follow on to HBASE-15965. That change effectively makes it so none
> of our ruby wrappers can be used to build expressions in an interactive REPL.
> This is a pretty severe change (most of my tips on HBASE-15611 will break, I
> think).
> I think we should
> a) Have a DISCUSS thread, spanning dev@ and user@
> b) based on the outcome of that thread, either default to the new behavior or
> the old behavior
> c) if we keep the HBASE-15965 behavior as the default, flag it as
> incompatible, call it out in the hbase 2.0 upgrade section, and update docs
> (two examples: the output in the shell_exercises sections would be wrong, and
> the _table_variables section won't work)
> d) In either case document the new flag in the ref guide
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20276) [shell] Revert shell REPL change and document
[
https://issues.apache.org/jira/browse/HBASE-20276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-20276:
Attachment: HBASE-20276.1.patch
> [shell] Revert shell REPL change and document
> -
>
> Key: HBASE-20276
> URL: https://issues.apache.org/jira/browse/HBASE-20276
> Project: HBase
> Issue Type: Sub-task
> Components: documentation, shell
>Affects Versions: 1.4.0, 2.0.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 1.4.4, 2.0.0
>
> Attachments: HBASE-20276.0.patch, HBASE-20276.1.patch
>
>
> Feedback from [~mdrob] on HBASE-19158:
> {quote}
> Shell:
> HBASE-19770. There was another issue opened where this was identified as a
> problem so maybe the shape will change further, but I can't find it now.
> {quote}
> New commentary from [~busbey]:
> This was a follow on to HBASE-15965. That change effectively makes it so none
> of our ruby wrappers can be used to build expressions in an interactive REPL.
> This is a pretty severe change (most of my tips on HBASE-15611 will break, I
> think).
> I think we should
> a) Have a DISCUSS thread, spanning dev@ and user@
> b) based on the outcome of that thread, either default to the new behavior or
> the old behavior
> c) if we keep the HBASE-15965 behavior as the default, flag it as
> incompatible, call it out in the hbase 2.0 upgrade section, and update docs
> (two examples: the output in the shell_exercises sections would be wrong, and
> the _table_variables section won't work)
> d) In either case document the new flag in the ref guide
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20276) [shell] Revert shell REPL change and document
[
https://issues.apache.org/jira/browse/HBASE-20276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-20276:
Status: Patch Available (was: In Progress)
-1
- rubocop suggested fixes
- disable class length check on Table and Shell classes, since I can't fix
them without a major refactoring.
> [shell] Revert shell REPL change and document
> -
>
> Key: HBASE-20276
> URL: https://issues.apache.org/jira/browse/HBASE-20276
> Project: HBase
> Issue Type: Sub-task
> Components: documentation, shell
>Affects Versions: 1.4.0, 2.0.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 1.4.4, 2.0.0
>
> Attachments: HBASE-20276.0.patch, HBASE-20276.1.patch
>
>
> Feedback from [~mdrob] on HBASE-19158:
> {quote}
> Shell:
> HBASE-19770. There was another issue opened where this was identified as a
> problem so maybe the shape will change further, but I can't find it now.
> {quote}
> New commentary from [~busbey]:
> This was a follow on to HBASE-15965. That change effectively makes it so none
> of our ruby wrappers can be used to build expressions in an interactive REPL.
> This is a pretty severe change (most of my tips on HBASE-15611 will break, I
> think).
> I think we should
> a) Have a DISCUSS thread, spanning dev@ and user@
> b) based on the outcome of that thread, either default to the new behavior or
> the old behavior
> c) if we keep the HBASE-15965 behavior as the default, flag it as
> incompatible, call it out in the hbase 2.0 upgrade section, and update docs
> (two examples: the output in the shell_exercises sections would be wrong, and
> the _table_variables section won't work)
> d) In either case document the new flag in the ref guide
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20276) [shell] Revert shell REPL change and document
[
https://issues.apache.org/jira/browse/HBASE-20276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-20276:
Status: In Progress (was: Patch Available)
asflicense warning was from HBASE-17730 and has since been fixed.
rubocop looks legit. let me see what I can do.
> [shell] Revert shell REPL change and document
> -
>
> Key: HBASE-20276
> URL: https://issues.apache.org/jira/browse/HBASE-20276
> Project: HBase
> Issue Type: Sub-task
> Components: documentation, shell
>Affects Versions: 1.4.0, 2.0.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 1.4.4, 2.0.0
>
> Attachments: HBASE-20276.0.patch
>
>
> Feedback from [~mdrob] on HBASE-19158:
> {quote}
> Shell:
> HBASE-19770. There was another issue opened where this was identified as a
> problem so maybe the shape will change further, but I can't find it now.
> {quote}
> New commentary from [~busbey]:
> This was a follow on to HBASE-15965. That change effectively makes it so none
> of our ruby wrappers can be used to build expressions in an interactive REPL.
> This is a pretty severe change (most of my tips on HBASE-15611 will break, I
> think).
> I think we should
> a) Have a DISCUSS thread, spanning dev@ and user@
> b) based on the outcome of that thread, either default to the new behavior or
> the old behavior
> c) if we keep the HBASE-15965 behavior as the default, flag it as
> incompatible, call it out in the hbase 2.0 upgrade section, and update docs
> (two examples: the output in the shell_exercises sections would be wrong, and
> the _table_variables section won't work)
> d) In either case document the new flag in the ref guide
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20276) [shell] Revert shell REPL change and document
[
https://issues.apache.org/jira/browse/HBASE-20276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-20276:
Status: Patch Available (was: In Progress)
I'd like to add some kind of test here, but I'm still chewing on what that
looks like. Happy to have that punted to a follow-on if folks want to see this
closed out sooner rather than later.
-0
- restores old behavior
- warn on ignored flag use
- docs on muting console value inspection
- upgrade docs
> [shell] Revert shell REPL change and document
> -
>
> Key: HBASE-20276
> URL: https://issues.apache.org/jira/browse/HBASE-20276
> Project: HBase
> Issue Type: Sub-task
> Components: documentation, shell
>Affects Versions: 1.4.0, 2.0.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 1.4.4, 2.0.0
>
> Attachments: HBASE-20276.0.patch
>
>
> Feedback from [~mdrob] on HBASE-19158:
> {quote}
> Shell:
> HBASE-19770. There was another issue opened where this was identified as a
> problem so maybe the shape will change further, but I can't find it now.
> {quote}
> New commentary from [~busbey]:
> This was a follow on to HBASE-15965. That change effectively makes it so none
> of our ruby wrappers can be used to build expressions in an interactive REPL.
> This is a pretty severe change (most of my tips on HBASE-15611 will break, I
> think).
> I think we should
> a) Have a DISCUSS thread, spanning dev@ and user@
> b) based on the outcome of that thread, either default to the new behavior or
> the old behavior
> c) if we keep the HBASE-15965 behavior as the default, flag it as
> incompatible, call it out in the hbase 2.0 upgrade section, and update docs
> (two examples: the output in the shell_exercises sections would be wrong, and
> the _table_variables section won't work)
> d) In either case document the new flag in the ref guide
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20276) [shell] Revert shell REPL change and document
[
https://issues.apache.org/jira/browse/HBASE-20276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-20276:
Attachment: HBASE-20276.0.patch
> [shell] Revert shell REPL change and document
> -
>
> Key: HBASE-20276
> URL: https://issues.apache.org/jira/browse/HBASE-20276
> Project: HBase
> Issue Type: Sub-task
> Components: documentation, shell
>Affects Versions: 1.4.0, 2.0.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 1.4.4, 2.0.0
>
> Attachments: HBASE-20276.0.patch
>
>
> Feedback from [~mdrob] on HBASE-19158:
> {quote}
> Shell:
> HBASE-19770. There was another issue opened where this was identified as a
> problem so maybe the shape will change further, but I can't find it now.
> {quote}
> New commentary from [~busbey]:
> This was a follow on to HBASE-15965. That change effectively makes it so none
> of our ruby wrappers can be used to build expressions in an interactive REPL.
> This is a pretty severe change (most of my tips on HBASE-15611 will break, I
> think).
> I think we should
> a) Have a DISCUSS thread, spanning dev@ and user@
> b) based on the outcome of that thread, either default to the new behavior or
> the old behavior
> c) if we keep the HBASE-15965 behavior as the default, flag it as
> incompatible, call it out in the hbase 2.0 upgrade section, and update docs
> (two examples: the output in the shell_exercises sections would be wrong, and
> the _table_variables section won't work)
> d) In either case document the new flag in the ref guide
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20276) [shell] Revert shell REPL change and document
[
https://issues.apache.org/jira/browse/HBASE-20276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-20276:
Summary: [shell] Revert shell REPL change and document (was: [shell]
confirm shell REPL change and document)
> [shell] Revert shell REPL change and document
> -
>
> Key: HBASE-20276
> URL: https://issues.apache.org/jira/browse/HBASE-20276
> Project: HBase
> Issue Type: Sub-task
> Components: documentation, shell
>Affects Versions: 1.4.0, 2.0.0
>Reporter: Sean Busbey
>Priority: Blocker
> Fix For: 1.4.4, 2.0.0
>
>
> Feedback from [~mdrob] on HBASE-19158:
> {quote}
> Shell:
> HBASE-19770. There was another issue opened where this was identified as a
> problem so maybe the shape will change further, but I can't find it now.
> {quote}
> New commentary from [~busbey]:
> This was a follow on to HBASE-15965. That change effectively makes it so none
> of our ruby wrappers can be used to build expressions in an interactive REPL.
> This is a pretty severe change (most of my tips on HBASE-15611 will break, I
> think).
> I think we should
> a) Have a DISCUSS thread, spanning dev@ and user@
> b) based on the outcome of that thread, either default to the new behavior or
> the old behavior
> c) if we keep the HBASE-15965 behavior as the default, flag it as
> incompatible, call it out in the hbase 2.0 upgrade section, and update docs
> (two examples: the output in the shell_exercises sections would be wrong, and
> the _table_variables section won't work)
> d) In either case document the new flag in the ref guide
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
