[jira] [Updated] (HBASE-20419) Two Potential NPE
[ https://issues.apache.org/jira/browse/HBASE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-20419: -- Attachment: HBASE-20419_1.patch > Two Potential NPE > -- > > Key: HBASE-20419 > URL: https://issues.apache.org/jira/browse/HBASE-20419 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-beta-2 >Reporter: lujie >Priority: Major > Attachments: HBASE-20419_1.patch > > > Callee ZKUtil#listChildrenAndWatchForNewChildren may return null, it has 8 > callers, 6 of the caller have null checker like: > {code:java} > List children = ZKUtil.listChildrenAndWatchForNewChildren(zkw, > zkw.znodePaths.rsZNode); > if (children == null) { > return Collections.emptyList(); > } > {code} > but another two callers do not have null > checker:RSGroupInfoManagerImpl#retrieveGroupListFromZookeeper,ZKProcedureMemberRpcs#watchForAbortedProcedures. > > We attach the patch to fix this probelm.(We found this bug by tool > [NPEDetector|https://github.com/lujiefsi/NPEDetector]) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20419) Two Potential NPE
[ https://issues.apache.org/jira/browse/HBASE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-20419: -- Status: Patch Available (was: Open) > Two Potential NPE > -- > > Key: HBASE-20419 > URL: https://issues.apache.org/jira/browse/HBASE-20419 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-beta-2 >Reporter: lujie >Priority: Major > Attachments: HBASE-20419_1.patch > > > Callee ZKUtil#listChildrenAndWatchForNewChildren may return null, it has 8 > callers, 6 of the caller have null checker like: > {code:java} > List children = ZKUtil.listChildrenAndWatchForNewChildren(zkw, > zkw.znodePaths.rsZNode); > if (children == null) { > return Collections.emptyList(); > } > {code} > but another two callers do not have null > checker:RSGroupInfoManagerImpl#retrieveGroupListFromZookeeper,ZKProcedureMemberRpcs#watchForAbortedProcedures. > > We attach the patch to fix this probelm.(We found this bug by tool > [NPEDetector|https://github.com/lujiefsi/NPEDetector]) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20419) Two Potential NPE
[ https://issues.apache.org/jira/browse/HBASE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-20419: -- Description: We have developed a static analysis tool [NPEDetector|https://github.com/lujiefsi/NPEDetector] to find some potential NPE. Our analysis shows that some callees may return null in corner case(e.g. node crash , IO exception), some of their callers have _!=null_ check but some do not have. For example: Callee ZKUtil#listChildrenAndWatchForNewChildren may return null, it has 8 callers, 6 of the caller have null checker like: {code:java} List children = ZKUtil.listChildrenAndWatchForNewChildren(zkw, zkw.znodePaths.rsZNode); if (children == null) { return Collections.emptyList(); } {code} but another two callers do not have null checker:RSGroupInfoManagerImpl#retrieveGroupListFromZookeeper,ZKProcedureMemberRpcs#watchForAbortedProcedures. We attach the patch to fix this problem. was: We have developed a static analysis tool [NPEDetector|https://github.com/lujiefsi/NPEDetector] to find some potential NPE. Our analysis shows that some callees may return null in corner case(e.g. node crash , IO exception), some of their callers have _!=null_ check but some do not have. In this issue we post a patch which can add !=null based on existed !=null check. For example: Callee ZKUtil#listChildrenAndWatchForNewChildren may return null, it has 8 callers, 6 of the caller have null checker like: {code:java} List children = ZKUtil.listChildrenAndWatchForNewChildren(zkw, zkw.znodePaths.rsZNode); if (children == null) { return Collections.emptyList(); } {code} but another two callers do not have null checker:RSGroupInfoManagerImpl#retrieveGroupListFromZookeeper,ZKProcedureMemberRpcs#watchForAbortedProcedures. We attach the patch to fix this problem. > Two Potential NPE > -- > > Key: HBASE-20419 > URL: https://issues.apache.org/jira/browse/HBASE-20419 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-beta-2 >Reporter: lujie >Priority: Major > Attachments: HBASE-20419_1.patch > > > We have developed a static analysis tool > [NPEDetector|https://github.com/lujiefsi/NPEDetector] to find some potential > NPE. Our analysis shows that some callees may return null in corner case(e.g. > node crash , IO exception), some of their callers have _!=null_ check but > some do not have. For example: > Callee ZKUtil#listChildrenAndWatchForNewChildren may return null, it has 8 > callers, 6 of the caller have null checker like: > {code:java} > List children = ZKUtil.listChildrenAndWatchForNewChildren(zkw, > zkw.znodePaths.rsZNode); > if (children == null) { > return Collections.emptyList(); > } > {code} > but another two callers do not have null > checker:RSGroupInfoManagerImpl#retrieveGroupListFromZookeeper,ZKProcedureMemberRpcs#watchForAbortedProcedures. > > We attach the patch to fix this problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20419) Two Potential NPE
[ https://issues.apache.org/jira/browse/HBASE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-20419: -- Description: We have developed a static analysis tool [NPEDetector|https://github.com/lujiefsi/NPEDetector] to find some potential NPE. Our analysis shows that some callees may return null in corner case(e.g. node crash , IO exception), some of their callers have _!=null_ check but some do not have. In this issue we post a patch which can add !=null based on existed !=null check. For example: Callee ZKUtil#listChildrenAndWatchForNewChildren may return null, it has 8 callers, 6 of the caller have null checker like: {code:java} List children = ZKUtil.listChildrenAndWatchForNewChildren(zkw, zkw.znodePaths.rsZNode); if (children == null) { return Collections.emptyList(); } {code} but another two callers do not have null checker:RSGroupInfoManagerImpl#retrieveGroupListFromZookeeper,ZKProcedureMemberRpcs#watchForAbortedProcedures. We attach the patch to fix this problem. was: Callee ZKUtil#listChildrenAndWatchForNewChildren may return null, it has 8 callers, 6 of the caller have null checker like: {code:java} List children = ZKUtil.listChildrenAndWatchForNewChildren(zkw, zkw.znodePaths.rsZNode); if (children == null) { return Collections.emptyList(); } {code} but another two callers do not have null checker:RSGroupInfoManagerImpl#retrieveGroupListFromZookeeper,ZKProcedureMemberRpcs#watchForAbortedProcedures. We attach the patch to fix this probelm.(We found this bug by tool [NPEDetector|https://github.com/lujiefsi/NPEDetector]) > Two Potential NPE > -- > > Key: HBASE-20419 > URL: https://issues.apache.org/jira/browse/HBASE-20419 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-beta-2 >Reporter: lujie >Priority: Major > Attachments: HBASE-20419_1.patch > > > We have developed a static analysis tool > [NPEDetector|https://github.com/lujiefsi/NPEDetector] to find some potential > NPE. Our analysis shows that some callees may return null in corner case(e.g. > node crash , IO exception), some of their callers have _!=null_ check but > some do not have. In this issue we post a patch which can add !=null based > on existed !=null check. For example: > Callee ZKUtil#listChildrenAndWatchForNewChildren may return null, it has 8 > callers, 6 of the caller have null checker like: > {code:java} > List children = ZKUtil.listChildrenAndWatchForNewChildren(zkw, > zkw.znodePaths.rsZNode); > if (children == null) { > return Collections.emptyList(); > } > {code} > but another two callers do not have null > checker:RSGroupInfoManagerImpl#retrieveGroupListFromZookeeper,ZKProcedureMemberRpcs#watchForAbortedProcedures. > > We attach the patch to fix this problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20419) Two Potential NPE
[ https://issues.apache.org/jira/browse/HBASE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-20419: -- Attachment: HBASE-20419_2.patch > Two Potential NPE > -- > > Key: HBASE-20419 > URL: https://issues.apache.org/jira/browse/HBASE-20419 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-beta-2 >Reporter: lujie >Priority: Major > Attachments: HBASE-20419_1.patch, HBASE-20419_2.patch > > > We have developed a static analysis tool > [NPEDetector|https://github.com/lujiefsi/NPEDetector] to find some potential > NPE. Our analysis shows that some callees may return null in corner case(e.g. > node crash , IO exception), some of their callers have _!=null_ check but > some do not have. For example: > Callee ZKUtil#listChildrenAndWatchForNewChildren may return null, it has 8 > callers, 6 of the caller have null checker like: > {code:java} > List children = ZKUtil.listChildrenAndWatchForNewChildren(zkw, > zkw.znodePaths.rsZNode); > if (children == null) { > return Collections.emptyList(); > } > {code} > but another two callers do not have null > checker:RSGroupInfoManagerImpl#retrieveGroupListFromZookeeper,ZKProcedureMemberRpcs#watchForAbortedProcedures. > > We attach the patch to fix this problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20419) Two Potential NPE
[ https://issues.apache.org/jira/browse/HBASE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-20419: -- Affects Version/s: 1.4.1 1.1.13 > Two Potential NPE > -- > > Key: HBASE-20419 > URL: https://issues.apache.org/jira/browse/HBASE-20419 > Project: HBase > Issue Type: Bug >Affects Versions: 1.4.1, 2.0.0-beta-2, 1.1.13 >Reporter: lujie >Priority: Major > Attachments: HBASE-20419_1.patch, HBASE-20419_2.patch > > > We have developed a static analysis tool > [NPEDetector|https://github.com/lujiefsi/NPEDetector] to find some potential > NPE. Our analysis shows that some callees may return null in corner case(e.g. > node crash , IO exception), some of their callers have _!=null_ check but > some do not have. For example: > Callee ZKUtil#listChildrenAndWatchForNewChildren may return null, it has 8 > callers, 6 of the caller have null checker like: > {code:java} > List children = ZKUtil.listChildrenAndWatchForNewChildren(zkw, > zkw.znodePaths.rsZNode); > if (children == null) { > return Collections.emptyList(); > } > {code} > but another two callers do not have null > checker:RSGroupInfoManagerImpl#retrieveGroupListFromZookeeper,ZKProcedureMemberRpcs#watchForAbortedProcedures. > > We attach the patch to fix this problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20419) Two Potential NPE
[ https://issues.apache.org/jira/browse/HBASE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Li updated HBASE-20419: -- Attachment: HBASE-20419.v3.patch > Two Potential NPE > -- > > Key: HBASE-20419 > URL: https://issues.apache.org/jira/browse/HBASE-20419 > Project: HBase > Issue Type: Bug >Affects Versions: 1.4.1, 2.0.0-beta-2, 1.1.13 >Reporter: lujie >Priority: Major > Attachments: HBASE-20419.v3.patch, HBASE-20419_1.patch, > HBASE-20419_2.patch > > > We have developed a static analysis tool > [NPEDetector|https://github.com/lujiefsi/NPEDetector] to find some potential > NPE. Our analysis shows that some callees may return null in corner case(e.g. > node crash , IO exception), some of their callers have _!=null_ check but > some do not have. For example: > Callee ZKUtil#listChildrenAndWatchForNewChildren may return null, it has 8 > callers, 6 of the caller have null checker like: > {code:java} > List children = ZKUtil.listChildrenAndWatchForNewChildren(zkw, > zkw.znodePaths.rsZNode); > if (children == null) { > return Collections.emptyList(); > } > {code} > but another two callers do not have null > checker:RSGroupInfoManagerImpl#retrieveGroupListFromZookeeper,ZKProcedureMemberRpcs#watchForAbortedProcedures. > > We attach the patch to fix this problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005)