[jira] [Updated] (HBASE-21243) Correct java-doc for the method RpcServer.getRemoteAddress()

2023-12-16 Thread Duo Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-21243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-21243:
--
Fix Version/s: 2.6.0
   2.4.18
   2.5.8
 Hadoop Flags: Reviewed
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

Pushed to all active branches.

Thanks [~nihaljain.cs]!

> Correct java-doc for the method RpcServer.getRemoteAddress()
> 
>
> Key: HBASE-21243
> URL: https://issues.apache.org/jira/browse/HBASE-21243
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0-alpha-1, 2.0.0
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Trivial
>  Labels: beginner, beginners, documentaion
> Fix For: 2.6.0, 2.4.18, 3.0.0-beta-1, 2.5.8
>
> Attachments: HBASE-21243.master.001.patch, 
> HBASE-21243.master.002.patch
>
>
> Correct the java-doc for the method {{RpcServer.getRemoteAddress()}}.
>  Currently it look like as below:
> {code:java}
>   /**
>* @return Address of remote client if a request is ongoing, else null
>*/
>   public static Optional getRemoteAddress() {
> return getCurrentCall().map(RpcCall::getRemoteAddress);
>   }
> {code}
> Contrary to the doc the method will never return null. Rather it may return 
> an empty Optional.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-21243) Correct java-doc for the method RpcServer.getRemoteAddress()

2018-10-11 Thread Nihal Jain (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-21243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nihal Jain updated HBASE-21243:
---
Attachment: HBASE-21243.master.002.patch

> Correct java-doc for the method RpcServer.getRemoteAddress()
> 
>
> Key: HBASE-21243
> URL: https://issues.apache.org/jira/browse/HBASE-21243
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 2.0.0
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Trivial
>  Labels: beginner, beginners, documentaion
> Fix For: 3.0.0
>
> Attachments: HBASE-21243.master.001.patch, 
> HBASE-21243.master.002.patch
>
>
> Correct the java-doc for the method {{RpcServer.getRemoteAddress()}}.
>  Currently it look like as below:
> {code:java}
>   /**
>* @return Address of remote client if a request is ongoing, else null
>*/
>   public static Optional getRemoteAddress() {
> return getCurrentCall().map(RpcCall::getRemoteAddress);
>   }
> {code}
> Contrary to the doc the method will never return null. Rather it may return 
> an empty Optional.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-21243) Correct java-doc for the method RpcServer.getRemoteAddress()

2018-10-08 Thread Nihal Jain (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-21243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nihal Jain updated HBASE-21243:
---
Fix Version/s: 3.0.0
   Status: Patch Available  (was: In Progress)

> Correct java-doc for the method RpcServer.getRemoteAddress()
> 
>
> Key: HBASE-21243
> URL: https://issues.apache.org/jira/browse/HBASE-21243
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 2.0.0, 3.0.0
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Trivial
>  Labels: beginner, beginners, documentaion
> Fix For: 3.0.0
>
> Attachments: HBASE-21243.master.001.patch
>
>
> Correct the java-doc for the method {{RpcServer.getRemoteAddress()}}.
>  Currently it look like as below:
> {code:java}
>   /**
>* @return Address of remote client if a request is ongoing, else null
>*/
>   public static Optional getRemoteAddress() {
> return getCurrentCall().map(RpcCall::getRemoteAddress);
>   }
> {code}
> Contrary to the doc the method will never return null. Rather it may return 
> an empty Optional.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-21243) Correct java-doc for the method RpcServer.getRemoteAddress()

2018-10-08 Thread Nihal Jain (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-21243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nihal Jain updated HBASE-21243:
---
Attachment: HBASE-21243.master.001.patch

> Correct java-doc for the method RpcServer.getRemoteAddress()
> 
>
> Key: HBASE-21243
> URL: https://issues.apache.org/jira/browse/HBASE-21243
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 2.0.0
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Trivial
>  Labels: beginner, beginners, documentaion
> Attachments: HBASE-21243.master.001.patch
>
>
> Correct the java-doc for the method {{RpcServer.getRemoteAddress()}}.
>  Currently it look like as below:
> {code:java}
>   /**
>* @return Address of remote client if a request is ongoing, else null
>*/
>   public static Optional getRemoteAddress() {
> return getCurrentCall().map(RpcCall::getRemoteAddress);
>   }
> {code}
> Contrary to the doc the method will never return null. Rather it may return 
> an empty Optional.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)