[jira] [Updated] (HBASE-21492) CellCodec Written To WAL Before It's Verified
[ https://issues.apache.org/jira/browse/HBASE-21492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-21492: Fix Version/s: (was: 1.5.0) > CellCodec Written To WAL Before It's Verified > - > > Key: HBASE-21492 > URL: https://issues.apache.org/jira/browse/HBASE-21492 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 1.2.7, 2.0.2 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Critical > Fix For: 3.0.0, 2.2.0, 2.1.2, 1.2.10, 2.0.4, 1.4.10, 1.3.4 > > Attachments: HBASE-21492-branch-1.patch, HBASE-21492.1.patch, > HBASE-21492.2.patch, HBASE-21492.2.patch > > > The cell codec class name is written into the WAL file, but the cell codec > class is not actually verified to exist. Therefore, users can inadvertently > configure an invalid class name and it will be recorded into the WAL file. > At that point, the WAL file becomes unreadable and blocks processing of all > other WAL files. > {code:java|title=AbstractProtobufLogWriter.java} > private WALHeader buildWALHeader0(Configuration conf, WALHeader.Builder > builder) { > if (!builder.hasWriterClsName()) { > builder.setWriterClsName(getWriterClassName()); > } > if (!builder.hasCellCodecClsName()) { > builder.setCellCodecClsName(WALCellCodec.getWALCellCodecClass(conf)); > } > return builder.build(); > } > {code} > https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractProtobufLogWriter.java#L78-L86 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-21492) CellCodec Written To WAL Before It's Verified
[ https://issues.apache.org/jira/browse/HBASE-21492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Liu updated HBASE-21492: Fix Version/s: 1.3.4 > CellCodec Written To WAL Before It's Verified > - > > Key: HBASE-21492 > URL: https://issues.apache.org/jira/browse/HBASE-21492 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 1.2.7, 2.0.2 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Critical > Fix For: 3.0.0, 1.5.0, 2.2.0, 2.1.2, 1.2.10, 2.0.4, 1.4.10, 1.3.4 > > Attachments: HBASE-21492-branch-1.patch, HBASE-21492.1.patch, > HBASE-21492.2.patch, HBASE-21492.2.patch > > > The cell codec class name is written into the WAL file, but the cell codec > class is not actually verified to exist. Therefore, users can inadvertently > configure an invalid class name and it will be recorded into the WAL file. > At that point, the WAL file becomes unreadable and blocks processing of all > other WAL files. > {code:java|title=AbstractProtobufLogWriter.java} > private WALHeader buildWALHeader0(Configuration conf, WALHeader.Builder > builder) { > if (!builder.hasWriterClsName()) { > builder.setWriterClsName(getWriterClassName()); > } > if (!builder.hasCellCodecClsName()) { > builder.setCellCodecClsName(WALCellCodec.getWALCellCodecClass(conf)); > } > return builder.build(); > } > {code} > https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractProtobufLogWriter.java#L78-L86 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21492) CellCodec Written To WAL Before It's Verified
[ https://issues.apache.org/jira/browse/HBASE-21492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Li updated HBASE-21492: -- Hadoop Flags: Incompatible change,Reviewed (was: Reviewed) Release Note: After HBASE-21492 the return type of WALCellCodec#getWALCellCodecClass has been changed from String to Class > CellCodec Written To WAL Before It's Verified > - > > Key: HBASE-21492 > URL: https://issues.apache.org/jira/browse/HBASE-21492 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 1.2.7, 2.0.2 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Critical > Fix For: 3.0.0, 1.5.0, 2.2.0, 2.1.2, 1.2.10, 2.0.4, 1.4.10 > > Attachments: HBASE-21492-branch-1.patch, HBASE-21492.1.patch, > HBASE-21492.2.patch, HBASE-21492.2.patch > > > The cell codec class name is written into the WAL file, but the cell codec > class is not actually verified to exist. Therefore, users can inadvertently > configure an invalid class name and it will be recorded into the WAL file. > At that point, the WAL file becomes unreadable and blocks processing of all > other WAL files. > {code:java|title=AbstractProtobufLogWriter.java} > private WALHeader buildWALHeader0(Configuration conf, WALHeader.Builder > builder) { > if (!builder.hasWriterClsName()) { > builder.setWriterClsName(getWriterClassName()); > } > if (!builder.hasCellCodecClsName()) { > builder.setCellCodecClsName(WALCellCodec.getWALCellCodecClass(conf)); > } > return builder.build(); > } > {code} > https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractProtobufLogWriter.java#L78-L86 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21492) CellCodec Written To WAL Before It's Verified
[ https://issues.apache.org/jira/browse/HBASE-21492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-21492: Fix Version/s: 1.2.10 > CellCodec Written To WAL Before It's Verified > - > > Key: HBASE-21492 > URL: https://issues.apache.org/jira/browse/HBASE-21492 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 1.2.7, 2.0.2 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Critical > Fix For: 3.0.0, 1.5.0, 2.2.0, 2.1.2, 1.2.10, 2.0.4, 1.4.10 > > Attachments: HBASE-21492-branch-1.patch, HBASE-21492.1.patch, > HBASE-21492.2.patch, HBASE-21492.2.patch > > > The cell codec class name is written into the WAL file, but the cell codec > class is not actually verified to exist. Therefore, users can inadvertently > configure an invalid class name and it will be recorded into the WAL file. > At that point, the WAL file becomes unreadable and blocks processing of all > other WAL files. > {code:java|title=AbstractProtobufLogWriter.java} > private WALHeader buildWALHeader0(Configuration conf, WALHeader.Builder > builder) { > if (!builder.hasWriterClsName()) { > builder.setWriterClsName(getWriterClassName()); > } > if (!builder.hasCellCodecClsName()) { > builder.setCellCodecClsName(WALCellCodec.getWALCellCodecClass(conf)); > } > return builder.build(); > } > {code} > https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractProtobufLogWriter.java#L78-L86 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21492) CellCodec Written To WAL Before It's Verified
[ https://issues.apache.org/jira/browse/HBASE-21492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-21492: --- Fix Version/s: 1.4.10 1.5.0 > CellCodec Written To WAL Before It's Verified > - > > Key: HBASE-21492 > URL: https://issues.apache.org/jira/browse/HBASE-21492 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 1.2.7, 2.0.2 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Critical > Fix For: 3.0.0, 1.5.0, 2.2.0, 2.1.2, 2.0.4, 1.4.10 > > Attachments: HBASE-21492-branch-1.patch, HBASE-21492.1.patch, > HBASE-21492.2.patch, HBASE-21492.2.patch > > > The cell codec class name is written into the WAL file, but the cell codec > class is not actually verified to exist. Therefore, users can inadvertently > configure an invalid class name and it will be recorded into the WAL file. > At that point, the WAL file becomes unreadable and blocks processing of all > other WAL files. > {code:java|title=AbstractProtobufLogWriter.java} > private WALHeader buildWALHeader0(Configuration conf, WALHeader.Builder > builder) { > if (!builder.hasWriterClsName()) { > builder.setWriterClsName(getWriterClassName()); > } > if (!builder.hasCellCodecClsName()) { > builder.setCellCodecClsName(WALCellCodec.getWALCellCodecClass(conf)); > } > return builder.build(); > } > {code} > https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractProtobufLogWriter.java#L78-L86 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21492) CellCodec Written To WAL Before It's Verified
[ https://issues.apache.org/jira/browse/HBASE-21492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-21492: --- Attachment: HBASE-21492-branch-1.patch > CellCodec Written To WAL Before It's Verified > - > > Key: HBASE-21492 > URL: https://issues.apache.org/jira/browse/HBASE-21492 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 1.2.7, 2.0.2 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Critical > Fix For: 3.0.0, 1.5.0, 2.2.0, 2.1.2, 2.0.4, 1.4.10 > > Attachments: HBASE-21492-branch-1.patch, HBASE-21492.1.patch, > HBASE-21492.2.patch, HBASE-21492.2.patch > > > The cell codec class name is written into the WAL file, but the cell codec > class is not actually verified to exist. Therefore, users can inadvertently > configure an invalid class name and it will be recorded into the WAL file. > At that point, the WAL file becomes unreadable and blocks processing of all > other WAL files. > {code:java|title=AbstractProtobufLogWriter.java} > private WALHeader buildWALHeader0(Configuration conf, WALHeader.Builder > builder) { > if (!builder.hasWriterClsName()) { > builder.setWriterClsName(getWriterClassName()); > } > if (!builder.hasCellCodecClsName()) { > builder.setCellCodecClsName(WALCellCodec.getWALCellCodecClass(conf)); > } > return builder.build(); > } > {code} > https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractProtobufLogWriter.java#L78-L86 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21492) CellCodec Written To WAL Before It's Verified
[ https://issues.apache.org/jira/browse/HBASE-21492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-21492: -- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.0.4 2.1.2 2.2.0 3.0.0 Status: Resolved (was: Patch Available) Pushed to branch-2.0+. Thanks for the patch [~belugabehr] (I tried backporting to branch-1 but conflicts so let it be). > CellCodec Written To WAL Before It's Verified > - > > Key: HBASE-21492 > URL: https://issues.apache.org/jira/browse/HBASE-21492 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 1.2.7, 2.0.2 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Critical > Fix For: 3.0.0, 2.2.0, 2.1.2, 2.0.4 > > Attachments: HBASE-21492.1.patch, HBASE-21492.2.patch, > HBASE-21492.2.patch > > > The cell codec class name is written into the WAL file, but the cell codec > class is not actually verified to exist. Therefore, users can inadvertently > configure an invalid class name and it will be recorded into the WAL file. > At that point, the WAL file becomes unreadable and blocks processing of all > other WAL files. > {code:java|title=AbstractProtobufLogWriter.java} > private WALHeader buildWALHeader0(Configuration conf, WALHeader.Builder > builder) { > if (!builder.hasWriterClsName()) { > builder.setWriterClsName(getWriterClassName()); > } > if (!builder.hasCellCodecClsName()) { > builder.setCellCodecClsName(WALCellCodec.getWALCellCodecClass(conf)); > } > return builder.build(); > } > {code} > https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractProtobufLogWriter.java#L78-L86 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21492) CellCodec Written To WAL Before It's Verified
[ https://issues.apache.org/jira/browse/HBASE-21492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-21492: -- Attachment: HBASE-21492.2.patch > CellCodec Written To WAL Before It's Verified > - > > Key: HBASE-21492 > URL: https://issues.apache.org/jira/browse/HBASE-21492 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 1.2.7, 2.0.2 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Critical > Attachments: HBASE-21492.1.patch, HBASE-21492.2.patch, > HBASE-21492.2.patch > > > The cell codec class name is written into the WAL file, but the cell codec > class is not actually verified to exist. Therefore, users can inadvertently > configure an invalid class name and it will be recorded into the WAL file. > At that point, the WAL file becomes unreadable and blocks processing of all > other WAL files. > {code:java|title=AbstractProtobufLogWriter.java} > private WALHeader buildWALHeader0(Configuration conf, WALHeader.Builder > builder) { > if (!builder.hasWriterClsName()) { > builder.setWriterClsName(getWriterClassName()); > } > if (!builder.hasCellCodecClsName()) { > builder.setCellCodecClsName(WALCellCodec.getWALCellCodecClass(conf)); > } > return builder.build(); > } > {code} > https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractProtobufLogWriter.java#L78-L86 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21492) CellCodec Written To WAL Before It's Verified
[ https://issues.apache.org/jira/browse/HBASE-21492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HBASE-21492: Status: Patch Available (was: Open) > CellCodec Written To WAL Before It's Verified > - > > Key: HBASE-21492 > URL: https://issues.apache.org/jira/browse/HBASE-21492 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 2.0.2, 1.2.7 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Critical > Attachments: HBASE-21492.1.patch, HBASE-21492.2.patch > > > The cell codec class name is written into the WAL file, but the cell codec > class is not actually verified to exist. Therefore, users can inadvertently > configure an invalid class name and it will be recorded into the WAL file. > At that point, the WAL file becomes unreadable and blocks processing of all > other WAL files. > {code:java|title=AbstractProtobufLogWriter.java} > private WALHeader buildWALHeader0(Configuration conf, WALHeader.Builder > builder) { > if (!builder.hasWriterClsName()) { > builder.setWriterClsName(getWriterClassName()); > } > if (!builder.hasCellCodecClsName()) { > builder.setCellCodecClsName(WALCellCodec.getWALCellCodecClass(conf)); > } > return builder.build(); > } > {code} > https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractProtobufLogWriter.java#L78-L86 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21492) CellCodec Written To WAL Before It's Verified
[ https://issues.apache.org/jira/browse/HBASE-21492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HBASE-21492: Status: Open (was: Patch Available) > CellCodec Written To WAL Before It's Verified > - > > Key: HBASE-21492 > URL: https://issues.apache.org/jira/browse/HBASE-21492 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 2.0.2, 1.2.7 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Critical > Attachments: HBASE-21492.1.patch > > > The cell codec class name is written into the WAL file, but the cell codec > class is not actually verified to exist. Therefore, users can inadvertently > configure an invalid class name and it will be recorded into the WAL file. > At that point, the WAL file becomes unreadable and blocks processing of all > other WAL files. > {code:java|title=AbstractProtobufLogWriter.java} > private WALHeader buildWALHeader0(Configuration conf, WALHeader.Builder > builder) { > if (!builder.hasWriterClsName()) { > builder.setWriterClsName(getWriterClassName()); > } > if (!builder.hasCellCodecClsName()) { > builder.setCellCodecClsName(WALCellCodec.getWALCellCodecClass(conf)); > } > return builder.build(); > } > {code} > https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractProtobufLogWriter.java#L78-L86 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21492) CellCodec Written To WAL Before It's Verified
[ https://issues.apache.org/jira/browse/HBASE-21492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HBASE-21492: Attachment: HBASE-21492.2.patch > CellCodec Written To WAL Before It's Verified > - > > Key: HBASE-21492 > URL: https://issues.apache.org/jira/browse/HBASE-21492 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 1.2.7, 2.0.2 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Critical > Attachments: HBASE-21492.1.patch, HBASE-21492.2.patch > > > The cell codec class name is written into the WAL file, but the cell codec > class is not actually verified to exist. Therefore, users can inadvertently > configure an invalid class name and it will be recorded into the WAL file. > At that point, the WAL file becomes unreadable and blocks processing of all > other WAL files. > {code:java|title=AbstractProtobufLogWriter.java} > private WALHeader buildWALHeader0(Configuration conf, WALHeader.Builder > builder) { > if (!builder.hasWriterClsName()) { > builder.setWriterClsName(getWriterClassName()); > } > if (!builder.hasCellCodecClsName()) { > builder.setCellCodecClsName(WALCellCodec.getWALCellCodecClass(conf)); > } > return builder.build(); > } > {code} > https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractProtobufLogWriter.java#L78-L86 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21492) CellCodec Written To WAL Before It's Verified
[ https://issues.apache.org/jira/browse/HBASE-21492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HBASE-21492: Attachment: (was: HBASE-21492.2.patch) > CellCodec Written To WAL Before It's Verified > - > > Key: HBASE-21492 > URL: https://issues.apache.org/jira/browse/HBASE-21492 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 1.2.7, 2.0.2 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Critical > Attachments: HBASE-21492.1.patch > > > The cell codec class name is written into the WAL file, but the cell codec > class is not actually verified to exist. Therefore, users can inadvertently > configure an invalid class name and it will be recorded into the WAL file. > At that point, the WAL file becomes unreadable and blocks processing of all > other WAL files. > {code:java|title=AbstractProtobufLogWriter.java} > private WALHeader buildWALHeader0(Configuration conf, WALHeader.Builder > builder) { > if (!builder.hasWriterClsName()) { > builder.setWriterClsName(getWriterClassName()); > } > if (!builder.hasCellCodecClsName()) { > builder.setCellCodecClsName(WALCellCodec.getWALCellCodecClass(conf)); > } > return builder.build(); > } > {code} > https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractProtobufLogWriter.java#L78-L86 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21492) CellCodec Written To WAL Before It's Verified
[ https://issues.apache.org/jira/browse/HBASE-21492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HBASE-21492: Attachment: HBASE-21492.2.patch > CellCodec Written To WAL Before It's Verified > - > > Key: HBASE-21492 > URL: https://issues.apache.org/jira/browse/HBASE-21492 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 1.2.7, 2.0.2 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Critical > Attachments: HBASE-21492.1.patch, HBASE-21492.2.patch > > > The cell codec class name is written into the WAL file, but the cell codec > class is not actually verified to exist. Therefore, users can inadvertently > configure an invalid class name and it will be recorded into the WAL file. > At that point, the WAL file becomes unreadable and blocks processing of all > other WAL files. > {code:java|title=AbstractProtobufLogWriter.java} > private WALHeader buildWALHeader0(Configuration conf, WALHeader.Builder > builder) { > if (!builder.hasWriterClsName()) { > builder.setWriterClsName(getWriterClassName()); > } > if (!builder.hasCellCodecClsName()) { > builder.setCellCodecClsName(WALCellCodec.getWALCellCodecClass(conf)); > } > return builder.build(); > } > {code} > https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractProtobufLogWriter.java#L78-L86 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21492) CellCodec Written To WAL Before It's Verified
[ https://issues.apache.org/jira/browse/HBASE-21492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HBASE-21492: Status: Open (was: Patch Available) > CellCodec Written To WAL Before It's Verified > - > > Key: HBASE-21492 > URL: https://issues.apache.org/jira/browse/HBASE-21492 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 2.0.2, 1.2.7 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Critical > Attachments: HBASE-21492.1.patch, HBASE-21492.2.patch > > > The cell codec class name is written into the WAL file, but the cell codec > class is not actually verified to exist. Therefore, users can inadvertently > configure an invalid class name and it will be recorded into the WAL file. > At that point, the WAL file becomes unreadable and blocks processing of all > other WAL files. > {code:java|title=AbstractProtobufLogWriter.java} > private WALHeader buildWALHeader0(Configuration conf, WALHeader.Builder > builder) { > if (!builder.hasWriterClsName()) { > builder.setWriterClsName(getWriterClassName()); > } > if (!builder.hasCellCodecClsName()) { > builder.setCellCodecClsName(WALCellCodec.getWALCellCodecClass(conf)); > } > return builder.build(); > } > {code} > https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractProtobufLogWriter.java#L78-L86 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21492) CellCodec Written To WAL Before It's Verified
[ https://issues.apache.org/jira/browse/HBASE-21492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HBASE-21492: Status: Patch Available (was: Open) > CellCodec Written To WAL Before It's Verified > - > > Key: HBASE-21492 > URL: https://issues.apache.org/jira/browse/HBASE-21492 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 2.0.2, 1.2.7 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Critical > Attachments: HBASE-21492.1.patch, HBASE-21492.2.patch > > > The cell codec class name is written into the WAL file, but the cell codec > class is not actually verified to exist. Therefore, users can inadvertently > configure an invalid class name and it will be recorded into the WAL file. > At that point, the WAL file becomes unreadable and blocks processing of all > other WAL files. > {code:java|title=AbstractProtobufLogWriter.java} > private WALHeader buildWALHeader0(Configuration conf, WALHeader.Builder > builder) { > if (!builder.hasWriterClsName()) { > builder.setWriterClsName(getWriterClassName()); > } > if (!builder.hasCellCodecClsName()) { > builder.setCellCodecClsName(WALCellCodec.getWALCellCodecClass(conf)); > } > return builder.build(); > } > {code} > https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractProtobufLogWriter.java#L78-L86 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21492) CellCodec Written To WAL Before It's Verified
[ https://issues.apache.org/jira/browse/HBASE-21492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HBASE-21492: Status: Patch Available (was: Open) > CellCodec Written To WAL Before It's Verified > - > > Key: HBASE-21492 > URL: https://issues.apache.org/jira/browse/HBASE-21492 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 2.0.2, 1.2.7 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Critical > Attachments: HBASE-21492.1.patch > > > The cell codec class name is written into the WAL file, but the cell codec > class is not actually verified to exist. Therefore, users can inadvertently > configure an invalid class name and it will be recorded into the WAL file. > At that point, the WAL file becomes unreadable and blocks processing of all > other WAL files. > {code:java|title=AbstractProtobufLogWriter.java} > private WALHeader buildWALHeader0(Configuration conf, WALHeader.Builder > builder) { > if (!builder.hasWriterClsName()) { > builder.setWriterClsName(getWriterClassName()); > } > if (!builder.hasCellCodecClsName()) { > builder.setCellCodecClsName(WALCellCodec.getWALCellCodecClass(conf)); > } > return builder.build(); > } > {code} > https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractProtobufLogWriter.java#L78-L86 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21492) CellCodec Written To WAL Before It's Verified
[ https://issues.apache.org/jira/browse/HBASE-21492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HBASE-21492: Attachment: HBASE-21492.1.patch > CellCodec Written To WAL Before It's Verified > - > > Key: HBASE-21492 > URL: https://issues.apache.org/jira/browse/HBASE-21492 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 1.2.7, 2.0.2 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Critical > Attachments: HBASE-21492.1.patch > > > The cell codec class name is written into the WAL file, but the cell codec > class is not actually verified to exist. Therefore, users can inadvertently > configure an invalid class name and it will be recorded into the WAL file. > At that point, the WAL file becomes unreadable and blocks processing of all > other WAL files. > {code:java|title=AbstractProtobufLogWriter.java} > private WALHeader buildWALHeader0(Configuration conf, WALHeader.Builder > builder) { > if (!builder.hasWriterClsName()) { > builder.setWriterClsName(getWriterClassName()); > } > if (!builder.hasCellCodecClsName()) { > builder.setCellCodecClsName(WALCellCodec.getWALCellCodecClass(conf)); > } > return builder.build(); > } > {code} > https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractProtobufLogWriter.java#L78-L86 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21492) CellCodec Written To WAL Before It's Verified
[ https://issues.apache.org/jira/browse/HBASE-21492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-21492: Priority: Critical (was: Major) > CellCodec Written To WAL Before It's Verified > - > > Key: HBASE-21492 > URL: https://issues.apache.org/jira/browse/HBASE-21492 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 1.2.7, 2.0.2 >Reporter: BELUGA BEHR >Priority: Critical > > The cell codec class name is written into the WAL file, but the cell codec > class is not actually verified to exist. Therefore, users can inadvertently > configure an invalid class name and it will be recorded into the WAL file. > At that point, the WAL file becomes unreadable and blocks processing of all > other WAL files. > {code:java|title=AbstractProtobufLogWriter.java} > private WALHeader buildWALHeader0(Configuration conf, WALHeader.Builder > builder) { > if (!builder.hasWriterClsName()) { > builder.setWriterClsName(getWriterClassName()); > } > if (!builder.hasCellCodecClsName()) { > builder.setCellCodecClsName(WALCellCodec.getWALCellCodecClass(conf)); > } > return builder.build(); > } > {code} > https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractProtobufLogWriter.java#L78-L86 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21492) CellCodec Written To WAL Before It's Verified
[ https://issues.apache.org/jira/browse/HBASE-21492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-21492: Issue Type: Bug (was: Improvement) > CellCodec Written To WAL Before It's Verified > - > > Key: HBASE-21492 > URL: https://issues.apache.org/jira/browse/HBASE-21492 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 1.2.7, 2.0.2 >Reporter: BELUGA BEHR >Priority: Major > > The cell codec class name is written into the WAL file, but the cell codec > class is not actually verified to exist. Therefore, users can inadvertently > configure an invalid class name and it will be recorded into the WAL file. > At that point, the WAL file becomes unreadable and blocks processing of all > other WAL files. > {code:java|title=AbstractProtobufLogWriter.java} > private WALHeader buildWALHeader0(Configuration conf, WALHeader.Builder > builder) { > if (!builder.hasWriterClsName()) { > builder.setWriterClsName(getWriterClassName()); > } > if (!builder.hasCellCodecClsName()) { > builder.setCellCodecClsName(WALCellCodec.getWALCellCodecClass(conf)); > } > return builder.build(); > } > {code} > https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractProtobufLogWriter.java#L78-L86 -- This message was sent by Atlassian JIRA (v7.6.3#76005)