[jira] [Updated] (HBASE-21721) reduce write#syncs() times

[Anoop Sam John (Jira)]

 [ 
https://issues.apache.org/jira/browse/HBASE-21721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anoop Sam John updated HBASE-21721:
---
Fix Version/s: 2.2.6
   2.4.0
   1.7.0
   2.3.1
   3.0.0-alpha-1

> reduce write#syncs() times
> --
>
> Key: HBASE-21721
> URL: https://issues.apache.org/jira/browse/HBASE-21721
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 1.3.1, 2.1.1, master, 2.2.3
>Reporter: Bo Cui
>Assignee: Bo Cui
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.1, 1.7.0, 2.4.0, 2.2.6
>
>
> the number of write#syncs can be reduced by updating the 
> highestUnsyncedSequence：
> before write#sync(), get the current highestUnsyncedSequence 
> after write#sync, highestSyncedSequence=highestUnsyncedSequence
>  
> {code:title=FSHLog.java|borderStyle=solid}
> // Some comments here
> public void run()
> {
> long currentSequence;
>   while (!isInterrupted()) {
> int syncCount = 0;
> try {
>   while (true) {
> ...
>   try {
> Trace.addTimelineAnnotation("syncing writer");
> long unSyncedFlushSeq = highestUnsyncedSequence;
> writer.sync();
> Trace.addTimelineAnnotation("writer synced");
> if( unSyncedFlushSeq > currentSequence ) currentSequence = 
> unSyncedFlushSeq;
> currentSequence = updateHighestSyncedSequence(currentSequence);
>   } catch (IOException e) {
> LOG.error("Error syncing, request close of WAL", e);
> lastException = e;
>   } catch (Exception e) {
>...
> }
> }
> {code}
> Add code
>  long unSyncedFlushSeq = highestUnsyncedSequence;
>  if( unSyncedFlushSeq > currentSequence ) currentSequence = unSyncedFlushSeq;



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HBASE-21721) reduce write#syncs() times

[Bo Cui (Jira)]

 [ 
https://issues.apache.org/jira/browse/HBASE-21721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bo Cui updated HBASE-21721:
---
Affects Version/s: master
   2.2.3

> reduce write#syncs() times
> --
>
> Key: HBASE-21721
> URL: https://issues.apache.org/jira/browse/HBASE-21721
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 1.3.1, 2.1.1, master, 2.2.3
>Reporter: Bo Cui
>Priority: Major
>
> the number of write#syncs can be reduced by updating the 
> highestUnsyncedSequence：
> before write#sync(), get the current highestUnsyncedSequence 
> after write#sync, highestSyncedSequence=highestUnsyncedSequence
>  
> {code:title=FSHLog.java|borderStyle=solid}
> // Some comments here
> public void run()
> {
> long currentSequence;
>   while (!isInterrupted()) {
> int syncCount = 0;
> try {
>   while (true) {
> ...
>   try {
> Trace.addTimelineAnnotation("syncing writer");
> long unSyncedFlushSeq = highestUnsyncedSequence;
> writer.sync();
> Trace.addTimelineAnnotation("writer synced");
> if( unSyncedFlushSeq > currentSequence ) currentSequence = 
> unSyncedFlushSeq;
> currentSequence = updateHighestSyncedSequence(currentSequence);
>   } catch (IOException e) {
> LOG.error("Error syncing, request close of WAL", e);
> lastException = e;
>   } catch (Exception e) {
>...
> }
> }
> {code}
> Add code
>  long unSyncedFlushSeq = highestUnsyncedSequence;
>  if( unSyncedFlushSeq > currentSequence ) currentSequence = unSyncedFlushSeq;



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HBASE-21721) reduce write#syncs() times

[Bo Cui (Jira)]

 [ 
https://issues.apache.org/jira/browse/HBASE-21721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bo Cui updated HBASE-21721:
---
Status: Patch Available  (was: Open)

> reduce write#syncs() times
> --
>
> Key: HBASE-21721
> URL: https://issues.apache.org/jira/browse/HBASE-21721
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 2.1.1, 1.3.1
>Reporter: Bo Cui
>Priority: Major
>
> the number of write#syncs can be reduced by updating the 
> highestUnsyncedSequence：
> before write#sync(), get the current highestUnsyncedSequence 
> after write#sync, highestSyncedSequence=highestUnsyncedSequence
>  
> {code:title=FSHLog.java|borderStyle=solid}
> // Some comments here
> public void run()
> {
> long currentSequence;
>   while (!isInterrupted()) {
> int syncCount = 0;
> try {
>   while (true) {
> ...
>   try {
> Trace.addTimelineAnnotation("syncing writer");
> long unSyncedFlushSeq = highestUnsyncedSequence;
> writer.sync();
> Trace.addTimelineAnnotation("writer synced");
> if( unSyncedFlushSeq > currentSequence ) currentSequence = 
> unSyncedFlushSeq;
> currentSequence = updateHighestSyncedSequence(currentSequence);
>   } catch (IOException e) {
> LOG.error("Error syncing, request close of WAL", e);
> lastException = e;
>   } catch (Exception e) {
>...
> }
> }
> {code}
> Add code
>  long unSyncedFlushSeq = highestUnsyncedSequence;
>  if( unSyncedFlushSeq > currentSequence ) currentSequence = unSyncedFlushSeq;



--
This message was sent by Atlassian Jira
(v8.3.4#803005)