[jira] [Updated] (HBASE-24805) HBaseTestingUtility.getConnection should be threadsafe

2020-08-04 Thread Sean Busbey (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-24805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-24805:

Fix Version/s: 2.4.0
   1.7.0
   3.0.0-alpha-1
 Hadoop Flags: Incompatible change
 Release Note: 

Users of `HBaseTestingUtility` can now safely call the `getConnection` method 
from multiple threads.

As a consequence of refactoring to improve the thread safety of the HBase 
testing classes, the protected `conf` member of the  
`HBaseCommonTestingUtility` class has been marked final. Downstream users who 
extend from the class hierarchy rooted at this class will need to pass the 
Configuration instance they want used to their super constructor rather than 
overwriting the instance variable.
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

> HBaseTestingUtility.getConnection should be threadsafe
> --
>
> Key: HBASE-24805
> URL: https://issues.apache.org/jira/browse/HBASE-24805
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.4.0
>
>
> the current javadoc for getConnection carries a thread safety warning:
> {code}
> /**
> * Get a Connection to the cluster. Not thread-safe (This class needs a 
> lot of work to make it
> * thread-safe).
> * @return A Connection that can be shared. Don't close. Will be closed on 
> shutdown of cluster.
> */
>public Connection getConnection() throws IOException {
> {code}
> We then ignore that warning across our test base. We should make the method 
> threadsafe since the intention is to share a single Connection across all 
> users of the HTU instance.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HBASE-24805) HBaseTestingUtility.getConnection should be threadsafe

2020-07-31 Thread Sean Busbey (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-24805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-24805:

Status: Patch Available  (was: Open)

> HBaseTestingUtility.getConnection should be threadsafe
> --
>
> Key: HBASE-24805
> URL: https://issues.apache.org/jira/browse/HBASE-24805
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
>
> the current javadoc for getConnection carries a thread safety warning:
> {code}
> /**
> * Get a Connection to the cluster. Not thread-safe (This class needs a 
> lot of work to make it
> * thread-safe).
> * @return A Connection that can be shared. Don't close. Will be closed on 
> shutdown of cluster.
> */
>public Connection getConnection() throws IOException {
> {code}
> We then ignore that warning across our test base. We should make the method 
> threadsafe since the intention is to share a single Connection across all 
> users of the HTU instance.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)