[jira] [Updated] (HBASE-4206) jenkins hash implementation uses longs unnecessarily
[ https://issues.apache.org/jira/browse/HBASE-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-4206: - Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) Thank you for the nice patch Ron. Applied TRUNK. > jenkins hash implementation uses longs unnecessarily > > > Key: HBASE-4206 > URL: https://issues.apache.org/jira/browse/HBASE-4206 > Project: HBase > Issue Type: Improvement > Components: util >Affects Versions: 0.90.4 >Reporter: Ron Yang >Assignee: Ron Yang >Priority: Minor > Fix For: 0.92.0, 0.90.5 > > Attachments: JenkinsHashTest.tgz, ryang.patch > > > I don't believe you need to use long for a,b,c and as a result no longer need > to & against INT_MASK. > At a minimum the private static longs should be made final, and the "main" > method should not print the absolute value of the hash but instead use > something like Integer.toHexString -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4206) jenkins hash implementation uses longs unnecessarily
[ https://issues.apache.org/jira/browse/HBASE-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Yang updated HBASE-4206: Attachment: JenkinsHashTest.tgz eclipse project with my tests that try to verify the changes didn't regress JenkinsHash > jenkins hash implementation uses longs unnecessarily > > > Key: HBASE-4206 > URL: https://issues.apache.org/jira/browse/HBASE-4206 > Project: HBase > Issue Type: Improvement > Components: util >Affects Versions: 0.90.4 >Reporter: Ron Yang >Assignee: Ron Yang >Priority: Minor > Fix For: 0.92.0, 0.90.5 > > Attachments: JenkinsHashTest.tgz, ryang.patch > > > I don't believe you need to use long for a,b,c and as a result no longer need > to & against INT_MASK. > At a minimum the private static longs should be made final, and the "main" > method should not print the absolute value of the hash but instead use > something like Integer.toHexString -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4206) jenkins hash implementation uses longs unnecessarily
[ https://issues.apache.org/jira/browse/HBASE-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Yang updated HBASE-4206: Affects Version/s: 0.90.4 Fix Version/s: 0.90.5 0.92.0 > jenkins hash implementation uses longs unnecessarily > > > Key: HBASE-4206 > URL: https://issues.apache.org/jira/browse/HBASE-4206 > Project: HBase > Issue Type: Improvement > Components: util >Affects Versions: 0.90.4 >Reporter: Ron Yang >Priority: Minor > Fix For: 0.92.0, 0.90.5 > > Attachments: ryang.patch > > > I don't believe you need to use long for a,b,c and as a result no longer need > to & against INT_MASK. > At a minimum the private static longs should be made final, and the "main" > method should not print the absolute value of the hash but instead use > something like Integer.toHexString -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4206) jenkins hash implementation uses longs unnecessarily
[ https://issues.apache.org/jira/browse/HBASE-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Yang updated HBASE-4206: Attachment: ryang.patch > jenkins hash implementation uses longs unnecessarily > > > Key: HBASE-4206 > URL: https://issues.apache.org/jira/browse/HBASE-4206 > Project: HBase > Issue Type: Improvement > Components: util >Reporter: Ron Yang >Priority: Minor > Attachments: ryang.patch > > > I don't believe you need to use long for a,b,c and as a result no longer need > to & against INT_MASK. > At a minimum the private static longs should be made final, and the "main" > method should not print the absolute value of the hash but instead use > something like Integer.toHexString -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4206) jenkins hash implementation uses longs unnecessarily
[ https://issues.apache.org/jira/browse/HBASE-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Yang updated HBASE-4206: Status: Patch Available (was: Open) > jenkins hash implementation uses longs unnecessarily > > > Key: HBASE-4206 > URL: https://issues.apache.org/jira/browse/HBASE-4206 > Project: HBase > Issue Type: Improvement > Components: util >Reporter: Ron Yang >Priority: Minor > > I don't believe you need to use long for a,b,c and as a result no longer need > to & against INT_MASK. > At a minimum the private static longs should be made final, and the "main" > method should not print the absolute value of the hash but instead use > something like Integer.toHexString -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
