[jira] [Updated] (HBASE-5257) Allow filter to be evaluated after version handling
[
https://issues.apache.org/jira/browse/HBASE-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Sharma updated HBASE-5257:
Attachment: HBASE-5257-0.92.txt
Attached patch passed unittests for Hbase 0.92 - hbase 0.95-snapshot will need
a different patch.
Allow filter to be evaluated after version handling
---
Key: HBASE-5257
URL: https://issues.apache.org/jira/browse/HBASE-5257
Project: HBase
Issue Type: Improvement
Reporter: Lars Hofhansl
Attachments: HBASE-5257-0.92.txt
There are various usecases and filter types where evaluating the filter
before version are handled either do not make sense, or make filter handling
more complicated.
Also see this comment in ScanQueryMatcher:
{code}
/**
* Filters should be checked before checking column trackers. If we do
* otherwise, as was previously being done, ColumnTracker may increment
its
* counter for even that KV which may be discarded later on by Filter.
This
* would lead to incorrect results in certain cases.
*/
{code}
So we had Filters after the column trackers (which do the version checking),
and then moved it.
Should be at the discretion of the Filter.
Could either add a new method to FilterBase (maybe excludeVersions() or
something). Or have a new Filter wrapper (like WhileMatchFilter), that should
only be used as outmost filter and indicates the same (maybe
ExcludeVersionsFilter).
See latest comments on HBASE-5229 for motivation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5257) Allow filter to be evaluated after version handling
[
https://issues.apache.org/jira/browse/HBASE-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-5257:
--
Attachment: 5257-trunk.txt
Patch for trunk.
TestColumnPaginationFilter, TestFilter and TestFilterList passed.
Allow filter to be evaluated after version handling
---
Key: HBASE-5257
URL: https://issues.apache.org/jira/browse/HBASE-5257
Project: HBase
Issue Type: Improvement
Reporter: Lars Hofhansl
Fix For: 0.96.0
Attachments: 5257-trunk.txt, HBASE-5257-0.92.txt
There are various usecases and filter types where evaluating the filter
before version are handled either do not make sense, or make filter handling
more complicated.
Also see this comment in ScanQueryMatcher:
{code}
/**
* Filters should be checked before checking column trackers. If we do
* otherwise, as was previously being done, ColumnTracker may increment
its
* counter for even that KV which may be discarded later on by Filter.
This
* would lead to incorrect results in certain cases.
*/
{code}
So we had Filters after the column trackers (which do the version checking),
and then moved it.
Should be at the discretion of the Filter.
Could either add a new method to FilterBase (maybe excludeVersions() or
something). Or have a new Filter wrapper (like WhileMatchFilter), that should
only be used as outmost filter and indicates the same (maybe
ExcludeVersionsFilter).
See latest comments on HBASE-5229 for motivation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5257) Allow filter to be evaluated after version handling
[
https://issues.apache.org/jira/browse/HBASE-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-5257:
--
Fix Version/s: 0.96.0
Status: Patch Available (was: Reopened)
Allow filter to be evaluated after version handling
---
Key: HBASE-5257
URL: https://issues.apache.org/jira/browse/HBASE-5257
Project: HBase
Issue Type: Improvement
Reporter: Lars Hofhansl
Fix For: 0.96.0
Attachments: 5257-trunk.txt, HBASE-5257-0.92.txt
There are various usecases and filter types where evaluating the filter
before version are handled either do not make sense, or make filter handling
more complicated.
Also see this comment in ScanQueryMatcher:
{code}
/**
* Filters should be checked before checking column trackers. If we do
* otherwise, as was previously being done, ColumnTracker may increment
its
* counter for even that KV which may be discarded later on by Filter.
This
* would lead to incorrect results in certain cases.
*/
{code}
So we had Filters after the column trackers (which do the version checking),
and then moved it.
Should be at the discretion of the Filter.
Could either add a new method to FilterBase (maybe excludeVersions() or
something). Or have a new Filter wrapper (like WhileMatchFilter), that should
only be used as outmost filter and indicates the same (maybe
ExcludeVersionsFilter).
See latest comments on HBASE-5229 for motivation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5257) Allow filter to be evaluated after version handling
[
https://issues.apache.org/jira/browse/HBASE-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Sharma updated HBASE-5257:
Attachment: HBASE-5257-0.94.txt
Patch for 0.94
Allow filter to be evaluated after version handling
---
Key: HBASE-5257
URL: https://issues.apache.org/jira/browse/HBASE-5257
Project: HBase
Issue Type: Improvement
Reporter: Lars Hofhansl
Fix For: 0.96.0
Attachments: 5257-trunk.txt, HBASE-5257-0.92.txt, HBASE-5257-0.94.txt
There are various usecases and filter types where evaluating the filter
before version are handled either do not make sense, or make filter handling
more complicated.
Also see this comment in ScanQueryMatcher:
{code}
/**
* Filters should be checked before checking column trackers. If we do
* otherwise, as was previously being done, ColumnTracker may increment
its
* counter for even that KV which may be discarded later on by Filter.
This
* would lead to incorrect results in certain cases.
*/
{code}
So we had Filters after the column trackers (which do the version checking),
and then moved it.
Should be at the discretion of the Filter.
Could either add a new method to FilterBase (maybe excludeVersions() or
something). Or have a new Filter wrapper (like WhileMatchFilter), that should
only be used as outmost filter and indicates the same (maybe
ExcludeVersionsFilter).
See latest comments on HBASE-5229 for motivation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5257) Allow filter to be evaluated after version handling
[
https://issues.apache.org/jira/browse/HBASE-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Sharma updated HBASE-5257:
Attachment: HBASE-5257-0.92.txt
Corrected patch file in right format for 0.92
Allow filter to be evaluated after version handling
---
Key: HBASE-5257
URL: https://issues.apache.org/jira/browse/HBASE-5257
Project: HBase
Issue Type: Improvement
Reporter: Lars Hofhansl
Fix For: 0.96.0
Attachments: 5257-trunk.txt, HBASE-5257-0.92.txt,
HBASE-5257-0.92.txt, HBASE-5257-0.94.txt, HBASE-5257-0.94.txt
There are various usecases and filter types where evaluating the filter
before version are handled either do not make sense, or make filter handling
more complicated.
Also see this comment in ScanQueryMatcher:
{code}
/**
* Filters should be checked before checking column trackers. If we do
* otherwise, as was previously being done, ColumnTracker may increment
its
* counter for even that KV which may be discarded later on by Filter.
This
* would lead to incorrect results in certain cases.
*/
{code}
So we had Filters after the column trackers (which do the version checking),
and then moved it.
Should be at the discretion of the Filter.
Could either add a new method to FilterBase (maybe excludeVersions() or
something). Or have a new Filter wrapper (like WhileMatchFilter), that should
only be used as outmost filter and indicates the same (maybe
ExcludeVersionsFilter).
See latest comments on HBASE-5229 for motivation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5257) Allow filter to be evaluated after version handling
[
https://issues.apache.org/jira/browse/HBASE-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Sharma updated HBASE-5257:
Attachment: HBASE-5257-0.94.txt
Correctly formatted patch file...
Allow filter to be evaluated after version handling
---
Key: HBASE-5257
URL: https://issues.apache.org/jira/browse/HBASE-5257
Project: HBase
Issue Type: Improvement
Reporter: Lars Hofhansl
Fix For: 0.96.0
Attachments: 5257-trunk.txt, HBASE-5257-0.92.txt,
HBASE-5257-0.92.txt, HBASE-5257-0.94.txt, HBASE-5257-0.94.txt
There are various usecases and filter types where evaluating the filter
before version are handled either do not make sense, or make filter handling
more complicated.
Also see this comment in ScanQueryMatcher:
{code}
/**
* Filters should be checked before checking column trackers. If we do
* otherwise, as was previously being done, ColumnTracker may increment
its
* counter for even that KV which may be discarded later on by Filter.
This
* would lead to incorrect results in certain cases.
*/
{code}
So we had Filters after the column trackers (which do the version checking),
and then moved it.
Should be at the discretion of the Filter.
Could either add a new method to FilterBase (maybe excludeVersions() or
something). Or have a new Filter wrapper (like WhileMatchFilter), that should
only be used as outmost filter and indicates the same (maybe
ExcludeVersionsFilter).
See latest comments on HBASE-5229 for motivation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5257) Allow filter to be evaluated after version handling
[
https://issues.apache.org/jira/browse/HBASE-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lars Hofhansl updated HBASE-5257:
-
Fix Version/s: 0.94.3
I'm good on 0.94.
@Ted: Your call for 0.92
Allow filter to be evaluated after version handling
---
Key: HBASE-5257
URL: https://issues.apache.org/jira/browse/HBASE-5257
Project: HBase
Issue Type: Improvement
Reporter: Lars Hofhansl
Fix For: 0.94.3, 0.96.0
Attachments: 5257-trunk.txt, HBASE-5257-0.92.txt,
HBASE-5257-0.92.txt, HBASE-5257-0.94.txt, HBASE-5257-0.94.txt
There are various usecases and filter types where evaluating the filter
before version are handled either do not make sense, or make filter handling
more complicated.
Also see this comment in ScanQueryMatcher:
{code}
/**
* Filters should be checked before checking column trackers. If we do
* otherwise, as was previously being done, ColumnTracker may increment
its
* counter for even that KV which may be discarded later on by Filter.
This
* would lead to incorrect results in certain cases.
*/
{code}
So we had Filters after the column trackers (which do the version checking),
and then moved it.
Should be at the discretion of the Filter.
Could either add a new method to FilterBase (maybe excludeVersions() or
something). Or have a new Filter wrapper (like WhileMatchFilter), that should
only be used as outmost filter and indicates the same (maybe
ExcludeVersionsFilter).
See latest comments on HBASE-5229 for motivation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
