[jira] [Updated] (HBASE-5330) TestCompactSelection - adding 2 test cases to testCompactionRatio

2012-02-09 Thread Doug Meil (Updated) (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HBASE-5330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doug Meil updated HBASE-5330:
-

Resolution: Fixed
Status: Resolved  (was: Patch Available)

Committing this update to the unit test

> TestCompactSelection - adding 2 test cases to testCompactionRatio
> -
>
> Key: HBASE-5330
> URL: https://issues.apache.org/jira/browse/HBASE-5330
> Project: HBase
>  Issue Type: Improvement
>Reporter: Doug Meil
>Assignee: Doug Meil
>Priority: Minor
> Attachments: TestCompactSelection_hbase_5330.java.patch, 
> TestCompactSelection_hbase_5330_v2.java.patch
>
>
> There were three existing assertions in TestCompactSelection 
> testCompactionRatio that did "max # of files" assertions...
> {code}
> assertEquals(maxFiles,
> 
> store.compactSelection(sfCreate(7,6,5,4,3,2,1)).getFilesToCompact().size());
> {code}
> ... and for references ...
> {code}
>   assertEquals(maxFiles,
> store.compactSelection(sfCreate(true, 
> 7,6,5,4,3,2,1)).getFilesToCompact().size());
> {code}
>  
> ... but they didn't assert against which StoreFiles got selected.  While the 
> number of StoreFiles is the same, the files selected are actually different, 
> and I thought that there should be explicit assertions showing that.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5330) TestCompactSelection - adding 2 test cases to testCompactionRatio

2012-02-09 Thread Doug Meil (Updated) (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HBASE-5330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doug Meil updated HBASE-5330:
-

Attachment: TestCompactSelection_hbase_5330_v2.java.patch

> TestCompactSelection - adding 2 test cases to testCompactionRatio
> -
>
> Key: HBASE-5330
> URL: https://issues.apache.org/jira/browse/HBASE-5330
> Project: HBase
>  Issue Type: Improvement
>Reporter: Doug Meil
>Assignee: Doug Meil
>Priority: Minor
> Attachments: TestCompactSelection_hbase_5330.java.patch, 
> TestCompactSelection_hbase_5330_v2.java.patch
>
>
> There were three existing assertions in TestCompactSelection 
> testCompactionRatio that did "max # of files" assertions...
> {code}
> assertEquals(maxFiles,
> 
> store.compactSelection(sfCreate(7,6,5,4,3,2,1)).getFilesToCompact().size());
> {code}
> ... and for references ...
> {code}
>   assertEquals(maxFiles,
> store.compactSelection(sfCreate(true, 
> 7,6,5,4,3,2,1)).getFilesToCompact().size());
> {code}
>  
> ... but they didn't assert against which StoreFiles got selected.  While the 
> number of StoreFiles is the same, the files selected are actually different, 
> and I thought that there should be explicit assertions showing that.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5330) TestCompactSelection - adding 2 test cases to testCompactionRatio

2012-02-03 Thread Doug Meil (Updated) (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HBASE-5330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doug Meil updated HBASE-5330:
-

Status: Patch Available  (was: Open)

> TestCompactSelection - adding 2 test cases to testCompactionRatio
> -
>
> Key: HBASE-5330
> URL: https://issues.apache.org/jira/browse/HBASE-5330
> Project: HBase
>  Issue Type: Improvement
>Reporter: Doug Meil
>Assignee: Doug Meil
>Priority: Minor
> Attachments: TestCompactSelection_hbase_5330.java.patch
>
>
> There were three existing assertions in TestCompactSelection 
> testCompactionRatio that did "max # of files" assertions...
> {code}
> assertEquals(maxFiles,
> 
> store.compactSelection(sfCreate(7,6,5,4,3,2,1)).getFilesToCompact().size());
> {code}
> ... and for references ...
> {code}
>   assertEquals(maxFiles,
> store.compactSelection(sfCreate(true, 
> 7,6,5,4,3,2,1)).getFilesToCompact().size());
> {code}
>  
> ... but they didn't assert against which StoreFiles got selected.  While the 
> number of StoreFiles is the same, the files selected are actually different, 
> and I thought that there should be explicit assertions showing that.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5330) TestCompactSelection - adding 2 test cases to testCompactionRatio

2012-02-03 Thread Doug Meil (Updated) (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HBASE-5330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doug Meil updated HBASE-5330:
-

Attachment: TestCompactSelection_hbase_5330.java.patch

> TestCompactSelection - adding 2 test cases to testCompactionRatio
> -
>
> Key: HBASE-5330
> URL: https://issues.apache.org/jira/browse/HBASE-5330
> Project: HBase
>  Issue Type: Improvement
>Reporter: Doug Meil
>Assignee: Doug Meil
>Priority: Minor
> Attachments: TestCompactSelection_hbase_5330.java.patch
>
>
> There were three existing assertions in TestCompactSelection 
> testCompactionRatio that did "max # of files" assertions...
> {code}
> assertEquals(maxFiles,
> 
> store.compactSelection(sfCreate(7,6,5,4,3,2,1)).getFilesToCompact().size());
> {code}
> ... and for references ...
> {code}
>   assertEquals(maxFiles,
> store.compactSelection(sfCreate(true, 
> 7,6,5,4,3,2,1)).getFilesToCompact().size());
> {code}
>  
> ... but they didn't assert against which StoreFiles got selected.  While the 
> number of StoreFiles is the same, the files selected are actually different, 
> and I thought that there should be explicit assertions showing that.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5330) TestCompactSelection - adding 2 test cases to testCompactionRatio

2012-02-03 Thread Doug Meil (Updated) (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HBASE-5330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doug Meil updated HBASE-5330:
-

Description: 
There were three existing assertions in TestCompactSelection 
testCompactionRatio that did "max # of files" assertions...
{code}
assertEquals(maxFiles,

store.compactSelection(sfCreate(7,6,5,4,3,2,1)).getFilesToCompact().size());
{code}

... and for references ...

{code}
  assertEquals(maxFiles,
store.compactSelection(sfCreate(true, 
7,6,5,4,3,2,1)).getFilesToCompact().size());
{code}
 
... but they didn't assert against which StoreFiles got selected.  While the 
number of StoreFiles is the same, the files selected are actually different, 
and I thought that there should be explicit assertions showing that.



  was:
There were three existing assertions in the compaction test that did "max # of 
files" assertions...
{code}
assertEquals(maxFiles,

store.compactSelection(sfCreate(7,6,5,4,3,2,1)).getFilesToCompact().size());
{code}

... and for references ...

{code}
  assertEquals(maxFiles,
store.compactSelection(sfCreate(true, 
7,6,5,4,3,2,1)).getFilesToCompact().size());
{code}
 
... but they didn't assert against which StoreFiles got selected.  While the 
number of StoreFiles is the same, the files selected are actually different, 
and I thought that there should be explicit assertions showing that.




> TestCompactSelection - adding 2 test cases to testCompactionRatio
> -
>
> Key: HBASE-5330
> URL: https://issues.apache.org/jira/browse/HBASE-5330
> Project: HBase
>  Issue Type: Improvement
>Reporter: Doug Meil
>Assignee: Doug Meil
>Priority: Minor
>
> There were three existing assertions in TestCompactSelection 
> testCompactionRatio that did "max # of files" assertions...
> {code}
> assertEquals(maxFiles,
> 
> store.compactSelection(sfCreate(7,6,5,4,3,2,1)).getFilesToCompact().size());
> {code}
> ... and for references ...
> {code}
>   assertEquals(maxFiles,
> store.compactSelection(sfCreate(true, 
> 7,6,5,4,3,2,1)).getFilesToCompact().size());
> {code}
>  
> ... but they didn't assert against which StoreFiles got selected.  While the 
> number of StoreFiles is the same, the files selected are actually different, 
> and I thought that there should be explicit assertions showing that.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira