[jira] [Updated] (HBASE-5512) Add support for INCLUDE_AND_SEEK_USING_HINT
[ https://issues.apache.org/jira/browse/HBASE-5512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-5512: - Assignee: (was: Lars Hofhansl) > Add support for INCLUDE_AND_SEEK_USING_HINT > --- > > Key: HBASE-5512 > URL: https://issues.apache.org/jira/browse/HBASE-5512 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu > Attachments: 5512-v2.txt, 5512.txt > > > This came up from HBASE-2038 > From Anoop: > - What we wanted from the filter is include a row and then seek to the next > row which we are interested in. I cant see such a facility with our Filter > right now. Correct me if I am wrong. So suppose we already seeked to one row > and this need to be included in the result, then the Filter should return > INCLUDE. Then when the next next() call happens, then only we can return a > SEEK_USING_HINT. So one extra row reading is needed. This might create even > one unwanted HFileBlock fetch (who knows). > Can we add reseek() at higher level? > From Lars: > Yep, for that we'd need to add INCLUDE_AND_SEEK_USING_HINT (similar to the > INCLUDE_AND_SEEK_NEXT_ROW that we already have). Shouldn't be hard to add, > I'm happy to do that, if that's the route we want to go with this. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-5512) Add support for INCLUDE_AND_SEEK_USING_HINT
[ https://issues.apache.org/jira/browse/HBASE-5512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-5512: - Resolution: Won't Fix Status: Resolved (was: Patch Available) Marking as won't fix, as we now question the usefulnes. > Add support for INCLUDE_AND_SEEK_USING_HINT > --- > > Key: HBASE-5512 > URL: https://issues.apache.org/jira/browse/HBASE-5512 > Project: HBase > Issue Type: Improvement >Reporter: Zhihong Yu >Assignee: Lars Hofhansl > Attachments: 5512-v2.txt, 5512.txt > > > This came up from HBASE-2038 > From Anoop: > - What we wanted from the filter is include a row and then seek to the next > row which we are interested in. I cant see such a facility with our Filter > right now. Correct me if I am wrong. So suppose we already seeked to one row > and this need to be included in the result, then the Filter should return > INCLUDE. Then when the next next() call happens, then only we can return a > SEEK_USING_HINT. So one extra row reading is needed. This might create even > one unwanted HFileBlock fetch (who knows). > Can we add reseek() at higher level? > From Lars: > Yep, for that we'd need to add INCLUDE_AND_SEEK_USING_HINT (similar to the > INCLUDE_AND_SEEK_NEXT_ROW that we already have). Shouldn't be hard to add, > I'm happy to do that, if that's the route we want to go with this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5512) Add support for INCLUDE_AND_SEEK_USING_HINT
[ https://issues.apache.org/jira/browse/HBASE-5512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhihong Yu updated HBASE-5512: -- Hadoop Flags: Reviewed Status: Patch Available (was: Open) > Add support for INCLUDE_AND_SEEK_USING_HINT > --- > > Key: HBASE-5512 > URL: https://issues.apache.org/jira/browse/HBASE-5512 > Project: HBase > Issue Type: Improvement >Reporter: Zhihong Yu >Assignee: Lars Hofhansl > Attachments: 5512-v2.txt, 5512.txt > > > This came up from HBASE-2038 > From Anoop: > - What we wanted from the filter is include a row and then seek to the next > row which we are interested in. I cant see such a facility with our Filter > right now. Correct me if I am wrong. So suppose we already seeked to one row > and this need to be included in the result, then the Filter should return > INCLUDE. Then when the next next() call happens, then only we can return a > SEEK_USING_HINT. So one extra row reading is needed. This might create even > one unwanted HFileBlock fetch (who knows). > Can we add reseek() at higher level? > From Lars: > Yep, for that we'd need to add INCLUDE_AND_SEEK_USING_HINT (similar to the > INCLUDE_AND_SEEK_NEXT_ROW that we already have). Shouldn't be hard to add, > I'm happy to do that, if that's the route we want to go with this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5512) Add support for INCLUDE_AND_SEEK_USING_HINT
[ https://issues.apache.org/jira/browse/HBASE-5512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-5512: - Attachment: 5512-v2.txt This version should work. (but see caveats raised before) > Add support for INCLUDE_AND_SEEK_USING_HINT > --- > > Key: HBASE-5512 > URL: https://issues.apache.org/jira/browse/HBASE-5512 > Project: HBase > Issue Type: Improvement >Reporter: Zhihong Yu >Assignee: Lars Hofhansl > Attachments: 5512-v2.txt, 5512.txt > > > This came up from HBASE-2038 > From Anoop: > - What we wanted from the filter is include a row and then seek to the next > row which we are interested in. I cant see such a facility with our Filter > right now. Correct me if I am wrong. So suppose we already seeked to one row > and this need to be included in the result, then the Filter should return > INCLUDE. Then when the next next() call happens, then only we can return a > SEEK_USING_HINT. So one extra row reading is needed. This might create even > one unwanted HFileBlock fetch (who knows). > Can we add reseek() at higher level? > From Lars: > Yep, for that we'd need to add INCLUDE_AND_SEEK_USING_HINT (similar to the > INCLUDE_AND_SEEK_NEXT_ROW that we already have). Shouldn't be hard to add, > I'm happy to do that, if that's the route we want to go with this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5512) Add support for INCLUDE_AND_SEEK_USING_HINT
[ https://issues.apache.org/jira/browse/HBASE-5512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-5512: - Attachment: 5512.txt Not ready (especially the test)... just storing the patch here. > Add support for INCLUDE_AND_SEEK_USING_HINT > --- > > Key: HBASE-5512 > URL: https://issues.apache.org/jira/browse/HBASE-5512 > Project: HBase > Issue Type: Improvement >Reporter: Zhihong Yu >Assignee: Lars Hofhansl > Attachments: 5512.txt > > > This came up from HBASE-2038 > From Anoop: > - What we wanted from the filter is include a row and then seek to the next > row which we are interested in. I cant see such a facility with our Filter > right now. Correct me if I am wrong. So suppose we already seeked to one row > and this need to be included in the result, then the Filter should return > INCLUDE. Then when the next next() call happens, then only we can return a > SEEK_USING_HINT. So one extra row reading is needed. This might create even > one unwanted HFileBlock fetch (who knows). > Can we add reseek() at higher level? > From Lars: > Yep, for that we'd need to add INCLUDE_AND_SEEK_USING_HINT (similar to the > INCLUDE_AND_SEEK_NEXT_ROW that we already have). Shouldn't be hard to add, > I'm happy to do that, if that's the route we want to go with this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5512) Add support for INCLUDE_AND_SEEK_USING_HINT
[ https://issues.apache.org/jira/browse/HBASE-5512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-5512: - Assignee: Lars Hofhansl > Add support for INCLUDE_AND_SEEK_USING_HINT > --- > > Key: HBASE-5512 > URL: https://issues.apache.org/jira/browse/HBASE-5512 > Project: HBase > Issue Type: Improvement >Reporter: Zhihong Yu >Assignee: Lars Hofhansl > > This came up from HBASE-2038 > From Anoop: > - What we wanted from the filter is include a row and then seek to the next > row which we are interested in. I cant see such a facility with our Filter > right now. Correct me if I am wrong. So suppose we already seeked to one row > and this need to be included in the result, then the Filter should return > INCLUDE. Then when the next next() call happens, then only we can return a > SEEK_USING_HINT. So one extra row reading is needed. This might create even > one unwanted HFileBlock fetch (who knows). > Can we add reseek() at higher level? > From Lars: > Yep, for that we'd need to add INCLUDE_AND_SEEK_USING_HINT (similar to the > INCLUDE_AND_SEEK_NEXT_ROW that we already have). Shouldn't be hard to add, > I'm happy to do that, if that's the route we want to go with this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
