[jira] [Updated] (HBASE-5724) Row cache of KeyValue should be cleared in readFields().

2012-04-05 Thread stack (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5724:
-

   Resolution: Fixed
Fix Version/s: (was: 0.96.0)
   0.92.2
   0.90.7
   Status: Resolved  (was: Patch Available)

Applied to 0.90, 0.92, 0.94 branches and trunk.  Thanks for the patch Teruyoshi.

> Row cache of KeyValue should be cleared in readFields().
> 
>
> Key: HBASE-5724
> URL: https://issues.apache.org/jira/browse/HBASE-5724
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.1
>Reporter: Teruyoshi Zenmyo
>Assignee: Teruyoshi Zenmyo
> Fix For: 0.90.7, 0.92.2, 0.94.0
>
> Attachments: 5724.092.txt, HBASE-5724.txt, HBASE-5724v2.txt
>
>
> KeyValue does not clear its row cache in reading new values (readFields()).
> Therefore, If a KeyValue (kv) which caches its row bytes reads another 
> KeyValue instance, kv.getRow() returns a wrong value. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5724) Row cache of KeyValue should be cleared in readFields().

2012-04-05 Thread stack (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5724:
-

Attachment: 5724.092.txt

What I applied to 0.92 and 0.90

> Row cache of KeyValue should be cleared in readFields().
> 
>
> Key: HBASE-5724
> URL: https://issues.apache.org/jira/browse/HBASE-5724
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.1
>Reporter: Teruyoshi Zenmyo
>Assignee: Teruyoshi Zenmyo
> Fix For: 0.94.0, 0.96.0
>
> Attachments: 5724.092.txt, HBASE-5724.txt, HBASE-5724v2.txt
>
>
> KeyValue does not clear its row cache in reading new values (readFields()).
> Therefore, If a KeyValue (kv) which caches its row bytes reads another 
> KeyValue instance, kv.getRow() returns a wrong value. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5724) Row cache of KeyValue should be cleared in readFields().

2012-04-05 Thread stack (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5724:
-

Attachment: HBASE-5724v2.txt

Patch w/ comment amended as per Tedd's suggestion.  This is what I am applying.

> Row cache of KeyValue should be cleared in readFields().
> 
>
> Key: HBASE-5724
> URL: https://issues.apache.org/jira/browse/HBASE-5724
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.1
>Reporter: Teruyoshi Zenmyo
>Assignee: Teruyoshi Zenmyo
> Fix For: 0.94.0, 0.96.0
>
> Attachments: HBASE-5724.txt, HBASE-5724v2.txt
>
>
> KeyValue does not clear its row cache in reading new values (readFields()).
> Therefore, If a KeyValue (kv) which caches its row bytes reads another 
> KeyValue instance, kv.getRow() returns a wrong value. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5724) Row cache of KeyValue should be cleared in readFields().

2012-04-05 Thread Zhihong Yu (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhihong Yu updated HBASE-5724:
--

Fix Version/s: 0.96.0
   0.94.0
 Hadoop Flags: Reviewed

> Row cache of KeyValue should be cleared in readFields().
> 
>
> Key: HBASE-5724
> URL: https://issues.apache.org/jira/browse/HBASE-5724
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.1
>Reporter: Teruyoshi Zenmyo
>Assignee: Teruyoshi Zenmyo
> Fix For: 0.94.0, 0.96.0
>
> Attachments: HBASE-5724.txt
>
>
> KeyValue does not clear its row cache in reading new values (readFields()).
> Therefore, If a KeyValue (kv) which caches its row bytes reads another 
> KeyValue instance, kv.getRow() returns a wrong value. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5724) Row cache of KeyValue should be cleared in readFields().

2012-04-05 Thread Zhihong Yu (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhihong Yu updated HBASE-5724:
--

Comment: was deleted

(was: How about making the following comment in test clearer ?
{code}
+   * make sure a row cache is cleared after a new value is read.
{code}
The row cache is cleared and re-read for the new value.)

> Row cache of KeyValue should be cleared in readFields().
> 
>
> Key: HBASE-5724
> URL: https://issues.apache.org/jira/browse/HBASE-5724
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.1
>Reporter: Teruyoshi Zenmyo
> Attachments: HBASE-5724.txt
>
>
> KeyValue does not clear its row cache in reading new values (readFields()).
> Therefore, If a KeyValue (kv) which caches its row bytes reads another 
> KeyValue instance, kv.getRow() returns a wrong value. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5724) Row cache of KeyValue should be cleared in readFields().

2012-04-05 Thread Teruyoshi Zenmyo (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Teruyoshi Zenmyo updated HBASE-5724:


Description: 
KeyValue does not clear its row cache in reading new values (readFields()).
Therefore, If a KeyValue (kv) which caches its row bytes reads another KeyValue 
instance, kv.getRow() returns a wrong value. 

  was:
KeyValue does not clear its row cache in reading new values (readFileds()).
Therefore, If a KeyValue (kv) which caches its row bytes reads another KeyValue 
instance, kv.getRow() returns a wrong value. 


> Row cache of KeyValue should be cleared in readFields().
> 
>
> Key: HBASE-5724
> URL: https://issues.apache.org/jira/browse/HBASE-5724
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.1
>Reporter: Teruyoshi Zenmyo
> Attachments: HBASE-5724.txt
>
>
> KeyValue does not clear its row cache in reading new values (readFields()).
> Therefore, If a KeyValue (kv) which caches its row bytes reads another 
> KeyValue instance, kv.getRow() returns a wrong value. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5724) Row cache of KeyValue should be cleared in readFields().

2012-04-05 Thread Teruyoshi Zenmyo (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Teruyoshi Zenmyo updated HBASE-5724:


Status: Patch Available  (was: Open)

> Row cache of KeyValue should be cleared in readFields().
> 
>
> Key: HBASE-5724
> URL: https://issues.apache.org/jira/browse/HBASE-5724
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.1
>Reporter: Teruyoshi Zenmyo
> Attachments: HBASE-5724.txt
>
>
> KeyValue does not clear its row cache in reading new values (readFileds()).
> Therefore, If a KeyValue (kv) which caches its row bytes reads another 
> KeyValue instance, kv.getRow() returns a wrong value. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5724) Row cache of KeyValue should be cleared in readFields().

2012-04-05 Thread Teruyoshi Zenmyo (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Teruyoshi Zenmyo updated HBASE-5724:


Attachment: HBASE-5724.txt

The attached file is a patch which adds just one line together with a new test.
- set rowcache of KeyValue to null in the readFields()
- one new test which makes sure KeyValue.getRow() returns a correct value.

> Row cache of KeyValue should be cleared in readFields().
> 
>
> Key: HBASE-5724
> URL: https://issues.apache.org/jira/browse/HBASE-5724
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.1
>Reporter: Teruyoshi Zenmyo
> Attachments: HBASE-5724.txt
>
>
> KeyValue does not clear its row cache in reading new values (readFileds()).
> Therefore, If a KeyValue (kv) which caches its row bytes reads another 
> KeyValue instance, kv.getRow() returns a wrong value. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira