[jira] [Updated] (HBASE-5736) ThriftServerRunner.HbaseHandler.mutateRow() does not use ByteBuffer correctly
[ https://issues.apache.org/jira/browse/HBASE-5736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-5736: --- Attachment: HBASE-5736.D2649.1.patch sc requested code review of "HBASE-5736 [jira] ThriftServerRunner.HbaseHandler.mutateRow() does not use ByteBuffer correctly". Reviewers: tedyu, dhruba, JIRA ThriftServerRunner.HbaseHandler.mutateRow() does not use ByteBuffer correctly Task ID: # Blame Rev: We have fixed similar bug in https://issues.apache.org/jira/browse/HBASE-5507 It uses ByteBuffer.array() to read the ByteBuffer. This will ignore the offset return the whole underlying byte array. The bug can be triggered by using framed Transport thrift servers. TEST PLAN unit test Revert Plan: Tags: REVISION DETAIL https://reviews.facebook.net/D2649 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/6087/ Tip: use the X-Herald-Rules header to filter Herald messages in your client. > ThriftServerRunner.HbaseHandler.mutateRow() does not use ByteBuffer correctly > - > > Key: HBASE-5736 > URL: https://issues.apache.org/jira/browse/HBASE-5736 > Project: HBase > Issue Type: Bug >Reporter: Scott Chen >Assignee: Scott Chen > Attachments: HBASE-5736.D2649.1.patch > > > We have fixed similar bug in > https://issues.apache.org/jira/browse/HBASE-5507 > It uses ByteBuffer.array() to read the ByteBuffer. > This will ignore the offset return the whole underlying byte array. > The bug can be triggered by using framed Transport thrift servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5736) ThriftServerRunner.HbaseHandler.mutateRow() does not use ByteBuffer correctly
[ https://issues.apache.org/jira/browse/HBASE-5736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-5736: --- Attachment: HBASE-5736.D2649.2.patch sc updated the revision "HBASE-5736 [jira] ThriftServerRunner.HbaseHandler.mutateRow() does not use ByteBuffer correctly". Reviewers: tedyu, dhruba, JIRA Remove some testing codes REVISION DETAIL https://reviews.facebook.net/D2649 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java > ThriftServerRunner.HbaseHandler.mutateRow() does not use ByteBuffer correctly > - > > Key: HBASE-5736 > URL: https://issues.apache.org/jira/browse/HBASE-5736 > Project: HBase > Issue Type: Bug >Reporter: Scott Chen >Assignee: Scott Chen > Attachments: HBASE-5736.D2649.1.patch, HBASE-5736.D2649.2.patch > > > We have fixed similar bug in > https://issues.apache.org/jira/browse/HBASE-5507 > It uses ByteBuffer.array() to read the ByteBuffer. > This will ignore the offset return the whole underlying byte array. > The bug can be triggered by using framed Transport thrift servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5736) ThriftServerRunner.HbaseHandler.mutateRow() does not use ByteBuffer correctly
[ https://issues.apache.org/jira/browse/HBASE-5736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhihong Yu updated HBASE-5736: -- Hadoop Flags: Reviewed Status: Patch Available (was: Open) > ThriftServerRunner.HbaseHandler.mutateRow() does not use ByteBuffer correctly > - > > Key: HBASE-5736 > URL: https://issues.apache.org/jira/browse/HBASE-5736 > Project: HBase > Issue Type: Bug >Reporter: Scott Chen >Assignee: Scott Chen > Attachments: HBASE-5736.D2649.1.patch, HBASE-5736.D2649.2.patch > > > We have fixed similar bug in > https://issues.apache.org/jira/browse/HBASE-5507 > It uses ByteBuffer.array() to read the ByteBuffer. > This will ignore the offset return the whole underlying byte array. > The bug can be triggered by using framed Transport thrift servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5736) ThriftServerRunner.HbaseHandler.mutateRow() does not use ByteBuffer correctly
[ https://issues.apache.org/jira/browse/HBASE-5736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-5736: --- Attachment: HBASE-5736.D2649.3.patch sc updated the revision "HBASE-5736 [jira] ThriftServerRunner.HbaseHandler.mutateRow() does not use ByteBuffer correctly". Reviewers: tedyu, dhruba, JIRA Increase test timeout because more tests are added. REVISION DETAIL https://reviews.facebook.net/D2649 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java > ThriftServerRunner.HbaseHandler.mutateRow() does not use ByteBuffer correctly > - > > Key: HBASE-5736 > URL: https://issues.apache.org/jira/browse/HBASE-5736 > Project: HBase > Issue Type: Bug >Reporter: Scott Chen >Assignee: Scott Chen > Attachments: HBASE-5736.D2649.1.patch, HBASE-5736.D2649.2.patch, > HBASE-5736.D2649.3.patch > > > We have fixed similar bug in > https://issues.apache.org/jira/browse/HBASE-5507 > It uses ByteBuffer.array() to read the ByteBuffer. > This will ignore the offset return the whole underlying byte array. > The bug can be triggered by using framed Transport thrift servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5736) ThriftServerRunner.HbaseHandler.mutateRow() does not use ByteBuffer correctly
[ https://issues.apache.org/jira/browse/HBASE-5736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhihong Yu updated HBASE-5736: -- Fix Version/s: 0.96.0 > ThriftServerRunner.HbaseHandler.mutateRow() does not use ByteBuffer correctly > - > > Key: HBASE-5736 > URL: https://issues.apache.org/jira/browse/HBASE-5736 > Project: HBase > Issue Type: Bug >Reporter: Scott Chen >Assignee: Scott Chen > Fix For: 0.96.0 > > Attachments: HBASE-5736.D2649.1.patch, HBASE-5736.D2649.2.patch, > HBASE-5736.D2649.3.patch > > > We have fixed similar bug in > https://issues.apache.org/jira/browse/HBASE-5507 > It uses ByteBuffer.array() to read the ByteBuffer. > This will ignore the offset return the whole underlying byte array. > The bug can be triggered by using framed Transport thrift servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5736) ThriftServerRunner.HbaseHandler.mutateRow() does not use ByteBuffer correctly
[ https://issues.apache.org/jira/browse/HBASE-5736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhihong Yu updated HBASE-5736: -- Attachment: 5736-94.txt Patch for 0.94 > ThriftServerRunner.HbaseHandler.mutateRow() does not use ByteBuffer correctly > - > > Key: HBASE-5736 > URL: https://issues.apache.org/jira/browse/HBASE-5736 > Project: HBase > Issue Type: Bug >Reporter: Scott Chen >Assignee: Scott Chen > Fix For: 0.96.0 > > Attachments: 5736-94.txt, HBASE-5736.D2649.1.patch, > HBASE-5736.D2649.2.patch, HBASE-5736.D2649.3.patch > > > We have fixed similar bug in > https://issues.apache.org/jira/browse/HBASE-5507 > It uses ByteBuffer.array() to read the ByteBuffer. > This will ignore the offset return the whole underlying byte array. > The bug can be triggered by using framed Transport thrift servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5736) ThriftServerRunner.HbaseHandler.mutateRow() does not use ByteBuffer correctly
[ https://issues.apache.org/jira/browse/HBASE-5736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhihong Yu updated HBASE-5736: -- Status: Open (was: Patch Available) > ThriftServerRunner.HbaseHandler.mutateRow() does not use ByteBuffer correctly > - > > Key: HBASE-5736 > URL: https://issues.apache.org/jira/browse/HBASE-5736 > Project: HBase > Issue Type: Bug >Reporter: Scott Chen >Assignee: Scott Chen > Fix For: 0.96.0 > > Attachments: 5736-94.txt, HBASE-5736.D2649.1.patch, > HBASE-5736.D2649.2.patch, HBASE-5736.D2649.3.patch > > > We have fixed similar bug in > https://issues.apache.org/jira/browse/HBASE-5507 > It uses ByteBuffer.array() to read the ByteBuffer. > This will ignore the offset return the whole underlying byte array. > The bug can be triggered by using framed Transport thrift servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5736) ThriftServerRunner.HbaseHandler.mutateRow() does not use ByteBuffer correctly
[ https://issues.apache.org/jira/browse/HBASE-5736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhihong Yu updated HBASE-5736: -- Fix Version/s: 0.94.0 Integrated patch to 0.94 branch > ThriftServerRunner.HbaseHandler.mutateRow() does not use ByteBuffer correctly > - > > Key: HBASE-5736 > URL: https://issues.apache.org/jira/browse/HBASE-5736 > Project: HBase > Issue Type: Bug >Reporter: Scott Chen >Assignee: Scott Chen > Fix For: 0.94.0, 0.96.0 > > Attachments: 5736-94.txt, HBASE-5736.D2649.1.patch, > HBASE-5736.D2649.2.patch, HBASE-5736.D2649.3.patch > > > We have fixed similar bug in > https://issues.apache.org/jira/browse/HBASE-5507 > It uses ByteBuffer.array() to read the ByteBuffer. > This will ignore the offset return the whole underlying byte array. > The bug can be triggered by using framed Transport thrift servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
