[jira] [Updated] (HBASE-5737) Minor Improvements related to balancer.
[ https://issues.apache.org/jira/browse/HBASE-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-5737: -- Summary: Minor Improvements related to balancer. (was: Use a treemap instead of hashmap in in AM.getAssignmentByTable used in balancer) There are few more changes that we can do here -> Currently two different balancer objects are created in AssignmentManager and HMaster. Unify them -> balancer.randomAssignment() is getting called once but based on whether the existingplan is null or if it is a force plan we either use the randomplan or not. Ideally if we are extending a new balancer then randomAssignment will be called but later the plan given by randomAssignment may not be used. > Minor Improvements related to balancer. > --- > > Key: HBASE-5737 > URL: https://issues.apache.org/jira/browse/HBASE-5737 > Project: HBase > Issue Type: Improvement > Components: master >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Minor > > Currently in Am.getAssignmentByTable() we use a result map which is currenly > a hashmap. It could be better if we have a treeMap. Even in > MetaReader.fullScan we have the treeMap only so that we have the naming order > maintained. I felt this change could be very useful in cases where we are > extending the DefaultLoadBalancer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5737) Minor Improvements related to balancer.
[ https://issues.apache.org/jira/browse/HBASE-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-5737: -- Status: Patch Available (was: Open) > Minor Improvements related to balancer. > --- > > Key: HBASE-5737 > URL: https://issues.apache.org/jira/browse/HBASE-5737 > Project: HBase > Issue Type: Improvement > Components: master >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Minor > Attachments: HBASE-5737.patch > > > Currently in Am.getAssignmentByTable() we use a result map which is currenly > a hashmap. It could be better if we have a treeMap. Even in > MetaReader.fullScan we have the treeMap only so that we have the naming order > maintained. I felt this change could be very useful in cases where we are > extending the DefaultLoadBalancer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5737) Minor Improvements related to balancer.
[ https://issues.apache.org/jira/browse/HBASE-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-5737: -- Attachment: HBASE-5737.patch Patch is minor..but important one incase we provide pluggability for the loadbalancer. > Minor Improvements related to balancer. > --- > > Key: HBASE-5737 > URL: https://issues.apache.org/jira/browse/HBASE-5737 > Project: HBase > Issue Type: Improvement > Components: master >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Minor > Attachments: HBASE-5737.patch > > > Currently in Am.getAssignmentByTable() we use a result map which is currenly > a hashmap. It could be better if we have a treeMap. Even in > MetaReader.fullScan we have the treeMap only so that we have the naming order > maintained. I felt this change could be very useful in cases where we are > extending the DefaultLoadBalancer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5737) Minor Improvements related to balancer.
[ https://issues.apache.org/jira/browse/HBASE-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-5737: -- Status: Open (was: Patch Available) > Minor Improvements related to balancer. > --- > > Key: HBASE-5737 > URL: https://issues.apache.org/jira/browse/HBASE-5737 > Project: HBase > Issue Type: Improvement > Components: master >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Minor > Attachments: HBASE-5737.patch > > > Currently in Am.getAssignmentByTable() we use a result map which is currenly > a hashmap. It could be better if we have a treeMap. Even in > MetaReader.fullScan we have the treeMap only so that we have the naming order > maintained. I felt this change could be very useful in cases where we are > extending the DefaultLoadBalancer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5737) Minor Improvements related to balancer.
[ https://issues.apache.org/jira/browse/HBASE-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-5737: -- Attachment: HBASE-5737_1.patch Pls review the latest one. If you feel still TreeMap change is not needed, i think the other changes are needed. > Minor Improvements related to balancer. > --- > > Key: HBASE-5737 > URL: https://issues.apache.org/jira/browse/HBASE-5737 > Project: HBase > Issue Type: Improvement > Components: master >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Minor > Attachments: HBASE-5737.patch, HBASE-5737_1.patch > > > Currently in Am.getAssignmentByTable() we use a result map which is currenly > a hashmap. It could be better if we have a treeMap. Even in > MetaReader.fullScan we have the treeMap only so that we have the naming order > maintained. I felt this change could be very useful in cases where we are > extending the DefaultLoadBalancer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5737) Minor Improvements related to balancer.
[ https://issues.apache.org/jira/browse/HBASE-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-5737: -- Status: Patch Available (was: Open) > Minor Improvements related to balancer. > --- > > Key: HBASE-5737 > URL: https://issues.apache.org/jira/browse/HBASE-5737 > Project: HBase > Issue Type: Improvement > Components: master >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Minor > Attachments: HBASE-5737.patch, HBASE-5737_1.patch > > > Currently in Am.getAssignmentByTable() we use a result map which is currenly > a hashmap. It could be better if we have a treeMap. Even in > MetaReader.fullScan we have the treeMap only so that we have the naming order > maintained. I felt this change could be very useful in cases where we are > extending the DefaultLoadBalancer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5737) Minor Improvements related to balancer.
[ https://issues.apache.org/jira/browse/HBASE-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-5737: -- Attachment: HBASE-5737_2.patch Updated patch. > Minor Improvements related to balancer. > --- > > Key: HBASE-5737 > URL: https://issues.apache.org/jira/browse/HBASE-5737 > Project: HBase > Issue Type: Improvement > Components: master >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Minor > Attachments: HBASE-5737.patch, HBASE-5737_1.patch, HBASE-5737_2.patch > > > Currently in Am.getAssignmentByTable() we use a result map which is currenly > a hashmap. It could be better if we have a treeMap. Even in > MetaReader.fullScan we have the treeMap only so that we have the naming order > maintained. I felt this change could be very useful in cases where we are > extending the DefaultLoadBalancer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5737) Minor Improvements related to balancer.
[ https://issues.apache.org/jira/browse/HBASE-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-5737: -- Status: Open (was: Patch Available) > Minor Improvements related to balancer. > --- > > Key: HBASE-5737 > URL: https://issues.apache.org/jira/browse/HBASE-5737 > Project: HBase > Issue Type: Improvement > Components: master >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Minor > Attachments: HBASE-5737.patch, HBASE-5737_1.patch, HBASE-5737_2.patch > > > Currently in Am.getAssignmentByTable() we use a result map which is currenly > a hashmap. It could be better if we have a treeMap. Even in > MetaReader.fullScan we have the treeMap only so that we have the naming order > maintained. I felt this change could be very useful in cases where we are > extending the DefaultLoadBalancer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5737) Minor Improvements related to balancer.
[ https://issues.apache.org/jira/browse/HBASE-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-5737: -- Status: Patch Available (was: Open) > Minor Improvements related to balancer. > --- > > Key: HBASE-5737 > URL: https://issues.apache.org/jira/browse/HBASE-5737 > Project: HBase > Issue Type: Improvement > Components: master >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Minor > Attachments: HBASE-5737.patch, HBASE-5737_1.patch, HBASE-5737_2.patch > > > Currently in Am.getAssignmentByTable() we use a result map which is currenly > a hashmap. It could be better if we have a treeMap. Even in > MetaReader.fullScan we have the treeMap only so that we have the naming order > maintained. I felt this change could be very useful in cases where we are > extending the DefaultLoadBalancer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5737) Minor Improvements related to balancer.
[ https://issues.apache.org/jira/browse/HBASE-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-5737: -- Attachment: HBASE-5737_3.patch Latest patch as per Stack's suggestion. > Minor Improvements related to balancer. > --- > > Key: HBASE-5737 > URL: https://issues.apache.org/jira/browse/HBASE-5737 > Project: HBase > Issue Type: Improvement > Components: master >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Minor > Attachments: HBASE-5737.patch, HBASE-5737_1.patch, > HBASE-5737_2.patch, HBASE-5737_3.patch > > > Currently in Am.getAssignmentByTable() we use a result map which is currenly > a hashmap. It could be better if we have a treeMap. Even in > MetaReader.fullScan we have the treeMap only so that we have the naming order > maintained. I felt this change could be very useful in cases where we are > extending the DefaultLoadBalancer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5737) Minor Improvements related to balancer.
[ https://issues.apache.org/jira/browse/HBASE-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-5737: -- Status: Open (was: Patch Available) > Minor Improvements related to balancer. > --- > > Key: HBASE-5737 > URL: https://issues.apache.org/jira/browse/HBASE-5737 > Project: HBase > Issue Type: Improvement > Components: master >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Minor > Attachments: HBASE-5737.patch, HBASE-5737_1.patch, > HBASE-5737_2.patch, HBASE-5737_3.patch > > > Currently in Am.getAssignmentByTable() we use a result map which is currenly > a hashmap. It could be better if we have a treeMap. Even in > MetaReader.fullScan we have the treeMap only so that we have the naming order > maintained. I felt this change could be very useful in cases where we are > extending the DefaultLoadBalancer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5737) Minor Improvements related to balancer.
[ https://issues.apache.org/jira/browse/HBASE-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-5737: -- Status: Patch Available (was: Open) > Minor Improvements related to balancer. > --- > > Key: HBASE-5737 > URL: https://issues.apache.org/jira/browse/HBASE-5737 > Project: HBase > Issue Type: Improvement > Components: master >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Minor > Attachments: HBASE-5737.patch, HBASE-5737_1.patch, > HBASE-5737_2.patch, HBASE-5737_3.patch > > > Currently in Am.getAssignmentByTable() we use a result map which is currenly > a hashmap. It could be better if we have a treeMap. Even in > MetaReader.fullScan we have the treeMap only so that we have the naming order > maintained. I felt this change could be very useful in cases where we are > extending the DefaultLoadBalancer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5737) Minor Improvements related to balancer.
[ https://issues.apache.org/jira/browse/HBASE-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-5737: -- Fix Version/s: 0.96.0 Can this be an improvement or bug? I think the 'balancer' usage in HMaster and AM was a bug right? > Minor Improvements related to balancer. > --- > > Key: HBASE-5737 > URL: https://issues.apache.org/jira/browse/HBASE-5737 > Project: HBase > Issue Type: Improvement > Components: master >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Minor > Fix For: 0.96.0 > > Attachments: HBASE-5737.patch, HBASE-5737_1.patch, > HBASE-5737_2.patch, HBASE-5737_3.patch > > > Currently in Am.getAssignmentByTable() we use a result map which is currenly > a hashmap. It could be better if we have a treeMap. Even in > MetaReader.fullScan we have the treeMap only so that we have the naming order > maintained. I felt this change could be very useful in cases where we are > extending the DefaultLoadBalancer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5737) Minor Improvements related to balancer.
[ https://issues.apache.org/jira/browse/HBASE-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-5737: -- Fix Version/s: 0.94.1 Issue Type: Bug (was: Improvement) @Stack Yes i have a configured LB. But as we provide option to use master services in the LB and now if i try to use the 'balancer' object there, it is a new one. I am updating it to a bug Stack. > Minor Improvements related to balancer. > --- > > Key: HBASE-5737 > URL: https://issues.apache.org/jira/browse/HBASE-5737 > Project: HBase > Issue Type: Bug > Components: master >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Minor > Fix For: 0.96.0, 0.94.1 > > Attachments: HBASE-5737.patch, HBASE-5737_1.patch, > HBASE-5737_2.patch, HBASE-5737_3.patch > > > Currently in Am.getAssignmentByTable() we use a result map which is currenly > a hashmap. It could be better if we have a treeMap. Even in > MetaReader.fullScan we have the treeMap only so that we have the naming order > maintained. I felt this change could be very useful in cases where we are > extending the DefaultLoadBalancer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5737) Minor Improvements related to balancer.
[ https://issues.apache.org/jira/browse/HBASE-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-5737: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Minor Improvements related to balancer. > --- > > Key: HBASE-5737 > URL: https://issues.apache.org/jira/browse/HBASE-5737 > Project: HBase > Issue Type: Bug > Components: master >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Minor > Fix For: 0.96.0, 0.94.1 > > Attachments: HBASE-5737.patch, HBASE-5737_1.patch, > HBASE-5737_2.patch, HBASE-5737_3.patch > > > Currently in Am.getAssignmentByTable() we use a result map which is currenly > a hashmap. It could be better if we have a treeMap. Even in > MetaReader.fullScan we have the treeMap only so that we have the naming order > maintained. I felt this change could be very useful in cases where we are > extending the DefaultLoadBalancer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5737) Minor Improvements related to balancer.
[ https://issues.apache.org/jira/browse/HBASE-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-5737: - Fix Version/s: (was: 0.94.1) 0.94.0 > Minor Improvements related to balancer. > --- > > Key: HBASE-5737 > URL: https://issues.apache.org/jira/browse/HBASE-5737 > Project: HBase > Issue Type: Bug > Components: master >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Minor > Fix For: 0.94.0, 0.96.0 > > Attachments: HBASE-5737.patch, HBASE-5737_1.patch, > HBASE-5737_2.patch, HBASE-5737_3.patch > > > Currently in Am.getAssignmentByTable() we use a result map which is currenly > a hashmap. It could be better if we have a treeMap. Even in > MetaReader.fullScan we have the treeMap only so that we have the naming order > maintained. I felt this change could be very useful in cases where we are > extending the DefaultLoadBalancer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5737) Minor Improvements related to balancer.
[ https://issues.apache.org/jira/browse/HBASE-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-5737: - Issue Type: Improvement (was: Bug) > Minor Improvements related to balancer. > --- > > Key: HBASE-5737 > URL: https://issues.apache.org/jira/browse/HBASE-5737 > Project: HBase > Issue Type: Improvement > Components: master >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Minor > Fix For: 0.94.0, 0.96.0 > > Attachments: HBASE-5737.patch, HBASE-5737_1.patch, > HBASE-5737_2.patch, HBASE-5737_3.patch > > > Currently in Am.getAssignmentByTable() we use a result map which is currenly > a hashmap. It could be better if we have a treeMap. Even in > MetaReader.fullScan we have the treeMap only so that we have the naming order > maintained. I felt this change could be very useful in cases where we are > extending the DefaultLoadBalancer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira