[jira] [Updated] (HBASE-5803) [89-fb] Upgrade hbase 0.89-fb to Thrift 0.8.0 and bring Thrift server enhancements from trunk
[ https://issues.apache.org/jira/browse/HBASE-5803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-5803: --- Attachment: D2811.1.patch mbautin requested code review of "[jira] [HBASE-5803] [89-fb] Upgrade hbase 0.89-fb to Thrift 0.8.0 and bring Thrift server enhancements from trunk". Reviewers: sc, nspiegelberg, Kannan, Liyin, JIRA TBoundedThreadPoolServer has been a problem for us when there is a large number of clients. We need to migrate to 0.8.0. in 89-fb and bring the relevant improvements from trunk, including supporting TThreadedSelectorServer. TEST PLAN - Run unit tests - Deploy to a test cluster, turn on the load, and monitor correctness/performance REVISION DETAIL https://reviews.facebook.net/D2811 AFFECTED FILES pom.xml src/main/java/org/apache/hadoop/hbase/HConstants.java src/main/java/org/apache/hadoop/hbase/filter/ParseFilter.java src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java src/main/java/org/apache/hadoop/hbase/thrift/HThreadedSelectorServerArgs.java src/main/java/org/apache/hadoop/hbase/thrift/TBoundedThreadPoolServer.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java src/main/java/org/apache/hadoop/hbase/thrift/generated/AlreadyExists.java src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java src/main/java/org/apache/hadoop/hbase/thrift/generated/ColumnDescriptor.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java src/main/java/org/apache/hadoop/hbase/thrift/generated/IOError.java src/main/java/org/apache/hadoop/hbase/thrift/generated/IllegalArgument.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TCell.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TRegionInfo.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java src/main/java/org/apache/hadoop/hbase/util/Bytes.java src/test/java/org/apache/hadoop/hbase/thrift/TestCallQueue.java src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/6405/ Tip: use the X-Herald-Rules header to filter Herald messages in your client. > [89-fb] Upgrade hbase 0.89-fb to Thrift 0.8.0 and bring Thrift server > enhancements from trunk > - > > Key: HBASE-5803 > URL: https://issues.apache.org/jira/browse/HBASE-5803 > Project: HBase > Issue Type: Improvement >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin > Attachments: D2811.1.patch > > > TBoundedThreadPoolServer has been a problem for us when there is a large > number of clients. We need to migrate to 0.8.0. in 89-fb and bring the > relevant improvements from trunk, including supporting > TThreadedSelectorServer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5803) [89-fb] Upgrade hbase 0.89-fb to Thrift 0.8.0 and bring Thrift server enhancements from trunk
[ https://issues.apache.org/jira/browse/HBASE-5803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-5803: --- Attachment: D2811.2.patch mbautin updated the revision "[jira] [HBASE-5803] [89-fb] Upgrade hbase 0.89-fb to Thrift 0.8.0 and bring Thrift server enhancements from trunk". Reviewers: sc, nspiegelberg, Kannan, Liyin, JIRA - Addressing Scott's comment. - Breaking TestThriftServerCmdLine into multiple parts because its running time became too long (will be ported to trunk). - Not waiting before a retry in a multiput if all errors were NotServingRegionExceptions (this will also be a separate JIRA but is included here for testing). REVISION DETAIL https://reviews.facebook.net/D2811 AFFECTED FILES pom.xml src/main/java/org/apache/hadoop/hbase/HConstants.java src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java src/main/java/org/apache/hadoop/hbase/filter/ParseFilter.java src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java src/main/java/org/apache/hadoop/hbase/thrift/HThreadedSelectorServerArgs.java src/main/java/org/apache/hadoop/hbase/thrift/TBoundedThreadPoolServer.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java src/main/java/org/apache/hadoop/hbase/thrift/generated/AlreadyExists.java src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java src/main/java/org/apache/hadoop/hbase/thrift/generated/ColumnDescriptor.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java src/main/java/org/apache/hadoop/hbase/thrift/generated/IOError.java src/main/java/org/apache/hadoop/hbase/thrift/generated/IllegalArgument.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TCell.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TRegionInfo.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java src/main/java/org/apache/hadoop/hbase/util/Bytes.java src/test/java/org/apache/hadoop/hbase/thrift/TestCallQueue.java src/test/java/org/apache/hadoop/hbase/thrift/TestHsHaServerCmdLine.java src/test/java/org/apache/hadoop/hbase/thrift/TestNonblockingServerCmdLine.java src/test/java/org/apache/hadoop/hbase/thrift/TestThreadPoolServerCmdLine.java src/test/java/org/apache/hadoop/hbase/thrift/TestThreadedSelectorServerCmdLine.java src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java src/test/java/org/apache/hadoop/hbase/thrift/ThriftServerCmdLineTestBase.java > [89-fb] Upgrade hbase 0.89-fb to Thrift 0.8.0 and bring Thrift server > enhancements from trunk > - > > Key: HBASE-5803 > URL: https://issues.apache.org/jira/browse/HBASE-5803 > Project: HBase > Issue Type: Improvement >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin > Attachments: D2811.1.patch, D2811.2.patch > > > TBoundedThreadPoolServer has been a problem for us when there is a large > number of clients. We need to migrate to 0.8.0. in 89-fb and bring the > relevant improvements from trunk, including supporting > TThreadedSelectorServer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5803) [89-fb] Upgrade hbase 0.89-fb to Thrift 0.8.0 and bring Thrift server enhancements from trunk
[ https://issues.apache.org/jira/browse/HBASE-5803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-5803: --- Attachment: D2811.3.patch mbautin updated the revision "[jira] [HBASE-5803] [89-fb] Upgrade hbase 0.89-fb to Thrift 0.8.0 and bring Thrift server enhancements from trunk". Reviewers: sc, nspiegelberg, Kannan, Liyin, JIRA Moved HConnectionManager changes to D2847. REVISION DETAIL https://reviews.facebook.net/D2811 AFFECTED FILES pom.xml src/main/java/org/apache/hadoop/hbase/HConstants.java src/main/java/org/apache/hadoop/hbase/filter/ParseFilter.java src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java src/main/java/org/apache/hadoop/hbase/thrift/HThreadedSelectorServerArgs.java src/main/java/org/apache/hadoop/hbase/thrift/TBoundedThreadPoolServer.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java src/main/java/org/apache/hadoop/hbase/thrift/generated/AlreadyExists.java src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java src/main/java/org/apache/hadoop/hbase/thrift/generated/ColumnDescriptor.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java src/main/java/org/apache/hadoop/hbase/thrift/generated/IOError.java src/main/java/org/apache/hadoop/hbase/thrift/generated/IllegalArgument.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TCell.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TRegionInfo.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java src/main/java/org/apache/hadoop/hbase/util/Bytes.java src/test/java/org/apache/hadoop/hbase/thrift/TestCallQueue.java src/test/java/org/apache/hadoop/hbase/thrift/TestHsHaServerCmdLine.java src/test/java/org/apache/hadoop/hbase/thrift/TestNonblockingServerCmdLine.java src/test/java/org/apache/hadoop/hbase/thrift/TestThreadPoolServerCmdLine.java src/test/java/org/apache/hadoop/hbase/thrift/TestThreadedSelectorServerCmdLine.java src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java src/test/java/org/apache/hadoop/hbase/thrift/ThriftServerCmdLineTestBase.java > [89-fb] Upgrade hbase 0.89-fb to Thrift 0.8.0 and bring Thrift server > enhancements from trunk > - > > Key: HBASE-5803 > URL: https://issues.apache.org/jira/browse/HBASE-5803 > Project: HBase > Issue Type: Improvement >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin > Attachments: D2811.1.patch, D2811.2.patch, D2811.3.patch > > > TBoundedThreadPoolServer has been a problem for us when there is a large > number of clients. We need to migrate to 0.8.0. in 89-fb and bring the > relevant improvements from trunk, including supporting > TThreadedSelectorServer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5803) [89-fb] Upgrade hbase 0.89-fb to Thrift 0.8.0 and bring Thrift server enhancements from trunk
[ https://issues.apache.org/jira/browse/HBASE-5803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-5803: --- Attachment: D2811.4.patch mbautin updated the revision "[jira] [HBASE-5803] [89-fb] Upgrade hbase 0.89-fb to Thrift 0.8.0 and bring Thrift server enhancements from trunk". Reviewers: sc, nspiegelberg, Kannan, Liyin, JIRA Keeping the old TestThriftServer around as TestThriftServerLegacy (reusing some of the methods) since there seem to be slight differences and we want to get the maximum test coverage out of existing tests. REVISION DETAIL https://reviews.facebook.net/D2811 AFFECTED FILES pom.xml src/main/java/org/apache/hadoop/hbase/HConstants.java src/main/java/org/apache/hadoop/hbase/filter/ParseFilter.java src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java src/main/java/org/apache/hadoop/hbase/thrift/HThreadedSelectorServerArgs.java src/main/java/org/apache/hadoop/hbase/thrift/TBoundedThreadPoolServer.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java src/main/java/org/apache/hadoop/hbase/thrift/generated/AlreadyExists.java src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java src/main/java/org/apache/hadoop/hbase/thrift/generated/ColumnDescriptor.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java src/main/java/org/apache/hadoop/hbase/thrift/generated/IOError.java src/main/java/org/apache/hadoop/hbase/thrift/generated/IllegalArgument.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TCell.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TRegionInfo.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java src/main/java/org/apache/hadoop/hbase/util/Bytes.java src/test/java/org/apache/hadoop/hbase/thrift/TestCallQueue.java src/test/java/org/apache/hadoop/hbase/thrift/TestHsHaServerCmdLine.java src/test/java/org/apache/hadoop/hbase/thrift/TestNonblockingServerCmdLine.java src/test/java/org/apache/hadoop/hbase/thrift/TestThreadPoolServerCmdLine.java src/test/java/org/apache/hadoop/hbase/thrift/TestThreadedSelectorServerCmdLine.java src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerLegacy.java src/test/java/org/apache/hadoop/hbase/thrift/ThriftServerCmdLineTestBase.java > [89-fb] Upgrade hbase 0.89-fb to Thrift 0.8.0 and bring Thrift server > enhancements from trunk > - > > Key: HBASE-5803 > URL: https://issues.apache.org/jira/browse/HBASE-5803 > Project: HBase > Issue Type: Improvement >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin > Attachments: D2811.1.patch, D2811.2.patch, D2811.3.patch, > D2811.4.patch > > > TBoundedThreadPoolServer has been a problem for us when there is a large > number of clients. We need to migrate to 0.8.0. in 89-fb and bring the > relevant improvements from trunk, including supporting > TThreadedSelectorServer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5803) [89-fb] Upgrade hbase 0.89-fb to Thrift 0.8.0 and bring Thrift server enhancements from trunk
[ https://issues.apache.org/jira/browse/HBASE-5803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-5803: --- Attachment: D2811.5.patch mbautin updated the revision "[jira] [HBASE-5803] [89-fb] Upgrade hbase 0.89-fb to Thrift 0.8.0 and bring Thrift server enhancements from trunk". Reviewers: sc, nspiegelberg, Kannan, Liyin, JIRA Using separate configuration key "namespaces" for Thrift proxy and embedded Thrift server: "hbase.thrift." and "hbase.regionserver.thrift." Also using different ports by default (9090 for proxy and 9091 for embedded Thrift server). REVISION DETAIL https://reviews.facebook.net/D2811 AFFECTED FILES pom.xml src/main/java/org/apache/hadoop/hbase/HConstants.java src/main/java/org/apache/hadoop/hbase/filter/ParseFilter.java src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java src/main/java/org/apache/hadoop/hbase/thrift/HThreadedSelectorServerArgs.java src/main/java/org/apache/hadoop/hbase/thrift/TBoundedThreadPoolServer.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java src/main/java/org/apache/hadoop/hbase/thrift/generated/AlreadyExists.java src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java src/main/java/org/apache/hadoop/hbase/thrift/generated/ColumnDescriptor.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java src/main/java/org/apache/hadoop/hbase/thrift/generated/IOError.java src/main/java/org/apache/hadoop/hbase/thrift/generated/IllegalArgument.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TCell.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TRegionInfo.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java src/main/java/org/apache/hadoop/hbase/util/Bytes.java src/test/java/org/apache/hadoop/hbase/thrift/TestCallQueue.java src/test/java/org/apache/hadoop/hbase/thrift/TestHsHaServerCmdLine.java src/test/java/org/apache/hadoop/hbase/thrift/TestNonblockingServerCmdLine.java src/test/java/org/apache/hadoop/hbase/thrift/TestThreadPoolServerFramedCmdLine.java src/test/java/org/apache/hadoop/hbase/thrift/TestThreadPoolServerUnframedCmdLine.java src/test/java/org/apache/hadoop/hbase/thrift/TestThreadedSelectorServerCmdLine.java src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerLegacy.java src/test/java/org/apache/hadoop/hbase/thrift/ThriftServerCmdLineTestBase.java > [89-fb] Upgrade hbase 0.89-fb to Thrift 0.8.0 and bring Thrift server > enhancements from trunk > - > > Key: HBASE-5803 > URL: https://issues.apache.org/jira/browse/HBASE-5803 > Project: HBase > Issue Type: Improvement >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin > Attachments: D2811.1.patch, D2811.2.patch, D2811.3.patch, > D2811.4.patch, D2811.5.patch > > > TBoundedThreadPoolServer has been a problem for us when there is a large > number of clients. We need to migrate to 0.8.0. in 89-fb and bring the > relevant improvements from trunk, including supporting > TThreadedSelectorServer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
