[jira] [Updated] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devaraj Das updated HBASE-6787: --- Attachment: 6787-7.patch Thanks, [~ghelmling], this patch takes into account the module changes introduced HBASE-7185. Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch, 6787-4.patch, 6787-5.patch, 6787-6.patch, 6787-7.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devaraj Das updated HBASE-6787: --- Attachment: 6787-8.1.patch An unnecessary change in ProtobufUtil.java had crept in in the last patch. This patch removes that. Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch, 6787-4.patch, 6787-5.patch, 6787-6.patch, 6787-7.patch, 6787-8.1.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devaraj Das updated HBASE-6787: --- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks, guys for the reviews and the commit. I am marking the issue as 'Fixed'. Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch, 6787-4.patch, 6787-5.patch, 6787-6.patch, 6787-7.patch, 6787-8.1.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devaraj Das updated HBASE-6787: --- Attachment: 6787-5.patch This addresses Ted's comments except for the comments to do with 'Type'. This is because I removed the code that infers the type of the result (in the last patch, I used to check if the result was null, and if so, send an empty result of the desired type). That seemed undesirable when I thought about it (and could hide usercode bugs). Instead, the implementations of the rowprocessors should always provide a getResult implementation to return the correct result type instance (albeit in some cases it may be empty). Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch, 6787-4.patch, 6787-5.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devaraj Das updated HBASE-6787: --- Attachment: 6787-6.patch Missed some getResult changes in the earlier patch. This patch removes the default implementation of getResult (that would return null), and instead adds getResult to the concrete rowprocessor implementations. Please review the patch. Once this patch is committed, I'll do similar PBfying of user code in the other coprocessor protocols. Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch, 6787-4.patch, 6787-5.patch, 6787-6.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devaraj Das updated HBASE-6787: --- Attachment: 6787-3.patch Okay here is an updated patch that incorporates all the comments so far. Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[
https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-6787:
--
Attachment: 6787-4.patch
The test failure was caused by a typo:
{code}
assertEquals(0, failures.get());
+assertEquals(0,1);
{code}
Patch v4 removes that hunk.
Convert RowProcessorProtocol to protocol buffer service
---
Key: HBASE-6787
URL: https://issues.apache.org/jira/browse/HBASE-6787
Project: HBase
Issue Type: Sub-task
Components: Coprocessors
Reporter: Gary Helmling
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch, 6787-4.patch
With coprocessor endpoints now exposed as protobuf defined services, we
should convert over all of our built-in endpoints to PB services.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devaraj Das updated HBASE-6787: --- Attachment: 6787-2.patch Addresses Stack's comments. Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch, 6787-2.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devaraj Das updated HBASE-6787: --- Attachment: 6787-1.patch First pass. Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devaraj Das updated HBASE-6787: --- Status: Patch Available (was: Open) Pushing through hadoopqa Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
