[jira] [Updated] (HBASE-6789) Convert test CoprocessorProtocol implementations to protocol buffer services

2012-12-20 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-6789:
-

  Resolution: Fixed
Hadoop Flags: Reviewed
  Status: Resolved  (was: Patch Available)

Committed to trunk (Gary gave me +1 up on rb).  I wonder what the zombie tests 
are?

> Convert test CoprocessorProtocol implementations to protocol buffer services
> 
>
> Key: HBASE-6789
> URL: https://issues.apache.org/jira/browse/HBASE-6789
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Gary Helmling
>Assignee: stack
> Fix For: 0.96.0
>
> Attachments: 6789.txt, 6789v2.txt, 6789v3.txt, 6789v4.txt, 6789v5.txt
>
>
> With coprocessor endpoints now exposed as protobuf defined services, we 
> should convert over all of our built-in endpoints to PB services.
> Several CoprocessorProtocol implementations are defined for tests:
> * ColumnAggregationProtocol
> * GenericProtocol
> * TestServerCustomProtocol.PingProtocol
> These should either be converted to PB services or removed if they duplicate 
> other tests/are no longer necessary.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6789) Convert test CoprocessorProtocol implementations to protocol buffer services

2012-12-20 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-6789:
-

Status: Patch Available  (was: Open)

> Convert test CoprocessorProtocol implementations to protocol buffer services
> 
>
> Key: HBASE-6789
> URL: https://issues.apache.org/jira/browse/HBASE-6789
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Gary Helmling
>Assignee: stack
> Fix For: 0.96.0
>
> Attachments: 6789.txt, 6789v2.txt, 6789v3.txt, 6789v4.txt, 6789v5.txt
>
>
> With coprocessor endpoints now exposed as protobuf defined services, we 
> should convert over all of our built-in endpoints to PB services.
> Several CoprocessorProtocol implementations are defined for tests:
> * ColumnAggregationProtocol
> * GenericProtocol
> * TestServerCustomProtocol.PingProtocol
> These should either be converted to PB services or removed if they duplicate 
> other tests/are no longer necessary.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6789) Convert test CoprocessorProtocol implementations to protocol buffer services

2012-12-20 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-6789:
-

Status: Open  (was: Patch Available)

> Convert test CoprocessorProtocol implementations to protocol buffer services
> 
>
> Key: HBASE-6789
> URL: https://issues.apache.org/jira/browse/HBASE-6789
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Gary Helmling
>Assignee: stack
> Fix For: 0.96.0
>
> Attachments: 6789.txt, 6789v2.txt, 6789v3.txt, 6789v4.txt, 6789v5.txt
>
>
> With coprocessor endpoints now exposed as protobuf defined services, we 
> should convert over all of our built-in endpoints to PB services.
> Several CoprocessorProtocol implementations are defined for tests:
> * ColumnAggregationProtocol
> * GenericProtocol
> * TestServerCustomProtocol.PingProtocol
> These should either be converted to PB services or removed if they duplicate 
> other tests/are no longer necessary.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6789) Convert test CoprocessorProtocol implementations to protocol buffer services

2012-12-20 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-6789:
-

Attachment: 6789v5.txt

> Convert test CoprocessorProtocol implementations to protocol buffer services
> 
>
> Key: HBASE-6789
> URL: https://issues.apache.org/jira/browse/HBASE-6789
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Gary Helmling
>Assignee: stack
> Fix For: 0.96.0
>
> Attachments: 6789.txt, 6789v2.txt, 6789v3.txt, 6789v4.txt, 6789v5.txt
>
>
> With coprocessor endpoints now exposed as protobuf defined services, we 
> should convert over all of our built-in endpoints to PB services.
> Several CoprocessorProtocol implementations are defined for tests:
> * ColumnAggregationProtocol
> * GenericProtocol
> * TestServerCustomProtocol.PingProtocol
> These should either be converted to PB services or removed if they duplicate 
> other tests/are no longer necessary.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6789) Convert test CoprocessorProtocol implementations to protocol buffer services

2012-12-20 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-6789:
-

Attachment: 6789v4.txt

Fixed failed test.  Let me load to rb.

  8 Added more deprecations of CoprocessorProtocol mentions.
  7 
  6 Added new protos and generated classes necessary converting
  5 over PingProtocol and ColumnAggregateProtocol.
  4 
  3 Removed GenericProtocol and supporting classes and references
  2 in tests.  Generics not supported in pb way of doing dynamic
  1 endpoints.

> Convert test CoprocessorProtocol implementations to protocol buffer services
> 
>
> Key: HBASE-6789
> URL: https://issues.apache.org/jira/browse/HBASE-6789
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Gary Helmling
>Assignee: stack
> Fix For: 0.96.0
>
> Attachments: 6789.txt, 6789v2.txt, 6789v3.txt, 6789v4.txt
>
>
> With coprocessor endpoints now exposed as protobuf defined services, we 
> should convert over all of our built-in endpoints to PB services.
> Several CoprocessorProtocol implementations are defined for tests:
> * ColumnAggregationProtocol
> * GenericProtocol
> * TestServerCustomProtocol.PingProtocol
> These should either be converted to PB services or removed if they duplicate 
> other tests/are no longer necessary.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6789) Convert test CoprocessorProtocol implementations to protocol buffer services

2012-12-20 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-6789:
-

Status: Patch Available  (was: Open)

> Convert test CoprocessorProtocol implementations to protocol buffer services
> 
>
> Key: HBASE-6789
> URL: https://issues.apache.org/jira/browse/HBASE-6789
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Gary Helmling
>Assignee: stack
> Fix For: 0.96.0
>
> Attachments: 6789.txt, 6789v2.txt, 6789v3.txt
>
>
> With coprocessor endpoints now exposed as protobuf defined services, we 
> should convert over all of our built-in endpoints to PB services.
> Several CoprocessorProtocol implementations are defined for tests:
> * ColumnAggregationProtocol
> * GenericProtocol
> * TestServerCustomProtocol.PingProtocol
> These should either be converted to PB services or removed if they duplicate 
> other tests/are no longer necessary.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6789) Convert test CoprocessorProtocol implementations to protocol buffer services

2012-12-20 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-6789:
-

Attachment: 6789v3.txt

This patches is complete but in need of edit.  Will pass it by hadoopqa to see 
how well lit does too (There may be issue in testclassloading).

I converted 'GenericProtocol' by removing it.  I don't think we can do Generics 
with new cp engine -- waiting on response from Gary.

Added more 'deprecateds' too.

> Convert test CoprocessorProtocol implementations to protocol buffer services
> 
>
> Key: HBASE-6789
> URL: https://issues.apache.org/jira/browse/HBASE-6789
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Gary Helmling
>Assignee: stack
> Fix For: 0.96.0
>
> Attachments: 6789.txt, 6789v2.txt, 6789v3.txt
>
>
> With coprocessor endpoints now exposed as protobuf defined services, we 
> should convert over all of our built-in endpoints to PB services.
> Several CoprocessorProtocol implementations are defined for tests:
> * ColumnAggregationProtocol
> * GenericProtocol
> * TestServerCustomProtocol.PingProtocol
> These should either be converted to PB services or removed if they duplicate 
> other tests/are no longer necessary.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6789) Convert test CoprocessorProtocol implementations to protocol buffer services

2012-12-19 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-6789:
-

Attachment: 6789v2.txt

Brings over TestServerCustomProtocol PingProtocol.  Let me work on other two 
CPs.

> Convert test CoprocessorProtocol implementations to protocol buffer services
> 
>
> Key: HBASE-6789
> URL: https://issues.apache.org/jira/browse/HBASE-6789
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Gary Helmling
> Fix For: 0.96.0
>
> Attachments: 6789.txt, 6789v2.txt
>
>
> With coprocessor endpoints now exposed as protobuf defined services, we 
> should convert over all of our built-in endpoints to PB services.
> Several CoprocessorProtocol implementations are defined for tests:
> * ColumnAggregationProtocol
> * GenericProtocol
> * TestServerCustomProtocol.PingProtocol
> These should either be converted to PB services or removed if they duplicate 
> other tests/are no longer necessary.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6789) Convert test CoprocessorProtocol implementations to protocol buffer services

2012-12-13 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-6789:
-

Attachment: 6789.txt

Here is a start converting over PingProtocol.   About half done.  Stuck at 
moment because specifying a row range that would seem to specify a single 
region only, the second of three, is returning results from the first region 
when I do table.coprocessorService(PingProtos.PingService.class, start, end, 
new Batch...

I seem to be passing the proper rows...

> Convert test CoprocessorProtocol implementations to protocol buffer services
> 
>
> Key: HBASE-6789
> URL: https://issues.apache.org/jira/browse/HBASE-6789
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Gary Helmling
> Fix For: 0.96.0
>
> Attachments: 6789.txt
>
>
> With coprocessor endpoints now exposed as protobuf defined services, we 
> should convert over all of our built-in endpoints to PB services.
> Several CoprocessorProtocol implementations are defined for tests:
> * ColumnAggregationProtocol
> * GenericProtocol
> * TestServerCustomProtocol.PingProtocol
> These should either be converted to PB services or removed if they duplicate 
> other tests/are no longer necessary.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira