[jira] [Updated] (HBASE-7255) KV size metric went missing from StoreScanner.
[ https://issues.apache.org/jira/browse/HBASE-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-7255: - Resolution: Fixed Fix Version/s: 0.98.0 Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Thanks for the review everyone. Checked into trunk and 0.95 KV size metric went missing from StoreScanner. -- Key: HBASE-7255 URL: https://issues.apache.org/jira/browse/HBASE-7255 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Elliott Clark Priority: Critical Fix For: 0.98.0, 0.95.1 Attachments: HBASE-7255-0.patch, HBASE-7255-1.patch, HBASE-7255-2.patch, HBASE-7255-3.patch, HBASE-7255-4.patch In trunk due to the metric refactor, at least the KV size metric went missing. See this code in StoreScanner.java: {code} } finally { if (cumulativeMetric 0 metric != null) { } } {code} Just an empty if statement, where the metric used to be collected. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7255) KV size metric went missing from StoreScanner.
[ https://issues.apache.org/jira/browse/HBASE-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-7255: - Attachment: HBASE-7255-3.patch KV size metric went missing from StoreScanner. -- Key: HBASE-7255 URL: https://issues.apache.org/jira/browse/HBASE-7255 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Elliott Clark Priority: Critical Fix For: 0.95.1 Attachments: HBASE-7255-0.patch, HBASE-7255-1.patch, HBASE-7255-2.patch, HBASE-7255-3.patch In trunk due to the metric refactor, at least the KV size metric went missing. See this code in StoreScanner.java: {code} } finally { if (cumulativeMetric 0 metric != null) { } } {code} Just an empty if statement, where the metric used to be collected. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7255) KV size metric went missing from StoreScanner.
[ https://issues.apache.org/jira/browse/HBASE-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-7255: - Attachment: HBASE-7255-4.patch So I had to move the key size computation into nextRaw as some scans (ones that aren't meta) were missing metrics. So I added a test to make sure this isn't missed again. KV size metric went missing from StoreScanner. -- Key: HBASE-7255 URL: https://issues.apache.org/jira/browse/HBASE-7255 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Elliott Clark Priority: Critical Fix For: 0.95.1 Attachments: HBASE-7255-0.patch, HBASE-7255-1.patch, HBASE-7255-2.patch, HBASE-7255-3.patch, HBASE-7255-4.patch In trunk due to the metric refactor, at least the KV size metric went missing. See this code in StoreScanner.java: {code} } finally { if (cumulativeMetric 0 metric != null) { } } {code} Just an empty if statement, where the metric used to be collected. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7255) KV size metric went missing from StoreScanner.
[ https://issues.apache.org/jira/browse/HBASE-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-7255: - Status: Open (was: Patch Available) KV size metric went missing from StoreScanner. -- Key: HBASE-7255 URL: https://issues.apache.org/jira/browse/HBASE-7255 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Elliott Clark Priority: Critical Fix For: 0.95.1 Attachments: HBASE-7255-0.patch, HBASE-7255-1.patch In trunk due to the metric refactor, at least the KV size metric went missing. See this code in StoreScanner.java: {code} } finally { if (cumulativeMetric 0 metric != null) { } } {code} Just an empty if statement, where the metric used to be collected. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7255) KV size metric went missing from StoreScanner.
[ https://issues.apache.org/jira/browse/HBASE-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-7255: - Attachment: HBASE-7255-2.patch Added more comments for ted. KV size metric went missing from StoreScanner. -- Key: HBASE-7255 URL: https://issues.apache.org/jira/browse/HBASE-7255 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Elliott Clark Priority: Critical Fix For: 0.95.1 Attachments: HBASE-7255-0.patch, HBASE-7255-1.patch, HBASE-7255-2.patch In trunk due to the metric refactor, at least the KV size metric went missing. See this code in StoreScanner.java: {code} } finally { if (cumulativeMetric 0 metric != null) { } } {code} Just an empty if statement, where the metric used to be collected. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7255) KV size metric went missing from StoreScanner.
[ https://issues.apache.org/jira/browse/HBASE-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-7255: - Status: Patch Available (was: Open) KV size metric went missing from StoreScanner. -- Key: HBASE-7255 URL: https://issues.apache.org/jira/browse/HBASE-7255 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Elliott Clark Priority: Critical Fix For: 0.95.1 Attachments: HBASE-7255-0.patch, HBASE-7255-1.patch, HBASE-7255-2.patch In trunk due to the metric refactor, at least the KV size metric went missing. See this code in StoreScanner.java: {code} } finally { if (cumulativeMetric 0 metric != null) { } } {code} Just an empty if statement, where the metric used to be collected. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7255) KV size metric went missing from StoreScanner.
[ https://issues.apache.org/jira/browse/HBASE-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-7255: - Attachment: HBASE-7255-0.patch Adds get and scan sizes back per region. KV size metric went missing from StoreScanner. -- Key: HBASE-7255 URL: https://issues.apache.org/jira/browse/HBASE-7255 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Elliott Clark Priority: Critical Fix For: 0.95.1 Attachments: HBASE-7255-0.patch In trunk due to the metric refactor, at least the KV size metric went missing. See this code in StoreScanner.java: {code} } finally { if (cumulativeMetric 0 metric != null) { } } {code} Just an empty if statement, where the metric used to be collected. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7255) KV size metric went missing from StoreScanner.
[ https://issues.apache.org/jira/browse/HBASE-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-7255: - Attachment: HBASE-7255-1.patch KV size metric went missing from StoreScanner. -- Key: HBASE-7255 URL: https://issues.apache.org/jira/browse/HBASE-7255 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Elliott Clark Priority: Critical Fix For: 0.95.1 Attachments: HBASE-7255-0.patch, HBASE-7255-1.patch In trunk due to the metric refactor, at least the KV size metric went missing. See this code in StoreScanner.java: {code} } finally { if (cumulativeMetric 0 metric != null) { } } {code} Just an empty if statement, where the metric used to be collected. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7255) KV size metric went missing from StoreScanner.
[ https://issues.apache.org/jira/browse/HBASE-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-7255: - Status: Patch Available (was: Open) KV size metric went missing from StoreScanner. -- Key: HBASE-7255 URL: https://issues.apache.org/jira/browse/HBASE-7255 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Elliott Clark Priority: Critical Fix For: 0.95.1 Attachments: HBASE-7255-0.patch, HBASE-7255-1.patch In trunk due to the metric refactor, at least the KV size metric went missing. See this code in StoreScanner.java: {code} } finally { if (cumulativeMetric 0 metric != null) { } } {code} Just an empty if statement, where the metric used to be collected. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7255) KV size metric went missing from StoreScanner.
[ https://issues.apache.org/jira/browse/HBASE-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-7255: - Priority: Critical (was: Major) Making critical so we don't forget it. Seems like simple fix. KV size metric went missing from StoreScanner. -- Key: HBASE-7255 URL: https://issues.apache.org/jira/browse/HBASE-7255 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Elliott Clark Priority: Critical Fix For: 0.96.0 In trunk due to the metric refactor, at least the KV size metric went missing. See this code in StoreScanner.java: {code} } finally { if (cumulativeMetric 0 metric != null) { } } {code} Just an empty if statement, where the metric used to be collected. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira