[jira] [Updated] (HBASE-7658) grant with an empty string as permission should throw an exception
[
https://issues.apache.org/jira/browse/HBASE-7658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matteo Bertozzi updated HBASE-7658:
---
Attachment: HBASE-7658-v0.patch
patch that catch the null action from the shell...
if I throw an exception in the method the client keeps retrying until reaches
the limit of retries number... I need to look into that.
> grant with an empty string as permission should throw an exception
> --
>
> Key: HBASE-7658
> URL: https://issues.apache.org/jira/browse/HBASE-7658
> Project: HBase
> Issue Type: Bug
> Components: security
>Affects Versions: 0.96.0, 0.94.4
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Trivial
> Attachments: HBASE-7658-v0.patch
>
>
> If someone specify an empty permission
> {code}grant 'user', ''{code}
> AccessControlLists.addUserPermission() output a log message and doesn't
> change the permission, but the user doesn't know about it.
> {code}
> if ((actions == null) || (actions.length == 0)) {
> LOG.warn("No actions associated with user
> '"+Bytes.toString(userPerm.getUser())+"'");
> return;
> }
> {code}
> I think we should throw an exception instead of just logging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7658) grant with an empty string as permission should throw an exception
[
https://issues.apache.org/jira/browse/HBASE-7658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matteo Bertozzi updated HBASE-7658:
---
Attachment: HBASE-7658-v1.patch
> grant with an empty string as permission should throw an exception
> --
>
> Key: HBASE-7658
> URL: https://issues.apache.org/jira/browse/HBASE-7658
> Project: HBase
> Issue Type: Bug
> Components: security
>Affects Versions: 0.94.4, 0.95.2
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Trivial
> Attachments: HBASE-7658-v0.patch, HBASE-7658-v1.patch
>
>
> If someone specify an empty permission
> {code}grant 'user', ''{code}
> AccessControlLists.addUserPermission() output a log message and doesn't
> change the permission, but the user doesn't know about it.
> {code}
> if ((actions == null) || (actions.length == 0)) {
> LOG.warn("No actions associated with user
> '"+Bytes.toString(userPerm.getUser())+"'");
> return;
> }
> {code}
> I think we should throw an exception instead of just logging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7658) grant with an empty string as permission should throw an exception
[
https://issues.apache.org/jira/browse/HBASE-7658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matteo Bertozzi updated HBASE-7658:
---
Affects Version/s: (was: 0.94.4)
Status: Patch Available (was: Open)
> grant with an empty string as permission should throw an exception
> --
>
> Key: HBASE-7658
> URL: https://issues.apache.org/jira/browse/HBASE-7658
> Project: HBase
> Issue Type: Bug
> Components: security
>Affects Versions: 0.95.2
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Trivial
> Attachments: HBASE-7658-v0.patch, HBASE-7658-v1.patch
>
>
> If someone specify an empty permission
> {code}grant 'user', ''{code}
> AccessControlLists.addUserPermission() output a log message and doesn't
> change the permission, but the user doesn't know about it.
> {code}
> if ((actions == null) || (actions.length == 0)) {
> LOG.warn("No actions associated with user
> '"+Bytes.toString(userPerm.getUser())+"'");
> return;
> }
> {code}
> I think we should throw an exception instead of just logging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7658) grant with an empty string as permission should throw an exception
[
https://issues.apache.org/jira/browse/HBASE-7658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matteo Bertozzi updated HBASE-7658:
---
Resolution: Fixed
Fix Version/s: 0.95.1
Status: Resolved (was: Patch Available)
> grant with an empty string as permission should throw an exception
> --
>
> Key: HBASE-7658
> URL: https://issues.apache.org/jira/browse/HBASE-7658
> Project: HBase
> Issue Type: Bug
> Components: security
>Affects Versions: 0.95.2
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Trivial
> Fix For: 0.95.1
>
> Attachments: HBASE-7658-v0.patch, HBASE-7658-v1.patch
>
>
> If someone specify an empty permission
> {code}grant 'user', ''{code}
> AccessControlLists.addUserPermission() output a log message and doesn't
> change the permission, but the user doesn't know about it.
> {code}
> if ((actions == null) || (actions.length == 0)) {
> LOG.warn("No actions associated with user
> '"+Bytes.toString(userPerm.getUser())+"'");
> return;
> }
> {code}
> I think we should throw an exception instead of just logging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7658) grant with an empty string as permission should throw an exception
[
https://issues.apache.org/jira/browse/HBASE-7658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matteo Bertozzi updated HBASE-7658:
---
Attachment: HBASE-7658-0.94.patch
94 patch, is the same as trunk. If no objection I'll backport it
> grant with an empty string as permission should throw an exception
> --
>
> Key: HBASE-7658
> URL: https://issues.apache.org/jira/browse/HBASE-7658
> Project: HBase
> Issue Type: Bug
> Components: security
>Affects Versions: 0.95.2
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Trivial
> Fix For: 0.95.1
>
> Attachments: HBASE-7658-0.94.patch, HBASE-7658-v0.patch,
> HBASE-7658-v1.patch
>
>
> If someone specify an empty permission
> {code}grant 'user', ''{code}
> AccessControlLists.addUserPermission() output a log message and doesn't
> change the permission, but the user doesn't know about it.
> {code}
> if ((actions == null) || (actions.length == 0)) {
> LOG.warn("No actions associated with user
> '"+Bytes.toString(userPerm.getUser())+"'");
> return;
> }
> {code}
> I think we should throw an exception instead of just logging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
