[jira] [Updated] (HBASE-7789) Clean DeadServer.java and add a Jitter method in ConnectionUtils
[ https://issues.apache.org/jira/browse/HBASE-7789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nkeywal updated HBASE-7789: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) > Clean DeadServer.java and add a Jitter method in ConnectionUtils > > > Key: HBASE-7789 > URL: https://issues.apache.org/jira/browse/HBASE-7789 > Project: HBase > Issue Type: Bug > Components: master >Affects Versions: 0.96.0 >Reporter: nkeywal >Assignee: nkeywal > Fix For: 0.96.0 > > Attachments: 7789.v1.patch, 7789.v2.patch > > > I need to do some changes in DeadServer because of HBASE-7590. To minimize > the patch size and simplifies the feedback, I prefer to isolate the issue. > Changes are: > - Add the time when the server was declared as dead. It's what I need in > HBASE-7590, but it makes sense even without it, for example to be shown in > the UI. > - suppress the extends on Set & clean up all the not used methods > - use directly the object instead of a copy. > For connection utils, we currently have a jitter of 1%. I need a bigger one > for sure in one case, but I wonder if we should not increase it in all cases? > instead of plus 1%, we should have plus or minus 10% imho. > Tests are in progress locally, I will add the patch when they're ok. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7789) Clean DeadServer.java and add a Jitter method in ConnectionUtils
[ https://issues.apache.org/jira/browse/HBASE-7789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nkeywal updated HBASE-7789: --- Attachment: 7789.v2.patch > Clean DeadServer.java and add a Jitter method in ConnectionUtils > > > Key: HBASE-7789 > URL: https://issues.apache.org/jira/browse/HBASE-7789 > Project: HBase > Issue Type: Bug > Components: master >Affects Versions: 0.96.0 >Reporter: nkeywal >Assignee: nkeywal > Fix For: 0.96.0 > > Attachments: 7789.v1.patch, 7789.v2.patch > > > I need to do some changes in DeadServer because of HBASE-7590. To minimize > the patch size and simplifies the feedback, I prefer to isolate the issue. > Changes are: > - Add the time when the server was declared as dead. It's what I need in > HBASE-7590, but it makes sense even without it, for example to be shown in > the UI. > - suppress the extends on Set & clean up all the not used methods > - use directly the object instead of a copy. > For connection utils, we currently have a jitter of 1%. I need a bigger one > for sure in one case, but I wonder if we should not increase it in all cases? > instead of plus 1%, we should have plus or minus 10% imho. > Tests are in progress locally, I will add the patch when they're ok. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7789) Clean DeadServer.java and add a Jitter method in ConnectionUtils
[ https://issues.apache.org/jira/browse/HBASE-7789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nkeywal updated HBASE-7789: --- Description: I need to do some changes in DeadServer because of HBASE-7590. To minimize the patch size and simplifies the feedback, I prefer to isolate the issue. Changes are: - Add the time when the server was declared as dead. It's what I need in HBASE-7590, but it makes sense even without it, for example to be shown in the UI. - suppress the extends on Set & clean up all the not used methods - use directly the object instead of a copy. For connection utils, we currently have a jitter of 1%. I need a bigger one for sure in one case, but I wonder if we should not increase it in all cases? instead of plus 1%, we should have plus or minus 10% imho. Tests are in progress locally, I will add the patch when they're ok. was: I need to do some changes in DeadServer because of HBASE-7390. To minimize the patch size and simplifies the feedback, I prefer to isolate the issue. Changes are: - Add the time when the server was declared as dead. It's what I need in HBASE-7390, but it makes sense even without it, for example to be shown in the UI. - suppress the extends on Set & clean up all the not used methods - use directly the object instead of a copy. For connection utils, we currently have a jitter of 1%. I need a bigger one for sure in one case, but I wonder if we should not increase it in all cases? instead of plus 1%, we should have plus or minus 10% imho. Tests are in progress locally, I will add the patch when they're ok. > Clean DeadServer.java and add a Jitter method in ConnectionUtils > > > Key: HBASE-7789 > URL: https://issues.apache.org/jira/browse/HBASE-7789 > Project: HBase > Issue Type: Bug > Components: master >Affects Versions: 0.96.0 >Reporter: nkeywal >Assignee: nkeywal > Fix For: 0.96.0 > > Attachments: 7789.v1.patch > > > I need to do some changes in DeadServer because of HBASE-7590. To minimize > the patch size and simplifies the feedback, I prefer to isolate the issue. > Changes are: > - Add the time when the server was declared as dead. It's what I need in > HBASE-7590, but it makes sense even without it, for example to be shown in > the UI. > - suppress the extends on Set & clean up all the not used methods > - use directly the object instead of a copy. > For connection utils, we currently have a jitter of 1%. I need a bigger one > for sure in one case, but I wonder if we should not increase it in all cases? > instead of plus 1%, we should have plus or minus 10% imho. > Tests are in progress locally, I will add the patch when they're ok. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7789) Clean DeadServer.java and add a Jitter method in ConnectionUtils
[ https://issues.apache.org/jira/browse/HBASE-7789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nkeywal updated HBASE-7789: --- Status: Patch Available (was: Open) > Clean DeadServer.java and add a Jitter method in ConnectionUtils > > > Key: HBASE-7789 > URL: https://issues.apache.org/jira/browse/HBASE-7789 > Project: HBase > Issue Type: Bug > Components: master >Affects Versions: 0.96.0 >Reporter: nkeywal >Assignee: nkeywal > Fix For: 0.96.0 > > Attachments: 7789.v1.patch > > > I need to do some changes in DeadServer because of HBASE-7390. To minimize > the patch size and simplifies the feedback, I prefer to isolate the issue. > Changes are: > - Add the time when the server was declared as dead. It's what I need in > HBASE-7390, but it makes sense even without it, for example to be shown in > the UI. > - suppress the extends on Set & clean up all the not used methods > - use directly the object instead of a copy. > For connection utils, we currently have a jitter of 1%. I need a bigger one > for sure in one case, but I wonder if we should not increase it in all cases? > instead of plus 1%, we should have plus or minus 10% imho. > Tests are in progress locally, I will add the patch when they're ok. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7789) Clean DeadServer.java and add a Jitter method in ConnectionUtils
[ https://issues.apache.org/jira/browse/HBASE-7789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nkeywal updated HBASE-7789: --- Attachment: 7789.v1.patch > Clean DeadServer.java and add a Jitter method in ConnectionUtils > > > Key: HBASE-7789 > URL: https://issues.apache.org/jira/browse/HBASE-7789 > Project: HBase > Issue Type: Bug > Components: master >Affects Versions: 0.96.0 >Reporter: nkeywal >Assignee: nkeywal > Fix For: 0.96.0 > > Attachments: 7789.v1.patch > > > I need to do some changes in DeadServer because of HBASE-7390. To minimize > the patch size and simplifies the feedback, I prefer to isolate the issue. > Changes are: > - Add the time when the server was declared as dead. It's what I need in > HBASE-7390, but it makes sense even without it, for example to be shown in > the UI. > - suppress the extends on Set & clean up all the not used methods > - use directly the object instead of a copy. > For connection utils, we currently have a jitter of 1%. I need a bigger one > for sure in one case, but I wonder if we should not increase it in all cases? > instead of plus 1%, we should have plus or minus 10% imho. > Tests are in progress locally, I will add the patch when they're ok. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
