[jira] [Updated] (HBASE-7970) Improve file descriptor usage: currently, there are two file descriptors per storefile
[
https://issues.apache.org/jira/browse/HBASE-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated HBASE-7970:
Resolution: Fixed
Status: Resolved (was: Patch Available)
in 95 and trunk
> Improve file descriptor usage: currently, there are two file descriptors per
> storefile
> --
>
> Key: HBASE-7970
> URL: https://issues.apache.org/jira/browse/HBASE-7970
> Project: HBase
> Issue Type: Sub-task
>Reporter: Himanshu Vashishtha
>Assignee: Sergey Shelukhin
> Attachments: HBASE-7970-v0.patch, HBASE-7970-v1.patch,
> HBASE-7970-v2.1.patch, HBASE-7970-v2.patch, HBASE-7970-v3.patch,
> HBASE-7970-v4.patch
>
>
> This is because there are two open calls in the HFile: one with checksum and
> another for without checksum support in v2:
> see the method in HFile:createReaderWithEncoding()
> {code}
> FSDataInputStream fsdis = fs.open(path);
> FSDataInputStream fsdisNoFsChecksum = fsdis;
> // If the fs is not an instance of HFileSystem, then create an
> // instance of HFileSystem that wraps over the specified fs.
> // In this case, we will not be able to avoid checksumming inside
> // the filesystem.
> if (!(fs instanceof HFileSystem)) {
> hfs = new HFileSystem(fs);
> } else {
> hfs = (HFileSystem)fs;
> // open a stream to read data without checksum verification in
> // the filesystem
> fsdisNoFsChecksum = hfs.getNoChecksumFs().open(path);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7970) Improve file descriptor usage: currently, there are two file descriptors per storefile
[
https://issues.apache.org/jira/browse/HBASE-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated HBASE-7970:
Attachment: HBASE-7970-v4.patch
> Improve file descriptor usage: currently, there are two file descriptors per
> storefile
> --
>
> Key: HBASE-7970
> URL: https://issues.apache.org/jira/browse/HBASE-7970
> Project: HBase
> Issue Type: Sub-task
>Reporter: Himanshu Vashishtha
>Assignee: Sergey Shelukhin
> Attachments: HBASE-7970-v0.patch, HBASE-7970-v1.patch,
> HBASE-7970-v2.1.patch, HBASE-7970-v2.patch, HBASE-7970-v3.patch,
> HBASE-7970-v4.patch
>
>
> This is because there are two open calls in the HFile: one with checksum and
> another for without checksum support in v2:
> see the method in HFile:createReaderWithEncoding()
> {code}
> FSDataInputStream fsdis = fs.open(path);
> FSDataInputStream fsdisNoFsChecksum = fsdis;
> // If the fs is not an instance of HFileSystem, then create an
> // instance of HFileSystem that wraps over the specified fs.
> // In this case, we will not be able to avoid checksumming inside
> // the filesystem.
> if (!(fs instanceof HFileSystem)) {
> hfs = new HFileSystem(fs);
> } else {
> hfs = (HFileSystem)fs;
> // open a stream to read data without checksum verification in
> // the filesystem
> fsdisNoFsChecksum = hfs.getNoChecksumFs().open(path);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7970) Improve file descriptor usage: currently, there are two file descriptors per storefile
[
https://issues.apache.org/jira/browse/HBASE-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated HBASE-7970:
Attachment: HBASE-7970-v3.patch
try again... stupid error in assert
> Improve file descriptor usage: currently, there are two file descriptors per
> storefile
> --
>
> Key: HBASE-7970
> URL: https://issues.apache.org/jira/browse/HBASE-7970
> Project: HBase
> Issue Type: Sub-task
>Reporter: Himanshu Vashishtha
>Assignee: Sergey Shelukhin
> Attachments: HBASE-7970-v0.patch, HBASE-7970-v1.patch,
> HBASE-7970-v2.1.patch, HBASE-7970-v2.patch, HBASE-7970-v3.patch
>
>
> This is because there are two open calls in the HFile: one with checksum and
> another for without checksum support in v2:
> see the method in HFile:createReaderWithEncoding()
> {code}
> FSDataInputStream fsdis = fs.open(path);
> FSDataInputStream fsdisNoFsChecksum = fsdis;
> // If the fs is not an instance of HFileSystem, then create an
> // instance of HFileSystem that wraps over the specified fs.
> // In this case, we will not be able to avoid checksumming inside
> // the filesystem.
> if (!(fs instanceof HFileSystem)) {
> hfs = new HFileSystem(fs);
> } else {
> hfs = (HFileSystem)fs;
> // open a stream to read data without checksum verification in
> // the filesystem
> fsdisNoFsChecksum = hfs.getNoChecksumFs().open(path);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7970) Improve file descriptor usage: currently, there are two file descriptors per storefile
[
https://issues.apache.org/jira/browse/HBASE-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated HBASE-7970:
Attachment: HBASE-7970-v2.1.patch
attaching... (for QA)
> Improve file descriptor usage: currently, there are two file descriptors per
> storefile
> --
>
> Key: HBASE-7970
> URL: https://issues.apache.org/jira/browse/HBASE-7970
> Project: HBase
> Issue Type: Sub-task
>Reporter: Himanshu Vashishtha
>Assignee: Sergey Shelukhin
> Attachments: HBASE-7970-v0.patch, HBASE-7970-v1.patch,
> HBASE-7970-v2.1.patch, HBASE-7970-v2.patch
>
>
> This is because there are two open calls in the HFile: one with checksum and
> another for without checksum support in v2:
> see the method in HFile:createReaderWithEncoding()
> {code}
> FSDataInputStream fsdis = fs.open(path);
> FSDataInputStream fsdisNoFsChecksum = fsdis;
> // If the fs is not an instance of HFileSystem, then create an
> // instance of HFileSystem that wraps over the specified fs.
> // In this case, we will not be able to avoid checksumming inside
> // the filesystem.
> if (!(fs instanceof HFileSystem)) {
> hfs = new HFileSystem(fs);
> } else {
> hfs = (HFileSystem)fs;
> // open a stream to read data without checksum verification in
> // the filesystem
> fsdisNoFsChecksum = hfs.getNoChecksumFs().open(path);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7970) Improve file descriptor usage: currently, there are two file descriptors per storefile
[
https://issues.apache.org/jira/browse/HBASE-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated HBASE-7970:
Attachment: HBASE-7970-v2.patch
Added comments
> Improve file descriptor usage: currently, there are two file descriptors per
> storefile
> --
>
> Key: HBASE-7970
> URL: https://issues.apache.org/jira/browse/HBASE-7970
> Project: HBase
> Issue Type: Sub-task
>Reporter: Himanshu Vashishtha
>Assignee: Sergey Shelukhin
> Attachments: HBASE-7970-v0.patch, HBASE-7970-v1.patch,
> HBASE-7970-v2.patch
>
>
> This is because there are two open calls in the HFile: one with checksum and
> another for without checksum support in v2:
> see the method in HFile:createReaderWithEncoding()
> {code}
> FSDataInputStream fsdis = fs.open(path);
> FSDataInputStream fsdisNoFsChecksum = fsdis;
> // If the fs is not an instance of HFileSystem, then create an
> // instance of HFileSystem that wraps over the specified fs.
> // In this case, we will not be able to avoid checksumming inside
> // the filesystem.
> if (!(fs instanceof HFileSystem)) {
> hfs = new HFileSystem(fs);
> } else {
> hfs = (HFileSystem)fs;
> // open a stream to read data without checksum verification in
> // the filesystem
> fsdisNoFsChecksum = hfs.getNoChecksumFs().open(path);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7970) Improve file descriptor usage: currently, there are two file descriptors per storefile
[
https://issues.apache.org/jira/browse/HBASE-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated HBASE-7970:
Attachment: HBASE-7970-v1.patch
r feedback, fix javadoc
> Improve file descriptor usage: currently, there are two file descriptors per
> storefile
> --
>
> Key: HBASE-7970
> URL: https://issues.apache.org/jira/browse/HBASE-7970
> Project: HBase
> Issue Type: Sub-task
>Reporter: Himanshu Vashishtha
>Assignee: Sergey Shelukhin
> Attachments: HBASE-7970-v0.patch, HBASE-7970-v1.patch
>
>
> This is because there are two open calls in the HFile: one with checksum and
> another for without checksum support in v2:
> see the method in HFile:createReaderWithEncoding()
> {code}
> FSDataInputStream fsdis = fs.open(path);
> FSDataInputStream fsdisNoFsChecksum = fsdis;
> // If the fs is not an instance of HFileSystem, then create an
> // instance of HFileSystem that wraps over the specified fs.
> // In this case, we will not be able to avoid checksumming inside
> // the filesystem.
> if (!(fs instanceof HFileSystem)) {
> hfs = new HFileSystem(fs);
> } else {
> hfs = (HFileSystem)fs;
> // open a stream to read data without checksum verification in
> // the filesystem
> fsdisNoFsChecksum = hfs.getNoChecksumFs().open(path);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7970) Improve file descriptor usage: currently, there are two file descriptors per storefile
[
https://issues.apache.org/jira/browse/HBASE-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated HBASE-7970:
Attachment: HBASE-7970-v0.patch
Here's the patch. I ended up encapsulated bunch of things, so r is at
https://reviews.apache.org/r/10202/
> Improve file descriptor usage: currently, there are two file descriptors per
> storefile
> --
>
> Key: HBASE-7970
> URL: https://issues.apache.org/jira/browse/HBASE-7970
> Project: HBase
> Issue Type: Sub-task
>Reporter: Himanshu Vashishtha
>Assignee: Sergey Shelukhin
> Attachments: HBASE-7970-v0.patch
>
>
> This is because there are two open calls in the HFile: one with checksum and
> another for without checksum support in v2:
> see the method in HFile:createReaderWithEncoding()
> {code}
> FSDataInputStream fsdis = fs.open(path);
> FSDataInputStream fsdisNoFsChecksum = fsdis;
> // If the fs is not an instance of HFileSystem, then create an
> // instance of HFileSystem that wraps over the specified fs.
> // In this case, we will not be able to avoid checksumming inside
> // the filesystem.
> if (!(fs instanceof HFileSystem)) {
> hfs = new HFileSystem(fs);
> } else {
> hfs = (HFileSystem)fs;
> // open a stream to read data without checksum verification in
> // the filesystem
> fsdisNoFsChecksum = hfs.getNoChecksumFs().open(path);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7970) Improve file descriptor usage: currently, there are two file descriptors per storefile
[
https://issues.apache.org/jira/browse/HBASE-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated HBASE-7970:
Status: Patch Available (was: Open)
> Improve file descriptor usage: currently, there are two file descriptors per
> storefile
> --
>
> Key: HBASE-7970
> URL: https://issues.apache.org/jira/browse/HBASE-7970
> Project: HBase
> Issue Type: Sub-task
>Reporter: Himanshu Vashishtha
>Assignee: Sergey Shelukhin
> Attachments: HBASE-7970-v0.patch
>
>
> This is because there are two open calls in the HFile: one with checksum and
> another for without checksum support in v2:
> see the method in HFile:createReaderWithEncoding()
> {code}
> FSDataInputStream fsdis = fs.open(path);
> FSDataInputStream fsdisNoFsChecksum = fsdis;
> // If the fs is not an instance of HFileSystem, then create an
> // instance of HFileSystem that wraps over the specified fs.
> // In this case, we will not be able to avoid checksumming inside
> // the filesystem.
> if (!(fs instanceof HFileSystem)) {
> hfs = new HFileSystem(fs);
> } else {
> hfs = (HFileSystem)fs;
> // open a stream to read data without checksum verification in
> // the filesystem
> fsdisNoFsChecksum = hfs.getNoChecksumFs().open(path);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7970) Improve file descriptor usage: currently, there are two file descriptors per storefile
[
https://issues.apache.org/jira/browse/HBASE-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-7970:
--
Summary: Improve file descriptor usage: currently, there are two file
descriptors per storefile (was: Improve file descriptor usage: Currently,
there are two fds per one storefile)
> Improve file descriptor usage: currently, there are two file descriptors per
> storefile
> --
>
> Key: HBASE-7970
> URL: https://issues.apache.org/jira/browse/HBASE-7970
> Project: HBase
> Issue Type: Sub-task
>Reporter: Himanshu Vashishtha
>
> This is because there are two open calls in the HFile: one with checksum and
> another for without checksum support in v2:
> see the method in HFile:createReaderWithEncoding()
> {code}
> FSDataInputStream fsdis = fs.open(path);
> FSDataInputStream fsdisNoFsChecksum = fsdis;
> // If the fs is not an instance of HFileSystem, then create an
> // instance of HFileSystem that wraps over the specified fs.
> // In this case, we will not be able to avoid checksumming inside
> // the filesystem.
> if (!(fs instanceof HFileSystem)) {
> hfs = new HFileSystem(fs);
> } else {
> hfs = (HFileSystem)fs;
> // open a stream to read data without checksum verification in
> // the filesystem
> fsdisNoFsChecksum = hfs.getNoChecksumFs().open(path);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
