[jira] [Updated] (HBASE-9816) Address review comments in HBASE-8496
[ https://issues.apache.org/jira/browse/HBASE-9816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-9816: -- Attachment: HBASE-9816_3.patch Latest updated patch against latest code. Will commit later in the evening > Address review comments in HBASE-8496 > - > > Key: HBASE-9816 > URL: https://issues.apache.org/jira/browse/HBASE-9816 > Project: HBase > Issue Type: Bug >Affects Versions: 0.98.0 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.98.0 > > Attachments: HBASE-9816.patch, HBASE-9816_1.patch, > HBASE-9816_1.patch, HBASE-9816_2.patch, HBASE-9816_3.patch > > > This JIRA would be used to address the review comments in HBASE-8496. Any > more comments would be addressed and committed as part of this. There are > already few comments from Stack on the RB. > https://reviews.apache.org/r/13311/ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HBASE-9816) Address review comments in HBASE-8496
[ https://issues.apache.org/jira/browse/HBASE-9816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-9816: -- Status: Open (was: Patch Available) > Address review comments in HBASE-8496 > - > > Key: HBASE-9816 > URL: https://issues.apache.org/jira/browse/HBASE-9816 > Project: HBase > Issue Type: Bug >Affects Versions: 0.98.0 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.98.0 > > Attachments: HBASE-9816.patch, HBASE-9816_1.patch, > HBASE-9816_1.patch, HBASE-9816_2.patch > > > This JIRA would be used to address the review comments in HBASE-8496. Any > more comments would be addressed and committed as part of this. There are > already few comments from Stack on the RB. > https://reviews.apache.org/r/13311/ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HBASE-9816) Address review comments in HBASE-8496
[ https://issues.apache.org/jira/browse/HBASE-9816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-9816: -- Status: Patch Available (was: Open) > Address review comments in HBASE-8496 > - > > Key: HBASE-9816 > URL: https://issues.apache.org/jira/browse/HBASE-9816 > Project: HBase > Issue Type: Bug >Affects Versions: 0.98.0 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.98.0 > > Attachments: HBASE-9816.patch, HBASE-9816_1.patch, > HBASE-9816_1.patch, HBASE-9816_2.patch > > > This JIRA would be used to address the review comments in HBASE-8496. Any > more comments would be addressed and committed as part of this. There are > already few comments from Stack on the RB. > https://reviews.apache.org/r/13311/ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HBASE-9816) Address review comments in HBASE-8496
[ https://issues.apache.org/jira/browse/HBASE-9816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-9816: -- Attachment: HBASE-9816_2.patch Latest patch for trunk. Regarding that TODO it is because for builder pattern generally we don't have setters but here we need to setIncludesTags based on the Writer V2 or V3. Hence after the HFileContext is built we still change the includesTag param. > Address review comments in HBASE-8496 > - > > Key: HBASE-9816 > URL: https://issues.apache.org/jira/browse/HBASE-9816 > Project: HBase > Issue Type: Bug >Affects Versions: 0.98.0 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.98.0 > > Attachments: HBASE-9816.patch, HBASE-9816_1.patch, > HBASE-9816_1.patch, HBASE-9816_2.patch > > > This JIRA would be used to address the review comments in HBASE-8496. Any > more comments would be addressed and committed as part of this. There are > already few comments from Stack on the RB. > https://reviews.apache.org/r/13311/ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HBASE-9816) Address review comments in HBASE-8496
[ https://issues.apache.org/jira/browse/HBASE-9816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-9816: - Attachment: HBASE-9816_1.patch Retry against hadoopqa > Address review comments in HBASE-8496 > - > > Key: HBASE-9816 > URL: https://issues.apache.org/jira/browse/HBASE-9816 > Project: HBase > Issue Type: Bug >Affects Versions: 0.98.0 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.98.0 > > Attachments: HBASE-9816.patch, HBASE-9816_1.patch, HBASE-9816_1.patch > > > This JIRA would be used to address the review comments in HBASE-8496. Any > more comments would be addressed and committed as part of this. There are > already few comments from Stack on the RB. > https://reviews.apache.org/r/13311/ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HBASE-9816) Address review comments in HBASE-8496
[ https://issues.apache.org/jira/browse/HBASE-9816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-9816: -- Status: Open (was: Patch Available) > Address review comments in HBASE-8496 > - > > Key: HBASE-9816 > URL: https://issues.apache.org/jira/browse/HBASE-9816 > Project: HBase > Issue Type: Bug >Affects Versions: 0.98.0 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.98.0 > > Attachments: HBASE-9816.patch, HBASE-9816_1.patch > > > This JIRA would be used to address the review comments in HBASE-8496. Any > more comments would be addressed and committed as part of this. There are > already few comments from Stack on the RB. > https://reviews.apache.org/r/13311/ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HBASE-9816) Address review comments in HBASE-8496
[ https://issues.apache.org/jira/browse/HBASE-9816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-9816: -- Attachment: HBASE-9816_1.patch Updated patch. Trying to add to RB faced some issues. Will try again now. > Address review comments in HBASE-8496 > - > > Key: HBASE-9816 > URL: https://issues.apache.org/jira/browse/HBASE-9816 > Project: HBase > Issue Type: Bug >Affects Versions: 0.98.0 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.98.0 > > Attachments: HBASE-9816.patch, HBASE-9816_1.patch > > > This JIRA would be used to address the review comments in HBASE-8496. Any > more comments would be addressed and committed as part of this. There are > already few comments from Stack on the RB. > https://reviews.apache.org/r/13311/ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HBASE-9816) Address review comments in HBASE-8496
[ https://issues.apache.org/jira/browse/HBASE-9816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-9816: -- Status: Patch Available (was: In Progress) > Address review comments in HBASE-8496 > - > > Key: HBASE-9816 > URL: https://issues.apache.org/jira/browse/HBASE-9816 > Project: HBase > Issue Type: Bug >Affects Versions: 0.98.0 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.98.0 > > Attachments: HBASE-9816.patch > > > This JIRA would be used to address the review comments in HBASE-8496. Any > more comments would be addressed and committed as part of this. There are > already few comments from Stack on the RB. > https://reviews.apache.org/r/13311/ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HBASE-9816) Address review comments in HBASE-8496
[ https://issues.apache.org/jira/browse/HBASE-9816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-9816: -- Attachment: HBASE-9816.patch Patch that addresses the review comments. > Address review comments in HBASE-8496 > - > > Key: HBASE-9816 > URL: https://issues.apache.org/jira/browse/HBASE-9816 > Project: HBase > Issue Type: Bug >Affects Versions: 0.98.0 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.98.0 > > Attachments: HBASE-9816.patch > > > This JIRA would be used to address the review comments in HBASE-8496. Any > more comments would be addressed and committed as part of this. There are > already few comments from Stack on the RB. > https://reviews.apache.org/r/13311/ -- This message was sent by Atlassian JIRA (v6.1#6144)
