[jira] Commented: (HBASE-2721) Fix hardcoded defaults to match hbase-default.xml
[ https://issues.apache.org/jira/browse/HBASE-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918199#action_12918199 ] Jonathan Gray commented on HBASE-2721: -- Lars, you have time to work on this this week? Otherwise let's punt to 0.92 > Fix hardcoded defaults to match hbase-default.xml > - > > Key: HBASE-2721 > URL: https://issues.apache.org/jira/browse/HBASE-2721 > Project: HBase > Issue Type: Improvement >Affects Versions: 0.20.4 >Reporter: Lars George > Fix For: 0.90.0 > > > The defaults from the hbase-default.xml and what is hardcoded in the various > classes has deviated somewhat. Check and update code to match XML. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2721) Fix hardcoded defaults to match hbase-default.xml
[ https://issues.apache.org/jira/browse/HBASE-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878908#action_12878908 ] Lars George commented on HBASE-2721: I like that as I have always done the same in my own code. But since it was all hardcoded strings up until now I did not question to change it. :) But I am +1 > Fix hardcoded defaults to match hbase-default.xml > - > > Key: HBASE-2721 > URL: https://issues.apache.org/jira/browse/HBASE-2721 > Project: HBase > Issue Type: Improvement >Affects Versions: 0.20.4 >Reporter: Lars George > Fix For: 0.21.0 > > > The defaults from the hbase-default.xml and what is hardcoded in the various > classes has deviated somewhat. Check and update code to match XML. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2721) Fix hardcoded defaults to match hbase-default.xml
[ https://issues.apache.org/jira/browse/HBASE-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878640#action_12878640 ] Todd Lipcon commented on HBASE-2721: On the Hadoop side we moved towards putting all the conf keys/defaults as constants - eg HdfsConfigKeys.FOO_BAR_KEY and FOO_BAR_DEFAULT. Worth considering for HBase? There are plusses (everything in one place is easier to reference) and minuses (defaults farther away from where they're used), I spose > Fix hardcoded defaults to match hbase-default.xml > - > > Key: HBASE-2721 > URL: https://issues.apache.org/jira/browse/HBASE-2721 > Project: HBase > Issue Type: Improvement >Affects Versions: 0.20.4 >Reporter: Lars George > Fix For: 0.21.0 > > > The defaults from the hbase-default.xml and what is hardcoded in the various > classes has deviated somewhat. Check and update code to match XML. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
