[jira] Commented: (HBASE-3513) upgrade thrift to 0.5.0 and use mvn version
[ https://issues.apache.org/jira/browse/HBASE-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005492#comment-13005492 ] stack commented on HBASE-3513: -- I didn't notice the thrift 0.5.0 a hadoop built thing. Thanks for the warning @LarsF. > upgrade thrift to 0.5.0 and use mvn version > --- > > Key: HBASE-3513 > URL: https://issues.apache.org/jira/browse/HBASE-3513 > Project: HBase > Issue Type: Bug > Components: thrift >Reporter: ryan rawson >Assignee: ryan rawson > Fix For: 0.92.0 > > Attachments: HBASE-3513.txt, HBASE-3515.txt > > > We should upgrade our thrift to 0.5.0, it is the latest and greatest and is > in apache maven repo. > Doing some testing with a thrift 0.5.0 server, and an older pre-release php > client shows the two are on-wire compatible. > Given that the upgrade is entirely on the server side, and has no wire-impact > this should be a relatively low-impact change. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3513) upgrade thrift to 0.5.0 and use mvn version
[ https://issues.apache.org/jira/browse/HBASE-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005003#comment-13005003 ] Lars Francke commented on HBASE-3513: - Oh, I never saw your answer. Sorry Ryan I never searched for _libthrift_, thanks for pointing it out Stack. As this is a custom release by the Hadoop folks are we sure this is not in any way customized by them? I haven't looked at the Maven stuff in a while but by being in a custom group we might get a different version by accident as a transitive dependency if any other project decides to do the same as Hadoop. > upgrade thrift to 0.5.0 and use mvn version > --- > > Key: HBASE-3513 > URL: https://issues.apache.org/jira/browse/HBASE-3513 > Project: HBase > Issue Type: Bug > Components: thrift >Reporter: ryan rawson >Assignee: ryan rawson > Fix For: 0.92.0 > > Attachments: HBASE-3513.txt, HBASE-3515.txt > > > We should upgrade our thrift to 0.5.0, it is the latest and greatest and is > in apache maven repo. > Doing some testing with a thrift 0.5.0 server, and an older pre-release php > client shows the two are on-wire compatible. > Given that the upgrade is entirely on the server side, and has no wire-impact > this should be a relatively low-impact change. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3513) upgrade thrift to 0.5.0 and use mvn version
[ https://issues.apache.org/jira/browse/HBASE-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003608#comment-13003608 ] Hudson commented on HBASE-3513: --- Integrated in HBase-TRUNK #1771 (See [https://hudson.apache.org/hudson/job/HBase-TRUNK/1771/]) > upgrade thrift to 0.5.0 and use mvn version > --- > > Key: HBASE-3513 > URL: https://issues.apache.org/jira/browse/HBASE-3513 > Project: HBase > Issue Type: Bug > Components: thrift >Reporter: ryan rawson >Assignee: ryan rawson > Fix For: 0.92.0 > > Attachments: HBASE-3513.txt, HBASE-3515.txt > > > We should upgrade our thrift to 0.5.0, it is the latest and greatest and is > in apache maven repo. > Doing some testing with a thrift 0.5.0 server, and an older pre-release php > client shows the two are on-wire compatible. > Given that the upgrade is entirely on the server side, and has no wire-impact > this should be a relatively low-impact change. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3513) upgrade thrift to 0.5.0 and use mvn version
[ https://issues.apache.org/jira/browse/HBASE-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002881#comment-13002881 ] ryan rawson commented on HBASE-3513: it is wire compatible with older clients, tested with an older SU client. There is no actual incompatibility! > upgrade thrift to 0.5.0 and use mvn version > --- > > Key: HBASE-3513 > URL: https://issues.apache.org/jira/browse/HBASE-3513 > Project: HBase > Issue Type: Bug > Components: thrift >Reporter: ryan rawson >Assignee: ryan rawson > Fix For: 0.92.0 > > Attachments: HBASE-3513.txt, HBASE-3515.txt > > > We should upgrade our thrift to 0.5.0, it is the latest and greatest and is > in apache maven repo. > Doing some testing with a thrift 0.5.0 server, and an older pre-release php > client shows the two are on-wire compatible. > Given that the upgrade is entirely on the server side, and has no wire-impact > this should be a relatively low-impact change. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3513) upgrade thrift to 0.5.0 and use mvn version
[ https://issues.apache.org/jira/browse/HBASE-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002880#comment-13002880 ] stack commented on HBASE-3513: -- +1 on patch (if tests pass). This breaks old thrift clients? Needs to go into INCOMPATIBLE CHANGES section. Add a release note on resolve? > upgrade thrift to 0.5.0 and use mvn version > --- > > Key: HBASE-3513 > URL: https://issues.apache.org/jira/browse/HBASE-3513 > Project: HBase > Issue Type: Bug > Components: thrift >Reporter: ryan rawson >Assignee: ryan rawson > Fix For: 0.92.0 > > Attachments: HBASE-3513.txt, HBASE-3515.txt > > > We should upgrade our thrift to 0.5.0, it is the latest and greatest and is > in apache maven repo. > Doing some testing with a thrift 0.5.0 server, and an older pre-release php > client shows the two are on-wire compatible. > Given that the upgrade is entirely on the server side, and has no wire-impact > this should be a relatively low-impact change. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3513) upgrade thrift to 0.5.0 and use mvn version
[ https://issues.apache.org/jira/browse/HBASE-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001960#comment-13001960 ] Kazuki Ohta commented on HBASE-3513: Hi, ryan. Thanks for the comment. > hbase serverside thrift version. That's right. I'll test the wire compatibility in my environment. Big thanks for your patch anyway! > upgrade thrift to 0.5.0 and use mvn version > --- > > Key: HBASE-3513 > URL: https://issues.apache.org/jira/browse/HBASE-3513 > Project: HBase > Issue Type: Bug > Components: thrift >Affects Versions: 0.90.0 >Reporter: ryan rawson >Assignee: ryan rawson > Fix For: 0.90.2 > > Attachments: HBASE-3513.txt, HBASE-3515.txt > > > We should upgrade our thrift to 0.5.0, it is the latest and greatest and is > in apache maven repo. > Doing some testing with a thrift 0.5.0 server, and an older pre-release php > client shows the two are on-wire compatible. > Given that the upgrade is entirely on the server side, and has no wire-impact > this should be a relatively low-impact change. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3513) upgrade thrift to 0.5.0 and use mvn version
[ https://issues.apache.org/jira/browse/HBASE-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001820#comment-13001820 ] ryan rawson commented on HBASE-3513: Kazuki, 0.6.0 doesnt exist yet (in maven) so we cant depend on it. The on the wire serialization should be the same between 0.5.0 and 0.6.0, so you can use whatever version of C++ client you wish. This is about the _hbase serverside_ thrift version. > upgrade thrift to 0.5.0 and use mvn version > --- > > Key: HBASE-3513 > URL: https://issues.apache.org/jira/browse/HBASE-3513 > Project: HBase > Issue Type: Bug > Components: thrift >Affects Versions: 0.90.0 >Reporter: ryan rawson >Assignee: ryan rawson > Fix For: 0.90.2 > > Attachments: HBASE-3513.txt, HBASE-3515.txt > > > We should upgrade our thrift to 0.5.0, it is the latest and greatest and is > in apache maven repo. > Doing some testing with a thrift 0.5.0 server, and an older pre-release php > client shows the two are on-wire compatible. > Given that the upgrade is entirely on the server side, and has no wire-impact > this should be a relatively low-impact change. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3513) upgrade thrift to 0.5.0 and use mvn version
[ https://issues.apache.org/jira/browse/HBASE-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001598#comment-13001598 ] Kazuki Ohta commented on HBASE-3513: I prefer 0.6.0 rather than 0.5.0, because THRIFT-923 supports asynchronous client in C++. * https://issues.apache.org/jira/browse/THRIFT-923 * https://github.com/apache/thrift/blob/trunk/CHANGES FYI > upgrade thrift to 0.5.0 and use mvn version > --- > > Key: HBASE-3513 > URL: https://issues.apache.org/jira/browse/HBASE-3513 > Project: HBase > Issue Type: Bug > Components: thrift >Affects Versions: 0.90.0 >Reporter: ryan rawson >Assignee: ryan rawson > Fix For: 0.90.2 > > Attachments: HBASE-3515.txt > > > We should upgrade our thrift to 0.5.0, it is the latest and greatest and is > in apache maven repo. > Doing some testing with a thrift 0.5.0 server, and an older pre-release php > client shows the two are on-wire compatible. > Given that the upgrade is entirely on the server side, and has no wire-impact > this should be a relatively low-impact change. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3513) upgrade thrift to 0.5.0 and use mvn version
[ https://issues.apache.org/jira/browse/HBASE-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994567#comment-12994567 ] ryan rawson commented on HBASE-3513: Try this search: https://repository.apache.org/index.html#nexus-search;quick~libthrift > upgrade thrift to 0.5.0 and use mvn version > --- > > Key: HBASE-3513 > URL: https://issues.apache.org/jira/browse/HBASE-3513 > Project: HBase > Issue Type: Bug > Components: thrift >Affects Versions: 0.90.0 >Reporter: ryan rawson >Assignee: ryan rawson > Fix For: 0.90.2 > > Attachments: HBASE-3515.txt > > > We should upgrade our thrift to 0.5.0, it is the latest and greatest and is > in apache maven repo. > Doing some testing with a thrift 0.5.0 server, and an older pre-release php > client shows the two are on-wire compatible. > Given that the upgrade is entirely on the server side, and has no wire-impact > this should be a relatively low-impact change. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3513) upgrade thrift to 0.5.0 and use mvn version
[ https://issues.apache.org/jira/browse/HBASE-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994285#comment-12994285 ] Lars Francke commented on HBASE-3513: - Ryan, I'm pretty sure Thrift is *not* in any repository. As I said the issue is still unresolved and they are looking for help getting it into the repository. https://repository.apache.org/index.html#nexus-search;quick~thrift > upgrade thrift to 0.5.0 and use mvn version > --- > > Key: HBASE-3513 > URL: https://issues.apache.org/jira/browse/HBASE-3513 > Project: HBase > Issue Type: Bug > Components: thrift >Affects Versions: 0.90.0 >Reporter: ryan rawson >Assignee: ryan rawson > Fix For: 0.90.2 > > Attachments: HBASE-3515.txt > > > We should upgrade our thrift to 0.5.0, it is the latest and greatest and is > in apache maven repo. > Doing some testing with a thrift 0.5.0 server, and an older pre-release php > client shows the two are on-wire compatible. > Given that the upgrade is entirely on the server side, and has no wire-impact > this should be a relatively low-impact change. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3513) upgrade thrift to 0.5.0 and use mvn version
[ https://issues.apache.org/jira/browse/HBASE-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994152#comment-12994152 ] ryan rawson commented on HBASE-3513: thrift 0.5.0 is in the apache maven official repo... there was no 0.6.0 when i went looking. > upgrade thrift to 0.5.0 and use mvn version > --- > > Key: HBASE-3513 > URL: https://issues.apache.org/jira/browse/HBASE-3513 > Project: HBase > Issue Type: Bug > Components: thrift >Affects Versions: 0.90.0 >Reporter: ryan rawson >Assignee: ryan rawson > Fix For: 0.90.2 > > Attachments: HBASE-3515.txt > > > We should upgrade our thrift to 0.5.0, it is the latest and greatest and is > in apache maven repo. > Doing some testing with a thrift 0.5.0 server, and an older pre-release php > client shows the two are on-wire compatible. > Given that the upgrade is entirely on the server side, and has no wire-impact > this should be a relatively low-impact change. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3513) upgrade thrift to 0.5.0 and use mvn version
[ https://issues.apache.org/jira/browse/HBASE-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994089#comment-12994089 ] Lars George commented on HBASE-3513: And now there is 0.6.0 which we should use I presume? > upgrade thrift to 0.5.0 and use mvn version > --- > > Key: HBASE-3513 > URL: https://issues.apache.org/jira/browse/HBASE-3513 > Project: HBase > Issue Type: Bug > Components: thrift >Affects Versions: 0.90.0 >Reporter: ryan rawson >Assignee: ryan rawson > Fix For: 0.90.2 > > Attachments: HBASE-3515.txt > > > We should upgrade our thrift to 0.5.0, it is the latest and greatest and is > in apache maven repo. > Doing some testing with a thrift 0.5.0 server, and an older pre-release php > client shows the two are on-wire compatible. > Given that the upgrade is entirely on the server side, and has no wire-impact > this should be a relatively low-impact change. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3513) upgrade thrift to 0.5.0 and use mvn version
[ https://issues.apache.org/jira/browse/HBASE-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993509#comment-12993509 ] Lars Francke commented on HBASE-3513: - This is a duplicate of HBASE-3117. Also Thrift 0.5 isn't available in any official repository. The issue is still unresolved (THRIFT-363). > upgrade thrift to 0.5.0 and use mvn version > --- > > Key: HBASE-3513 > URL: https://issues.apache.org/jira/browse/HBASE-3513 > Project: HBase > Issue Type: Bug > Components: thrift >Affects Versions: 0.90.0 >Reporter: ryan rawson >Assignee: ryan rawson > Fix For: 0.90.2 > > Attachments: HBASE-3515.txt > > > We should upgrade our thrift to 0.5.0, it is the latest and greatest and is > in apache maven repo. > Doing some testing with a thrift 0.5.0 server, and an older pre-release php > client shows the two are on-wire compatible. > Given that the upgrade is entirely on the server side, and has no wire-impact > this should be a relatively low-impact change. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3513) upgrade thrift to 0.5.0 and use mvn version
[ https://issues.apache.org/jira/browse/HBASE-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991791#comment-12991791 ] stack commented on HBASE-3513: -- Sorry, I meant, the patch looks great. Its cool getting ICV and parallelGet into our thrift interface. > upgrade thrift to 0.5.0 and use mvn version > --- > > Key: HBASE-3513 > URL: https://issues.apache.org/jira/browse/HBASE-3513 > Project: HBase > Issue Type: Bug > Components: thrift >Affects Versions: 0.90.0 >Reporter: ryan rawson >Assignee: ryan rawson > Fix For: 0.90.1 > > Attachments: HBASE-3515.txt > > > We should upgrade our thrift to 0.5.0, it is the latest and greatest and is > in apache maven repo. > Doing some testing with a thrift 0.5.0 server, and an older pre-release php > client shows the two are on-wire compatible. > Given that the upgrade is entirely on the server side, and has no wire-impact > this should be a relatively low-impact change. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3513) upgrade thrift to 0.5.0 and use mvn version
[ https://issues.apache.org/jira/browse/HBASE-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991790#comment-12991790 ] stack commented on HBASE-3513: -- That patch looks fine. I don't see a pom edit though included in your patch. > upgrade thrift to 0.5.0 and use mvn version > --- > > Key: HBASE-3513 > URL: https://issues.apache.org/jira/browse/HBASE-3513 > Project: HBase > Issue Type: Bug > Components: thrift >Affects Versions: 0.90.0 >Reporter: ryan rawson >Assignee: ryan rawson > Fix For: 0.90.1 > > Attachments: HBASE-3515.txt > > > We should upgrade our thrift to 0.5.0, it is the latest and greatest and is > in apache maven repo. > Doing some testing with a thrift 0.5.0 server, and an older pre-release php > client shows the two are on-wire compatible. > Given that the upgrade is entirely on the server side, and has no wire-impact > this should be a relatively low-impact change. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
